[PATCH v4 1/3] sched: fix subport profile ID

In rte_sched_subport_config() API, subport_profile_id is not set correctly. Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera Acked by: Dumitrescu, Cristian --- lib/sched/rte_sched.c | 2 -- 1 file changed, 2

[PATCH v4 2/3] sched: fix number of subport profiles

Removed unused subport field from profile.cfg Correctly using subport profile id in subport config load. Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") Cc: sta...@dpdk.org Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- examples/qos_sched/

[PATCH v4 3/3] sched: support for 100G+ rates in subport/pipe config

Config load functions updated to support 100G rates for subport and pipes. Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 294 ++ 1 file changed, 230 insertions(+), 64 deletions(-) diff --git a/examples/qos_sched/cfg_file.c b/examples/qos_sched

[PATCH v5 1/3] sched: fix subport profile ID

In rte_sched_subport_config() API, subport_profile_id is not set correctly. Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera Acked-by: Dumitrescu, Cristian --- lib/sched/rte_sched.c | 2 -- 1 file changed, 2

[PATCH v5 3/3] sched: support for 100G+ rates in subport/pipe config

Config load functions updated to support 100G rates for subport and pipes. Added new parse function to convert string to unsigned long long. Added error checks. Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 180 +- examples/qos_sched/cfg_file.h

[PATCH v5 2/3] sched: fix number of subport profiles

Removed unused subport field from profile.cfg Correctly using subport profile id in subport config load. Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") Cc: sta...@dpdk.org Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- examples/qos_sched/

[PATCH v6 1/3] sched: fix subport profile ID

In rte_sched_subport_config() API, subport_profile_id is not set correctly. Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera Acked-by: Dumitrescu, Cristian --- lib/sched/rte_sched.c | 2 -- 1 file changed, 2

[PATCH v6 2/3] sched: fix number of subport profiles

Removed unused subport field from profile.cfg Correctly using subport profile id in subport config load. Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") Cc: sta...@dpdk.org Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- examples/qos_sched/

[PATCH v6 3/3] sched: support for 100G+ rates in subport/pipe config

- Config load functions updated to support 100G rates for subport and pipes. - Added new parse function to convert string to unsigned long long. - Added error checks. - Fixed format warnings. Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 179

[PATCH v2] sched: fix for incorrect alignment of bitmap, pipe and queue structs in subport

_ov_enabled variable in subport structure. Fixes: f5e60154ade ("sched: enable traffic class oversubscription conditionally") Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- lib/sched/rte_sched.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib

[PATCH] sched: Cleanup qos scheduler defines from rte_config

Cleanup of sched config options those are by-default not defined. Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- config/rte_config.h | 7 --- lib/sched/rte_sched.c | 4 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/config/rte_config.h b/config

[PATCH v2] sched: Cleanup qos scheduler defines from rte_config

Cleanup of sched config options those are by-default not defined. Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- config/rte_config.h| 7 --- doc/guides/sample_app_ug/qos_scheduler.rst | 3 +-- lib/sched/rte_sched.c | 4 3

[PATCH v2] sched: Fix subport profile id not set correctly.

In rte_sched_subport_config() API, subport_profile_id is not set correctly. Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 2 -- 1 file changed, 2 deletions(-) diff --git a

[PATCH v2] sched: subport field is unused in hqos profile

Removed ununsed subport field from profile.cfg Correctly using subport profile id in subport config load. Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_f

[PATCH v3] sched: subport field is unused in hqos profile

Removed unused subport field from profile.cfg Correctly using subport profile id in subport config load. Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 2 +-

[PATCH 1/3] sched: fix subport profile id not set correctly

In rte_sched_subport_config() API, subport_profile_id is not set correctly. Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 2 -- 1 file changed, 2 deletions(-) diff --git a

[PATCH 2/3] sched: removed unused subport field in hqos profile

Removed unused subport field from profile.cfg Correctly using subport profile id in subport config load. Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 2 +-

[PATCH 3/3] sched: support for 100G+ rates in subport/pipe config

Config load functions updated to support 100G rates for subport and pipes. Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 64 +-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/examples/qos_sched/cfg_file.c b/examples/qos_sched

[PATCH] sched: fix for demo failure in debug mode

This issue is happening due to non-initialization of some fields in “rte_eth_rxconf” structure in our application. Doing a memset to zero before initialization in HQoS application. Signed-off-by: Megha Ajmera --- examples/qos_sched/init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH] sched: fix for tc_ov_enable flag position in subport structure.

Current position of "tv_ov_enable" variable in rte_sched_subport structure makes the "memory" variable unused. Fixes: f5e60154ade ("sched: enable traffic class oversubscription conditionally") CC: marcinx.danilew...@intel.com Signed-off-by: Megha Ajmera --- lib/

[PATCH] sched:subport field is unused in hqos profile.

From: Megha Ajmera --- examples/qos_sched/profile.cfg | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/qos_sched/profile.cfg b/examples/qos_sched/profile.cfg index d4b21c0170..8da5777538 100644 --- a/examples/qos_sched/profile.cfg +++ b/examples/qos_sched/profile.cfg @@ -26,8 +26,6

[PATCH] sched: Fix subport profile id not set correctly.

In rte_sched_subport_config() API, subport_profile_id is not set correctly. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 599c7e9536..09f855a04b 100644 --- a/lib/sched/rte_sched.c

[PATCH] sched: subport field is unused in hqos profile

Signed-off-by: Megha Ajmera --- examples/qos_sched/profile.cfg | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/qos_sched/profile.cfg b/examples/qos_sched/profile.cfg index d4b21c0170..8da5777538 100644 --- a/examples/qos_sched/profile.cfg +++ b/examples/qos_sched/profile.cfg

[PATCH] sched: Support to config 100G rate to subport/pipe

Currently in hqos tc rates, tb sizes can be configured upto 25G. Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 64 +-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/examples/qos_sched/cfg_file.c b/examples/qos_sched/cfg_file.c

[PATCH] sched:subport field is unused in hqos profile.

--- examples/qos_sched/profile.cfg | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/qos_sched/profile.cfg b/examples/qos_sched/profile.cfg index d4b21c0170..8da5777538 100644 --- a/examples/qos_sched/profile.cfg +++ b/examples/qos_sched/profile.cfg @@ -26,8 +26,6 @@ number of subports

[PATCH] sched:In rte_sched_subport_config() API, subport_profile_id is not set correctly.

--- lib/sched/rte_sched.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 599c7e9536..09f855a04b 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/rte_sched.c @@ -1263,8 +1263,6 @@ rte_sched_subport_config(struct rte_sched_port *port,

[PATCH] sched:higher rates of pipe and subport are not taken care in application.

--- examples/qos_sched/cfg_file.c | 66 +-- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/examples/qos_sched/cfg_file.c b/examples/qos_sched/cfg_file.c index 450482f07d..fe0b42b023 100644 --- a/examples/qos_sched/cfg_file.c +++ b/examples/qos_sched

[PATCH v1 0/4] sched: HQoS Library cleanup.

v1: * Removed unused HQoS #defines from rte_config. * Enabled stats in HQoS by default. * TC subscription for best effort queues is always enabled in HQoS library. * VECTOR defines are removed from HQoS library. Megha Ajmera (4): sched: Cleanup qos scheduler defines from rte_config sched

[PATCH v1 1/4] sched: Cleanup qos scheduler defines from rte_config

Cleanup of sched config options those are by-default not defined. Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- config/rte_config.h| 7 --- doc/guides/sample_app_ug/qos_scheduler.rst | 3 +-- lib/sched/rte_sched.c | 4 3

[PATCH v1 2/4] sched: Always enable stats in HQoS library.

Removed "RTE_SCHED_COLLECT_STATS" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 12 1 file changed, 12 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 6c3e3bb0bf..6f2d85edc0 100644 --- a/lib/sched/rte_sched.c +++ b

[PATCH v1 3/4] sched: Always enable best effort TC oversubscription in HQoS library.

Removed "RTE_SCHED_SUBPORT_TC_OV" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 91 --- 1 file changed, 91 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 6f2d85edc0..807134b48d 100644

[PATCH v1 4/4] sched: Removed code defined under VECTOR Defines.

Removed "RTE_SCHED_VECTOR" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 53 --- 1 file changed, 53 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 807134b48d..8ad5ca7e05 100644 --- a

[PATCH v2 0/4] sched: HQoS Library cleanup

from the code. Stats collection is now always enabled. * RTE_SCHED_SUBPORT_TC_OV flag is removed. TC subscription for best effort queues is always enabled in HQoS library. * RTE_SCHED_VECTOR flag is removed from HQoS library as the code under this flag is no longer useful. Megha Ajmera (4

[PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config

Cleanup of sched config options those are by-default not defined. Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- config/rte_config.h| 8 ++-- doc/guides/sample_app_ug/qos_scheduler.rst | 3 +-- lib/sched/rte_sched.c | 4 3

[PATCH v2 2/4] sched: Always enable stats in HQoS library.

Removed "RTE_SCHED_COLLECT_STATS" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 12 1 file changed, 12 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 6c3e3bb0bf..6f2d85edc0 100644 --- a/lib/sched/rte_sched.c +++ b

[PATCH v2 3/4] sched: Always enable best effort TC oversubscription in HQoS library.

Removed "RTE_SCHED_SUBPORT_TC_OV" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 91 --- 1 file changed, 91 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 6f2d85edc0..807134b48d 100644

[PATCH v2 4/4] sched: Removed code defined under VECTOR Defines.

Removed "RTE_SCHED_VECTOR" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 53 --- 1 file changed, 53 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 807134b48d..8ad5ca7e05 100644 --- a

[PATCH v3 0/4] sched: cleanup of sched library

the code under this flag is no longer useful. Only scalar version is supported. * Rebased with latest main branch code. Megha Ajmera (4): sched: remove code no longer needed sched: move grinder configuration flag sched: enable statistics unconditionally sched: enable traffic class

[PATCH v3 1/4] sched: remove code no longer needed

Remove RTE_SCHED_VECTOR flag from rte_config.h. This flag is no longer useful. Only scalar version is supported. Signed-off-by: Megha Ajmera --- config/arm/meson.build | 1 - config/rte_config.h| 1 - lib/sched/rte_sched.c | 54 -- 3 files changed

[PATCH v3 2/4] sched: move grinder configuration flag

Grinder configuration is now moved to sched library. Number of grinders can also modified by specifying RTE_SCHED_PORT_N_GRINDERS=N in CFLAGS, where N is number of grinders. Signed-off-by: Megha Ajmera --- config/rte_config.h| 1 - doc/guides/sample_app_ug

[PATCH v3 3/4] sched: enable statistics unconditionally

Removed RTE_SCHED_COLLECT_STATS flag from rte_config.h. Stats collection is always enabled. Signed-off-by: Megha Ajmera --- config/rte_config.h| 1 - doc/guides/sample_app_ug/qos_scheduler.rst | 6 -- lib/sched/rte_sched.c | 12 3

[PATCH v3 4/4] sched: enable traffic class oversubscription unconditionally

Removed RTE_SCHED_SUBPORT_TC_OV from rte_config.h. Best effort traffic class oversubscription is always enabled. Signed-off-by: Megha Ajmera --- config/rte_config.h | 1 - drivers/net/softnic/rte_eth_softnic_tm.c | 18 - examples/qos_sched/init.c| 2

[PATCH] sched: fix integer handling issue

arithmetic, and then used in a context that expects an expression of type "uint64_t" (64 bits, unsigned). Coverity issue: 375859 Signed-off-by: Megha Ajmera --- examples/qos_sched/args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/qos_sched/args

[PATCH v2] sched: fix integer handling issue

arithmetic, and then used in a context that expects an expression of type "uint64_t" (64 bits, unsigned). Coverity issue: 375859 Signed-off-by: Megha Ajmera --- examples/qos_sched/args.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/qos_sched/args

[PATCH v1] sched: enable/disable TC OV at runtime

Added new API to enable or disable TC over subscription for best effort traffic class at subport level. By default TC OV is disabled for subport. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 182 +++--- lib/sched/rte_sched.h | 18 + lib/sched

[PATCH] Revert "sched: enable traffic class oversubscription unconditionally"

This reverts commit d91c4b1bb5a938734fe8e66da8f965304919f38e. When enabling TC OV unconditionally, it is observed the performance drops by ~20% hence reverting this commit. Signed-off-by: Megha Ajmera --- config/rte_config.h | 1 + drivers/net/softnic/rte_eth_softnic_tm.c

[PATCH v2] Revert "sched: enable traffic class oversubscription unconditionally"

This reverts commit d91c4b1bb5a938734fe8e66da8f965304919f38e. When enabling TC OV unconditionally, it is observed the performance drops by ~20% hence reverting this commit. Fixes: d91c4b1bb5a9 ("sched: enable traffic class oversubscription unconditionally") Signed-off-by: Me

[PATCH] sched: fix wrr parameter data type

wrr tokens getting truncated to uint8_t in wrr_store function() due to type mismatch. This patch chnages the data type to uint16_t. Fixes: e16b06da0908 ("sched: remove WRR from strict priority TC queues") Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1