[dpdk-dev] [PATCH] eventdev: change port_id to uint16_t

2018-05-07 Thread Lei
From: yao >From 17.11, port_id is changed from uint8_t to uint16_t.But in eventdev, it still use the old fashion. This patch fix this issue. Signed-off-by: Lei Yao --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

net_af_xdp pmd memory leak

2022-11-16 Thread Lei Kong
My test reports memory leaks for receive path, looking at the code, it seems the following allocations were never released, should they? Thanks. https://github.com/DPDK/dpdk/blob/903ec2b1b49e496815c016b0104fd655cd972661/drivers/net/af_xdp/rte_eth_af_xdp.c#L312

[dpdk-dev] [PATCH] net: support PPPOE in software packet type parser

2017-04-07 Thread Zhang Lei
Add a new RTE_PTYPE_L2_ETHER_PPPOE and its support in rte_net_get_ptype() Signed-off-by: Ray Zhang --- lib/librte_mbuf/rte_mbuf_ptype.h | 7 +++ lib/librte_net/rte_ether.h | 12 lib/librte_net/rte_net.c | 19 +++ 3 files changed, 38 insertions(+)

[dpdk-dev] [PATCH] net: support PPPOE in software packet type parser

2017-04-07 Thread Zhang Lei
Add a new RTE_PTYPE_L2_ETHER_PPPOE and its support in rte_net_get_ptype() Signed-off-by: Ray Zhang --- lib/librte_mbuf/rte_mbuf_ptype.h | 7 +++ lib/librte_net/rte_ether.h | 12 lib/librte_net/rte_net.c | 19 +++ 3 files changed, 38 insertions(+)

Re: [dpdk-dev] [PATCH v3 00/10] rxq interrupt mode for virtio PMD

2017-01-16 Thread Yao, Lei A
Tested-by: Lei Yao Apply patch to dpdk_next_virtio branch. Qemu version: 2.5.0 Kernel version in VM: 4.8.1 Following TCs are tested and passed: Test Case1: Basic Virtio Interrupt test Test Case2: Interrupted received in VM with different Virtio version(0.95 and 1.0) Test Case3: Interrupted by

Re: [dpdk-dev] [PATCH v2] eal: optimize aligned rte_memcpy

2016-12-07 Thread Yao, Lei A
Tested-by: Lei Yao - Apply patch to v16.11 I have tested the loopback performance for this patch on 3 following settings: CPU: IVB Ubutnu16.04 Kernal: 4.4.0 gcc : 5.4.0 CPU: HSW Fedora 21 Kernal: 4.1.13 gcc: 4.9.2 CPU:BDW Ubutnu16.04 Kernal: 4.4.0 gcc : 5.4.0 I can see 10%~20% performance

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-19 Thread Yao, Lei A
have any one tested the memcpy > with big packets? Does the one from DPDK outweigh the one from glibc, > even for big packets? > > --yliu > I have test the loopback performanc rte_memcpy and glibc memcpy. For both small packer and Big packet, rte_memcpy has better performa

Re: [dpdk-dev] [PATCH v14 3/3] app/testpmd: enable TCP/IPv4 GRO

2017-07-09 Thread Yao, Lei A
> -Original Message- > From: Hu, Jiayu > Sent: Sunday, July 9, 2017 1:47 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Ananyev, Konstantin > ; y...@fridaylinux.org; > step...@networkplumber.org; Wu, Jingjing ; Yao, > Lei A ; Hu, Jiayu > Subject: [PATCH v14 3

Re: [dpdk-dev] [PATCH] vhost: fix vhost-user init failed

2017-07-13 Thread Yao, Lei A
> -Original Message- > From: Yang, Zhiyong > Sent: Monday, July 10, 2017 4:07 PM > To: dev@dpdk.org > Cc: y...@fridaylinux.org; maxime.coque...@redhat.com; Yao, Lei A > ; Yang, Zhiyong > Subject: [PATCH] vhost: fix vhost-user init failed > > Exception handlin

Re: [dpdk-dev] [PATCH v3 0/9] virtio/vhost: Add MTU feature support

2017-03-27 Thread Yao, Lei A
.c | 44 +++--- > --- > lib/librte_vhost/vhost_user.h | 5 +++- > 13 files changed, 156 insertions(+), 13 deletions(-) > > -- > 2.9.3 Hi, Maxime If I want have a try for this MTU function, is there any specific requirement for the settings? Such as the qemu version, kernel version or any others? Looks like this feature are very new in Qemu and linux side. Thanks a lot! BRs Lei

Re: [dpdk-dev] [PATCH v3 0/5] consistent PMD batching behaviour

2017-03-31 Thread Yao, Lei A
e PMD update on fast path, effected PMDs, can you please > confirm the performance after test? Hi, I have compare the vhost PVP performance with and without Zhiyong's Patch. Almost no performance drop Mergeable path: -0.2% Normal Path: -0.73% Vector Path : -0.55% Test bench: Ubutnu16.04 Kernal: 4.4.0 gcc : 5.4.0 BRs Lei

Re: [dpdk-dev] [RFC PATCH] net/virtio: Align Virtio-net header on cache line in receive path

2017-03-07 Thread Yao, Lei A
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Monday, March 6, 2017 10:11 PM > To: Yuanhan Liu > Cc: Liang, Cunming ; Tan, Jianfeng > ; dev@dpdk.org; Wang, Zhihong > ; Yao, Lei A > Subject: Re: [RFC PATCH] net/virtio:

Re: [dpdk-dev] [PATCH v5 3/3] app/testpmd: enable TCP/IPv4 GRO

2017-06-18 Thread Yao, Lei A
> -Original Message- > From: Hu, Jiayu > Sent: Sunday, June 18, 2017 3:21 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; > y...@fridaylinux.org; Wiles, Keith ; Tan, Jianfeng > ; Bie, Tiwei ; Yao, Lei A > ; Hu, Jiayu > Subject: [PATCH v5 3/3] app/testpmd: en

Re: [dpdk-dev] [PATCH v6 3/3] app/testpmd: enable TCP/IPv4 GRO

2017-06-24 Thread Yao, Lei A
> -Original Message- > From: Hu, Jiayu > Sent: Friday, June 23, 2017 10:43 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Tan, Jianfeng > ; step...@networkplumber.org; > y...@fridaylinux.org; Wiles, Keith ; Bie, Tiwei > ; Yao, Lei A ; Hu, Jiayu > > Subje

Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix Rx descriptor size

2017-04-28 Thread Yao, Lei A
I have test this patch based on 17.05-rc2 , issue is fixed. Host frequency can be changed according to the data throughput. Tested-by: Lei Yao (lei.a@intel.com) > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday,

Re: [dpdk-dev] [PATCH] libs/power: fix the resource leaking issue

2019-01-01 Thread Yao, Lei A
> -Original Message- > From: Ma, Liang J > Sent: Friday, December 28, 2018 7:33 PM > To: Hunt, David > Cc: dev@dpdk.org; Burakov, Anatoly ; Yao, Lei > A ; Ma, Liang J > Subject: [PATCH] libs/power: fix the resource leaking issue > > Fixes: e6c6dc0f96c8

Re: [dpdk-dev] [PATCH] examples/power: fix wrong core_id with JSON cmds

2019-01-07 Thread Yao, Lei A
> -Original Message- > From: Hunt, David > Sent: Monday, January 7, 2019 7:39 PM > To: dev@dpdk.org > Cc: Hunt, David ; Yao, Lei A > Subject: [PATCH] examples/power: fix wrong core_id with JSON cmds > > This patch fixes a bug introduced in the 64-core limtation

Re: [dpdk-dev] [PATCH] examples/power: fix wrong core_id with JSON cmds

2019-01-08 Thread Yao, Lei A
> -Original Message- > From: Hunt, David > Sent: Tuesday, January 8, 2019 5:20 PM > To: Yao, Lei A ; dev@dpdk.org > Subject: Re: [PATCH] examples/power: fix wrong core_id with JSON cmds > > Hi Lei, > > On 8/1/2019 2:02 AM, Yao, Lei A wrote: > > > >

Re: [dpdk-dev] [PATCH v5 07/10] examples/power: add json string handling

2018-09-29 Thread Yao, Lei A
> +#ifdef USE_JANSSON > +static int > +parse_json_to_pkt(json_t *element, struct channel_packet *pkt) > +{ > + const char *key; > + json_t *value; > + int ret; > + > + memset(pkt, 0, sizeof(struct channel_packet)); > + > + pkt->nb_mac_to_monitor = 0; > + pkt->t_boost_status.

Re: [dpdk-dev] [PATCH v10 1/4] lib/librte_power: traffic pattern aware power control

2018-10-11 Thread Yao, Lei A
e power lib always execute the training steps, even we set the policy.state=MED_NORMAL in the sample. This will confuse the user, they don’t know why they can't skip the training steps even the sample is already configured to --empty-poll=0,x,xx BRs Lei

Re: [dpdk-dev] [PATCH v10 1/4] lib/librte_power: traffic pattern aware power control

2018-10-12 Thread Yao, Lei A
> -Original Message- > From: Ma, Liang J > Sent: Friday, October 12, 2018 6:03 PM > To: Yao, Lei A > Cc: Hunt, David ; dev@dpdk.org; > ktray...@redhat.com; Kovacevic, Marko > Subject: Re: [PATCH v10 1/4] lib/librte_power: traffic pattern aware power > control &

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

2018-10-29 Thread Yao, Lei A
memory policy. EAL: Setting policy MPOL_PREFERRED for socket 0 EAL: Restoring previous memory policy: 0 Could you have a check on this? A lot of test cases in our validation team fail because of this. Thanks a lot! BRs Lei > -Original Message- > From: dev [mailto:dev-boun...@dpdk

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

2018-10-29 Thread Yao, Lei A
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, October 29, 2018 4:43 PM > To: Yao, Lei A > Cc: Alejandro Lucero ; dev@dpdk.org; > Xu, Qian Q ; Lin, Xueqin ; > Burakov, Anatoly > Subject: Re: [dpdk-dev] [PATCH v3 0/6]

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

2018-10-29 Thread Yao, Lei A
Hi, Lucero My server info: Intel(R) Xeon(R) Platinum 8180 CPU @ 2.50GHz Hugepage: 1G Kernel: 4.15.0 OS: Ubuntu Steps are simple: 1. Bind one i40e/ixgbe NIC to igb_uio 2. Launch testpmd: ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x03 -n 4 --log-level=eal,8 -- -i BRs Lei From

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

2018-10-29 Thread Yao, Lei A
From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com] Sent: Monday, October 29, 2018 8:56 PM To: Thomas Monjalon Cc: Yao, Lei A ; dev ; Xu, Qian Q ; Lin, Xueqin ; Burakov, Anatoly ; Yigit, Ferruh Subject: Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask On Mon, Oct

Re: [dpdk-dev] [PATCH] mem: fix alignment of requested virtual areas

2018-07-16 Thread Yao, Lei A
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, July 16, 2018 3:57 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yao, Lei A ; Stojaczyk, > DariuszX ; sta...@dpdk.org > Subject: [PATCH] mem: fix alignment of requested virtual areas > > The

Re: [dpdk-dev] [PATCH] eal: fix circular dependency in EAL proc type detection

2018-07-18 Thread Yao, Lei A
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, July 18, 2018 11:54 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Xu, Qian Q > ; Yao, Lei A ; Lu, PeipeiX > > Subject: [PATCH] eal: fix circular dependency in EAL proc type detection > >

Re: [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading

2018-04-17 Thread Yao, Lei A
> -Original Message- > From: Dai, Wei > Sent: Tuesday, April 17, 2018 3:44 PM > To: Lu, Wenzhuo ; Ananyev, Konstantin > ; Yao, Lei A > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading > &

Re: [dpdk-dev] [PATCH 00/12] Vhost: CVE-2018-1059 fixes

2018-05-01 Thread Yao, Lei A
64 -8.60% 128 -3.54% 260 -2.63% 520 -6.12% 1024-1.05% 1500-1.20% CPU info: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz OS: Ubuntu 16.04 BRs Lei > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Monday,

Re: [dpdk-dev] [PATCH 00/12] Vhost: CVE-2018-1059 fixes

2018-05-02 Thread Yao, Lei A
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, May 2, 2018 5:20 PM > To: Yao, Lei A ; dev@dpdk.org > Cc: Bie, Tiwei > Subject: Re: [dpdk-dev] [PATCH 00/12] Vhost: CVE-2018-1059 fixes > > Hi Lei, > &

Re: [dpdk-dev] [PATCH 2/2] net/vhost: insert/strip VLAN header in software

2018-05-07 Thread Yao, Lei A
Hi, Jan For this patch, I find it will break the VM2VM Iperf test as it clear the of_flags. "bufs[i]->ol_flags = 0;" Could you have a check on this? The test step to reproduce this issue: 1. Lauch testpmd with two vhost-user port, using IO fwd mode testpmd -c 0xe -n 4 --socket-mem 1024,1024 \ --l

Re: [dpdk-dev] [PATCH v6 1/4] lib/librte_power: traffic pattern aware power control

2018-09-03 Thread Yao, Lei A
> -Original Message- > From: Ma, Liang J > Sent: Friday, August 31, 2018 11:04 PM > To: Hunt, David > Cc: dev@dpdk.org; Yao, Lei A ; Nicolau, Radu > ; Burakov, Anatoly ; > Geary, John ; Ma, Liang J > Subject: [PATCH v6 1/4] lib/librte_power: traffic pattern aw

Re: [dpdk-dev] [PATCH v6 1/4] lib/librte_power: traffic pattern aware power control

2018-09-03 Thread Yao, Lei A
> -Original Message- > From: Ma, Liang J > Sent: Friday, August 31, 2018 11:04 PM > To: Hunt, David > Cc: dev@dpdk.org; Yao, Lei A ; Nicolau, Radu > ; Burakov, Anatoly ; > Geary, John ; Ma, Liang J > Subject: [PATCH v6 1/4] lib/librte_power: traffic pattern aw

Re: [dpdk-dev] [PATCH v1 6/7] doc/vm_power_manager: add JSON interface API info

2018-09-03 Thread Yao, Lei A
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Thursday, August 30, 2018 6:54 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Hunt, David > > Subject: [dpdk-dev] [PATCH v1 6/7] doc/vm_power_manager: add JSON > interface API info > > Signed-o

Re: [dpdk-dev] [PATCH v1 4/7] examples/power: add host channel to power manager

2018-09-04 Thread Yao, Lei A
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Thursday, August 30, 2018 6:54 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Hunt, David > > Subject: [dpdk-dev] [PATCH v1 4/7] examples/power: add host channel to > power manager > > This pat

Re: [dpdk-dev] [PATCH v5 10/10] doc/vm_power_manager: add JSON interface API info

2018-09-28 Thread Yao, Lei A
> +:Pair Name: "avg_packet_thresh" > +:Description: Threshold below which the frequency will be set to min for > + the TRAFFIC policy. If the traffic rate is above this and below max, the > + frequency will be set to medium. > +:Type: integer > +:Values: The number of packets below which the TRAF

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix feature setting with vhost-net backend

2018-05-08 Thread Yao, Lei A
> -Original Message- > From: Hu, Jiayu > Sent: Tuesday, May 8, 2018 4:15 PM > To: dev@dpdk.org > Cc: Bie, Tiwei ; Yang, Zhiyong > ; maxime.coque...@redhat.com; Yao, Lei A > ; Hu, Jiayu > Subject: [PATCH v2] net/virtio-user: fix feature setting with vhost-net

Re: [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous code

2018-05-14 Thread Yao, Lei A
Hi, Andy This patch will break the vfio-pci driver on my server. I can't launch NIC with vfio-pci using testpmd. Could you have a check on this? Thanks a lot! My server info: OS: Ubuntu 16.04 LTS gcc: 5.4.0 kernel: 4.4.0 CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz NIC: Ethernet Controller X

Re: [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous code

2018-05-15 Thread Yao, Lei A
> -Original Message- > From: Andy Green [mailto:a...@warmcat.com] > Sent: Tuesday, May 15, 2018 3:33 PM > To: Yao, Lei A ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous > code > > > > On 05/15/2018 02:12 PM,

Re: [dpdk-dev] [PATCH 00/12] Vhost: CVE-2018-1059 fixes

2018-05-17 Thread Yao, Lei A
Hi, Maxime Any idea for this performance drop? Will we improve it in this release or it will be long term work? Thanks. BRs Lei > -Original Message- > From: Yao, Lei A > Sent: Wednesday, May 2, 2018 8:10 PM > To: Maxime Coquelin ; dev@dpdk.org > Cc: Bie, Tiwei > Subj

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-17 Thread Yao, Lei A
> -Original Message- > From: Yang, Zhiyong > Sent: Friday, May 18, 2018 6:00 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Yigit, Ferruh ; > Bie, Tiwei ; Yao, Lei A ; > Iremonger, Bernard ; sta...@dpdk.org; > Yang, Zhiyong > Subject: [PATCH v2] app

Re: [dpdk-dev] [PATCH] vhost: adaptively batch small guest memory copies

2017-08-28 Thread Yao, Lei A
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jens Freimann > Sent: Monday, August 28, 2017 2:31 PM > To: Bie, Tiwei > Cc: dev@dpdk.org; y...@fridaylinux.org; maxime.coque...@redhat.com; > Wang, Zhihong ; Yang, Zhiyong > > Subject: Re: [dpdk-dev] [PATCH] vh

Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS from 32 to 1024

2017-09-04 Thread Yao, Lei A
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang > Sent: Monday, September 4, 2017 1:58 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; Wiles, > Keith ; step...@networkplumber.org; Yang, > Zhiyong > Subject: [dpdk-dev] [PATCH v2 3/

Re: [dpdk-dev] [PATCH v3] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO

2017-09-20 Thread Yao, Lei A
reassembly tables. With the command "show port gro", users can > display GRO configuration. > > Signed-off-by: Jiayu Hu Tested-by : Lei Yao This patch has been tested on my bench, iperf test result is as following: No-GRO: 8 Gbps Kernel GRO: 14.3 Gbps GRO flush 0 : 12.7 Gbps GRO flu

Re: [dpdk-dev] [PATCH v4 2/5] gso: add TCP/IPv4 GSO support

2017-09-20 Thread Yao, Lei A
e NIC driver. > > If a packet is GSOed, TCP/IPv4 GSO reduces its MBUF refcnt by 1. As a > result, when all of its GSOed segments are freed, the packet is freed > automatically. > > TCP/IPv4 GSO clears the PKT_TX_TCP_SEG flag for the input packet and > GSO segments on the eve

Re: [dpdk-dev] [PATCH v4] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO

2017-09-27 Thread Yao, Lei A
> -Original Message- > From: Hu, Jiayu > Sent: Tuesday, September 26, 2017 2:27 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Tan, Jianfeng > ; Ananyev, Konstantin > ; tho...@monjalon.net; Wu, Jingjing > ; Yao, Lei A ; Hu, Jiayu > > Subject: [PATCH v4] app/t

Re: [dpdk-dev] [PATCH v3 15/19] vhost: postpone rings addresses translation

2017-10-12 Thread Yao, Lei A
le-hw-vlan-filter BRs Lei > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Thursday, October 5, 2017 4:36 PM > To: dev@dpdk.org; Horton, Remy ; Bie, Tiwei > ; y...@fridaylinux.org > Cc: m...@redhat.com; jfrei...@red

Re: [dpdk-dev] [PATCH v3 15/19] vhost: postpone rings addresses translation

2017-10-13 Thread Yao, Lei A
Hi, Maxime > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, October 13, 2017 3:32 PM > To: Yao, Lei A ; dev@dpdk.org; Horton, Remy > ; Bie, Tiwei ; > y...@fridaylinux.org > Cc: m...@redhat.com; jfrei...@redhat.com

Re: [dpdk-dev] [PATCH v3 15/19] vhost: postpone rings addresses translation

2017-10-15 Thread Yao, Lei A
Hi, Maxime > -Original Message- > From: Yao, Lei A > Sent: Friday, October 13, 2017 3:55 PM > To: Maxime Coquelin ; dev@dpdk.org; > Horton, Remy ; Bie, Tiwei ; > y...@fridaylinux.org > Cc: m...@redhat.com; jfrei...@redhat.com; vkapl...@redhat.com; > jasow...@

Re: [dpdk-dev] [PATCH v3 15/19] vhost: postpone rings addresses translation

2017-10-15 Thread Yao, Lei A
Hi, Maxime Add one comment: This issue with virtio-net only occur when I use CPU on socket 1. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yao, Lei A > Sent: Monday, October 16, 2017 2:00 PM > To: 'Maxime Coquelin' ; 'dev@dpdk.

Re: [dpdk-dev] [PATCH v3 15/19] vhost: postpone rings addresses translation

2017-10-16 Thread Yao, Lei A
Hi, Maxime > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Monday, October 16, 2017 6:48 PM > To: Yao, Lei A ; 'dev@dpdk.org' ; > Horton, Remy ; Bie, Tiwei ; > 'y...@fridaylinux.org' > Cc: 'm...@

Re: [dpdk-dev] [PATCH v3 17/19] vhost-user: iommu: postpone device creation until ring are mapped

2017-11-02 Thread Yao, Lei A
> - if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM)) > - vhost_user_iotlb_rd_lock(vq); > - > for (i = 0; i < count; i++) { > struct vring_desc *desc; > uint16_t sz, idx; > @@ -1329,9 +1343,6 @@ rte_vhost_dequeue_burst(int vid, uint16_t > queue_id, > TAILQ_INSERT_TAIL(&vq->zmbuf_list, zmbuf, next); > } > } > - if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM)) > - vhost_user_iotlb_rd_unlock(vq); > - > vq->last_avail_idx += i; > > if (likely(dev->dequeue_zero_copy == 0)) { > @@ -1341,6 +1352,9 @@ rte_vhost_dequeue_burst(int vid, uint16_t > queue_id, > } > > out: > + if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM)) > + vhost_user_iotlb_rd_unlock(vq); > + > if (unlikely(rarp_mbuf != NULL)) { > /* >* Inject it to the head of "pkts" array, so that switch's mac > -- > 2.13.6 Hi, Maxime I met one issue with your patch set during the v17.11 test. The test scenario is following, 1. Bind one NIC, use test-pmd set vhost-user with 2 queue usertools/dpdk-devbind.py --bind=igb_uio :05:00.0 ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xe -n 4 --socket-mem 1024,1024 \ --vdev 'net_vhost0,iface=vhost-net,queues=2' - -i --rxq=2 --txq=2 --nb-cores=2 --rss-ip 2. Launch qemu with virtio device which has 2 queue 3. In VM, launch testpmd with virtio-pmd using only 1 queue. x86_64-native-linuxapp-gcc/app/testpmd -c 0x07 -n 3 - -i --txqflags=0xf01 \ --rxq=1 --txq=1 --rss-ip --nb-cores=1 First, commit 09927b5249694bad1c094d3068124673722e6b8f vhost: translate ring addresses when IOMMU enabled The patch causes no traffic in PVP test. but link status is still up in vhost-user. Second, eefac9536a901a1f0bb52aa3b6fec8f375f09190 vhost: postpone device creation until rings are mapped The patch causes link status "down" in vhost-user. Could you have a check at your side? Thanks. BRs Lei

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-11-03 Thread Yao, Lei A
Hi, Thomas > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, November 2, 2017 6:45 PM > To: Wang, Zhihong ; Li, Xiaoyun > > Cc: dev@dpdk.org; Richardson, Bruce ; > Ananyev, Konstantin ; Lu, Wenzhuo > ; Zhang, Helin ; > ophi...@me

Re: [dpdk-dev] [PATCH v2 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power

2017-11-03 Thread Yao, Lei A
fix Rx queue interrupt mapping > in VF"), > the interrupt vector of Rx queues should be mapped to vector 1 to fix above > 2nd bug. > > These patches have passed test with l3fwd-power using i40e VF bound to > VFIO-PCI. > They also passed the test with testpmd rxonly a

Re: [dpdk-dev] [PATCH] vhost: postpone ring addresses translations at kick time only

2017-11-05 Thread Yao, Lei A
Hi, Maxime > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, November 3, 2017 11:57 PM > To: dev@dpdk.org; y...@fridaylinux.org; Yao, Lei A > Cc: m...@redhat.com > Subject: Re: [PATCH] vhost: postpone ring addresses transla

Re: [dpdk-dev] [PATCH v2 06/10] net/virtio: fix queue setup consistency

2018-01-31 Thread Yao, Lei A
Hi, Olivier This is Lei from DPDK validation team in Intel. During our DPDK 18.02-rc1 test, I find the following patch will cause one serious issue with virtio vector path: the traffic can't resume after stop/start the virtio device. The step like following: 1. Launch vhost-user port

Re: [dpdk-dev] [PATCH 1/2] virtio: fix resuming traffic with rx vector path

2018-02-11 Thread Yao, Lei A
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, February 9, 2018 10:27 PM > To: Bie, Tiwei ; y...@fridaylinux.org; Yigit, Ferruh > ; vict...@redhat.com > Cc: dev@dpdk.org; sta...@dpdk.org; Wang, Zhihong > ; Xu

Re: [dpdk-dev] [PATCH] vhost: support UDP Fragmentation Offload

2017-12-24 Thread Yao, Lei A
host-user. > > Signed-off-by: Jiayu Hu Tested-by: Lei Yao This patch has been tested on my server, with guest_ufo=on,host_ufo=on are added to the qemu cmdlind, using vhost-user as backend, vm can send and receive big UDP packets. > --- > lib/librte_mbuf/rte_mbuf.h| 7

Re: [dpdk-dev] [PATCH] vhost: support Generic Segmentation Offload

2017-12-24 Thread Yao, Lei A
ost-net to vhost-user possible, this patch > enables GSO for vhost-user. > > Signed-off-by: Jiayu Hu Tested-by: Lei Yao This patch has been tested on my server, after add csum=on, gso=on to qemu cmdline, Following offload are active in vm: udp-fragmentation-offload: on tx-tcp-segmentation: on

Re: [dpdk-dev] [PATCH v4 1/2] gro: code cleanup

2018-01-07 Thread Yao, Lei A
> -Original Message- > From: Hu, Jiayu > Sent: Friday, January 5, 2018 2:13 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Chen, Junjie J > ; Tan, Jianfeng ; > step...@networkplumber.org; Yigit, Ferruh ; > Ananyev, Konstantin ; Yao, Lei A > ; Hu, Jiayu &g

Re: [dpdk-dev] [PATCH v7] vhost: support virtqueue interrupt/notification suppression

2018-01-08 Thread Yao, Lei A
> -Original Message- > From: Chen, Junjie J > Sent: Tuesday, January 9, 2018 7:04 PM > To: y...@fridaylinux.org; maxime.coque...@redhat.com; Wang, Xiao W > ; Bie, Tiwei ; Yao, Lei A > > Cc: dev@dpdk.org; Chen, Junjie J > Subject: [PATCH v7] vhost: sup

[dpdk-dev] [PATCH] i40e: enable i40e pmd on ARM platform

2016-08-03 Thread Yao, Lei A
way to avoid such performance drop on X86? Thanks. BRs Lei -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jianbo Liu Sent: Tuesday, August 2, 2016 2:58 PM To: dev at dpdk.org; Zhang, Helin ; Wu, Jingjing Cc: Jianbo Liu Subject: [dpdk-dev] [PATCH] i40e: enable

Re: [dpdk-dev] [PATCH] examples/power: fix ack for enable/disable turbo

2020-02-11 Thread Yao, Lei A
> -Original Message- > From: Hunt, David > Sent: Tuesday, February 11, 2020 6:50 PM > To: dev@dpdk.org; Hunt, David > Cc: Yao, Lei A ; sta...@dpdk.org > Subject: [PATCH] examples/power: fix ack for enable/disable turbo > > When a VM sends a command through

Re: [dpdk-dev] [PATCH v4 1/3] vfio: revert change that does intr eventfd setup at probe

2019-07-19 Thread Yao, Lei A
behavior of rte_intr_[enable|disable] to > only mask and unmask unlike earlier behavior and thereby > breaking above two scenarios. > > Fixes: 89aac60e0be9 ("vfio: fix interrupts race condition") > Cc: david.march...@redhat.com > > Signed-off-by: Nithin Dabilpuram

Re: [dpdk-dev] [PATCH v1] examples/vm_power: fix no PCI option for guest cli

2019-10-29 Thread Yao, Lei A
> -Original Message- > From: Hunt, David > Sent: Tuesday, October 29, 2019 7:40 PM > To: dev@dpdk.org > Cc: Yao, Lei A ; Hunt, David > Subject: [PATCH v1] examples/vm_power: fix no PCI option for guest cli > > If there are no ports available to the guest cli a

Re: [dpdk-dev] [PATCH v6 3/4] app/testpmd: move pkt prepare logic into a separate function

2019-04-09 Thread Yao, Lei A
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Tuesday, April 9, 2019 5:33 PM > To: Lin, Xueqin ; Yigit, Ferruh > Cc: dev@dpdk.org; Xu, Qian Q ; Li, WenjieX A > ; Wang, FengqinX ; > Yao, Lei A ; Wang,

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size calculation

2019-04-09 Thread Yao, Lei A
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, April 10, 2019 4:59 AM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran ; Lin, Xueqin ; > Richardson, Bruce ; tho...@monjalon.net > Cc: dev@dpdk.org; Yao, Lei A ; Wang, FengqinX >

[dpdk-dev] [PATCH v3] i40e: enable i40e pmd on ARM platform

2016-08-10 Thread Yao, Lei A
Hi, Jianbo I have tested you patch , this v3 patch didn't impact the performance on X86 platform. Non-vector PMD single core performance with patch : ~35 Mpps Non-vector PMD single core performance without patch: ~35 Mpps BRs Lei -Original Message- Date

[dpdk-dev] [PATCH] vhost: add pmd xstats

2016-08-30 Thread Yao, Lei A
/ ~15249. If both patch integrated, the performance drop will be much higher Vhsot Xstats patch + Vhost mergeable on patch with mergeable on : the performance drop is around 6% Best Regards Lei -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Zhiyong

[dpdk-dev] [PATCH] vhost: add pmd xstats

2016-08-30 Thread Yao, Lei A
Hi, Qian The test setup at my side is Vhost/VirtIO loopback with 64B packets. -Original Message- From: Xu, Qian Q Sent: Tuesday, August 30, 2016 11:03 AM To: Yao, Lei A ; Yang, Zhiyong ; Panu Matilainen ; Thomas Monjalon ; Yuanhan Liu Cc: dev at dpdk.org Subject: RE: [dpdk-dev

[dpdk-dev] [PATCH v3 02/12] net/virtio: setup and start cq in configure callback

2016-11-02 Thread Yao, Lei A
port), the vm shutdown immediately. BRs Lei -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz Sent: Thursday, October 13, 2016 10:16 PM To: dev at dpdk.org; yuanhan.liu at linux.intel.com Cc: Ananyev, Konstantin ; Chandran, Sugesh ; Richardson, Bruce

[dpdk-dev] [PATCH v2 00/10] net/virtio: fix queue reconfigure issue

2016-11-07 Thread Yao, Lei A
Tested-by: Lei Yao - Apply patch to v16.11-rc2 - Compile: Pass - OS: Ubuntu16.04 4.4.0-45-generic - GCC: 5.4.0 Most of the basic Virtio related test cases are tested with this patch. No function issue found and no obvious performance drop. The following is the pass case list: TC1:? vhost

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Yao, Lei A
Tested-by: Lei Yao - Apply patch to v16.11-rc3 - Compile: Pass - Host OS: VMware ESXi 6.0 - VM OS: Fedora 20 - GCC: 4.8.3 Tested with this patch, l3fwd sample can work with i40e VF with Fedora VM using VMware as the host. -Original Message- From: Topel, Bjorn Sent: Wednesday, November

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-10 Thread Yao, Lei A
rc-strip enable" is a better way to resolve this issue. Lei -Original Message- From: Topel, Bjorn Sent: Wednesday, November 9, 2016 9:10 PM To: Zhang, Helin ; Ananyev, Konstantin ; dev at dpdk.org Cc: Xu, Qian Q ; Yao, Lei A ; Wu, Jingjing ; thomas.monjalon at 6wind.com Subject: R