[PATCH v2 07/29] crypto/cnxk: only enable queues that are allocated

2021-12-16 Thread Anoob Joseph
From: Shijith Thotton Only enable/disable queue pairs that are allocated during cryptodev start/stop. Fixes: 6a95dbc1a291 ("crypto/cnxk: add dev start and dev stop") Signed-off-by: Shijith Thotton --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 13 +++-- 1 file changed, 11 insertions(+

[PATCH v2 08/29] crypto/cnxk: add lookaside IPsec AES-CBC-HMAC-SHA256 support

2021-12-16 Thread Anoob Joseph
From: Tejasree Kondoj Adding AES-CBC-HMAC-SHA256 support to lookaside IPsec PMD. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 39 +++ doc/guides/rel_notes/release_22_03.rst| 4 +++ drivers/common/cnxk/cnxk_security.c

[PATCH v2 09/29] crypto/cnxk: clear session data before populating

2021-12-16 Thread Anoob Joseph
Clear session data before populating fields to not have garbage data. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/cnxk/cn10k_ipsec.c b/drivers/crypto/cnxk/cn10k_ipsec.c index 93eab1b..1bd127e 100644

[PATCH v2 10/29] crypto/cnxk: update max sec crypto caps

2021-12-16 Thread Anoob Joseph
Update the macro to include newly added ciphers. Updated the functions populating caps to throw error when max is exceeded. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev.h | 2 +- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 8 ++-- 2 files changed

[PATCH v2 11/29] crypto/cnxk: write CPT CTX through microcode op

2021-12-16 Thread Anoob Joseph
From: Tejasree Kondoj Adding support to write CPT CTX through microcode op(SET_CTX) for cn10k lookaside PMD. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_ipsec.c | 121 -- 1 file changed, 89 insertions(+), 32 deletions(-) diff --git a/driver

[PATCH v2 12/29] crypto/cnxk: support cnxk lookaside IPsec HMAC-SHA384/512

2021-12-16 Thread Anoob Joseph
From: Tejasree Kondoj Adding HMAC-SHA384/512 support to cnxk lookaside IPsec. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 4 ++ doc/guides/rel_notes/release_22_03.rst| 2 + drivers/common/cnxk/cnxk_security.c | 36 +

[PATCH v2 13/29] crypto/cnxk: account for CPT CTX updates and flush delays

2021-12-16 Thread Anoob Joseph
to differentiate s/w immutable and s/w mutable portions. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 4 +-- drivers/crypto/cnxk/cn10k_ipsec.c | 60 --- drivers/crypto/cnxk/cn10k_ipsec.h | 27 +- drivers

[PATCH v2 14/29] crypto/cnxk: use struct sizes for ctx writes

2021-12-16 Thread Anoob Joseph
CTX writes only require the lengths are 8B aligned. Use the struct size directly. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_ipsec.c b/drivers/crypto/cnxk

[PATCH v2 15/29] crypto/cnxk: add security session stats get

2021-12-16 Thread Anoob Joseph
From: Ankur Dwivedi Adds the security session stats get op for cn10k. Signed-off-by: Ankur Dwivedi --- drivers/crypto/cnxk/cn10k_ipsec.c | 55 +++ drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + drivers/crypto/cnxk/cnxk_cryptodev_sec.c |

[PATCH v2 16/29] crypto/cnxk: add skip for unsupported cases

2021-12-16 Thread Anoob Joseph
Add skip for transport mode tests that are not supported. Also, updated the transport mode path to configure IP version as v4. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec.c | 53 +++- 1 file changed, 47 insertions(+), 6 deletions(-) diff

[PATCH v2 17/29] crypto/cnxk: add context reload for IV

2021-12-16 Thread Anoob Joseph
From: Tejasree Kondoj Adding context reload in datapath for IV in debug mode. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 7 --- drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 10 -- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/dr

[PATCH v2 18/29] crypto/cnxk: handle null chained ops

2021-12-16 Thread Anoob Joseph
Verification doesn't cover cases when NULL auth/cipher is provided as a chain. Removed the separate function for verification and added a replacement function which calls the appropriate downstream functions. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c

[PATCH v2 19/29] crypto/cnxk: fix inflight cnt calculation

2021-12-16 Thread Anoob Joseph
Inflight count calculation is updated to cover wrap around cases where head can become smaller than tail. Reported-by: Kiran Kumar K Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto

[PATCH v2 20/29] crypto/cnxk: use atomics to access CPT res

2021-12-16 Thread Anoob Joseph
The memory would be updated by hardware. Use atomics to read the same. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/hw/cpt.h | 2 ++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 24 drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 28

[PATCH v2 21/29] crypto/cnxk: add more info on command timeout

2021-12-16 Thread Anoob Joseph
Print more info when command timeout happens. Print software and hardware queue information. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/hw/cpt.h | 11 drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 1 + drivers/crypto/cnxk

[PATCH v2 23/29] crypto/cnxk: fix extend tail calculation

2021-12-16 Thread Anoob Joseph
arvell.com Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h b/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h index 2dc8913..2b0261e 100644 --- a/drivers/c

[PATCH v2 24/29] crypto/cnxk: add aes xcbc and null cipher

2021-12-16 Thread Anoob Joseph
Add support for AES XCBC and NULL cipher. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/cnxk.rst| 4 + doc/guides/rel_notes/release_22_03.rst| 2 + drivers/common/cnxk/cnxk_security.c | 48 drivers/common/cnxk/roc_ie_on.h

[PATCH v2 25/29] crypto/cnxk: add copy and set DF

2021-12-16 Thread Anoob Joseph
Add support for copy and set DF bit. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec.c | 7 ++- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cn9k_ipsec.c b/drivers

[PATCH v2 26/29] crypto/cnxk: add aes cmac

2021-12-16 Thread Anoob Joseph
Add support for AES CMAC auth algorithm. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/cnxk.rst| 1 + doc/guides/cryptodevs/features/cn10k.ini | 37 +++--- doc/guides/cryptodevs/features/cn9k.ini | 37 +++--- doc/guides/rel_notes

[PATCH v2 27/29] crypto/cnxk: add per pkt IV in lookaside IPsec debug mode

2021-12-16 Thread Anoob Joseph
From: Archana Muniganti For cn9k, use HW GEN IV as default and add per pkt IV in lookaside IPsec debug mode. Debug mode helps to verify lookaside PMD using known outbound vectors in lookaside autotest. Signed-off-by: Archana Muniganti --- drivers/common/cnxk/roc_ie_on.h | 7

[PATCH v2 28/29] crypto/cnxk: enable copy dscp

2021-12-16 Thread Anoob Joseph
Copy DSCP is supported. Enable it in capabilities. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c index

[PATCH v2 29/29] crypto/cnxk: update microcode completion handling

2021-12-16 Thread Anoob Joseph
Update microcode completion code handling to update the required mbuf & crypto op flags. IP checksum good case is now reported by specific microcode completion code. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 59 ++- drivers/cr

[PATCH v2 22/29] crypto/cnxk: support lookaside IPsec AES-CTR

2021-12-16 Thread Anoob Joseph
From: Tejasree Kondoj Adding AES-CTR support to cnxk CPT in lookaside IPsec mode. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 2 ++ doc/guides/rel_notes/release_22_03.rst| 1 + drivers/common/cnxk/cnxk_security.c | 6 +

[PATCH v3 00/29] New features and improvements in cnxk crypto PMD

2021-12-17 Thread Anoob Joseph
mp; set DSCP - Support for per packet IV in cn9k - Support for cn10k v1.19 microcode Ankur Dwivedi (1): crypto/cnxk: add security session stats get Anoob Joseph (20): common/cnxk: define minor opcodes for MISC opcode common/cnxk: add aes-xcbc key derive common/cnxk: fix reset of fields

[PATCH v3 01/29] common/cnxk: define minor opcodes for MISC opcode

2021-12-17 Thread Anoob Joseph
MISC CPT instruction behaves differently based on minor opcode. Define the missing minor opcodes for MISC major opcode. Signed-off-by: Aakash Sasidharan Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_se.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 02/29] common/cnxk: add aes-xcbc key derive

2021-12-17 Thread Anoob Joseph
Add support for AES-XCBC key derivation. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_aes.c | 208 drivers/common/cnxk/roc_aes.h | 14 +++ drivers/common/cnxk/roc_api.h | 3 + drivers/common

[PATCH v3 03/29] common/cnxk: add bit fields for params

2021-12-17 Thread Anoob Joseph
From: Archana Muniganti Added new structure with bit fields for params. Signed-off-by: Archana Muniganti --- drivers/common/cnxk/roc_ie_on.h | 30 +- drivers/crypto/cnxk/cn9k_ipsec.c | 16 +--- 2 files changed, 42 insertions(+), 4 deletions(-) diff --

[PATCH v3 04/29] common/cnxk: fix reset of fields

2021-12-17 Thread Anoob Joseph
Copy DF/DSCP fields would get set based on ipsec_xform in the code preceding this. Setting it again would cause the options to be reset. Fixes: 78d03027f2cc ("common/cnxk: add IPsec common code") Cc: scha...@marvell.com Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_secu

[PATCH v3 05/29] common/cnxk: verify input args

2021-12-17 Thread Anoob Joseph
Add input arg verification. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/hw/cpt.h | 2 ++ drivers/common/cnxk/roc_cpt.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/hw/cpt.h b/drivers/common/cnxk/hw/cpt.h index 919f842..ccc7af4 100644 --- a

[PATCH v3 06/29] common/cnxk: update completion code

2021-12-17 Thread Anoob Joseph
Update completion code to match v1.19 microcode release. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_ie_ot.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_ie_ot.h b/drivers/common/cnxk/roc_ie_ot.h index 5b61902..923656f 100644 --- a

[PATCH v3 07/29] crypto/cnxk: only enable queues that are allocated

2021-12-17 Thread Anoob Joseph
From: Shijith Thotton Only enable/disable queue pairs that are allocated during cryptodev start/stop. Fixes: 6a95dbc1a291 ("crypto/cnxk: add dev start and dev stop") Signed-off-by: Shijith Thotton --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 13 +++-- 1 file changed, 11 insertions(+

[PATCH v3 08/29] crypto/cnxk: add lookaside IPsec AES-CBC-HMAC-SHA256 support

2021-12-17 Thread Anoob Joseph
From: Tejasree Kondoj Adding AES-CBC-HMAC-SHA256 support to lookaside IPsec PMD. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 39 +++ doc/guides/rel_notes/release_22_03.rst| 4 +++ drivers/common/cnxk/cnxk_security.c

[PATCH v3 09/29] crypto/cnxk: clear session data before populating

2021-12-17 Thread Anoob Joseph
Clear session data before populating fields to not have garbage data. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/cnxk/cn10k_ipsec.c b/drivers/crypto/cnxk/cn10k_ipsec.c index 93eab1b..1bd127e 100644

[PATCH v3 10/29] crypto/cnxk: update max sec crypto caps

2021-12-17 Thread Anoob Joseph
Update the macro to include newly added ciphers. Updated the functions populating caps to throw error when max is exceeded. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev.h | 2 +- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 8 ++-- 2 files changed

[PATCH v3 11/29] crypto/cnxk: write CPT CTX through microcode op

2021-12-17 Thread Anoob Joseph
From: Tejasree Kondoj Adding support to write CPT CTX through microcode op(SET_CTX) for cn10k lookaside PMD. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_ipsec.c | 121 -- 1 file changed, 89 insertions(+), 32 deletions(-) diff --git a/driver

[PATCH v3 12/29] crypto/cnxk: support cnxk lookaside IPsec HMAC-SHA384/512

2021-12-17 Thread Anoob Joseph
From: Tejasree Kondoj Adding HMAC-SHA384/512 support to cnxk lookaside IPsec. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 4 ++ doc/guides/rel_notes/release_22_03.rst| 2 + drivers/common/cnxk/cnxk_security.c | 36 +

[PATCH v3 13/29] crypto/cnxk: account for CPT CTX updates and flush delays

2021-12-17 Thread Anoob Joseph
to differentiate s/w immutable and s/w mutable portions. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 4 +-- drivers/crypto/cnxk/cn10k_ipsec.c | 60 --- drivers/crypto/cnxk/cn10k_ipsec.h | 27 +- drivers

[PATCH v3 14/29] crypto/cnxk: use struct sizes for ctx writes

2021-12-17 Thread Anoob Joseph
CTX writes only require the lengths are 8B aligned. Use the struct size directly. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_ipsec.c b/drivers/crypto/cnxk

[PATCH v3 15/29] crypto/cnxk: add security session stats get

2021-12-17 Thread Anoob Joseph
From: Ankur Dwivedi Adds the security session stats get op for cn10k. Signed-off-by: Ankur Dwivedi --- drivers/crypto/cnxk/cn10k_ipsec.c | 55 +++ drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + drivers/crypto/cnxk/cnxk_cryptodev_sec.c |

[PATCH v3 16/29] crypto/cnxk: add skip for unsupported cases

2021-12-17 Thread Anoob Joseph
Add skip for transport mode tests that are not supported. Also, updated the transport mode path to configure IP version as v4. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec.c | 53 +++- 1 file changed, 47 insertions(+), 6 deletions(-) diff

[PATCH v3 17/29] crypto/cnxk: add context reload for IV

2021-12-17 Thread Anoob Joseph
From: Tejasree Kondoj Adding context reload in datapath for IV in debug mode. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 7 --- drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 10 -- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/dr

[PATCH v3 18/29] crypto/cnxk: handle null chained ops

2021-12-17 Thread Anoob Joseph
Verification doesn't cover cases when NULL auth/cipher is provided as a chain. Removed the separate function for verification and added a replacement function which calls the appropriate downstream functions. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c

[PATCH v3 19/29] crypto/cnxk: fix inflight cnt calculation

2021-12-17 Thread Anoob Joseph
Inflight count calculation is updated to cover wrap around cases where head can become smaller than tail. Reported-by: Kiran Kumar K Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto

[PATCH v3 20/29] crypto/cnxk: use atomics to access CPT res

2021-12-17 Thread Anoob Joseph
The memory would be updated by hardware. Use atomics to read the same. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/hw/cpt.h | 2 ++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 24 drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 28

[PATCH v3 21/29] crypto/cnxk: add more info on command timeout

2021-12-17 Thread Anoob Joseph
Print more info when command timeout happens. Print software and hardware queue information. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/hw/cpt.h | 11 drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 1 + drivers/crypto/cnxk

[PATCH v3 22/29] crypto/cnxk: support lookaside IPsec AES-CTR

2021-12-17 Thread Anoob Joseph
From: Tejasree Kondoj Adding AES-CTR support to cnxk CPT in lookaside IPsec mode. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 2 ++ doc/guides/rel_notes/release_22_03.rst| 1 + drivers/common/cnxk/cnxk_security.c | 6 +

[PATCH v3 23/29] crypto/cnxk: fix extend tail calculation

2021-12-17 Thread Anoob Joseph
arvell.com Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h b/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h index 2dc8913..2b0261e 100644 --- a/drivers/c

[PATCH v3 24/29] crypto/cnxk: add aes xcbc and null cipher

2021-12-17 Thread Anoob Joseph
Add support for AES XCBC and NULL cipher. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/cnxk.rst| 4 + doc/guides/rel_notes/release_22_03.rst| 2 + drivers/common/cnxk/cnxk_security.c | 48 drivers/common/cnxk/roc_ie_on.h

[PATCH v3 25/29] crypto/cnxk: add copy and set DF

2021-12-17 Thread Anoob Joseph
Add support for copy and set DF bit. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec.c | 7 ++- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cn9k_ipsec.c b/drivers

[PATCH v3 26/29] crypto/cnxk: add aes cmac

2021-12-17 Thread Anoob Joseph
Add support for AES CMAC auth algorithm. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/cnxk.rst| 1 + doc/guides/cryptodevs/features/cn10k.ini | 37 +++--- doc/guides/cryptodevs/features/cn9k.ini | 37 +++--- doc/guides/rel_notes

[PATCH v3 27/29] crypto/cnxk: add per pkt IV in lookaside IPsec debug mode

2021-12-17 Thread Anoob Joseph
From: Archana Muniganti For cn9k, use HW GEN IV as default and add per pkt IV in lookaside IPsec debug mode. Debug mode helps to verify lookaside PMD using known outbound vectors in lookaside autotest. Signed-off-by: Archana Muniganti --- drivers/common/cnxk/roc_ie_on.h | 7

[PATCH v3 28/29] crypto/cnxk: enable copy dscp

2021-12-17 Thread Anoob Joseph
Copy DSCP is supported. Enable it in capabilities. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c index

[PATCH v3 29/29] crypto/cnxk: update microcode completion handling

2021-12-17 Thread Anoob Joseph
Update microcode completion code handling to update the required mbuf & crypto op flags. IP checksum good case is now reported by specific microcode completion code. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 59 ++- drivers/cr

Re: [dpdk-dev] [EXT] [PATCH] cryptodev: support multiple cipher block sizes

2021-02-25 Thread Anoob Joseph
ay, February 4, 2021 8:04 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Declan Doherty ; > Somalapuram Amaranath ; Ruifeng Wang > ; Ajit Khaparde ; > Anoob Joseph ; Fan Zhang > ; John Griffin ; Pablo de > Lara ; Michael Shamis > ; Nagadheeraj Rottela > ; Ankur Dwivedi

RE: [PATCH 2/5] lib: add pdcp protocol

2023-02-13 Thread Anoob Joseph
Hi Akhil, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Wednesday, January 18, 2023 9:57 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger

RE: [PATCH] test/crypto: fix return value from session

2023-05-07 Thread Anoob Joseph
> > Fixing return value if session failure occurs due to unsupported feature. > > Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto > operations") > Cc: sta...@dpdk.org > > Signed-off-by: Tejasree Kondoj Acked-by: Anoob Joseph

RE: min_mbuf_head/tailroom_req in rte_cryptodev_info

2023-05-09 Thread Anoob Joseph
Hi Suanming, Please see inline. Thanks, Anoob > From: Suanming Mou > Sent: Tuesday, May 9, 2023 5:23 PM > To: Anoob Joseph ; Doherty, Declan > > Cc: Akhil Goyal ; dev@dpdk.org > Subject: [EXT] min_mbuf_head/tailroom_req in rte_cryptodev_info

[PATCH 1/2] test/crypto: use separate keys for auth and cipher

2023-05-11 Thread Anoob Joseph
The mixed test cases can have keys with different key lengths. The routine which prepares the session parameters uses same key length for both cipher & auth keys. Instead allow the caller to use same keys as required. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c

[PATCH 2/2] test/crypto: specify correct parameters with null algos

2023-05-11 Thread Anoob Joseph
Keys are not required for NULL algorithms. Same way IV, digest lengths should also be set to 0. The values are invalid and any PMD which validates such parameters would return "-ENOTSUP" for such cases which would result in false skipping of tests. Signed-off-by: Anoob Joseph ---

RE: [PATCH] test/crypto: fix IPsec AES CCM test vector

2023-05-12 Thread Anoob Joseph
1 insertion(+), 1 deletion(-) > Acked-by: Anoob Joseph

[PATCH 2/2] test/crypto: handle return code

2023-05-12 Thread Anoob Joseph
The sub test case, test_snow3g_decryption, may fail for non-critical reasons such as lack of support. Handle the return value gracefully to allow TEST_SKIPPED return value to be propagated correctly. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 6 -- 1 file changed, 4

[PATCH 1/2] test/crypto: free memory in error and skip paths

2023-05-12 Thread Anoob Joseph
ll as operation failures. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 55 +++ 1 file changed, 39 insertions(+), 16 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index fb4fc4e805..86e63a33fc 100644 --- a/app

[PATCH] test/crypto: remove redundant code

2023-05-12 Thread Anoob Joseph
Code for registering raw API tests for various PMDs are repeated. Add common routine to avoid duplication of code. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 40 ++- 1 file changed, 10 insertions(+), 30 deletions(-) diff --git a/app/test

RE: [PATCH 2/2] test/crypto: handle return code

2023-05-16 Thread Anoob Joseph
Hi Ciara, > This looks like a duplicate of a patch recently merged: Indeed. Missed it. @Akhil, we can abandon this patch. Thanks, Anoob > -Original Message- > From: Power, Ciara > Sent: Tuesday, May 16, 2023 4:16 PM > To: Akhil Goyal ; Anoob Joseph > ; Fan Zhang &g

[PATCH v2] test/crypto: free memory in error and skip paths

2023-05-17 Thread Anoob Joseph
ll as operation failures. Signed-off-by: Anoob Joseph --- v2: * Moved 'ASSERT' to the end to allow cleanup in all cases. --- app/test/test_cryptodev.c | 59 --- 1 file changed, 43 insertions(+), 16 deletions(-) diff --git a/app/test/test_cryptod

RE: [PATCH v2 02/22] lib: add pdcp protocol

2023-05-17 Thread Anoob Joseph
Hi Akhil, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 16, 2023 9:01 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger

RE: [PATCH v2 07/22] pdcp: add pre and post process for DL

2023-05-18 Thread Anoob Joseph
HI Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 12:17 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Ma

RE: [PATCH v2 04/22] pdcp: add packet group

2023-05-18 Thread Anoob Joseph
Hi Akhil, Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 16, 2023 9:27 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Ag

RE: [PATCH v2 02/22] lib: add pdcp protocol

2023-05-18 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 1:10 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Ma

RE: [PATCH v2 09/22] app/test: add lib pdcp tests

2023-05-18 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 1:34 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Ma

RE: [PATCH v2 09/22] app/test: add lib pdcp tests

2023-05-19 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 5:36 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Ma

RE: [PATCH v2 02/22] lib: add pdcp protocol

2023-05-22 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 2:16 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Ma

RE: [PATCH v2 11/22] doc: add PDCP library guide

2023-05-22 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 1:56 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Ma

RE: [PATCH v2 12/22] pdcp: add control PDU handling

2023-05-22 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 2:45 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Ma

RE: [PATCH v2 16/22] pdcp: add timer expiry handle

2023-05-22 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 3:13 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Volodymyr

[PATCH 1/2] cryptodev: update raw datapath API documentation

2023-05-22 Thread Anoob Joseph
Clarify the error codes returned by rte_cryptodev_raw_dp_ctx. Cryptodev can return -ENOTSUP to indicate any unsupported features with raw APIs. Remove redundant references about 'rte_cryptodev_raw_attach_session()'. The API is not part of the specification. Signed-off-by: Anoob Jose

[PATCH 2/2] test/crypto: handle returns from raw crypto APIs

2023-05-22 Thread Anoob Joseph
Raw crypto APIs may return -ENOTSUP when the cryptodev does not support the requested feature. Handle it gracefully so that tests get marked as "SKIPPED" instead of "FAILED". Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 449 +++-

[PATCH v3 00/22] lib: add pdcp protocol

2023-05-24 Thread Anoob Joseph
assed : 131 + Tests Failed : 0 + ------- + Test OK Anoob Joseph (10): lib: add pdcp protocol pdcp: add pre and post-process pdcp: add packet group pdcp: add crypto session create and destroy pdcp: add pre and post process for UL pdcp: add pre and post process for DL pdcp: add IV ge

[PATCH v3 01/22] net: add PDCP header

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Add PDCP protocol header to be used for supporting PDCP protocol processing. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- doc/api/doxy-api-index.md | 3 +- lib/net/meson.build | 1 + lib

[PATCH v3 02/22] lib: add pdcp protocol

2023-05-24 Thread Anoob Joseph
. Uplink data compression 5. Ciphering and integrity protection PDCP library provides following control path APIs that is used to configure various PDCP entities, 1. rte_pdcp_entity_establish() 2. rte_pdcp_entity_suspend() 3. rte_pdcp_entity_release() Signed-off-by: Anoob Joseph Signed-off-by: Kiran

[PATCH v3 03/22] pdcp: add pre and post-process

2023-05-24 Thread Anoob Joseph
lows skipping multiple checks that would come in datapath otherwise. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/rte_pdcp.h | 97 lib/pdcp/version.map | 3 ++ 2 files cha

[PATCH v3 04/22] pdcp: add packet group

2023-05-24 Thread Anoob Joseph
entity. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build | 1 + lib/pdcp/rte_pdcp.h | 2 + lib/pdcp/rte_pdcp_group.h | 131 ++ lib/pdcp/version.map | 3 + 4 files changed

[PATCH v3 05/22] pdcp: add crypto session create and destroy

2023-05-24 Thread Anoob Joseph
Add routines to create & destroy sessions. PDCP lib would take crypto transforms as input and creates the session on the corresponding device after verifying capabilities. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_crypto.c |

[PATCH v3 06/22] pdcp: add pre and post process for UL

2023-05-24 Thread Anoob Joseph
per PDCP specification). Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_entity.h | 24 +++ lib/pdcp/pdcp_process.c | 330 2 files changed, 354 insertions(+) diff --git a

[PATCH v3 07/22] pdcp: add pre and post process for DL

2023-05-24 Thread Anoob Joseph
Add routines to perform pre & post processing for down link entities. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 2 + lib/pdcp/pdcp_process.c | 454 2 files changed,

[PATCH v3 08/22] pdcp: add IV generation routines

2023-05-24 Thread Anoob Joseph
For PDCP, IV generated has varying formats depending on the ciphering and authentication algorithm used. Add routines to populate IV accordingly. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 87 lib/pdcp/pdcp_process.c | 284

[PATCH v3 09/22] app/test: add lib pdcp tests

2023-05-24 Thread Anoob Joseph
Add tests to verify lib PDCP operations. Tests leverage existing PDCP test vectors. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/meson.build | 1 + app/test/test_cryptodev.h | 3 + app/test/test_pdcp.c | 730 ++ 3

[PATCH v3 10/22] test/pdcp: pdcp HFN tests in combined mode

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Add tests to verify HFN/SN behaviour. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 302 ++- 1 file changed, 299 insertions(+), 3 deletions(-) diff --git a/app/test/test_pdcp.c b/app/test

[PATCH v3 11/22] doc: add PDCP library guide

2023-05-24 Thread Anoob Joseph
Add guide for PDCP library. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- .../img/pdcp_functional_overview.svg | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/pdcp_lib.rst| 254

[PATCH v3 12/22] pdcp: add control PDU handling for status report

2023-05-24 Thread Anoob Joseph
Add control PDU handling and implement status report generation. Status report generation works only when RX_DELIV = RX_NEXT. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- doc/guides/prog_guide/pdcp_lib.rst | 9 ++ lib/pdcp/meson.build | 2 ++ lib/pdcp

[PATCH v3 13/22] pdcp: implement t-Reordering and packet buffering

2023-05-24 Thread Anoob Joseph
se packets would be held in the buffer, waiting for any missing packets to arrive. Introduce packet buffering and state variables which indicate status of the timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build| 3 +- lib/pdcp/pdcp_entity.h | 19 ++

[PATCH v3 14/22] test/pdcp: add in-order delivery cases

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Add test cases to verify behaviour when in-order delivery is enabled and packets arrive in out-of-order. PDCP library is expected to buffer the packets and return packets in-order when the missing packet arrives. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr

[PATCH v3 15/22] pdcp: add timer callback handlers

2023-05-24 Thread Anoob Joseph
when a missing packet is received. To avoid dependency on particular timer implementation, PDCP library allows application to register two callbacks, timer_start() and timer_stop() that will be called later by library. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib

[PATCH v3 16/22] pdcp: add timer expiry handle

2023-05-24 Thread Anoob Joseph
notified, and further handling of the event will be performed in the PDCP library. When the timer expires, the PDCP library will return the cached packets, and PDCP internal state variables (like RX_REORD, RX_DELIV etc) will be updated accordingly. Signed-off-by: Anoob Joseph Signed-off-by

[PATCH v3 17/22] test/pdcp: add timer expiry cases

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Add test cases for handling the expiry with rte_timer and rte_event_timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 350 +++ 1 file changed, 350 insertions(+) diff --git a/app/test

[PATCH v3 18/22] test/pdcp: add timer restart case

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Add test to cover the case when t-reordering timer should be restarted on the same packet. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 68 1 file changed, 68 insertions(+) diff

[PATCH v3 19/22] pdcp: add support for status report

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Implement status report generation for PDCP entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 158 --- lib/pdcp/pdcp_cnt.h | 11 ++- lib/pdcp/pdcp_ctrl_pdu.c | 34 - lib

[PATCH v3 20/22] pdcp: allocate reorder buffer alongside with entity

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Instead of allocating reorder buffer separately on heap, allocate memory for it together with rest of entity, and then only initialize buffer via `rte_reorder_init()`. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 9

[PATCH v3 21/22] pdcp: add thread safe processing

2023-05-24 Thread Anoob Joseph
requires thread safe processing, the state variables need to be updated atomically. Add config option to select this option per entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 46 + lib/pdcp/pdcp_process.c

[PATCH v3 22/22] test/pdcp: add PDCP status report cases

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Test PDCP status report generation. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 312 +++ 1 file changed, 312 insertions(+) diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c index

<    1   2   3   4   5   6   7   8   9   10   >