[dpdk-dev] [PATCH 03/15] examples/l2fwd: move structure definitions to common header

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_common.h | 12 examples/l2fwd/main.c | 10 -- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2fwd/l2fwd_common.h index fe354cf..40979fd 100644 --- a

[dpdk-dev] [PATCH 05/15] examples/l2fwd: add missing space

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index a6089a1..6229a20 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -71,7 +71,7 @@ print_stats(void

[dpdk-dev] [PATCH 06/15] examples/l2fwd: fix lines exceeding 80 char limit

2018-06-08 Thread Anoob Joseph
Fixes: e2366e74e029 ("examples: use buffered Tx") Fixes: af75078fece3 ("first public release") Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/

[dpdk-dev] [PATCH 07/15] examples/l2fwd: move dataplane code to new file

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/Makefile | 1 + examples/l2fwd/l2fwd_worker.c | 233 ++ examples/l2fwd/l2fwd_worker.h | 10 ++ examples/l2fwd/main.c | 191 +- 4 files changed, 245 insertions

[dpdk-dev] [PATCH 04/15] examples/l2fwd: move globally accessed vars to common header

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_common.h | 26 ++ examples/l2fwd/main.c | 41 + 2 files changed, 43 insertions(+), 24 deletions(-) diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2fwd

[dpdk-dev] [PATCH 08/15] examples/l2fwd: remove unused header includes

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 12 1 file changed, 12 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 1f97911..8298005 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd/l2fwd_worker.c

[dpdk-dev] [PATCH 09/15] examples/l2fwd: move drain buffers to new function

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 8298005..ee2de58 100644 --- a/examples/l2fwd/l2fwd_worker.c

[dpdk-dev] [PATCH 12/15] examples/l2fwd: skip timer updates for non master cores

2018-06-08 Thread Anoob Joseph
The timer updates and checks are required only for stats printing by the master core. This can be entirely skipped for other cores. Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/examples

[dpdk-dev] [PATCH 11/15] examples/l2fwd: move periodic tasks to new function

2018-06-08 Thread Anoob Joseph
Move the periodic operations (stats flush and drain buffers) to a new function. Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 83 --- examples/l2fwd/l2fwd_worker.h | 6 2 files changed, 52 insertions(+), 37 deletions(-) diff --git

[dpdk-dev] [PATCH 10/15] examples/l2fwd: optimize check for master core

2018-06-08 Thread Anoob Joseph
Replacing the check for lcore_id & mastercore_id with the check for a flag. Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index ee2

[dpdk-dev] [PATCH 14/15] examples/l2fwd: use fprint instead of printf for usage print

2018-06-08 Thread Anoob Joseph
Following the convention of l3fwd, using fprintf instead of printf for printing usage. Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 05f9d28..3b697d1 100644 --- a

[dpdk-dev] [PATCH 15/15] examples/l2fwd: improvements to the usage print

2018-06-08 Thread Anoob Joseph
Fixed alignment and split the usage print to aid easy addition of eventmode usage prints. Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index

[dpdk-dev] [PATCH 13/15] examples/l2fwd: move pkt send code to a new function

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 9ba78f6..56e0bdb 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples

[dpdk-dev] [PATCH 00/20] add eventmode helper functions

2018-06-08 Thread Anoob Joseph
ntx event PMD on Cavium's CN83XX platform. Parts of this patchset is inspired by an RFC send by Sunil Kumar Kori Anoob Joseph (20): eventdev: add files for eventmode helper eventdev: add routines for logging eventmode helper eventdev: add eventmode CL options framework eventdev: all

[dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- lib/librte_eventdev/Makefile| 2 ++ lib/librte_eventdev/rte_eventmode_helper.c | 7 +++ lib/librte_eventdev/rte_eventmode_helper.h | 6 ++ lib/librte_eventdev/rte_eventmode_helper_internal.h | 6 ++ 4 files

[dpdk-dev] [PATCH 03/20] eventdev: add eventmode CL options framework

2018-06-08 Thread Anoob Joseph
Adding usage prints and CL parsing routines for eventmode. Option to select packet transfer mode is also added. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 128 + lib/librte_eventdev/rte_eventmode_helper.h | 50 +++ 2 files

[dpdk-dev] [PATCH 02/20] eventdev: add routines for logging eventmode helper

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- config/common_base | 1 + lib/librte_eal/common/eal_common_log.c | 1 + lib/librte_eal/common/include/rte_log.h| 1 + .../rte_eventmode_helper_internal.h| 24 ++ 4 files

[dpdk-dev] [PATCH 04/20] eventdev: allow application to set ethernet portmask

2018-06-08 Thread Anoob Joseph
Application would be required to restrict helper functions to use only certain ports. The field eth_portmask field in the conf could be used for this. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 3 +++ lib/librte_eventdev/rte_eventmode_helper.h | 7 +++ 2

[dpdk-dev] [PATCH 05/20] eventdev: add framework for eventmode conf

2018-06-08 Thread Anoob Joseph
Adding eventmode conf which would have all required configuration for the event mode. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 16 lib/librte_eventdev/rte_eventmode_helper_internal.h | 5 + 2 files changed, 21 insertions

[dpdk-dev] [PATCH 06/20] eventdev: add common initialize routine for eventmode devs

2018-06-08 Thread Anoob Joseph
Adding framework for common initialization routine for event mode. Event mode would involve initialization of multiple devices, like eventdev, ethdev etc and this routine would be the placeholder for all initialization to come in. Signed-off-by: Anoob Joseph --- lib/librte_eventdev

[dpdk-dev] [PATCH 08/20] eventdev: add eventdev port-lcore link

2018-06-08 Thread Anoob Joseph
Adding eventdev port-lcore link. In addition, this will also specify which event queue need to be connected to the event port. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 56 ++ lib/librte_eventdev/rte_eventmode_helper.h | 12

[dpdk-dev] [PATCH 07/20] eventdev: add eventdevice init for eventmode

2018-06-08 Thread Anoob Joseph
Adding routines to initialize event devs. The internal conf structure would be used to track device configuration. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 129 + .../rte_eventmode_helper_internal.h| 16 ++- 2

[dpdk-dev] [PATCH 09/20] eventdev: add option to specify schedule mode for app stage

2018-06-08 Thread Anoob Joseph
Scheduling mode for each event queue is dependent on the same of app stage. Configure event queue taking this also into account. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 23 -- .../rte_eventmode_helper_internal.h

[dpdk-dev] [PATCH 10/20] eventdev: add placeholder for ethdev init

2018-06-08 Thread Anoob Joseph
Presently, all the applications would do ethdev init and then pass control to eventmode helper init. So not doing any "real" initialization. But this would be expanded once applications are modified to pass the eth init task also to the helper routine. Signed-off-by: Anoob Joseph

[dpdk-dev] [PATCH 13/20] eventdev: add default conf for event devs field in conf

2018-06-08 Thread Anoob Joseph
Generate a default conf for event devs, if it's not specified in the conf. This routine will check the available event devices and it's properties and sets the conf accordingly. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 67 +++

[dpdk-dev] [PATCH 11/20] eventdev: add Rx adapter init in eventmode

2018-06-08 Thread Anoob Joseph
Adding rx adapter conf. The helper init routine would be initializing the rx adapter according to the conf. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 122 + .../rte_eventmode_helper_internal.h| 27 + 2 files

[dpdk-dev] [PATCH 14/20] eventdev: add default conf for Rx adapter conf

2018-06-08 Thread Anoob Joseph
. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 127 + .../rte_eventmode_helper_internal.h| 4 + 2 files changed, 131 insertions(+) diff --git a/lib/librte_eventdev/rte_eventmode_helper.c b/lib/librte_eventdev

[dpdk-dev] [PATCH 12/20] eventdev: add routine to validate conf

2018-06-08 Thread Anoob Joseph
Adding routine to validate event mode conf. This function will verify the conf requested by the user and would populate other fields with default values. Presently, the function acts as placeholder for the above mentioned actions. Signed-off-by: Anoob Joseph --- lib/librte_eventdev

[dpdk-dev] [PATCH 15/20] eventdev: add default conf for event port-lcore link

2018-06-08 Thread Anoob Joseph
with every port. This enables one core to receive packets from every port. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 109 - .../rte_eventmode_helper_internal.h| 5 + 2 files changed, 113 insertions(+), 1 deletion

[dpdk-dev] [PATCH 18/20] eventdev: add routine to access event queue for eth Tx

2018-06-08 Thread Anoob Joseph
TOMIC before sending it, to ensure ingress ordering is maintained. Since, it is application who would do the tx, this info is required in it's space. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 35 ++ lib/librte_eventdev/rte_eventmod

[dpdk-dev] [PATCH 19/20] eventdev: add routine to launch eventmode workers

2018-06-08 Thread Anoob Joseph
With eventmode, workers could be drafted differently according to the capabilities of the underlying event device. The added function would receive an array of such workers and probes the eventmode properties to choose the worker. Signed-off-by: Anoob Joseph --- lib/librte_eventdev

[dpdk-dev] [PATCH 20/20] examples/l2fwd: add eventmode for l2fwd

2018-06-08 Thread Anoob Joseph
Adding eventmode support in l2fwd. This uses rte_eventmode_helper APIs to setup and use the eventmode capabilties. Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 815 +- examples/l2fwd/main.c | 64 +++- 2 files changed, 864

[dpdk-dev] [PATCH 17/20] eventdev: add routine to access eventmode link info

2018-06-08 Thread Anoob Joseph
application. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 80 ++ lib/librte_eventdev/rte_eventmode_helper.h | 25 ++ 2 files changed, 105 insertions(+) diff --git a/lib/librte_eventdev/rte_eventmode_helper.c b/lib/librte_eventdev

[dpdk-dev] [PATCH 16/20] eventdev: add routines to display the eventmode conf

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- lib/librte_eventdev/Makefile | 1 + lib/librte_eventdev/rte_eventmode_helper.c| 3 + lib/librte_eventdev/rte_eventmode_helper.h| 10 ++ lib/librte_eventdev/rte_eventmode_helper_prints.c | 161 ++ 4

[dpdk-dev] [PATCH] doc: announce ABI change for cryptodev config

2019-01-17 Thread Anoob Joseph
h devices, rte_eth_conf.rx_mode.offloads and rte_eth_conf.tx_mode.offloads fields are used by applications to control the offloads enabled on the eth device. This proposal adds a similar ability for the crypto device. Signed-off-by: Anoob Joseph --- doc/guides/rel_notes/deprecation.rst | 10 ++ 1 file ch

Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev config

2019-01-17 Thread Anoob Joseph
Hi Fiona, Please see inline. Thanks, Anoob > -Original Message- > From: Trahe, Fiona > Sent: 17 January 2019 17:07 > To: Anoob Joseph ; Akhil Goyal ; > De Lara Guarch, Pablo > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Shally Verma ; > de

Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev config

2019-01-22 Thread Anoob Joseph
Hi Fiona, Any more comments on this? @ Akhil, Pablo Can you review this change and share your thoughts? Thanks, Anoob > -Original Message- > From: Shally Verma > Sent: 18 January 2019 12:29 > To: Anoob Joseph ; Trahe, Fiona > ; Akhil Goyal ; De Lara Guarch, > Pablo

[dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-04 Thread Anoob Joseph
("crypto_driver") is done, it could give a false positive when compared against "crypto_driver1". Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph --- lib/librte_cryptodev/rte_crypto

[dpdk-dev] [PATCH] common/cpt: fix failure with null auth only test case

2019-02-13 Thread Anoob Joseph
Fixes: 351fbee21986 ("common/cpt: support hash") Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_ucode.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cpt/cpt_ucode.h b/drivers/common/cpt/cpt_ucode.h ind

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-20 Thread Anoob Joseph
Hi Akhil, Declan, Pablo, Can you review this patch and share your thoughts? Thanks, Anoob > -Original Message- > From: Anoob Joseph > Sent: Monday, February 4, 2019 4:56 PM > To: Akhil Goyal ; Declan Doherty > ; Pablo de Lara > Cc: Anoob Joseph ; Jerin Jacob Kollanuk

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-21 Thread Anoob Joseph
Hi Fiona, Please see inline. Thanks, Anoob > -Original Message- > From: Trahe, Fiona > Sent: Thursday, February 21, 2019 10:33 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; De > Lara Guarch, Pablo > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-22 Thread Anoob Joseph
Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Friday, February 22, 2019 9:09 PM > To: Anoob Joseph ; Akhil Goyal ; > Doherty, Declan ; De Lara Guarch, Pablo > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; dev@dpdk.org; Ankur

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-27 Thread Anoob Joseph
Hi Akhil, Declan, Pablo, Can you review this patch and share your thoughts? Thanks, Anoob > -Original Message- > From: Trahe, Fiona > Sent: Monday, February 25, 2019 5:22 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; De > Lara Guarch, Pablo ; Yigit,

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-28 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, February 28, 2019 2:22 PM > To: Anoob Joseph ; Trahe, Fiona > ; Doherty, Declan ; De > Lara Guarch, Pablo ; Yigit, Ferruh > ; Thomas Monjalon > Cc: J

Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev config

2019-02-28 Thread Anoob Joseph
Hi Akhil, I'll send a v2 incorporating Fiona's comments. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, February 28, 2019 3:32 PM > To: Trahe, Fiona ; Thomas Monjalon > ; dev@dpdk.org > Cc: Anoob Joseph ; De Lara Guarch, Pablo &

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-28 Thread Anoob Joseph
Hi Fiona, Akhil, > -Original Message- > From: dev On Behalf Of Trahe, Fiona > Sent: Thursday, February 28, 2019 8:00 PM > To: Akhil Goyal ; Anoob Joseph > ; Doherty, Declan ; De > Lara Guarch, Pablo ; Yigit, Ferruh > ; Thomas Monjalon > Cc: Jerin Jacob Kollanu

[dpdk-dev] [PATCH 1/3] common/cpt: improve structures used in datapath

2019-03-01 Thread Anoob Joseph
Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph --- drivers/common/cpt/cpt_common.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/cpt/cpt_common.h b/drivers/common/cpt/cpt_common.h index 8461cd6..8568d5b 100644 --- a/drivers/common/cpt

[dpdk-dev] [PATCH 2/3] common/cpt: redesign propagation of error

2019-03-01 Thread Anoob Joseph
: Anoob Joseph Signed-off-by: Archana Muniganti --- drivers/common/cpt/cpt_request_mgr.h | 12 +- drivers/common/cpt/cpt_ucode.h | 318 --- 2 files changed, 189 insertions(+), 141 deletions(-) diff --git a/drivers/common/cpt/cpt_request_mgr.h b/drivers/common

[dpdk-dev] [PATCH 3/3] crypto/octeontx: move device specific code to driver

2019-03-01 Thread Anoob Joseph
Moving upper level enqueue/dequeue routines to driver. The h/w interface used to submit request has enough differences to substantiate the need for separate routines. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti --- drivers/common/cpt/cpt_common.h

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-03-06 Thread Anoob Joseph
Hi Akhil, Fiona, Would the usage of strcmp be alright? Please check my comment inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Friday, March 1, 2019 11:55 AM > To: Trahe, Fiona ; Akhil Goyal > ; Doherty, Declan ; De > Lara Gua

[dpdk-dev] [PATCH v2] doc: announce ABI change for cryptodev config

2019-03-07 Thread Anoob Joseph
by: Anoob Joseph --- v2: * Renamed 'ff_enable' to 'ff_disable' doc/guides/rel_notes/deprecation.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 1b4fcb7..d0a60f9 1006

[dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-10 Thread Anoob Joseph
or crypto devices") Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph --- v2: * Using strlen + 1, instead of RTE_CRYPTODEV_NAME_MAX_LEN for the comparison. * Strcmp would not cause this issue. Touching only the places which would result in the issue. lib/librte_cryptodev/rte_cryptodev.

Re: [dpdk-dev] [PATCH v3 0/5] handle seq no overflow in IPsec offload

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: This series enables application to set the sequence number soft limit for IPsec offload. In inline IPsec offload, as the sequence number (maintained by PMD/device) reaches the specified soft l

Re: [dpdk-dev] [PATCH v3 2/5] lib/security: add ESN soft limit in conf

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: Adding ESN soft limit in conf. This will be used in case of protocol offload. Per SA, application could specify for what ESN the security device need to notify application. In case of eth dev(in

Re: [dpdk-dev] [PATCH v3 1/5] lib/ethdev: support for inline IPsec events

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: Adding support for IPsec events in rte_eth_event framework. In inline IPsec offload, the per packet protocol defined variables, like ESN, would be managed by PMD. In such cases, PMD would need I

Re: [dpdk-dev] [PATCH v3 3/5] lib/security: extend userdata for IPsec events

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: Extending 'userdata' to be used for IPsec events too. IPsec events would have some metadata which would uniquely identify the security session for which the event is raised. But app

Re: [dpdk-dev] [PATCH v3 4/5] examples/ipsec-secgw: handle ESN soft limit event

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: For inline protocol processing, the PMD/device is required to maintain the ESN. But the application is required to monitor ESN overflow to initiate SA expiry. For such cases, application would

Re: [dpdk-dev] [PATCH v3 5/5] app/testpmd: support for IPsec event

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: Adding support for IPsec event Signed-off-by: Anoob Joseph --- v3: * No change v2: * No change app/test-pmd/parameters.c | 2 ++ app/test-pmd/testpmd.c| 2 ++ 2 files change

Re: [dpdk-dev] [PATCH v3 1/5] lib/ethdev: support for inline IPsec events

2018-04-09 Thread Anoob Joseph
Hi Thomas, Can you review the patch and let me know if you have any comments. Thanks, Anoob On 03/04/18 19:57, Anoob Joseph wrote: Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: Adding support for IPsec events in rte_eth_event framework

Re: [dpdk-dev] [PATCH v3 1/5] lib/ethdev: support for inline IPsec events

2018-04-10 Thread Anoob Joseph
Hi Thomas, Thanks for the comments. Will send a revised patch with your suggestions. Anoob On 10/04/18 14:41, Thomas Monjalon wrote: Hi, 21/03/2018 12:11, Anoob Joseph: Adding support for IPsec events in rte_eth_event framework. In inline IPsec offload, the per packet protocol defined

[dpdk-dev] [PATCH v4 0/5] handle seq no overflow in IPsec offload

2018-04-10 Thread Anoob Joseph
be used by the application to identify the SA on which the sequence number overflow is about to happen. Anoob Joseph (5): lib/ethdev: support for inline IPsec events lib/security: add ESN soft limit in conf lib/security: extend userdata for IPsec events examples/ipsec-secgw: handle ESN soft l

[dpdk-dev] [PATCH v4 1/5] lib/ethdev: support for inline IPsec events

2018-04-10 Thread Anoob Joseph
Joseph Acked-by: Akhil Goyal --- v4: * Added more details in documentation * Renamed members of struct rte_eth_event_ipsec_desc for better readablity v3: * No change v2: * Added time expiry & byte expiry IPsec events in the enum lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v4 4/5] examples/ipsec-secgw: handle ESN soft limit event

2018-04-10 Thread Anoob Joseph
soft limit set by the application. Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal --- v4: * Reflected the variable renames v3: * No change v2: * No change examples/ipsec-secgw/ipsec-secgw.c | 59 ++ examples/ipsec-secgw/ipsec.c | 10 +-- examples

[dpdk-dev] [PATCH v4 2/5] lib/security: add ESN soft limit in conf

2018-04-10 Thread Anoob Joseph
Adding ESN soft limit in conf. This will be used in case of protocol offload. Per SA, application could specify for what ESN the security device need to notify application. In case of eth dev(inline protocol), rte_eth_event framework would raise an IPsec event. Signed-off-by: Anoob Joseph Acked

[dpdk-dev] [PATCH v4 3/5] lib/security: extend userdata for IPsec events

2018-04-10 Thread Anoob Joseph
r problem for inline processed inbound traffic. Updating the documentation to extend the usage of 'userdata'. Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal --- v4: * No change v3: * No change v2: * No change lib/librte_security/rte_security.h| 14 -- lib/librte_

[dpdk-dev] [PATCH v4 5/5] app/testpmd: support for IPsec event

2018-04-10 Thread Anoob Joseph
Adding support for IPsec event Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal --- v4: * No change v3: * No change v2: * No change app/test-pmd/parameters.c | 2 ++ app/test-pmd/testpmd.c| 2 ++ 2 files changed, 4 insertions(+) diff --git a/app/test-pmd/parameters.c b/app/test-pmd

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix usage print

2018-04-16 Thread Anoob Joseph
what is existing in other applications like l3fwd. Fixes: bbabfe6e4ee4 ("examples/ipsec_secgw: support jumbo frames") Fixes: 2c68fe791538 ("examples/ipsec-secgw: add cryptodev mask option") Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application&q

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2018-01-09 Thread Anoob Joseph
Hi Nelio, On 01/09/2018 06:18 PM, Nelio Laranjeiro wrote: Hi Anoob, On Fri, Jan 05, 2018 at 11:48:50AM +0530, Anoob Joseph wrote: Hi Adrien, On 12/21/2017 07:52 PM, Adrien Mazarguil wrote: On Thu, Dec 21, 2017 at 12:12:29PM +0200, Boris Pismenny wrote: On 12/21/2017 10:06 AM, Anoob

[dpdk-dev] [RFC 1/3] lib/security: set/retrieve per packet protocol metadata

2018-01-22 Thread Anoob Joseph
Retrieving the sequence number is required to monitor the sequence number overflow in inline IPsec offload. Signed-off-by: Anoob Joseph --- lib/librte_security/rte_security.c| 7 ++-- lib/librte_security/rte_security.h| 66 --- lib/librte_security/rte_sec

[dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

2018-01-22 Thread Anoob Joseph
that ability - for now for the outbound SA. Anoob Joseph (3): lib/security: set/retrieve per packet protocol metadata net/ixgbe: use structure for passing metadata examples/ipsec-secgw: support for setting seq no drivers/net/ixgbe/ixgbe_ipsec.c | 5 ++- examples/ipse

[dpdk-dev] [RFC 2/3] net/ixgbe: use structure for passing metadata

2018-01-22 Thread Anoob Joseph
Using structure to pass metadata Signed-off-by: Anoob Joseph --- drivers/net/ixgbe/ixgbe_ipsec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c index 85305c6..6c8d6b4 100644 --- a/drivers/net/ixgbe

[dpdk-dev] [RFC 3/3] examples/ipsec-secgw: support for setting seq no

2018-01-22 Thread Anoob Joseph
Adding support for setting sequence number for inline protocol processed packets. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/esp.h | 9 + examples/ipsec-secgw/ipsec.c | 42 -- 2 files changed, 45 insertions(+), 6 deletions(-) diff

Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

2018-01-25 Thread Anoob Joseph
Hi Akhil, Radu, Could you review the patch and share your thoughts on the proposed change? Thanks Anoob On 01/22/2018 06:41 PM, Anoob Joseph wrote: This series adds support for setting & retrieving per packet protocol specific metadata. This is primarily required by the application to mon

Re: [dpdk-dev] [PATCH v2 2/5] lib/security: add ESN soft limit in conf

2018-03-13 Thread Anoob Joseph
Hi Akhil, Will revise the patch with the mentioned change. Thanks, Anoob On 13/03/18 17:49, Akhil Goyal wrote: Hi Anoob, Just a minor comment. On 3/1/2018 2:51 PM, Anoob Joseph wrote: Adding ESN soft limit in conf. This will be used in case of protocol offload. Per SA, application could

Re: [dpdk-dev] [PATCH v2 4/5] examples/ipsec-secgw: handle ESN soft limit event

2018-03-13 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob On 13/03/18 17:54, Akhil Goyal wrote: Hi Anoob, On 3/1/2018 2:51 PM, Anoob Joseph wrote: For inline protocol processing, the PMD/device is required to maintain the ESN. But the application is required to monitor ESN overflow to initiate SA expiry

Re: [dpdk-dev] [PATCH v2 4/5] examples/ipsec-secgw: handle ESN soft limit event

2018-03-20 Thread Anoob Joseph
Hi Akhil, If you are fine with the existing code, I'll send a revised patchset incorporating the comment change you had suggested for 3rd patch. Shall I proceed? Thanks, Anoob On 14/03/18 11:36, Anoob Joseph wrote: Hi Akhil, Please see inline. Thanks, Anoob On 13/03/18 17:54,

[dpdk-dev] handle seq no overflow in IPsec offload

2018-03-21 Thread Anoob Joseph
be used by the application to identify the SA on which the sequence number overflow is about to happen. Anoob Joseph (5): lib/ethdev: support for inline IPsec events lib/security: add ESN soft limit in conf lib/security: extend userdata for IPsec events examples/ipsec-secgw: handle ESN soft l

[dpdk-dev] [PATCH v3 1/5] lib/ethdev: support for inline IPsec events

2018-03-21 Thread Anoob Joseph
Joseph --- v3: * No change v2: * Added time expiry & byte expiry IPsec events in the enum lib/librte_ether/rte_ethdev.h | 28 1 file changed, 28 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 0361533..96b2aa0 100644 -

[dpdk-dev] [PATCH v3 3/5] lib/security: extend userdata for IPsec events

2018-03-21 Thread Anoob Joseph
r problem for inline processed inbound traffic. Updating the documentation to extend the usage of 'userdata'. Signed-off-by: Anoob Joseph --- v3: * No change v2: * No change lib/librte_security/rte_security.h| 14 -- lib/librte_security/rte_security_driver.h |

[dpdk-dev] [PATCH v3 4/5] examples/ipsec-secgw: handle ESN soft limit event

2018-03-21 Thread Anoob Joseph
soft limit set by the application. Signed-off-by: Anoob Joseph --- v3: * No change v2: * No change examples/ipsec-secgw/ipsec-secgw.c | 56 ++ examples/ipsec-secgw/ipsec.c | 10 +-- examples/ipsec-secgw/ipsec.h | 2 ++ 3 files changed, 65

[dpdk-dev] [PATCH v3 2/5] lib/security: add ESN soft limit in conf

2018-03-21 Thread Anoob Joseph
Adding ESN soft limit in conf. This will be used in case of protocol offload. Per SA, application could specify for what ESN the security device need to notify application. In case of eth dev(inline protocol), rte_eth_event framework would raise an IPsec event. Signed-off-by: Anoob Joseph --- v3

[dpdk-dev] [PATCH v3 5/5] app/testpmd: support for IPsec event

2018-03-21 Thread Anoob Joseph
Adding support for IPsec event Signed-off-by: Anoob Joseph --- v3: * No change v2: * No change app/test-pmd/parameters.c | 2 ++ app/test-pmd/testpmd.c| 2 ++ 2 files changed, 4 insertions(+) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 97d22b8..7ea882f 100644

[dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

2018-03-22 Thread Anoob Joseph
referred to. Fixing this. In addition, the macros and enums used for long arguments have been renamed and repositioned adhering to the general convention followed in various other apps, like l3fwd. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec-secgw.c | 104 +++--

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

2018-03-28 Thread Anoob Joseph
Hi Akhil, Radu, Did you get time to review the patch? Thanks, Anoob On 23/03/18 11:20, Anoob Joseph wrote: Removing redundant strncmp in parsing long arguments. The getopt library provides means to identify long options using the "val" field of structure option. The existing code

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix usage of incorrect port

2017-11-13 Thread Anoob Joseph
per packet LPM lookup would be avoided for IPsec packets, in inline mode. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec-secgw.c | 92 -- 1 file changed, 78 inserti

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix usage of incorrect port

2017-11-13 Thread Anoob Joseph
Hi, Comments below On 13-11-2017 22:53, Radu Nicolau wrote: Hi, Comments below On 11/13/2017 4:13 PM, Anoob Joseph wrote: When security offload is enabled, the packet should be forwarded on the port configured in the SA. Security session will be configured on that port only, and sending

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix usage of incorrect port

2017-11-14 Thread Anoob Joseph
per packet LPM lookup would be avoided for IPsec packets, in inline mode. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Signed-off-by: Anoob Joseph --- v2: * Updated documentation with the change in behavior for outbound inline offloaded packets.

[dpdk-dev] [PATCH v3] examples/ipsec-secgw: fix usage of incorrect port

2017-11-15 Thread Anoob Joseph
per packet LPM lookup would be avoided for IPsec packets, in inline mode. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Signed-off-by: Anoob Joseph --- v3 * Bug fix (fixed a wrong if condition) * Minor changes in documentation v2: * Updated documentation with

[dpdk-dev] [PATCH 0/2] add inline protocol support

2017-11-20 Thread Anoob Joseph
adds the support for inline protocol in ipsec-secgw application. Anoob Joseph (2): lib/security: add support for saving app cookie examples/ipsec-secgw: add support for inline protocol examples/ipsec-secgw/esp.c| 6 +- examples/ipsec-secgw/ipsec-secgw.c| 40

[dpdk-dev] [PATCH 1/2] lib/security: add support for saving app cookie

2017-11-20 Thread Anoob Joseph
register SPI or a pointer to SA. Signed-off-by: Anoob Joseph --- lib/librte_security/rte_security.c| 26 +++ lib/librte_security/rte_security.h| 30 +++ lib/librte_security/rte_security_driver.h | 34 +++ 3 fi

[dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add support for inline protocol

2017-11-20 Thread Anoob Joseph
packet would be submitted to the driver. The packet will have optional metadata, which could be used to identify the security session associated with the packet. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/esp.c | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 40

Re: [dpdk-dev] [PATCH 1/2] lib/security: add support for saving app cookie

2017-11-20 Thread Anoob Joseph
arams is in the set_pkt_metadata). I think it will make a cleaner and more consistent implementation. Regards, Radu On 11/20/2017 10:31 AM, Anoob Joseph wrote: In case of inline protocol processed ingress traffic, the packet may not have enough information to determine the security parameters wit

[dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add support for inline protocol

2017-11-21 Thread Anoob Joseph
driver. The packet will have optional metadata, which could be used to identify the security session associated with the packet. Signed-off-by: Anoob Joseph --- v2: * Using get_pkt_metadata API instead of get_session & get_cookie APIs examples/ipsec-secgw/esp.c | 6 +- examples/i

[dpdk-dev] [PATCH v2 1/2] lib/security: add support for get metadata

2017-11-21 Thread Anoob Joseph
using "rte_security_get_pkt_metadata" API. Application can use this metadata to identify the parameters it need. Application can choose what it should register as the metadata. It can register SPI or a pointer to SA. Signed-off-by: Anoob Joseph --- v2: * Replaced get_session and get_cookie

[dpdk-dev] [PATCH v2 0/2] add inline protocol support

2017-11-21 Thread Anoob Joseph
parameters with which the packet was processed. Application can register what it needs to identify the required parameter. The metadata will be set while creating the security session. Second patch adds support for inline protocol in ipsec-secgw application. Anoob Joseph (2): lib/security: add s

[dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add support for inline protocol

2017-11-23 Thread Anoob Joseph
driver. The packet will have optional metadata, which could be used to identify the security session associated with the packet. Signed-off-by: Anoob Joseph --- v3: * Using (void *)userdata instead of 64 bit metadata in conf * Changes parallel to the change in API v2: * Using get_pkt_metadata

[dpdk-dev] [PATCH v3 0/2] add inline protocol support

2017-11-23 Thread Anoob Joseph
tion to identify the security parameters with which the packet was processed. Application can register what it needs to identify the required parameter. The userdata will be set while creating the security session. Second patch adds support for inline protocol in ipsec-secgw application. Anoob Joseph

[dpdk-dev] [PATCH v3 1/2] lib/security: add support for get metadata

2017-11-23 Thread Anoob Joseph
which the packet was processed. Signed-off-by: Anoob Joseph --- v3: * Replaced 64 bit metadata in conf with (void *)userdata * The API(rte_security_get_pkt_metadata) would return void * instead of uint64_t v2: * Replaced get_session and get_cookie APIs with get_pkt_metadata API lib

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: fix usage of incorrect port

2017-11-28 Thread Anoob Joseph
Hi Akhil, On 24-11-2017 16:19, Akhil Goyal wrote: Hi Anoob, On 11/24/2017 3:28 PM, Anoob wrote:   static inline void   route4_pkts(struct rt_ctx *rt_ctx, struct rte_mbuf *pkts[], uint8_t nb_pkts)   {   uint32_t hop[MAX_PKT_BURST * 2];   uint32_t dst_ip[MAX_PKT_BURST * 2]; +    int32

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-01 Thread Anoob Joseph
Hi Nelio, On 30-11-2017 17:58, Nelio Laranjeiro wrote: Hi Annob, On Thu, Nov 30, 2017 at 04:16:23PM +0530, Anoob wrote: On 11/29/2017 06:20 PM, Nelio Laranjeiro wrote: Hi Anoob, On Wed, Nov 29, 2017 at 06:00:38PM +0530, Anoob wrote: Hi Nelio, Since support of RSS with inline cryp

<    8   9   10   11   12   13   14   15   16   17   >