[dpdk-dev] [PATCH v4 08/23] crypto/octeontx: add basic dev ops

2018-10-09 Thread Anoob Joseph
From: Murthy NSSR Adding the following dev ops, - dev_configure - dev_start - dev_stop - dev_close - dev_infos_get - stats_get - stats_reset Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman

[dpdk-dev] [PATCH v4 14/23] common/cpt: add microcode interface for decryption

2018-10-09 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding microcode interface additions for supporting decryption. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed

[dpdk-dev] [PATCH v4 15/23] common/cpt: add crypo op enqueue request manager framework

2018-10-09 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding crypto enqueue op request manager framework. This routine won't submit to the hardware yet. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signe

[dpdk-dev] [PATCH v4 16/23] common/cpt: support zuc and snow3g

2018-10-09 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting ZUC and SNOW3G. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by

[dpdk-dev] [PATCH v4 13/23] common/cpt: add microcode interface for encryption

2018-10-09 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding microcode interface additions for supporting encryption. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed

[dpdk-dev] [PATCH v4 17/23] common/cpt: support kasumi

2018-10-09 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting kasumi. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree

[dpdk-dev] [PATCH v4 19/23] crypto/octeontx: add routines to prepare instructions

2018-10-09 Thread Anoob Joseph
From: Tejasree Kondoj Adding hardware specific routines which prepare cpt instructions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off

[dpdk-dev] [PATCH v4 18/23] common/cpt: support hash

2018-10-09 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting verify and authentication Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S

[dpdk-dev] [PATCH v4 21/23] crypto/octeontx: add dequeue burst op

2018-10-09 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_common.h

[dpdk-dev] [PATCH v4 23/23] doc: add documentation for OCTEON TX crypto

2018-10-09 Thread Anoob Joseph
Adding feature file and guide for OCTEON TX crypto PMD Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj

[dpdk-dev] [PATCH v4 20/23] crypto/octeontx: add enqueue burst op

2018-10-09 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_common.h

[dpdk-dev] [PATCH v4 22/23] test/crypto: add OCTEON TX unit tests

2018-10-09 Thread Anoob Joseph
From: Ankur Dwivedi Adding validation tests for OCTEON TX crypto device. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree

Re: [dpdk-dev] [PATCH 1/3] security: support pdcp protocol

2018-10-09 Thread Joseph, Anoob
Hi Akhil, Please see inline. Thanks, Anoob On 08-10-2018 15:19, Akhil Goyal wrote: External Email Hi Anoob, @@ -494,6 +553,23 @@ IPsec related configuration parameters are defined in ``rte_security_ipsec_xform    /**< Tunnel parameters, NULL for transport mode */    }; +PDCP relat

[dpdk-dev] [PATCH] maintainers: use registered name for OCTEON TX references

2018-10-09 Thread Anoob Joseph
'OCTEON TX' is the registered name. All other usages need to be fixed. Signed-off-by: Anoob Joseph --- MAINTAINERS | 8 doc/guides/compressdevs/features/octeontx.ini | 2 +- doc/guides/compressdevs/octeontx.rst

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-09 Thread Joseph, Anoob
with varying capability. Thanks, Anoob On 09-10-2018 01:57, Thomas Monjalon wrote: External Email 08/10/2018 17:59, Trahe, Fiona: Hi Akhil, Joseph, Thomas, Just spotted this now. See below. From: Thomas Monjalon [mailto:tho...@monjalon.net] 24/09/2018 13:36, Joseph, Anoob: Hi Fiona, Ca

[dpdk-dev] [PATCH] devtools: add exception for OCTEON TX

2018-10-10 Thread Anoob Joseph
The 'TX' in OCTEON TX would cause a warning. Adding an exception for that. OCTEON TX is a registered product under Cavium Signed-off-by: Anoob Joseph --- devtools/check-git-log.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/devtools/check-git-log.sh b/devtools/check-git-lo

Re: [dpdk-dev] [PATCH v5 1/3] security: support pdcp protocol

2018-10-16 Thread Joseph, Anoob
he following also need to be fixed, > + * @PDCP_SN_SIZE_18: 18bit sequence number */ enum > +rte_security_pdcp_sn_size { > + RTE_SECURITY_PDCP_SN_SIZE_18 = 18 }; With the above changes, Acked-by: Anoob Joseph Thanks, Anoob > -Original Message- > From: Akhil Goy

Re: [dpdk-dev] [PATCH v5 1/3] security: support pdcp protocol

2018-10-16 Thread Joseph, Anoob
I think the same issue is observed if you go through the following doc, https://doc.dpdk.org/api/structrte__security__ipsec__sa__options.html Check for the description of field copy_df in rte_security.h Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: 16 October 201

Re: [dpdk-dev] [PATCH] devtools: add exception for OCTEON TX

2018-10-16 Thread Joseph, Anoob
Hi Thomas, Can you review this patch and let me know your comments? Thanks, Anoob > -Original Message- > From: Joseph, Anoob > Sent: 10 October 2018 18:31 > To: Thomas Monjalon > Cc: Joseph, Anoob ; Jacob, Jerin > ; Athreya, Narayana Prasad > ; dev@dpdk.org > S

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-16 Thread Joseph, Anoob
Hi Fiona, Reminder!! Thanks, Anoob > -Original Message- > From: Joseph, Anoob > Sent: 10 October 2018 11:10 > To: Thomas Monjalon ; Trahe, Fiona > > Cc: dev@dpdk.org; Akhil Goyal ; Joseph, Anoob > ; De Lara Guarch, Pablo > ; Murthy, Nidadavolu > ; Jacob,

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-21 Thread Joseph, Anoob
plan is to follow the same approach for asym support, maybe we will also follow suit and submit the required patches. @Akhil, Thomas, thoughts? Thanks, Anoob > -Original Message- > From: Trahe, Fiona > Sent: 20 October 2018 02:40 > To: Joseph, Anoob ; Thomas Monjalon >

[dpdk-dev] [PATCH v1 01/15] examples/l2fwd: add new header to move common code

2018-06-14 Thread Anoob Joseph
v1: * No change Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_common.h | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 examples/l2fwd/l2fwd_common.h diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2fwd/l2fwd_common.h new file mode 100644 index 000..15059f4

[dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

2018-06-14 Thread Anoob Joseph
x all checkpatch reported issues Anoob Joseph (15): examples/l2fwd: add new header to move common code examples/l2fwd: move macro definitions to common header examples/l2fwd: move structure definitions to common header examples/l2fwd: move globally accessed vars to common header examples/

[dpdk-dev] [PATCH v1 02/15] examples/l2fwd: move macro definitions to common header

2018-06-14 Thread Anoob Joseph
v1: * Retaining Intel license with copied code Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_common.h | 19 +++ examples/l2fwd/main.c | 16 ++-- 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_common.h b/examples

[dpdk-dev] [PATCH v1 04/15] examples/l2fwd: move globally accessed vars to common header

2018-06-14 Thread Anoob Joseph
v1: * No change Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_common.h | 26 ++ examples/l2fwd/main.c | 41 + 2 files changed, 43 insertions(+), 24 deletions(-) diff --git a/examples/l2fwd/l2fwd_common.h b/examples

[dpdk-dev] [PATCH v1 03/15] examples/l2fwd: move structure definitions to common header

2018-06-14 Thread Anoob Joseph
v1: * Replaced 'unsigned' with 'unsigned int' Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_common.h | 12 examples/l2fwd/main.c | 10 -- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/examples/l2fwd/l2fwd_commo

[dpdk-dev] [PATCH v1 06/15] examples/l2fwd: fix lines exceeding 80 char limit

2018-06-14 Thread Anoob Joseph
v1: * Replaced 'unsigned' with 'unsigned int' Fixes: e2366e74e029 ("examples: use buffered Tx") Fixes: af75078fece3 ("first public release") Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 15 ++- 1 file changed, 10 insertions(+), 5 d

[dpdk-dev] [PATCH v1 05/15] examples/l2fwd: add missing space

2018-06-14 Thread Anoob Joseph
v1: * No change Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index a6089a1..6229a20 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -71,7 +71,7

[dpdk-dev] [PATCH v1 08/15] examples/l2fwd: remove unused header includes

2018-06-14 Thread Anoob Joseph
v1: * No change Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 12 1 file changed, 12 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 663c505..ad5468a 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd

[dpdk-dev] [PATCH v1 07/15] examples/l2fwd: move dataplane code to new file

2018-06-14 Thread Anoob Joseph
v1: * Replaced 'unsigned' with 'unsigned int' Signed-off-by: Anoob Joseph --- examples/l2fwd/Makefile | 1 + examples/l2fwd/l2fwd_worker.c | 233 ++ examples/l2fwd/l2fwd_worker.h | 10 ++ examples/l2fwd/

[dpdk-dev] [PATCH v1 09/15] examples/l2fwd: move drain buffers to new function

2018-06-14 Thread Anoob Joseph
v1: * Replaced 'unsigned' with 'unsigned int' Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_wo

[dpdk-dev] [PATCH v1 10/15] examples/l2fwd: optimize check for master core

2018-06-14 Thread Anoob Joseph
v1: * Replaced 'unsigned' with 'unsigned int' Replacing the check for lcore_id & mastercore_id with the check for a flag. Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/example

[dpdk-dev] [PATCH v1 11/15] examples/l2fwd: move periodic tasks to new function

2018-06-14 Thread Anoob Joseph
v1: * Replaced 'unsigned' with 'unsigned int' Move the periodic operations (stats flush and drain buffers) to a new function. Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 83 --- examples/l2fwd/l2fwd_worker.h | 6 +

[dpdk-dev] [PATCH v1 13/15] examples/l2fwd: move pkt send code to a new function

2018-06-14 Thread Anoob Joseph
v1: * Replaced 'unsigned' with 'unsigned int' Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index d6a5e90..

[dpdk-dev] [PATCH v1 12/15] examples/l2fwd: skip timer updates for non master cores

2018-06-14 Thread Anoob Joseph
v1: * No change The timer updates and checks are required only for stats printing by the master core. This can be entirely skipped for other cores. Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff

[dpdk-dev] [PATCH v1 14/15] examples/l2fwd: use fprint instead of printf for usage print

2018-06-14 Thread Anoob Joseph
v1: * No change Following the convention of l3fwd, using fprintf instead of printf for printing usage. Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 05f9d28

[dpdk-dev] [PATCH v1 15/15] examples/l2fwd: improvements to the usage print

2018-06-14 Thread Anoob Joseph
v1: * No change Fixed alignment and split the usage print to aid easy addition of eventmode usage prints. Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd

[dpdk-dev] [PATCH v1 03/15] examples/l2fwd: move structure definitions to common header

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_common.h | 12 examples/l2fwd/main.c | 10 -- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/examples/l2fwd/l2fwd_commo

[dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

2018-06-14 Thread Anoob Joseph
x all checkpatch reported issues Anoob Joseph (15): examples/l2fwd: add new header to move common code examples/l2fwd: move macro definitions to common header examples/l2fwd: move structure definitions to common header examples/l2fwd: move globally accessed vars to common header examples/

[dpdk-dev] [PATCH v1 01/15] examples/l2fwd: add new header to move common code

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/l2fwd_common.h | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 examples/l2fwd/l2fwd_common.h diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2fwd/l2fwd_common.h new file mode 100644 index 000..15059f4

[dpdk-dev] [PATCH v1 02/15] examples/l2fwd: move macro definitions to common header

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * Retaining Intel license with copied code examples/l2fwd/l2fwd_common.h | 19 +++ examples/l2fwd/main.c | 16 ++-- 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_common.h b/examples

[dpdk-dev] [PATCH v1 04/15] examples/l2fwd: move globally accessed vars to common header

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/l2fwd_common.h | 26 ++ examples/l2fwd/main.c | 41 + 2 files changed, 43 insertions(+), 24 deletions(-) diff --git a/examples/l2fwd/l2fwd_common.h b/examples

[dpdk-dev] [PATCH v1 05/15] examples/l2fwd: add missing space

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index a6089a1..6229a20 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -71,7 +71,7

[dpdk-dev] [PATCH v1 06/15] examples/l2fwd: fix lines exceeding 80 char limit

2018-06-14 Thread Anoob Joseph
Fixes: e2366e74e029 ("examples: use buffered Tx") Fixes: af75078fece3 ("first public release") Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/main.c | 15 ++- 1 file changed, 10 insertions(+), 5 d

[dpdk-dev] [PATCH v1 08/15] examples/l2fwd: remove unused header includes

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/l2fwd_worker.c | 12 1 file changed, 12 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 663c505..ad5468a 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd

[dpdk-dev] [PATCH v1 07/15] examples/l2fwd: move dataplane code to new file

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/Makefile | 1 + examples/l2fwd/l2fwd_worker.c | 233 ++ examples/l2fwd/l2fwd_worker.h | 10 ++ examples/l2fwd/

[dpdk-dev] [PATCH v1 09/15] examples/l2fwd: move drain buffers to new function

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_wo

[dpdk-dev] [PATCH v1 12/15] examples/l2fwd: skip timer updates for non master cores

2018-06-14 Thread Anoob Joseph
The timer updates and checks are required only for stats printing by the master core. This can be entirely skipped for other cores. Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/l2fwd_worker.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff

[dpdk-dev] [PATCH v1 10/15] examples/l2fwd: optimize check for master core

2018-06-14 Thread Anoob Joseph
Replacing the check for lcore_id & mastercore_id with the check for a flag. Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/example

[dpdk-dev] [PATCH v1 11/15] examples/l2fwd: move periodic tasks to new function

2018-06-14 Thread Anoob Joseph
Move the periodic operations (stats flush and drain buffers) to a new function. Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 83 --- examples/l2fwd/l2fwd_worker.h | 6 +

[dpdk-dev] [PATCH v1 14/15] examples/l2fwd: use fprint instead of printf for usage print

2018-06-14 Thread Anoob Joseph
Following the convention of l3fwd, using fprintf instead of printf for printing usage. Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 05f9d28

[dpdk-dev] [PATCH v1 13/15] examples/l2fwd: move pkt send code to a new function

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index d6a5e90..

[dpdk-dev] [PATCH v1 15/15] examples/l2fwd: improvements to the usage print

2018-06-14 Thread Anoob Joseph
Fixed alignment and split the usage print to aid easy addition of eventmode usage prints. Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd

Re: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto device(CPT) driver

2018-06-18 Thread Anoob Joseph
Hi Akhil, Pablo, Are there any top level comments on this? Thanks, Anoob On 08/06/18 22:15, Anoob Joseph wrote: Ankur Dwivedi (4): crypto/cpt/base: add hardware enq/deq API for CPT crypto/cpt/base: add sym crypto session init API for CPT crypto/cpt/base: add sym crypto request prepare

[dpdk-dev] [PATCH 2/2] app/crypto-perf: honour cryptodev's min headroom/tailroom

2018-06-18 Thread Anoob Joseph
Crypto dev would specify its headroom and tailroom requirement and the application is expected to honour this while creating buffers. Signed-off-by: Anoob Joseph --- app/test-crypto-perf/cperf_options.h | 2 ++ app/test-crypto-perf/cperf_test_common.c | 33

[dpdk-dev] [PATCH 0/2] add head/tailroom requirement for crypto PMDs

2018-06-18 Thread Anoob Joseph
support using the head/tailroom, can continue to operate without any performance-drop. Cavium's CPT hardware supports this feature and would use headroom and tailroom for submitting crypto-ops to the hardware. Anoob Joseph (2): cryptodev: add min headroom and tailroom requirement app/crypto

[dpdk-dev] [PATCH 1/2] cryptodev: add min headroom and tailroom requirement

2018-06-18 Thread Anoob Joseph
support using the head/tailroom, they can continue to operate without any performance-drop. Signed-off-by: Anoob Joseph --- doc/guides/rel_notes/deprecation.rst | 4 lib/librte_cryptodev/rte_cryptodev.h | 6 ++ 2 files changed, 10 insertions(+) diff --git a/doc/guides/rel_notes

Re: [dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

2018-06-19 Thread Anoob Joseph
Hi Bruce, Pablo, Any comments on this series? Thanks, Anoob On 14/06/18 17:18, Anoob Joseph wrote: This patchset modularizes l2fwd application to prepare it for eventmode additions. This patchset doesn't change the code flow or logic, except for few minor improvements. Some of the newly

Re: [dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

2018-06-19 Thread Anoob Joseph
Hi Bruce, Thanks for the feedback. Please see inline. + Hemant, Nikhil, Sunil, Gage, Harry, Narender, Pavan, Thomas, Akhil On 19/06/18 15:39, Bruce Richardson wrote: On Tue, Jun 19, 2018 at 03:34:29PM +0530, Anoob Joseph wrote: Hi Bruce, Pablo, Any comments on this series? Thanks, Anoob

Re: [dpdk-dev] [PATCH 1/2] cryptodev: add min headroom and tailroom requirement

2018-06-21 Thread Joseph, Anoob
21-06-2018 19:54, Akhil Goyal wrote: On 6/19/2018 11:56 AM, Anoob Joseph wrote: Enabling crypto devs to specify the minimum headroom and tailroom it expects in the mbuf. For net PMDs, standard headroom has to be honoured by applications, which is not strictly followed for crypto devs. This

Re: [dpdk-dev] [PATCH 1/2] cryptodev: add min headroom and tailroom requirement

2018-06-27 Thread Joseph, Anoob
Hi Declan, Please see inline. Thanks, Anoob On 26-06-2018 15:42, Doherty, Declan wrote: External Email On 19/06/2018 7:26 AM, Anoob Joseph wrote: Enabling crypto devs to specify the minimum headroom and tailroom it expects in the mbuf. For net PMDs, standard headroom has to be honoured by

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-06-28 Thread Joseph, Anoob
Hi Sunil, On 27-06-2018 11:50, Sunil Kumar Kori wrote: External Email Regards Sunil Kumar -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Friday, June 8, 2018 10:54 PM To: Bruce Richardson ; Jerin Jacob ; Pablo de Lara Cc: Anoob Joseph ; Hemant

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-06-28 Thread Joseph, Anoob
Hi Konstantin, On 28-06-2018 16:17, Ananyev, Konstantin wrote: Hi Anoob, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Joseph, Anoob Sent: Thursday, June 28, 2018 11:43 AM To: Sunil Kumar Kori ; Richardson, Bruce ; Jerin Jacob ; De Lara Guarch, Pablo Cc

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-06-28 Thread Joseph, Anoob
Hi Konstantin, On 28-06-2018 17:14, Ananyev, Konstantin wrote: -Original Message- From: Joseph, Anoob [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 28, 2018 11:59 AM To: Ananyev, Konstantin ; Sunil Kumar Kori ; Richardson, Bruce ; Jerin Jacob ; De Lara Guarch, Pablo

Re: [dpdk-dev] [PATCH 1/2] cryptodev: add min headroom and tailroom requirement

2018-06-28 Thread Joseph, Anoob
Hi Pablo, On 28-06-2018 17:11, De Lara Guarch, Pablo wrote: External Email Hi Anoob, -Original Message- From: Joseph, Anoob [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 28, 2018 3:56 AM To: Doherty, Declan ; De Lara Guarch, Pablo Cc: Akhil Goyal ; Ankur Dwivedi

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-07-03 Thread Joseph, Anoob
Hi Sunil, Please see inline. Thanks, Anoob On 03-07-2018 11:57, Sunil Kumar Kori wrote: External Email Hello Anoob, Regards Sunil Kumar -Original Message- From: Joseph, Anoob [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 28, 2018 4:13 PM To: Sunil Kumar Kori

Re: [dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

2018-07-03 Thread Joseph, Anoob
Hi, Gentle reminder! Thanks, Anoob On 19-06-2018 19:37, Anoob Joseph wrote: External Email Hi Bruce, Thanks for the feedback. Please see inline. + Hemant, Nikhil, Sunil, Gage, Harry, Narender, Pavan, Thomas, Akhil On 19/06/18 15:39, Bruce Richardson wrote: On Tue, Jun 19, 2018 at 03

[dpdk-dev] [PATCH v1 0/3] add head/tailroom requirement for crypto PMDs

2018-07-04 Thread Anoob Joseph
nding change in test-cryptodev Anoob Joseph (3): cryptodev: add min headroom and tailroom requirement app/crypto-perf: honour cryptodev's min headroom/tailroom test/crypto: skip validation of head/tailroom used by PMD app/test-crypto-perf/cperf_options.h | 2 ++ app/test-c

[dpdk-dev] [PATCH v1 2/3] app/crypto-perf: honour cryptodev's min headroom/tailroom

2018-07-04 Thread Anoob Joseph
Crypto dev would specify its headroom and tailroom requirement and the application is expected to honour this while creating buffers. Signed-off-by: Anoob Joseph --- v1: * Accomodated the name change of new fields app/test-crypto-perf/cperf_options.h | 2 ++ app/test-crypto-perf

[dpdk-dev] [PATCH v1 1/3] cryptodev: add min headroom and tailroom requirement

2018-07-04 Thread Anoob Joseph
support using the head/tailroom, they can continue to operate without any performance-drop. Signed-off-by: Anoob Joseph --- v1: * Removed deprecation notice * Updated release note * Renamed new fields to have 'mbuf' in the name * Changed the type of new fields to uint16_t (instead o

[dpdk-dev] [PATCH v1 3/3] test/crypto: skip validation of head/tailroom used by PMD

2018-07-04 Thread Anoob Joseph
Crypto PMDs would specify the head/tailroom it would use while processing the crypto requests. This need to be considered while verifying buffers processed by crypto PMDs. Signed-off-by: Anoob Joseph --- v1: * Added patch test/test/test_cryptodev_blockcipher.c | 60

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-23 Thread Joseph, Anoob
work. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: 22 October 2018 12:22 > To: Joseph, Anoob > Cc: Trahe, Fiona ; dev@dpdk.org; Akhil Goyal > ; De Lara Guarch, Pablo > ; Murthy, Nidadavolu > ; Jacob, Jerin > ; Athreya, Narayana Prasad &

Re: [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues

2018-10-28 Thread Joseph, Anoob
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: 29 October 2018 07:49 > To: Joseph, Anoob > Cc: dev@dpdk.org; Ferruh Yigit ; Bruce Richardson > ; Pablo de Lara > ; Jacob, Jerin > ; Athreya, Narayana Prasad > > Subject: Re: [dpdk-dev] [

[dpdk-dev] [PATCH 0/3] fixing coverity reported issues

2018-11-11 Thread Anoob Joseph
Anoob Joseph (3): crypto/octeontx: fix non null terminated string crypto/octeontx: fix null pointer dereferencing crypto/octeontx: fix null pointer dereferencing drivers/crypto/octeontx/otx_cryptodev.c | 2 +- drivers/crypto/octeontx/otx_cryptodev_hw_access.c | 5 - drivers

[dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing

2018-11-11 Thread Anoob Joseph
Fixes: bfe2ae495ee2 ("crypto/octeontx: add PMD skeleton") Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx/otx_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev.c b/drivers/crypto/octeontx/otx_cryptodev.c ind

[dpdk-dev] [PATCH 3/3] crypto/octeontx: fix null pointer dereferencing

2018-11-11 Thread Anoob Joseph
uot;crypto/octeontx: add queue pair functions") Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c index 23f9

[dpdk-dev] [PATCH 1/3] crypto/octeontx: fix non null terminated string

2018-11-11 Thread Anoob Joseph
dware init routine") Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx/otx_cryptodev_hw_access.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev_hw_access.c b/drivers/crypto/octeontx/otx_cryp

Re: [dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing

2018-11-12 Thread Joseph, Anoob
Hi Akhil, You can squash the entire series. Or should I send a revised patch? Either way is fine. Anoob > -Original Message- > From: Akhil Goyal > Sent: 12 November 2018 16:51 > To: Joseph, Anoob ; Pablo de Lara > > Cc: Joseph, Anoob ; Jacob, Jerin > ; Ath

[dpdk-dev] [PATCH] net/octeontx: fix mbuf corruption with larger priv sizes

2018-11-12 Thread Anoob Joseph
ion. Fixes: 197438ee9f18 ("net/octeontx: add Rx queue setup and release ops") Cc: sta...@dpdk.org Suggested-by: Jerin Jacob Signed-off-by: Anoob Joseph Signed-off-by: Nitin Saxena --- drivers/net/octeontx/base/octeontx_pki_var.h | 13 +++-- drivers/net/octeontx/octeontx_ethdev

[dpdk-dev] [PATCH v2] crypto/octeontx: fix coverity issues

2018-11-12 Thread Anoob Joseph
error, 'instance' would be set to NULL, and returns rte_errno. If rte_errno when 'instance' is set to NULL, it can lead to NULL pointer dereferencing. Fixes: 0961348fdf52 ("crypto/octeontx: add queue pair functions") Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob

Re: [dpdk-dev] [PATCH] doc: cryptodev deprecation notice for sym session changes

2018-11-13 Thread Joseph, Anoob
other? Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: 12 November 2018 17:34 > To: Konstantin Ananyev ; dev@dpdk.org; Ravi > Kumar ; Jacob, Jerin > ; Joseph, Anoob > ; Declan Doherty ; > Fiona Trahe ; Tomasz Duszynski ; > Dmitri Epshtein ; Natalie Sams

[dpdk-dev] [PATCH] net/octeontx: fix failures when available ports > queues

2018-11-14 Thread Anoob Joseph
that case the ports need to be setup, or otherwise it would lead to a segmentation fault when event device is started. Fixes: f7be70e5130e ("net/octeontx: add net device probe and remove") Signed-off-by: Anoob Joseph Signed-off-by: Pavan Nikhilesh --- drivers/net/octeontx/octeontx_eth

[dpdk-dev] [PATCH] doc/guides: update build steps for OCTEON TX

2018-11-14 Thread Anoob Joseph
Updating platform doc with steps to build when using Cavium OCTEON TX SDK. SDK would be required for using crypto offload block. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/octeontx.rst | 29 -- doc/guides/platform/octeontx.rst | 116 +++-- 2

Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-14 Thread Joseph, Anoob
Acked-by: Anoob Joseph > -Original Message- > From: Akhil Goyal > Sent: 13 November 2018 16:58 > To: dev@dpdk.org > Cc: tho...@monjalon.net; konstantin.anan...@intel.com; Jacob, Jerin > ; Joseph, Anoob > ; radu.nico...@intel.com; > declan.dohe...@intel.com;

Re: [dpdk-dev] [PATCH] doc: cryptodev deprecation notice for sym session changes

2018-11-14 Thread Joseph, Anoob
> -Original Message- > From: Ananyev, Konstantin > Sent: 14 November 2018 15:38 > To: Joseph, Anoob ; Akhil Goyal > ; dev@dpdk.org; Ravi Kumar ; > Jacob, Jerin ; Doherty, Declan > ; Trahe, Fiona ; Tomasz > Duszynski ; Dmitri Epshtein ; Natalie > Samsono

[dpdk-dev] [PATCH] common/cpt: fix bad shift operation

2018-11-14 Thread Anoob Joseph
From: Ankur Dwivedi Coverity Issue: 323477 Using the rte_bsf32 function to find last set bit. This avoids the for loop and hence the bad bit shift operation. Fixes: 351fbee21986 ("common/cpt: support hash") Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph --- drivers/

Re: [dpdk-dev] [PATCH v1 01/15] examples/l2fwd: add new header to move common code

2018-07-09 Thread Anoob Joseph
any other comments on this series? Anoob On 10-07-2018 04:16, De Lara Guarch, Pablo wrote: External Email Hi Anoob, -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 14, 2018 11:18 AM To: Richardson, Bruce ; De Lara Guarch, Pablo Cc: An

Re: [dpdk-dev] [PATCH v1 09/15] examples/l2fwd: move drain buffers to new function

2018-07-09 Thread Anoob Joseph
Hi Pablo, On 10-07-2018 04:19, De Lara Guarch, Pablo wrote: External Email -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 14, 2018 11:18 AM To: Richardson, Bruce ; De Lara Guarch, Pablo Cc: Anoob Joseph ; Jerin Jacob ; Narayana

Re: [dpdk-dev] [PATCH v1 05/15] examples/l2fwd: add missing space

2018-07-09 Thread Anoob Joseph
Hi Pablo, On 10-07-2018 04:21, De Lara Guarch, Pablo wrote: External Email -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 14, 2018 12:49 PM To: Richardson, Bruce ; De Lara Guarch, Pablo Cc: Anoob Joseph ; Jerin Jacob ; Narayana

Re: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto device(CPT) driver

2018-07-09 Thread Anoob Joseph
Guarch, Pablo wrote: External Email -Original Message- From: De Lara Guarch, Pablo Sent: Monday, June 18, 2018 3:30 PM To: Anoob Joseph ; Akhil Goyal Cc: Thomas Monjalon ; Ankur Dwivedi ; Jerin Jacob ; Murthy NSSR ; Narayana Prasad ; Nithin Dabilpuram ; Ragothaman Jayaraman

Re: [dpdk-dev] [PATCH v1 1/3] cryptodev: add min headroom and tailroom requirement

2018-07-10 Thread Anoob Joseph
Hi Pablo, I'll look into this and will give you an updated patch. Thanks, Anoob On 10-07-2018 15:56, De Lara Guarch, Pablo wrote: External Email Hi Anoob, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anoob Joseph Sent: Wednesday, July 4, 2018 2:56

Re: [dpdk-dev] [PATCH v1 2/3] app/crypto-perf: honour cryptodev's min headroom/tailroom

2018-07-10 Thread Anoob Joseph
Hi Pablo, Please see inline. Thanks, Anoob On 10-07-2018 17:18, De Lara Guarch, Pablo wrote: External Email -Original Message- From: De Lara Guarch, Pablo Sent: Tuesday, July 10, 2018 12:17 PM To: 'Anoob Joseph' ; Doherty, Declan Cc: 'Akhil Goyal' ; 'Anku

Re: [dpdk-dev] [PATCH v1 2/3] app/crypto-perf: honour cryptodev's min headroom/tailroom

2018-07-10 Thread Anoob Joseph
Hi Pablo, On 10-07-2018 18:57, De Lara Guarch, Pablo wrote: External Email -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Tuesday, July 10, 2018 1:23 PM To: De Lara Guarch, Pablo ; Doherty, Declan Cc: Akhil Goyal ; Ankur Dwivedi ; Jerin Jacob

[dpdk-dev] [PATCH v2 1/4] cryptodev: add min headroom and tailroom requirement

2018-07-10 Thread Anoob Joseph
support using the head/tailroom, they can continue to operate without any performance-drop. Signed-off-by: Anoob Joseph --- v2: * No change v1: * Removed deprecation notice * Updated release note * Renamed new fields to have 'mbuf' in the name * Changed the type of new fields to uint16_

[dpdk-dev] [PATCH v2 0/4] add head/tailroom requirement for crypto PMDs

2018-07-10 Thread Anoob Joseph
ation notice and updated release notes * Added corresponding change in test-cryptodev Anoob Joseph (4): cryptodev: add min headroom and tailroom requirement app/crypto-perf: honour cryptodev's min headroom/tailroom test/crypto: skip validation of head/tailroom used by PMD crypto/sche

[dpdk-dev] [PATCH v2 2/4] app/crypto-perf: honour cryptodev's min headroom/tailroom

2018-07-10 Thread Anoob Joseph
Crypto dev would specify its headroom and tailroom requirement and the application is expected to honour this while creating buffers. Signed-off-by: Anoob Joseph --- v2: * No change v1: * Accomodated the name change of new fields app/test-crypto-perf/cperf_options.h | 2 ++ app/test

[dpdk-dev] [PATCH v2 4/4] crypto/scheduler: add minimum head/tailroom requirement

2018-07-10 Thread Anoob Joseph
Minimum head/tailroom requirement for each PMD has to be considered while populating the dev_info. Signed-off-by: Anoob Joseph --- v2: * Added this patch drivers/crypto/scheduler/scheduler_pmd_ops.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/crypto/scheduler

[dpdk-dev] [PATCH v2 3/4] test/crypto: skip validation of head/tailroom used by PMD

2018-07-10 Thread Anoob Joseph
Crypto PMDs would specify the head/tailroom it would use while processing the crypto requests. This need to be considered while verifying buffers processed by crypto PMDs. Signed-off-by: Anoob Joseph --- v2: * No change v1: * Added patch test/test/test_cryptodev_blockcipher.c | 60

[dpdk-dev] [PATCH v2 01/12] examples/l2fwd: move macro definitions to common header

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * Merged the patch which was adding the common header v1: * Retaining Intel license with copied code examples/l2fwd/l2fwd_common.h | 25 + examples/l2fwd/main.c | 16 ++-- 2 files changed, 27 insertions(+), 14

[dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-07-10 Thread Anoob Joseph
erged small patches with others as directed by Pablo v1: * Fix all checkpatch reported issues Anoob Joseph (12): examples/l2fwd: move macro definitions to common header examples/l2fwd: move structure definitions to common header examples/l2fwd: move globally accessed vars to common header exa

<    6   7   8   9   10   11   12   13   14   15   >