92b ("net/qede: add infrastructure for debug data
>> collection")
>> Cc: rm...@marvell.com
>
> Hi @Rasesh Mody @Devendra Singh Rawat @Igor Russkikh
>
> Please review this patch to merge.
>
>
>>
>> Signed-off-by: Anatoly Burakov
Reviewed-by: Igor Russkikh
Thanks!
Fixing ex-Aquantia email - it is now part of Marvell.
Removing Pavel Belous email - he is not in company now.
Adding Marvell tree to run this through.
Signed-off-by: Igor Russkikh
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
Adding Marvell prefix for qlogic drivers.
Removing myself as I'm no longer responsible for qede driver
Signed-off-by: Igor Russkikh
Signed-off-by: Rasesh Mody
---
MAINTAINERS | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4de75
warning on uninit var
v1:
- fixes on Ferruh's comments
rfc v2: http://patchwork.dpdk.org/patch/78800/
- increment ref counter for each mbuf pointer copy
rfc v1: http://patchwork.dpdk.org/patch/78674/
Signed-off-by: Igor Russkikh
---
app/test-pmd/flowgen.c
> > Signed-off-by: Igor Russkikh
>
> Reviewed-by: Ferruh Yigit
>
> Also a testpmd command to set the 'flowgen-clones' can be useful, for
> interactive mode. If you have time for it, can you please work on it too?
>
>
> Applied to dpdk-next-net/m
Two small fixes after customer feedback.
Igor Russkikh (2):
qede: reduce trace verbosity level
qede: make driver accept bigger rss tables
drivers/net/qede/base/ecore_int.c | 2 +-
drivers/net/qede/qede_ethdev.c| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--
2.25.1
On some hardware units it was found this trace is flooding the output,
making any dpdk interactive usage kind of problematic.
It is only informational, without any consequences handling, so reducing
it to verbose from explicit notice level.
CC: sta...@dpdk.org
Signed-off-by: Igor Russkikh
trace message.
CC: sta...@dpdk.org
Signed-off-by: Igor Russkikh
---
drivers/net/qede/qede_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index ab5f5b106..7363d98f2 100644
--- a/drivers/net/qede
Hi Stephen,
> The DPDK Atlantic driver has 6 API's marked as experimental.
> These API's were added back in 19.05 release.
> These API's should either be marked as stable or removed in 23.11 release.
> What do you want to do?
Unfortunately to my knowledge, this project is no more supported by Ma
> - Move "Supported Chipsets and NICs" section to top
> - Fix section indentation
> - Remove empty sections
>
> Signed-off-by: Ferruh Yigit
Thanks for taking care, Ferruh!
Reviewed-by: Igor Russkikh
> On Fri, Mar 5, 2021 at 6:44 PM Balazs Nemeth wrote:
>>
>> This patch set optimizes qede_{rx,tx}_entry and introduces
>> rte_pktmbuf_free_bulk in qede_process_tx_compl. The overall performance
>> improvement depends on the use-case; in a physical-virtual-physical test
>> on a ThunderX2 99xx sy
Removing Shahed, adding me and Devendra
Signed-off-by: Igor Russkikh
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e341bc81d..0f5e745cd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -866,7 +866,8 @@ F: doc/guides/nics
>>> Cc: rm...@marvell.com
>>> Cc: shsha...@marvell.com>
>>> Hi Rasesh, Shahed
>>> Could you review this series from Balazs?
>>
>> Shahed is not within marvell, adding Devendra from our DPKD support team.
>
> Could you update the MAINTAINERS to reflect that status?
Sure, done, just sent!
Igor
Two small fixes after customer feedback.
v2: improved abit log message
Igor Russkikh (2):
qede: reduce trace verbosity level
qede: make driver accept bigger rss tables
drivers/net/qede/base/ecore_int.c | 2 +-
drivers/net/qede/qede_ethdev.c| 6 --
2 files changed, 5 insertions
Signed-off-by: Igor Russkikh
---
drivers/net/qede/base/ecore_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/qede/base/ecore_int.c
b/drivers/net/qede/base/ecore_int.c
index 4207b1853..2c4aac941 100644
--- a/drivers/net/qede/base/ecore_int.c
+++ b/drivers/net
trace message.
CC: sta...@dpdk.org
Signed-off-by: Igor Russkikh
---
drivers/net/qede/qede_ethdev.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index ab5f5b106..bfd38a977 100644
--- a/drivers/net/qede
> IMO, it will be better if the log message also states that RSS key is trimmed
> to 'len' size.
Resent v2, thanks.
Devendra, please take these two patches into our internal codebase as well.
Igor
>> Patch Series ACKed,
>> Acked-by: Devendra Singh Rawat
>
> Fixed the check-git-log.sh issues and Applied to
> dpdk-next-net-mrvl/for-main. Thanks
Thanks, Jerin, for taking care of that!
Igor
-
> drivers/net/qede/qede_rxtx.h | 21 +
> 2 files changed, 81 insertions(+), 88 deletions(-)
Series reviewed, for the series
Acked-by: Igor Russkikh
One checkpatch warn I see in patchwork output, probably worth fixing:
ERROR:POINTER_LOCATION: "(foo**)" should be "
family, so keeping it.
Signed-off-by: Igor Russkikh
Signed-off-by: Rasesh Mody
---
MAINTAINERS | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5877a16971..c25959b546 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -599,9 +599,8 @@ F
Adding my team members for that.
Strangely, even if by any reason we would get OOM condition - driver should
reject load gracefully.
Is there any possibility FW image could be corrupted/of bad size?
Regards,
Igor
On 5/26/2021 11:57 AM, Varghese, Vipin wrote:
> External Email
>
> --
> Fedora 34 only provides compressed firmwares.
>
> Introduce an internal driver helper to handle transparently compression.
>
> I chose libarchive for decompressing as it seems widely available and
> DPDK had used it in the past.
>
> Windows support only matters for net/ice and firmware loadi
On 6/2/2021 1:05 PM, David Marchand wrote:
> On Wed, Jun 2, 2021 at 12:38 PM Igor Russkikh wrote:
>> We (Marvell QED) already provide packed version of FW in linux-firmware:
>>
>> But thats a custom name, and zlib.
>
> Whatever binary blob is available in linux
barchive is set as an optional dependency: without libarchive, a
> runtime warning is emitted so that users know there is a compressed
> firmware.
>
> Windows implementation is left as an empty stub.
>
> Signed-off-by: David Marchand
for QEDE,
Reviewed-by: Igor Russkikh
Deven
oved extra logging #defines
- misc comments from previous review session
version 2 changes:
- fixed build on freebsd (no ETIME const)
- fixed a bunch of checkpatch failures and warnings
- removed extra CFLAGS disabled warning
- making static arrays const
Igor Russkikh (9):
net/atlantic: logging macroe
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_logs.h | 31 +++
drivers/net/atlantic/atl_types.h | 31 +++
2 files changed, 62 insertions(+)
create mode 100644 drivers/net/atlantic/atl_logs.h
From: Pavel Belous
Makefile/meson build infrastructure, atl_ethdev minimal skeleton,
header with aquantia aQtion NIC device and vendor IDs.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
config/common_base| 5 +
drivers/net/Makefile
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile | 1 +
drivers/net/atlantic/atl_hw_regs.c | 52 +
drivers/net/atlantic/atl_hw_regs.h | 53 ++
drivers/net/atlantic/atl_types.h
AQC NICs comes in fields with two major
FW generations: 1x and 3x.
This is part of linux atlantic driver shared code,
responsible for internal NIC firmware interactions,
including link management ops, FW initialization,
various lifecycle features.
Signed-off-by: Igor Russkikh
Signed-off-by
This is hw_atl logic layer derived from linux atlantic
driver. It contains RX/TX hardware initialization
sequences, various hw configuration.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile| 1 +
drivers/net/atlantic/atl_types.h
From: Pavel Belous
Start, stop and reset are all done via hw_atl layer.
Link interrupt configuration is also done here.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 196 --
drivers/net/atlantic
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile | 1 +
drivers/net/atlantic/atl_ethdev.c | 20 ++-
drivers/net/atlantic/atl_ethdev.h | 15 ++
drivers/net/atlantic/atl_rxtx.c | 42
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile | 2 +-
drivers/net/atlantic/atl_ethdev.c | 71 +
drivers/net/atlantic/atl_ethdev.h | 19 ++
drivers/net/atlantic/atl_rxtx.c | 616 +-
4 files changed
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 8 +++
drivers/net/atlantic/atl_ethdev.h | 12
drivers/net/atlantic/atl_rxtx.c | 125 ++
3 files changed, 145 insertions(+)
diff
From: Pavel Belous
Implement link interrupt, link info, link polling.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 461 +-
drivers/net/atlantic/atl_ethdev.h | 16 ++
drivers/net/atlantic/atl_rxtx.c
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 154 ++
drivers/net/atlantic/atl_ethdev.h | 1 +
drivers/net/atlantic/atl_rxtx.c | 11 ++-
drivers/net/atlantic/atl_types.h | 41
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 28 ++
drivers/net/atlantic/atl_ethdev.h | 7 +
drivers/net/atlantic/atl_rxtx.c | 530 +-
3 files changed, 556 insertions(+), 9
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 44 +++
1 file changed, 44 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 47 +++
1 file changed, 47 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 161 ++
drivers/net/atlantic/atl_types.h | 2 +
2 files changed, 163 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 107 ++
drivers/net/atlantic/atl_ethdev.h | 14 +
drivers/net/atlantic/atl_rxtx.c | 5 ++
3 files changed, 126 insertions(+)
diff --git a/drivers/net
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 126 ++
1 file changed, 126 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 54 +++
1 file changed, 54 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index 90ab8d9c0b1d
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile | 4 +++
drivers/net/atlantic/atl_ethdev.c | 53 +
drivers/net/atlantic/atl_ethdev.h | 3 ++
drivers/net/atlantic/meson.build| 3
Signed-off-by: Igor Russkikh
---
doc/guides/nics/atlantic.rst | 53 ++
doc/guides/nics/features/atlantic.ini | 37
doc/guides/nics/index.rst | 1 +
doc/guides/rel_notes/release_18_11.rst | 5
4 files changed
Hi Ferruh,
Thanks again for the review, we'll investigate and work on your comments!
> > +CONFIG_RTE_LIBRTE_ATLANTIC_PMD=y
> Just to check, default enable in "common_base" means PMD supports all
> architectures (x86_64, i686, arm, ppc) and both Linux and FreeBSD.
> If this is not the case, please
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 16
drivers/net/atlantic/atl_logs.h | 31 +++
drivers/net/atlantic/atl_types.h | 25 +
3 files changed, 72 insertions
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile | 1 +
drivers/net/atlantic/atl_hw_regs.c | 52 +
drivers/net/atlantic/atl_hw_regs.h | 53 ++
drivers/net/atlantic/atl_types.h
From: Pavel Belous
Makefile/meson build infrastructure, atl_ethdev minimal skeleton,
header with aquantia aQtion NIC device and vendor IDs.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
config/common_base| 5 +
config/defconfig_ppc_64-power8
(no ETIME const)
- fixed a bunch of checkpatch failures and warnings
- removed extra CFLAGS disabled warning
- making static arrays const
Igor Russkikh (9):
net/atlantic: logging macroes and some typedefs
net/atlantic: hardware register access routines
net/atlantic: hw_atl register declarat
AQC NICs comes in fields with two major
FW generations: 1x and 3x.
This is part of linux atlantic driver shared code,
responsible for internal NIC firmware interactions,
including link management ops, FW initialization,
various lifecycle features.
Signed-off-by: Igor Russkikh
Signed-off-by
This is hw_atl logic layer derived from linux atlantic
driver. It contains RX/TX hardware initialization
sequences, various hw configuration.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile| 1 +
drivers/net/atlantic/atl_types.h
From: Pavel Belous
Start, stop and reset are all done via hw_atl layer.
Link interrupt configuration is also done here.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 158
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile | 1 +
drivers/net/atlantic/atl_ethdev.c | 20 ++-
drivers/net/atlantic/atl_ethdev.h | 15 ++
drivers/net/atlantic
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile | 2 +-
drivers/net/atlantic/atl_ethdev.c | 72 -
drivers/net/atlantic/atl_ethdev.h | 19 ++
drivers/net/atlantic/atl_rxtx.c | 622 +-
4 files changed
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 8 +++
drivers/net/atlantic/atl_ethdev.h | 12
drivers/net/atlantic/atl_rxtx.c | 125 ++
3 files
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 44 +++
1 file changed, 44 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 28 ++
drivers/net/atlantic/atl_ethdev.h | 7 +
drivers/net/atlantic/atl_rxtx.c | 536 +-
3 files changed, 562 insertions(+), 9
From: Pavel Belous
Implement link interrupt, link info, link polling.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 463 +-
drivers/net/atlantic/atl_ethdev.h | 16 ++
drivers/net/atlantic/atl_rxtx.c
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 154 ++
drivers/net/atlantic/atl_ethdev.h | 1 +
drivers/net/atlantic/atl_rxtx.c | 11 ++-
drivers/net/atlantic/atl_types.h | 41
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 126 ++
1 file changed, 126 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 107 ++
drivers/net/atlantic/atl_ethdev.h | 14 +
drivers/net/atlantic/atl_rxtx.c | 5 ++
3 files changed, 126 insertions(+)
diff --git a/drivers/net
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 161 ++
drivers/net/atlantic/atl_types.h | 2 +
2 files changed, 163 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 54 +++
1 file changed, 54 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 47 +++
1 file changed, 47 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile | 4 +++
drivers/net/atlantic/atl_ethdev.c | 53 +
drivers/net/atlantic/atl_ethdev.h | 3 ++
drivers/net/atlantic/meson.build| 3
From: Pavel Belous
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index fb23dc89f88c
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/atlantic.rst | 53 ++
doc/guides/nics/features/atlantic.ini | 37
doc/guides/nics/index.rst | 1 +
doc/guides/rel_notes/release_18_11
On 10.10.2018 13:32, Ferruh Yigit wrote:
> Hi Igor,
>
> I put some comments on individual patches, please check them.
>
> Also can you please run "./devtools/check-git-log.sh -22" and fix reported
> warnings there?
Hi Ferruh,
Thanks alot for the detailed review and comments, we'll rework the
Hi Ferruh,
>> +int rte_pmd_atl_dev_led_control(int port, int control);
>
> What is the intention here, making PMD specific public API?
> If so .map file is missing but we discourage using PMD specific APIs,
>
> can't it be possible to extend exiting led related dev_ops in a generic way to
> cove
from previous review session
version 2 changes:
- fixed build on freebsd (no ETIME const)
- fixed a bunch of checkpatch failures and warnings
- removed extra CFLAGS disabled warning
- making static arrays const
Igor Russkikh (9):
net: atlantic: maintainers and documentation
net/atlantic: logging
From: Pavel Belous
Makefile/meson build infrastructure, atl_ethdev minimal skeleton,
header with aquantia aQtion NIC device and vendor IDs.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
config/common_base| 5 +
config/defconfig_ppc_64-power8
Add atlantic rst doc, minimal features file,
update MAINTAINERS for atlantic driver
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
MAINTAINERS | 7 +++
doc/guides/nics/atlantic.rst | 37 +++
doc/guides/nics
Implement logging macroses for debug purposes.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 14 ++
drivers/net/atlantic/atl_logs.h | 31 +++
drivers/net/atlantic/atl_types.h | 25
Add implementation for hardware registers access routines.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile | 1 +
drivers/net/atlantic/atl_hw_regs.c | 52 +
drivers/net/atlantic/atl_hw_regs.h | 53
AQC NICs comes in fields with two major
FW generations: 1x and 3x.
This is part of linux atlantic driver shared code,
responsible for internal NIC firmware interactions,
including link management ops, FW initialization,
various lifecycle features.
Signed-off-by: Igor Russkikh
Signed-off-by
Add implementation for RX datapath.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/atlantic.rst | 6 +
doc/guides/nics/features/atlantic.ini | 5 +
drivers/net/atlantic/Makefile | 2 +-
drivers/net/atlantic/atl_ethdev.c | 79
From: Pavel Belous
Start, stop and reset are all done via hw_atl layer.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/features/atlantic.ini | 1 +
drivers/net/atlantic/atl_ethdev.c | 140 --
drivers/net/atlantic
This is hw_atl logic layer derived from linux atlantic
driver. It contains RX/TX hardware initialization
sequences, various hw configuration.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile| 1 +
drivers/net/atlantic/atl_types.h
From: Pavel Belous
Add RX/TX function prototypes for further datapath development.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/features/atlantic.ini | 1 +
drivers/net/atlantic/Makefile | 1 +
drivers/net/atlantic/atl_ethdev.c | 14
From: Pavel Belous
Add implementation for TX datapath.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 28 ++
drivers/net/atlantic/atl_ethdev.h | 7 +
drivers/net/atlantic/atl_rxtx.c | 546 +-
3 files
From: Pavel Belous
Implement link interrupt, link info, link polling.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/features/atlantic.ini | 3 +
drivers/net/atlantic/atl_ethdev.c | 411 +-
drivers/net/atlantic/atl_ethdev.h
From: Pavel Belous
Add support for device statistics.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/atlantic.rst | 1 +
doc/guides/nics/features/atlantic.ini | 3 +
drivers/net/atlantic/atl_ethdev.c | 133
Add support for Receive Side Scaling feature.
RSS hash and reta table configuration.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/atlantic.rst | 1 +
doc/guides/nics/features/atlantic.ini | 3 +
drivers/net/atlantic/atl_ethdev.c | 107
From: Pavel Belous
Add support for flow control feature.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/features/atlantic.ini | 1 +
drivers/net/atlantic/atl_ethdev.c | 54 +++
2 files changed, 55 insertions(+)
diff --git a
From: Pavel Belous
Add support for Rx/Tx descriptors status information.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/features/atlantic.ini | 2 +
drivers/net/atlantic/atl_ethdev.c | 8 +++
drivers/net/atlantic/atl_ethdev.h | 12
drivers/net
From: Pavel Belous
Add support for adding/removing MAC addresses.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/features/atlantic.ini | 1 +
drivers/net/atlantic/atl_ethdev.c | 105 ++
2 files changed, 106 insertions
From: Pavel Belous
Add support for promiscuous/allmulticast modes configuration.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/atlantic.rst | 2 ++
doc/guides/nics/features/atlantic.ini | 2 ++
drivers/net/atlantic/atl_ethdev.c | 44
From: Pavel Belous
This patch add support for dumping MAC registers.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/features/atlantic.ini | 1 +
drivers/net/atlantic/atl_ethdev.c | 32
2 files changed, 33 insertions(+)
diff
From: Pavel Belous
Add support for updating MTU value.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/features/atlantic.ini | 1 +
drivers/net/atlantic/atl_ethdev.c | 21 +
2 files changed, 22 insertions(+)
diff --git a/doc/guides/nics
From: Pavel Belous
VLAN filters and VLAN offloads implementation.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/features/atlantic.ini | 2 +
drivers/net/atlantic/atl_ethdev.c | 159 ++
drivers/net/atlantic/atl_types.h
Release notes for Aquantia atlantic driver.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/rel_notes/release_18_11.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/release_18_11.rst
b/doc/guides/rel_notes/release_18_11.rst
index
From: Pavel Belous
Add support for EEPROM reading/writing.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
doc/guides/nics/features/atlantic.ini | 1 +
drivers/net/atlantic/atl_ethdev.c | 47 +++
2 files changed, 48 insertions(+)
diff --git
Hi Ferruh,
On 11.10.2018 16:11, Ferruh Yigit wrote:
> Hi Igor,
>
> Patchset mostly looks good to me, I put a few comments.
>
> Also I think patch 1/23 & 2/23 can be merged into single commit.
>
> And can you please follow the below format in patch title:
> : ,
>
> like:
>
> from: "net/atlant
Implement logging macroses for debug purposes.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 14 ++
drivers/net/atlantic/atl_logs.h | 31 +++
drivers/net/atlantic/atl_types.h | 25
From: Pavel Belous
Makefile/meson build infrastructure, atl_ethdev minimal skeleton,
header with aquantia aQtion NIC device and vendor IDs.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
MAINTAINERS | 7 +
config/common_base
Add implementation for hardware registers access routines.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/Makefile | 1 +
drivers/net/atlantic/atl_hw_regs.c | 52 +
drivers/net/atlantic/atl_hw_regs.h | 53
fixed a bunch of checkpatch failures and warnings
- removed extra CFLAGS disabled warning
- making static arrays const
Igor Russkikh (8):
net/atlantic: add logging structure
net/atlantic: add hardware registers access routines
net/atlantic: add hardware access layer
net/atlantic: implement fir
AQC NICs comes in fields with two major
FW generations: 1x and 3x.
This is part of linux atlantic driver shared code,
responsible for internal NIC firmware interactions,
including link management ops, FW initialization,
various lifecycle features.
Signed-off-by: Igor Russkikh
Signed-off-by
1 - 100 of 264 matches
Mail list logo
