Hi Ferruh, On 11.10.2018 16:11, Ferruh Yigit wrote:
> Hi Igor, > > Patchset mostly looks good to me, I put a few comments. > > Also I think patch 1/23 & 2/23 can be merged into single commit. > > And can you please follow the below format in patch title: > <subsystem>: <start with verb in lowercase and describe what is done>, > > like: > > from: "net/atlantic: logging macroses and some typedefs" > to: "net/atlantic: add logging structure" > > from "net/atlantic: atlantic hardware layer routines" > to: "net/atlantic: add hardware layer routines" > > from: "net/atlantic: transmit side structures and implementation" > to: "net/atlantic: implement Tx" Got it, thank you for quick turnaround! Regards, Igor