David Marchand writes:
> On Thu, Jun 30, 2022 at 1:43 PM Ferruh Yigit wrote:
>> Last minute opens were:
>>
>> * I am getting ABI check crash, when again v21.11 with abigail 2.0.0,
>> for the file 'librte_common_qat'. Not sure if this is specific to my
>> environment, would be good if someone dou
Hello Thomas and others,
Thomas Monjalon writes:
> Question to an expert, Dodji,
Thanks for the kind words, but I am not an expert in anything, sadly. I
am just trying to keep learning about these things ;-)
> We have this structure:
>
> struct rte_cryptodev {
> lot of fields...
>
Thomas Monjalon writes:
[...]
>> > Then I've added (quickly) a libabigail exception rule:
>> >
>> > [suppress_type]
>> >name = rte_cryptodev
>> >has_data_member_inserted_between = {0, 1023}
>> >
>> > Now we want to improve this rule to restrict the offsets
>> > to the padding at the end
"Kinsella, Ray" writes:
> On 22/01/2021 13:09, Dodji Seketeli wrote:
>> Thomas Monjalon writes:
>>
>> [...]
>>
>>>>> Then I've added (quickly) a libabigail exception rule:
>>>>>
>>>>> [suppress
Hello,
David Marchand writes:
> Dodji confirmed the issue in libabigail and prepared a fix.
Yes, that is correct. Sorry for the inconvenience.
The patch fixing this issue in libabigail has been applied to the
mainline and is
https://sourceware.org/git/?p=libabigail.git;a=commit;h=3cc1c3423c89c
Hello,
David Marchand writes:
> Hello Dodji,
o/
[...]
> This change is reported as a potential ABI change.
>
> For the context, this patch
> https://patchwork.dpdk.org/project/dpdk/patch/1709012499-12813-21-git-send-email-roret...@linux.microsoft.com/
> removes null-sized markers (those fiel
David Marchand writes:
> On Wed, Feb 28, 2024 at 3:04 PM Dodji Seketeli wrote:
>> > Btw, I see no way to suppress this (except a global [suppress_type]
>> > name = rte_mbuf)...
>>
>> Right.
>>
>> To avoid having subsequent changes to that typ
Hello,
> On Fri, Apr 5, 2024 at 2:55 AM Tyler Retzlaff
[...]
>> i'm jealous we don't have libabigail on windows, so helpful.
Heh, thank you for the kind words.
David Marchand writes:
[...]
> libabigail is written in C++ and relies on the elfutils and libxml2
> libraries.
That is correct.
Hello,
David Marchand writes:
> abidiff can provide some more information about the ABI difference it
> detected.
> In all cases, a discussion on the mailing must happen but we can give
> some hints to know if this is a problem with the script calling abidiff,
> a potential ABI breakage or an un
David Marchand writes:
[...]
>> --- a/devtools/libabigail.abignore
>> +++ b/devtools/libabigail.abignore
>> @@ -48,6 +48,10 @@
>> changed_enumerators = RTE_CRYPTO_AEAD_LIST_END
>> [suppress_variable]
>> name = rte_crypto_aead_algorithm_strings
>> +; Ignore updates of epoll eve
Hello,
Ray Kinsella writes:
> ah ok, the particular system I made the change on was Ubuntu 18.04.2.
> which is libabigail 1.2.0.
Whoah, 1.2 is super old.
In my opinion, one of the hallmarks of static analysis tools (and
libabigail is just a static analysis framework) is to be able to
recognize
Hello,
"Ananyev, Konstantin" writes:
> Hi David,
>
>> > Have a question regarding validate-abi.sh.
>> > It complains on the following changes with that patch:
>> >
>> > @@ -111,11 +129,21 @@ struct rte_ring {
>> > char pad0 __rte_cache_aligned; /**< empty cache line */
>> >
>> >
Hello Hemant,
Hemant Agrawal writes:
[...]
>> >> > > [Hemant]
>> >> > > As per the logs:
>> >> > >
>> >> > > Variables changes summary: 1 Removed, 2 Changed, 0 Added
>> >> > > variables
>> >> > > 1 Removed variable:
>> >> > > 'dpaa2_portal_dqrr per_lcore_dpaa2_held_bufs'
>> >> > {per_lcore_dp
help him get the syntax of a libabigail suppression
specification right.
Sorry for the confusion I might have induced.
Dodji Seketeli writes:
> Hello Hemant,
>
> Hemant Agrawal writes:
>
> [...]
>
>>> >> > > [Hemant]
>>> >> > > As pe
Hello,
Ferruh Yigit a écrit:
[...]
> +1 the change/shuffle of the existing values are problematic, but we don't
> have
> it in this case.
Right.
[...]
> The concern is when there are cases we can waive, we can't directly rely on
> the
> tool and automate it. These indicators good for impro
Hello,
David Marchand writes:
>> > +
>> > LIBABIGAIL_REPO=${LIBABIGAIL_REPO:-https://sourceware.org/git/libabigail.git}
>> > +LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6}
>> > +
>> > +if [ "$(cat libabigail/VERSION 2>/dev/null)" != "$LIBABIGAIL_VERSION"
>> > ]; then
>> >
Hello,
David Marchand writes:
> On Thu, Mar 5, 2020 at 10:19 AM Hemant Agrawal (OSS)
> wrote:
>> > On Thu, Mar 5, 2020 at 10:06 AM Hemant Agrawal (OSS)
>> > wrote:
>> > >
>> > > Hi David,
>> > > > On Mon, Mar 2, 2020 at 10:26 AM Hemant Agrawal
>> > > > wrote:
>> > > > >
>> > > > > This patch
David Marchand writes:
> On Thu, Jan 7, 2021 at 2:33 PM Thomas Monjalon wrote:
>> > Yes that may break the ABI but fortunately the checking-abi-compatibility
>> > tool shows negative :) , thanks Ferruh' s guide.
>> > https://github.com/ferruhy/dpdk/actions/runs/468859673
>>
>> That's very stran
Hello,
David Marchand writes:
[...]
On Thu, Jul 16, 2020 at 6:16 AM Phil Yang wrote:
>> >
>> > v4 does not pass the checks (in both my env, and Travis).
>> > https://travis-ci.com/github/ovsrobot/dpdk/jobs/359393389#L2405
>>
>> I think we need an exception in 'libabigail.abignore' for this ch
Hello,
Ferruh Yigit writes:
> On 9/5/2024 11:14 AM, Akhil Goyal wrote:
>> Replace *_LIST_END enumerators from asymmetric crypto
>> lib to avoid ABI breakage for every new addition in
>> enums with inline APIs.
>>
>> Signed-off-by: Akhil Goyal
>> ---
>> This patch was discussed in ML long time
Hello,
Ferruh Yigit writes:
[...]
>> This change cause the value of the the FOOD_END enumerator to increase.
>> And that increase might be problematic. At the moment, for it being
>> problematic or not has to be the result of a careful review.
>>
>
> As you said, FOOD_END value change can be
Hello,
Akhil Goyal writes:
[...]
>> I believe that if you want to know if an enumerator value is *USED* by a
>> type (which I believe is at the root of what you are alluding to), then
>> you would need a static analysis tool that works at the source level.
>> Or, you need a human review of the
Akhil Goyal writes:
>> >>> Now added inline APIs for getting the list end which need to be updated
>> >>> for each new entry to the enum. This shall help in avoiding ABI break
>> >>> for adding new algo.
>> >>>
>> >>
>> >> Hi Akhil,
>> >>
>> >> *I think* this hides the problem instead of fixing i
23 matches
Mail list logo
