Hi Cristian,
Please find answers inline.
> > Log: v2 change in rte_sched.h to avoid ABI breakage.
Lessons learned, so I have fixed also positioning of this above.
> > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index
> > ec74bee939..db14934832 100644
> > --- a/lib/sched/r
Hi Cristian,
Ok, let me check.
BR,
/Marcin
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Wednesday, June 8, 2022 1:59 PM
> To: Danilewicz, MarcinX ; dev@dpdk.org;
> Singh, Jasvinder
> Cc: Ajmera, Megha ; Liu, Yu Y
>
> Subject: RE: [PATCH v3] sched
> > Subject: [PATCH v5] ched: enable CMAN at runtime
> >
>
> Title: ched -> sched
Indeed!
BR,
/Marcin
Hi Cristian,
> The code changes in the library (rte-sched.c) look good to me, but I do have
> some questions for the qos_sched app and the Soft NIC driver on how CMAN
> gets enabled/disabled.
That was open q from start. We finally found a time to discuss this.
> How do we control whether conges
> Here only mode is set to RTE_SCHED_CMAN_RED. But I could not find the
> place where cman_params are set from cfg_file (for e.g. red_params). Can
> you clarify?
Look beyond that particular change. All this is joined work. I am adding final
touch to what I've started, he continued and now we all
> > Signed-off-by: Marcin Danilewicz
> > ---
> > Log: v2 change in rte_sched.h to avoid ABI breakage.
> > v3 changes from comments
> > v4 rebase to 22.07-rc1
> > v5 rebase to main latest
> > v6 commit message fixed
> > v7 changes from comments
> > v8 with changes fro
> > For an instance:
> > If (cman_params.cman_mode == RTE_SCHED_CMAN_PIE ||
> > cman_params.cman_mode == RTE_SCHED_CMAN_RED) { Then set
> > subport_params[i].cman_params to cman_params.
> > }
>
> Yes, this is correct as well.
I'm happy to hear that.
esday, May 24, 2022 4:30 PM
To: Danilewicz, MarcinX ; dev@dpdk.org; Singh,
Jasvinder
Cc: Ajmera, Megha ; Thakur, Sham Singh
; Mcnamara, John ;
Devlin, Michelle
Subject: RE: [PATCH v4] sched: enable traffic class oversubscription
conditionally
> -Original Message-
> From: Dan
essage. My apologies, even if I wasn't
source for that mistake.
BR,
/Marcin
> -Original Message-
> From: Stephen Hemminger
> Sent: Tuesday, May 24, 2022 4:53 PM
> To: Danilewicz, MarcinX
> Cc: Dumitrescu, Cristian ; dev@dpdk.org;
> Singh, Jasvinder ; Ajmera, Megha
&g
Hi all,
Going trough all notes on
http://patches.dpdk.org/project/dpdk/patch/20220427092357.491720-1-marcinx.danilew...@intel.com/
please find my answers inline here.
First of all please take my apologies, for not checking url as above on regular
basis. I was awaiting for mails with me on
Hi Cristian,
Thank you for comments. Please find my response inline.
> > Signed-off-by: Marcin Danilewicz
> > ---
> > lib/sched/rte_sched.c | 96
> > +--
> > 1 file changed, 93 insertions(+), 3 deletions(-)
> >
> This latest version of your patch only con
Hi Cristian,
>
> Using a switch statement for a binary condition instead of if-else does not
> make sense to me. I know you mention you saw better performance with the
> switch, but I am pretty sure it is not the switch providing the performance
> increase. You are using if-else for testing the
Hi Cristian,
> > By default TC OV is disabled.
> > History:
> > - v1 - TC OV disabled by default
> > - v2 - throughput improvements
> > - v3, v4, v5 - changes from comments
> > - v6 - removed rte_sched_subport_tc_ov_config declaration and map
>
> The place of the history log is not here. If you
Hi Cristian,
Please find inline answers:
> > History:
> > - v1 - TC OV disabled by default
> > - v2 - throughput improvements
> > - v3, v4, v5 - changes from comments
> > - v6 - removed rte_sched_subport_tc_ov_config declaration and map
> > - v7 - changes from comments on v6
>
> I see you moved
Hi Cristian,
> Can you please explain why you need to add the new
> RTE_SCHED_CMAN_NONE value to this enumeration and what is the ABI
> breakage that you are trying to avoid?
>
> The library expects the struct rte_sched_subport_params:: cman_params to
> be NULL when the CMAN is disabled, why i
Hi Cristian,
> Nope, it looks like we have a misunderstanding here. Looking back at my
> comments from V3: What I meant is that the configuration values related to
> this feature (all the tc_ov configuration values) should be computed at
> initialization regardless of whether this feature is enabl
Thank you Thomas.
BR,
/Marcin
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, May 31, 2022 6:42 PM
> To: Danilewicz, MarcinX
> Cc: dev@dpdk.org; Singh, Jasvinder ; Ajmera,
> Megha ; Dumitrescu, Cristian
>
> Subject: Re: [PATCH v10] sch
+this time to dpdk.org , to test removal of automatic footer
Hi Cristian,
< snip >
> > +++ b/lib/sched/rte_sched.h
> > @@ -128,6 +128,8 @@ extern "C" {
> > enum rte_sched_cman_mode {
> > RTE_SCHED_CMAN_RED, /**< Random Early Detection (RED) */
> > RTE_SCHED_CMAN_PIE, /**< Proportional I
Hi Thomas,
Could you merge this change with the latest DPDK?
Thanks!
Kind Regards,
/Marcin
> -Original Message-
> From: Singh, Jasvinder
> Sent: Tuesday, July 26, 2022 3:49 PM
> To: Danilewicz, MarcinX ; dev@dpdk.org;
> Dumitrescu, Cristian
> Cc: Ajmera, Megha
>
19 matches
Mail list logo
