Hi Cristian, > Nope, it looks like we have a misunderstanding here. Looking back at my > comments from V3: What I meant is that the configuration values related to > this feature (all the tc_ov configuration values) should be computed at > initialization regardless of whether this feature is enabled or not in order > to > minimize code changes and the size of the patch. In V3, you moved a lot of > the init code into a different function, but it was my mistake not to realize > this was the API function you introduced, sorry about the misunderstanding. That’s the way of life, no simple idea is simple 😊
> I think we definitely need an API function to simply set the internal subport > tc_ov_enabled flag (while also doing the proper argument checks that any > well behaved API function must do), but we should not move here the init > code that does not really need to be here. Makes sense? Agree. Will work out something asap. Regards, /Marcin
