Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function

2018-04-17 Thread Chen, Junjie J
Thanks to point this out. I agree for the title change. Do you want me to send v2 patch? Or you can handle it when committing? > > > Sometimes gcc does not inline the function despite keyword *inline*, > > > we obeserve rte_movX is not inline when doing performance profiling, > > > so use *alway

Re: [dpdk-dev] [PATCH] net/vhost: Initialise vid to -1

2018-05-06 Thread Chen, Junjie J
Hi Maxime I saw Yuanhan already did this. Two patches already in 17.11 LTS. Cheers JJ > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, May 4, 2018 9:09 PM > To: Loftus, Ciara ; dev@dpdk.org > Cc: Chen, Junjie J > Subj

Re: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev dynamically

2018-04-10 Thread Chen, Junjie J
Thanks for report, I just summited this patch to fix: https://dpdk.org/dev/patchwork/patch/37765/ > > Hi, > > On Fri, Mar 30, 2018 at 02:58:31PM +0800, Junjie Chen wrote: > >When creating vdev dynamically, vhost pmd driver starts directly > >without checking TX/RX queues are ready or not, and t

Re: [dpdk-dev] [PATCH] net/vhost: fix vhost invalid state

2018-04-10 Thread Chen, Junjie J
OWN; Will send out V2 to include this. Cheers JJ > -Original Message- > From: Jens Freimann [mailto:jfreim...@redhat.com] > Sent: Tuesday, April 10, 2018 7:13 PM > To: Chen, Junjie J > Cc: Tan, Jianfeng ; maxime.coque...@redhat.com; > mtetsu...@gmail.com; dev@dpdk.org >

Re: [dpdk-dev] [PATCH v2] net/vhost: fix vhost invalid state

2018-04-11 Thread Chen, Junjie J
> > > On 4/11/2018 6:53 PM, Junjie Chen wrote: > > dev_start sets *dev_attached* after setup queues, this sets device to > > invalid state since no frontend is attached. Also destroy_device set > > *started* to zero which makes *allow_queuing* always zero until > > dev_start get called again. Act

Re: [dpdk-dev] [PATCH v2] net/vhost: fix vhost invalid state

2018-04-11 Thread Chen, Junjie J
Hi Jianfeng. > On 4/11/2018 4:35 PM, Chen, Junjie J wrote: > >> > >> On 4/11/2018 6:53 PM, Junjie Chen wrote: > >>> dev_start sets *dev_attached* after setup queues, this sets device > >>> to invalid state since no frontend is attached. Also destroy_d

Re: [dpdk-dev] [PATCH v3] net/vhost: fix vhost invalid state

2018-04-12 Thread Chen, Junjie J
> > > > On 04/12/2018 09:21 AM, Tan, Jianfeng wrote: > > > > > > On 4/12/2018 1:02 AM, Junjie Chen wrote: > >> dev_start sets *dev_attached* after setup queues, this sets device to > >> invalid state since no frontend is attached. Also destroy_device set > >> *started* to zero which makes *allow

Re: [dpdk-dev] [PATCH v6 1/2] vhost: add support for interrupt mode

2018-04-13 Thread Chen, Junjie J
Hi > Please next time run checkpatch before posting, I had to fix below errors when Thanks, I ran for v1-v5 and too confident for the last minor change. > applying. > > Thanks, > Maxime > > ### [dpdk-dev,v6,1/2] vhost: add support for interrupt mode > > CHECK:BRACES: braces {} should be used o

Re: [dpdk-dev] [PATCH] vhost: do deep copy while reallocate vq

2018-01-15 Thread Chen, Junjie J
Hi > > @@ -227,6 +227,7 @@ vhost_user_set_vring_num(struct virtio_net *dev, > > "zero copy is force disabled\n"); > > dev->dequeue_zero_copy = 0; > > } > > + TAILQ_INIT(&vq->zmbuf_list); > > } > > > > vq->shadow_used_rin

Re: [dpdk-dev] [PATCH] vhost: do deep copy while reallocate vq

2018-01-15 Thread Chen, Junjie J
Hi > > > > @@ -227,6 +227,7 @@ vhost_user_set_vring_num(struct virtio_net > *dev, > > > > "zero copy is force disabled\n"); > > > > dev->dequeue_zero_copy = 0; > > > > } > > > > + TAILQ_INIT(&vq->zmbuf_list); > >

Re: [dpdk-dev] [PATCH] vhost: dequeue zero copy should restore mbuf before return to pool

2018-01-17 Thread Chen, Junjie J
> > > > dequeue zero copy change buf_addr and buf_iova of mbuf, and return to > > mbuf pool without restore them, it breaks vm memory if others allocate > > mbuf from same pool since mbuf reset doesn't reset buf_addr and > buf_iova. > > > > Signed-off-by: Junjie Chen > > --- > > lib/librte_vhost/

Re: [dpdk-dev] About : Enable optional dequeue zero copy for vHost User

2018-01-23 Thread Chen, Junjie J
Hi Which version of dpdk you are using? I have some fixes for dequeue zero copy and now in 18.02-rc1, you can try 18.02-r1. Cheers JJ > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Loftus, Ciara > Sent: Tuesday, January 23, 2018 6:46 PM > To: liyang07 > Cc:

Re: [dpdk-dev] [PATCH] doc: add driver limitation for vhost dequeue zero copy

2018-03-13 Thread Chen, Junjie J
Done, Thanks for reminder. Cheers JJ > -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, March 13, 2018 5:13 PM > To: Tan, Jianfeng ; Chen, Junjie J > ; dev@dpdk.org > Cc: y...@fridaylinux.org; maxime.coque...@redhat.com > Subject: RE: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH v3] doc: add driver limitation for vhost dequeue zero copy

2018-03-13 Thread Chen, Junjie J
Hi Jianfeng. > -Original Message- > From: Tan, Jianfeng > Sent: Monday, March 12, 2018 11:15 AM > To: Chen, Junjie J ; y...@fridaylinux.org; > maxime.coqu...@redhat.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v3] doc: add driver limitation for vhost dequeue zero c

Re: [dpdk-dev] [PATCH] net/vhost: fix segfault when creating vdev dynamically

2018-03-27 Thread Chen, Junjie J
Hi Jianfeng > On 3/28/2018 12:05 AM, Junjie Chen wrote: > > when creating vdev dynamically, vhost pmd driver start directly > > without checking TX/RX queues ready or not, and thus cause > > segmentation fault when vhost library accessing queues. This patch add > > flag to check whether queues set

Re: [dpdk-dev] [PATCH] net/vhost: fix segfault when creating vdev dynamically

2018-03-27 Thread Chen, Junjie J
> > > >> On 3/28/2018 12:05 AM, Junjie Chen wrote: > >>> when creating vdev dynamically, vhost pmd driver start directly > >>> without checking TX/RX queues ready or not, and thus cause > >>> segmentation fault when vhost library accessing queues. This patch > >>> add flag to check whether queues

Re: [dpdk-dev] [PATCH] net/vhost: fix segfault when creating vdev dynamically

2018-03-27 Thread Chen, Junjie J
> > On 3/27/2018 5:24 PM, Chen, Junjie J wrote: > >>>> On 3/28/2018 12:05 AM, Junjie Chen wrote: > >>>>> when creating vdev dynamically, vhost pmd driver start directly > >>>>> without checking TX/RX queues ready or not, and thus caus

Re: [dpdk-dev] [PATCH v2] vhost: add support for interrupt mode

2018-04-02 Thread Chen, Junjie J
> > > > On 3/29/2018 10:37 PM, Junjie Chen wrote: > > In some cases we want vhost dequeue work in interrupt mode to release > > cpus to others when no data to transmit. So we install interrupt > > handler of vhost device and interrupt vectors for each rx queue when > > creating new backend accor

Re: [dpdk-dev] [PATCH] doc: add a restriction to multi-process support

2017-11-29 Thread Chen, Junjie J
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, November 28, 2017 7:22 PM > To: Chen, Junjie J > Cc: Gonzalez Monroy, Sergio ; Mcnamara, > John ; Tahhan, Maryam > ; Pattan, Reshma ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: add a r

Re: [dpdk-dev] [PATCH v5] vhost_user: protect active rings from async ring changes

2018-01-30 Thread Chen, Junjie J
Hi May I know why not use trylock also in enqueue path? Cheers JJ > > When performing live migration or memory hot-plugging, the changes to the > device and vrings made by message handler done independently from vring > usage by PMD threads. > > This causes for example segfaults during live-mi

Re: [dpdk-dev] [PATCH v5] vhost_user: protect active rings from async ring changes

2018-01-31 Thread Chen, Junjie J
Make sense, Thanks. Cheers JJ > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, January 31, 2018 4:13 PM > To: Chen, Junjie J ; Victor Kaplansky > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5] vhost_user:

Re: [dpdk-dev] [PATCH v2] doc: add driver limitation for vhost dequeue zero copy

2018-03-08 Thread Chen, Junjie J
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, March 6, 2018 4:57 PM > To: Chen, Junjie J ; y...@fridaylinux.org; Tan, > Jianfeng > Cc: dev@dpdk.org > Subject: Re: [PATCH v2] doc: add driver limitation for vh

Re: [dpdk-dev] [PATCH v3] doc: add a restriction to multi-process support

2017-12-12 Thread Chen, Junjie J
Done! Cheers JJ > -Original Message- > From: Mcnamara, John > Sent: Tuesday, December 12, 2017 8:41 PM > To: Chen, Junjie J ; Gonzalez Monroy, Sergio > ; Tahhan, Maryam > ; dev@dpdk.org > Subject: RE: [PATCH v3] doc: add a restriction to multi-process support >

Re: [dpdk-dev] [PATCH v3 2/2] gro: support VxLAN GRO

2017-12-22 Thread Chen, Junjie J
Hi Jiayu > -Original Message- > From: Hu, Jiayu > Sent: Friday, December 22, 2017 3:26 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Chen, Junjie J > ; Ananyev, Konstantin > ; step...@networkplumber.org; Yigit, > Ferruh ; Yao, Lei A ; Hu, Jiayu > > Subjec

Re: [dpdk-dev] [PATCH v3 0/2] Support VxLAN GRO

2017-12-28 Thread Chen, Junjie J
> -Original Message- > From: Hu, Jiayu > Sent: Friday, December 22, 2017 3:26 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Chen, Junjie J > ; Ananyev, Konstantin > ; step...@networkplumber.org; Yigit, > Ferruh ; Yao, Lei A ; Hu, Jiayu > > Subject: [P

Re: [dpdk-dev] [PATCH v3 1/2] gro: code cleanup

2017-12-28 Thread Chen, Junjie J
> -Original Message- > From: Hu, Jiayu > Sent: Friday, December 22, 2017 3:26 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Chen, Junjie J > ; Ananyev, Konstantin > ; step...@networkplumber.org; Yigit, > Ferruh ; Yao, Lei A ; Hu, Jiayu > > Subject: [P

Re: [dpdk-dev] [PATCH v3 2/2] gro: support VxLAN GRO

2017-12-28 Thread Chen, Junjie J
> -Original Message- > From: Hu, Jiayu > Sent: Friday, December 22, 2017 3:26 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Chen, Junjie J > ; Ananyev, Konstantin > ; step...@networkplumber.org; Yigit, > Ferruh ; Yao, Lei A ; Hu, Jiayu > > Subject: [PATCH

Re: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self

2017-12-28 Thread Chen, Junjie J
Thanks Zhiyong Updated in v2. > -Original Message- > From: Yang, Zhiyong > Sent: Friday, December 29, 2017 2:27 PM > To: Chen, Junjie J ; y...@fridaylinux.org; > maxime.coque...@redhat.com > Cc: dev@dpdk.org; Chen, Junjie J > Subject: RE: [dpdk-dev] [PATCH] exampl

Re: [dpdk-dev] [PATCH v6] vhost: support virtqueue interrupt/notification suppression

2018-01-08 Thread Chen, Junjie J
Hi > -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Monday, January 8, 2018 10:07 PM > To: Chen, Junjie J > Cc: Wang, Xiao W ; maxime.coque...@redhat.com; > Bie, Tiwei ; dev@dpdk.org; Yao, Lei A > > Subject: Re: [PATCH v6] vhost: sup