> > entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 12 rate");
> > if (entry)
> > - subport_profile[i].tc_rate[12] = (uint64_t)atoi(entry);
> > + subport_profile[i].tc_rate[12] = atol(entry);
> > }
> >
> > return 0;
> > --
> > 2.2
> >
> > You need to use 'atoll', not 'atol'. And yes, typecast is still required.
>
> The code should be using strtoull() and checking for errors.
Thanks Cristian and Stephen. I have sent updated patch-series v4 for review and
commit.
> >
> > 10/01/2023 12:27, David Marchand:
> > > On Mon, Jan 9, 2023 at 3:59 PM Megha Ajmera
> > wrote:
> > > >
> > > > Current position of "tv_ov_enable" variable in
> > >
> > > tc_ov_enabled*
> > >
> > >
> > > > rte_sched_subport structure makes the "memory" variable unused.
> > >
> > > I did not
>
> Added changes to enable CMAN (RED or PIE) at init from profile configuration
> file.
>
> By default CMAN code is enable but not in use, when there is no RED or PIE
> profile configured.
>
> Signed-off-by: Marcin Danilewicz
> ---
> Log: v2 change in rte_sched.h to avoid ABI breakage.
>
Hi Cristian, Marcin,
> > -Original Message-
> > From: Danilewicz, MarcinX
> > Sent: Wednesday, April 27, 2022 10:24 AM
> > To: dev@dpdk.org; Singh, Jasvinder ;
> > Dumitrescu, Cristian
> > Cc: Ajmera, Megha
> > Subject: [PATCH v3] sched: enabl
>
> Hi Megha,
>
> I noticed several patches from you that all fix small things, can you please
> put all
> of them into a series as opposed to isolated patches? This is to avoid apply
> issues due to dependency order. No need for a cover letter in this case.
>
> Can you please also pay attentio
Hi David,
I have rebased patch-set with latest main branch code resolving the conflicts.
Also updated cover letter.
Regards,
Megha
-Original Message-
From: David Marchand
Sent: Friday, February 18, 2022 1:42 PM
To: Ajmera, Megha
Cc: dev ; Singh, Jasvinder ;
Dumitrescu, Cristian
> From: Stephen Hemminger
> Sent: Tuesday, February 22, 2022 9:33 PM
>
> On Tue, 22 Feb 2022 15:13:53 +0100
> Morten Brørup wrote:
>
> > > From: Megha Ajmera [mailto:megha.ajm...@intel.com]
> > > Sent: Tuesday, 22 February 2022 14.19
> > >
> > > Masking of core mask was incorrect. Instead of us
>
> > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index
> > ec74bee939..1d05089d00 100644
> > --- a/lib/sched/rte_sched.c
> > +++ b/lib/sched/rte_sched.c
> > @@ -155,6 +155,7 @@ struct rte_sched_subport {
> > uint64_t tc_credits[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
> >
> > /
9 matches
Mail list logo
