RE: [PATCH v6 1/8] net/rnp: add skeleton

Hi Ferruh, Thanks for your kindly review, please see the below comment. Regards Wenbo > -Original Message- > From: Ferruh Yigit > Sent: 2023年9月5日 23:35 > To: Wenbo Cao ; Thomas Monjalon > > Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; yao...@mucse.com > Subject: Re: [PATCH v6 1/

RE: [PATCH v6 6/8] net/rnp add port info resource init

Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: 2023年9月6日 0:56 > To: Wenbo Cao > Cc: dev@dpdk.org; tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; > yao...@mucse.com > Subject: Re: [PATCH v6 6/8] net/rnp add port info resource init > > On 9/1/2023 3:30 AM, Wenbo Cao wro

RE: [PATCH v6 7/8] net/rnp add devargs runtime parsing functions

> -Original Message- > From: Ferruh Yigit > Sent: 2023年9月5日 23:47 > To: Wenbo Cao > Cc: dev@dpdk.org; tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; > yao...@mucse.com > Subject: Re: [PATCH v6 7/8] net/rnp add devargs runtime parsing functions > > On 9/1/2023 3:30 AM, Wenbo Cao w

RE: [PATCH v6 5/8] net/rnp add reset code for Chip Init process

Hi Ferruh, Please see the below comment. Regards Wenbo. > -Original Message- > From: Ferruh Yigit > Sent: 2023年9月5日 23:46 > To: Wenbo Cao > Cc: dev@dpdk.org; tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; > yao...@mucse.com > Subject: Re: [PATCH v6 5/8] net/rnp add reset code for

RE: [PATCH v6 4/8] net/rnp: add mbx basic api feature

Hi Ferruh, Please see the below comment :) Regards Wenbo > -Original Message- > From: Ferruh Yigit > Sent: 2023年9月5日 23:45 > To: Wenbo Cao > Cc: dev@dpdk.org; tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; > yao...@mucse.com; Stephen Hemminger > Subject: Re: [PATCH v6 4/8] net/rn

RE: [PATCH v6 2/8] net/rnp: add ethdev probe and remove

> -Original Message- > From: Ferruh Yigit > Sent: 2023年9月5日 23:36 > To: Wenbo Cao ; Anatoly Burakov > > Cc: dev@dpdk.org; tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; > yao...@mucse.com > Subject: Re: [PATCH v6 2/8] net/rnp: add ethdev probe and remove > > On 9/1/2023 3:30 AM,

RE: [PATCH v6 3/8] net/rnp: add device init and uninit

Hi Ferruh, Thanks your kindly review, please see the below comment. Regards Wenbo > -Original Message- > From: Ferruh Yigit > Sent: 2023年9月5日 23:44 > To: Wenbo Cao ; Anatoly Burakov > > Cc: dev@dpdk.org; tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; > yao...@mucse.com > Subject:

RE: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

Hi Stephen, Thanks for your comment, as your advice that I need to define the virtual function pointers As the below type ? const struct rnp_mbx_api { .. } If It will protect the virtual function address ,won't be remove by mistake? Regards Wenbo -Original Message- From: Stephen Hemminger

RE: [[PATCH v1] 3/8] net/rnp: add device init and uninit

Hi Stephen, Why have two labels for same place, to later patches insert code here? For this question the new code in rnp_init_port_resource Will zmalloc dev->data->mac_addrs and dev->data->hash_mac_addrs So I wish to free the zmalloc mem when init port resource failed Regards wenbo -Origi

RE: [[PATCH v1] 0/8] *** SUBJECT HERE ***

Your git commit headings are messed up with extra []. Yes, this is my problem :) David has been mentioned before , I'm re edit the cover-letter now. Thanks a lot. Regards wenbo -Original Message- From: Stephen Hemminger Sent: 2023年8月2日 10:31 To: Wenbo Cao Cc: dev@dpdk.org Subject: Re:

RE: [PATCH v2 2/8] net/rnp: add ethdev probe and remove

; ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru Subject: Re: [PATCH v2 2/8] net/rnp: add ethdev probe and remove On Wed, 2 Aug 2023 08:11:00 + Wenbo Cao wrote: > +RTE_PMD_REGISTER_PCI(net_rnp, rte_rnp_pmd); > +RTE_PMD_REGISTER_PCI_TABLE(net_rnp, pci_id_r

RE: [PATCH v2 4/8] net/rnp: add mbx basic api feature

;+struct rnp_mbx_stats { >... >+} Regards Wenbo -Original Message- From: Stephen Hemminger Sent: 2023年8月3日 0:12 To: Wenbo Cao Cc: dev@dpdk.org; ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru Subject: Re: [PATCH v2 4/8] net/rnp: add mbx basic api feature On Wed, 2 Aug 2023

RE: [PATCH v2 3/8] net/rnp: add device init and uninit

: add device init and uninit On Wed, 2 Aug 2023 08:11:01 + Wenbo Cao wrote: > +struct rnp_hw { > + void *back; > + char *iobar0; > + uint32_t iobar0_len; > + char *iobar4; > + uint32_t iobar4_len; If possible, don't use untyped pointer for link l

RE: [PATCH v5 1/8] net/rnp: add skeleton

Hi Thomas, Thanks for your useful advice, previously only focused on code format and Ignored document format. Regards Wenbo > -Original Message- > From: Thomas Monjalon > Sent: 2023年8月15日 19:11 > To: Wenbo Cao > Cc: dev@dpdk.org; ferruh.yi...@amd.com; andrew.rybche.

RE: [PATCH v6 1/8] net/rnp: add skeleton

Hi Ferruh, Thanks for your reminder, I'm sorry for that I had been work on anothing before. Recendly, I have been reworked on this work. It will miss on release of v24.03. For another thing, I'm always confused for the secondary process call like hw->mac_ops this function pointer. is this meth

RE: [PATCH v8 00/28] [v8]drivers/net Add Support mucse N10 Pmd Driver

Hi Stephen, Thanks for your guideine, I will fixed these soon. Regards Wenbo > -Original Message- > From: Stephen Hemminger > Sent: 2025年2月11日 3:04 > To: Wenbo Cao > Cc: tho...@monjalon.net; dev@dpdk.org; ferruh.yi...@amd.com; > andrew.rybche...@oktetlabs.ru

RE: [PATCH v9 00/28] [v9]drivers/net Add Support mucse N10 Pmd Driver

Hi Stephen， For rsic-v,windows freebsd plaform, I need to limit compile meson file what we not support ? Regards Wenbo > -Original Message- > From: Stephen Hemminger > Sent: 2025年2月11日 22:57 > To: Wenbo Cao > Cc: tho...@monjalon.net; dev@dpdk.org; ferru

RE: [PATCH v9 12/28] net/rnp: add support link update operations

: 2025年2月12日 23:38 > To: 11 > Cc: tho...@monjalon.net; dev@dpdk.org; ferruh.yi...@amd.com; > andrew.rybche...@oktetlabs.ru; yao...@mucse.com > Subject: Re: [PATCH v9 12/28] net/rnp: add support link update operations > > On Wed, 12 Feb 2025 11:21:49 +0800 > "11"

RE: [PATCH v6 0/8] [v6]drivers/net Add Support mucse N10 Pmd Driver

Hi Thomas, I will continue to work on it on this quarter, a more detail servial patchs will be summit after the Spring Festival. Regards Wenbo > -Original Message- > From: Thomas Monjalon > Sent: 2025年1月17日 0:50 > To: yao...@mucse.com; Wenbo Cao > Cc: dev@dpdk.org; ferruh.yi...@amd.c

RE: [PATCH v9 04/28] net/rnp: support mailbox basic operate

Hi Stephen, This flag add will ignore some warning error ? > +error_cflags = ['-Wno-unused-value', > +'-Wno-unused-but-set-variable', > +'-Wno-unused-parameter', > +] Regards Wenbo > -Original Message----- > From:

RE: [PATCH v9 08/28] net/rnp: add queue setup and release operations

..@monjalon.net; dev@dpdk.org; ferruh.yi...@amd.com; > andrew.rybche...@oktetlabs.ru; yao...@mucse.com > Subject: Re: [PATCH v9 08/28] net/rnp: add queue setup and release operations > > On Tue, 11 Feb 2025 16:49:58 +0800 > Wenbo Cao wrote: > > > diff --git a/drivers/net/

RE: [PATCH v9 12/28] net/rnp: add support link update operations

Hi Stephen, For memcpy what ever base code or other code all used memcpy not rte_memcpy ? Even the memory is malloc from rte_malloc/zmalloc ? Regards Wenbo. > -Original Message- > From: Stephen Hemminger > Sent: 2025年2月11日 23:35 > To: Wenbo Cao > Cc: tho...@monjalon.ne

RE: [PATCH v13 00/28] [v13]drivers/net Add Support mucse N10 Pmd Driver

| PASS | +++ | CentOS Stream 10 (ARM) | PASS | +++ | Debian 11 (Buster) (ARM)

RE: [PATCH v15 09/29] net/rnp: add queue stop and start operations

Hi Stephen, I had been not added it to const struct eth_dev_ops for .rx/tx_queue_stop/stop :( Thanks for your check Regrads Wenbo > -Original Message- > From: Stephen Hemminger > Sent: 2025年2月26日 0:09 > To: Wenbo Cao > Cc: tho...@monjalon.net; dev@dpdk.org; yao...@mucse.com > Subject:

RE: [PATCH v16 00/28] [v16]drivers/net Add Support mucse N10 Pmd Driver

|6 + > > doc/guides/nics/features/rnp.ini | 34 + > > doc/guides/nics/img/mucse_nic_port.svg | 4023 > > doc/guides/nics/index.rst |1 + > > doc/guides/nics/rnp.rst| 130 + > > doc/g