Hi Ferruh, Please see the below comment.
Regards Wenbo. > -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@amd.com> > Sent: 2023年9月5日 23:46 > To: Wenbo Cao <caowe...@mucse.com> > Cc: dev@dpdk.org; tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; > yao...@mucse.com > Subject: Re: [PATCH v6 5/8] net/rnp add reset code for Chip Init process > > On 9/1/2023 3:30 AM, Wenbo Cao wrote: > > we must get the shape info of nic from Firmware for > > What is "shape info"? > For the nic 4/8 port mode or one-pcie-one port, media type fiber or copper, 10G/1G "shape info" words may be confused. > > reset. so the related codes is first get firmware info and then reset > > the chip > > > > Is there a specific reason to have "Chip Init" start with uppercase, if not > please > make all lowercase, also ':' after domain, like "net/rnp:'. "Chip Init" is don't have any special meaning, will change the to lowercase.
