[dpdk-dev] [PATCH v2] cycles: add isb before read cntvct_el0

2020-03-10 Thread Linhaifeng
We should use isb rather than dsb to sync system counter to cntvct_el0. Reference of linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/include/asm/arch_timer.h?h=v5.5#n220 Signed-off-by: Haifeng Lin --- .../common/include/arch/arm/rte_atomic_64.h

Re: [dpdk-dev] [PATCH v2] cycles: add isb before read cntvct_el0

2020-03-10 Thread Linhaifeng
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Tuesday, March 10, 2020 5:03 PM > To: Linhaifeng > Cc: Gavin Hu ; dev@dpdk.org; tho...@monjalon.net; > chenchanghu ; xudingke > ; Lilijun (Jerry) ; Honnappa > Nagarahalli ; Steve Capp

[dpdk-dev] [PATCH v3] eal/arm64: fix rdtsc precise version

2020-03-10 Thread Linhaifeng
In order to get more accurate the cntvct_el0 reading, SW must invoke isb and arch_counter_enforce_ordering. Reference of linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/include/asm/arch_timer.h?h=v5.5#n220 Signed-off-by: Haifeng Lin --- .../commo

[dpdk-dev] [PATCH v4] eal/arm64: fix rdtsc precise version

2020-03-10 Thread Linhaifeng
In order to get more accurate the cntvct_el0 reading, SW must invoke isb and arch_counter_enforce_ordering. Reference of linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/ torvalds/linux.git/tree/arch/arm64/include/asm/arch_timer.h?h=v5.5#n220 Fixes: ccad39ea0712 ("eal/arm: add cpu cy

[dpdk-dev] [PATCH v5] eal/arm64: fix rdtsc precise version

2020-03-10 Thread Linhaifeng
From 70acca49c2109ef07e59dd035c5b66d7987d Mon Sep 17 00:00:00 2001 From: Haifeng Lin Date: Mon, 9 Mar 2020 16:49:10 +0800 Subject: [PATCH] eal/arm64: fix rdtsc precise version In order to get more accurate the cntvct_el0 reading, SW must invoke isb and arch_counter_enforce_ordering. Referenc

[dpdk-dev] [PATCH v6] eal/arm64: fix rdtsc precise version

2020-03-11 Thread Linhaifeng
In order to get more accurate the cntvct_el0 reading, SW must invoke isb and arch_counter_enforce_ordering. Reference of linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/ linux.git/tree/arch/arm64/include/asm/arch_timer.h?h=v5.5#n220 Fixes: ccad39ea0712 ("eal/arm: add cpu cy

Re: [dpdk-dev] [PATCH v3] eal/arm64: fix rdtsc precise version

2020-03-11 Thread Linhaifeng
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Tuesday, March 10, 2020 6:47 PM > To: Linhaifeng > Cc: Gavin Hu ; dev@dpdk.org; tho...@monjalon.net; > chenchanghu ; xudingke > ; Lilijun (Jerry) ; Honnappa > Nagarahalli ; Steve Capp

Re: [dpdk-dev] [PATCH v6] eal/arm64: fix rdtsc precise version

2020-03-11 Thread Linhaifeng
> > +static inline void > > +isb(void) > > +{ > > + asm volatile("isb" : : : "memory"); } > > NAK. > > Don't export badly named stuff like this. > Just use asm volatile("isb" : : : "memory") in rte_rdtsc_precise or which file I should use to define this maco > > + > > +static inline voi

[dpdk-dev] [PATCH v7] eal/arm64: fix rdtsc precise version

2020-03-11 Thread Linhaifeng
In order to get more accurate the cntvct_el0 reading, SW must invoke isb. Fixes: ccad39ea0712 ("eal/arm: add cpu cycle operations for ARMv8") Cc: sta...@dpdk.org Reviewed-by: David Marchand Reviewed-by: Jerin Jacob Reviewed-by: Gavin Hu Signed-off-by: Haifeng Lin --- lib/librte_eal/common/in

[dpdk-dev] test: failed to clone dpdk source in windows

2016-08-05 Thread linhaifeng
hi,thomas Could you change the name of file in directory app/test/test_pci_sysfs/bus/pci/devices/ ? I think somebody like us also cann't access internet in liunux.Windows not support file name include ':'. thanks linhaifeng

[dpdk-dev] test: failed to clone dpdk source in windows

2016-08-08 Thread linhaifeng
? 2016/8/7 4:33, Jan Viktorin ??: > On Fri, 05 Aug 2016 09:51:06 +0200 > Thomas Monjalon wrote: > >> 2016-08-05 09:44, Thomas Monjalon: >>> 2016-08-05 10:09, linhaifeng: >>>> hi,thomas >>>> >>>> Could you change the name of fil

[dpdk-dev] [PATCH] net/bonding: not handle vlan slow packet

2016-11-01 Thread linhaifeng
? 2016/11/1 18:46, Ferruh Yigit ??: > Hi Haifeng, > > On 10/31/2016 3:52 AM, linhaifeng wrote: >> From: Haifeng Lin >> >> if rx vlan offload is enable we should not handle vlan slow >> packets too. >> >> Signed-off-by: Haifeng Lin >> --- >&

[dpdk-dev] [PATCH] net/bonding: not handle vlan slow packet

2016-11-04 Thread linhaifeng
Hi,all please ignore the patch which title is "net/bonding: not handle vlan slow packet", I will send another one. ? 2016/11/1 20:32, linhaifeng ??: > ? 2016/11/1 18:46, Ferruh Yigit ??: >> Hi Haifeng, >> >> On 10/31/2016 3:52 AM, linhaifeng wrote: >>&g

[dpdk-dev] [PATCH] net/bonding: only handle lacp slow packets

2016-11-04 Thread linhaifeng
From: Linhaifeng We should not drop the slow packets which subtype is not marker or lacp. Because slow packets have other subtype like OAM,OSSP,user defined and so on. Signed-off-by: Linhaifeng --- drivers/net/bonding/rte_eth_bond_pmd.c | 14 +- 1 file changed, 13 insertions(+), 1

[dpdk-dev] [PATCH v3 2/7] vhost: get guest/host physical address mappings

2016-11-29 Thread linhaifeng
? 2016/10/9 15:27, Yuanhan Liu ??: > + dev->nr_guest_pages = 0; > + if (!dev->guest_pages) { > + dev->max_guest_pages = 8; > + dev->guest_pages = malloc(dev->max_guest_pages * > + sizeof(struct guest_page)); > + } > + w

[dpdk-dev] [PATCH v3 2/7] vhost: get guest/host physical address mappings

2016-11-29 Thread linhaifeng
? 2016/10/9 15:27, Yuanhan Liu ??: > +static void > +add_guest_pages(struct virtio_net *dev, struct virtio_memory_region *reg, > + uint64_t page_size) > +{ > + uint64_t reg_size = reg->size; > + uint64_t host_user_addr = reg->host_user_addr; > + uint64_t guest_phys_addr = r

[dpdk-dev] [PATCH 0/6] vhost: add Tx zero copy support

2016-10-09 Thread linhaifeng
? 2016/8/23 16:10, Yuanhan Liu ??: > The basic idea of Tx zero copy is, instead of copying data from the > desc buf, here we let the mbuf reference the desc buf addr directly. Is there problem when push vlan to the mbuf which reference the desc buf addr directly? We know if guest use virtio_net(k

[dpdk-dev] [PATCH 0/6] vhost: add Tx zero copy support

2016-10-14 Thread linhaifeng
? 2016/10/10 16:03, Yuanhan Liu ??: > On Sun, Oct 09, 2016 at 06:46:44PM +0800, linhaifeng wrote: >> ? 2016/8/23 16:10, Yuanhan Liu ??: >>> The basic idea of Tx zero copy is, instead of copying data from the >>> desc buf, here we let the mbuf reference the desc buf ad

[dpdk-dev] [PATCH] vhost: flush used->idx update before reading avail->flags

2015-06-09 Thread Linhaifeng
On 2015/4/24 15:27, Luke Gorrie wrote: > On 24 April 2015 at 03:01, Linhaifeng wrote: > >> If not add memory fence what would happen? Packets loss or interrupt >> loss?How to test it ? >> > > You should be able to test it like this: > > 1. Boot two

[dpdk-dev] [PATCH] vhost: flush used->idx update before reading avail->flags

2015-06-10 Thread Linhaifeng
On 2015/6/9 21:34, Xie, Huawei wrote: > On 6/9/2015 4:47 PM, Michael S. Tsirkin wrote: >> On Tue, Jun 09, 2015 at 03:04:02PM +0800, Linhaifeng wrote: >>> >>> On 2015/4/24 15:27, Luke Gorrie wrote: >>>> On 24 April 2015 at 03:01, Linhaifeng wrote: >&g

[dpdk-dev] [PATCH] vhost: flush used->idx update before reading avail->flags

2015-06-11 Thread Linhaifeng
On 2015/6/10 16:30, Luke Gorrie wrote: > On 9 June 2015 at 10:46, Michael S. Tsirkin wrote: > >> By the way, similarly, host side must re-check avail idx after writing >> used flags. I don't see where snabbswitch does it - is that a bug >> in snabbswitch? > > > Good question. > > Snabb Switc

<    1   2