> > +static inline void
> > +isb(void)
> > +{
> > + asm volatile("isb" : : : "memory"); }
>
> NAK.
>
> Don't export badly named stuff like this.
>
Just use asm volatile("isb" : : : "memory") in rte_rdtsc_precise or which file
I should use to define this maco
> > +
> > +static inline void
> > +__rte_arm64_cntvct_el0_enforce_ordering(uint64_t val) {
> > + uint64_t tmp;
> > +
> > + asm volatile(
> > + " eor %0, %1, %1\n"
> > + " add %0, sp, %0\n"
> > + " ldr xzr, [%0]"
> > + : "=r" (tmp) : "r" (val));
> > +}
> > +
>
> I can see no point in exporting this.
> Please move this inline of rte_rdtsc_precise().
> If one day, ARM needs this elsewhere, we can reevaluate and introduce a
> helper, but I don't see this atm.
>
Ok. I will remove it.
>
> --
> David Marchand
