Re: 23.11.4 patches review and test

2025-04-28 Thread Yanghang Liu
Hi Xueming, Sorry for the late reply as I was off for a few days last week. I tested below 18 scenarios on RHEL 9.4 hosts and didn't find any new dpdk issues. - VM with device assignment(PF) throughput testing(1G hugepage size): PASS - VM with device assignment(PF) throughput testing(2M

Re: 23.11.4 patches review and test

2025-04-28 Thread Xueming Li
Hi Yanghang, Thanks for your test and reports, will save it in release notes. Thanks, Xueming From: Yanghang Liu Sent: Monday, April 28, 2025 3:22 PM To: Xueming Li Cc: sta...@dpdk.org ; dev@dpdk.org ; Abhishek Marathe ; Ali Alnubani ; David Christensen ; Hema

Re: Regarding Mellanox bifurcated driver on Azure

2025-04-28 Thread Stephen Hemminger
On Mon, 28 Apr 2025 11:31:10 +0530 Prashant Upadhyaya wrote: > On Sat, 26 Apr 2025 at 20:58, Stephen Hemminger > wrote: > > > On Fri, 25 Apr 2025 23:17:30 +0530 > > Prashant Upadhyaya wrote: > > > > > Hi, > > > > > > I am having a VM on Azure where I have got two 'accelerated networking' > >

Re: [PATCH 00/10] centralise base code handling for drivers

2025-04-28 Thread Bruce Richardson
On Thu, Apr 10, 2025 at 08:37:20AM -0700, Stephen Hemminger wrote: > On Mon, 31 Mar 2025 17:09:49 +0100 > Bruce Richardson wrote: > > > Many DPDK drivers use the same pattern for base code handling, having > > a meson.build file in the base code directory which optionally defines > > some custom

Re: [PATCH] net/intel: fix igb tx queue offloads capability

2025-04-28 Thread Bruce Richardson
On Mon, Apr 14, 2025 at 04:53:52PM +0800, Kaiwen Deng wrote: > The igb driver assigns the tx port offload capability to the > tx queue offload capability. > > This commit will fix this issue. > > Fixes: daa3b0833f08 ("net/e1000: fix Tx offload capability typos") > Cc: sta...@dpdk.org > > Signed-

Re: [PATCH v3 1/1] bus/pci: introduce get_iova_mode for pci dev

2025-04-28 Thread Stephen Hemminger
On Sun, 27 Apr 2025 02:27:34 + Kyo Liu wrote: > I propose this patch for DPDK to enable coexistence between > DPDK and kernel drivers for regular NICs.This solution requires > adding a new pci_ops in rte_pci_driver, through which DPDK will > retrieve the required IOVA mode from the vendor dri

[PATCH v8 2/4] net/intel: use common Tx entry structure

2025-04-28 Thread Shaiq Wani
Used the common Tx entry structure and common Tx mbuf ring replenish fn in place of idpf-specific structure and function. The vector driver code paths (AVX2, AVX512) use the smaller SW ring structure. Signed-off-by: Shaiq Wani Acked-by: Bruce Richardson --- drivers/net/intel/cpfl/cpfl_rxtx.c

[PATCH v8 3/4] net/intel: use common Tx queue structure

2025-04-28 Thread Shaiq Wani
Merge in additional fields used by the idpf driver and then convert it over to using the common Tx queue structure Signed-off-by: Shaiq Wani Acked-by: Bruce Richardson --- drivers/net/intel/common/tx.h | 18 ++ drivers/net/intel/cpfl/cpfl_ethdev.c | 3 +- drivers/n

[PATCH v8 1/4] net/intel: align Tx queue struct field names

2025-04-28 Thread Shaiq Wani
Align the Tx queue struct field names in idpf and cpfl driver with the common Tx queue struct. Signed-off-by: Shaiq Wani Acked-by: Bruce Richardson --- drivers/net/intel/cpfl/cpfl_rxtx.c| 40 - drivers/net/intel/cpfl/cpfl_rxtx_vec_common.h | 4 +- drivers/net/intel/idpf/idp

[PATCH v8 0/4] net/intel: using common functions in idpf driver

2025-04-28 Thread Shaiq Wani
reworked the drivers to use the common functions and structures from drivers/net/intel/common. v8: fixed idpf_desc_done fn. v7: rebased on top of latest main branch for a clean apply. Shaiq Wani (4): net/intel: align Tx queue struct field names net/intel: use common Tx entry structure net/i

[PATCH v8 4/4] net/idpf: use common Tx free fn in idpf

2025-04-28 Thread Shaiq Wani
Switch the idpf driver to use the common Tx free function for AVX2 and AVX512 Signed-off-by: Shaiq Wani Acked-by: Bruce Richardson --- .../net/intel/idpf/idpf_common_rxtx_avx2.c| 61 + .../net/intel/idpf/idpf_common_rxtx_avx512.c | 230 +- drivers/net/intel/idpf/idpf_r

Re: 23.11.4 patches review and test

2025-04-28 Thread Xueming Li
Hi Hailin, Thanks for the test and feedback, will collect. Best Regards, Xueming From: Xu, HailinX Sent: Monday, April 28, 2025 4:08 PM To: Xueming Li ; sta...@dpdk.org Cc: dev@dpdk.org ; Abhishek Marathe ; Ali Alnubani ; David Christensen ; Hemant Agrawal ;

Re: 23.11.4 patches review and test

2025-04-28 Thread Xueming Li
Hi Ali, Thanks for your support, will collection into release notes. Regarding the gcc 15 warnning, it's a small issue, I will fix it in the next release. Best regards, Xueming From: Ali Alnubani Sent: Friday, April 25, 2025 3:30 AM To: Xueming Li ; sta...@dpdk

Re: [PATCH v3] net/ixgbe: support Rx/Tx burst mode info

2025-04-28 Thread Roger Melton (rmelton)
On 4/28/25 12:11 PM, Bruce Richardson wrote: > On Wed, Apr 16, 2025 at 01:23:11PM -0400, Roger Melton wrote: >> Return burst mode according to the selected Rx/Tx burst >> function name. >> Update 25.07 release notes with this information. >> >> Signed-off-by: Roger Melton >> --- > Generally looks

[PATCH v4] net/ixgbe: support Rx/Tx burst mode info

2025-04-28 Thread Roger Melton
Return burst mode according to the selected Rx/Tx burst function name. Update 25.07 release notes with this information. Signed-off-by: Roger Melton --- doc/guides/rel_notes/release_25_07.rst| 3 + drivers/net/intel/ixgbe/ixgbe_ethdev.c| 4 ++ drivers/net/intel/ixgbe/ixgbe_ethd

[PATCH v2] net/iavf: support Rx/Tx burst mode info

2025-04-28 Thread Roger Melton
Return burst mode according to the selected Rx/Tx burst function name. Update 25.07 release notes with this information. Signed-off-by: Roger Melton --- doc/guides/rel_notes/release_25_07.rst | 3 + drivers/net/intel/iavf/iavf.h | 2 + drivers/net/intel/iavf/iavf_ethdev.c | 2 +

Re: [PATCH] net/mlx5/hws: fix send queue drain on FW WQE destroy

2025-04-28 Thread Patrick Robb
Recheck-request: iol-intel-Performance Looks like this patch was affected by an infra failure - putting in a retest request for the CI testing system. On Sun, Apr 27, 2025 at 7:28 AM Maayan Kashani wrote: > Queue sync operation was skipped on rule destroy. > Unlike on fw wqe rule create in whic

Re: add one example of DPI ?

2025-04-28 Thread fengchengwen
On 2025/4/28 23:49, Stephen Hemminger wrote: > On Mon, 28 Apr 2025 16:20:22 +0800 > fengchengwen wrote: > >> Hi all, >> >> Currently, we supported several DPI application scenarios performance tuning, >> in these scenarios, the DPDK library ethdev, ring, mbuf and hash APIs are >> used. >> >> One

RE: 23.11.4 patches review and test

2025-04-28 Thread Xu, HailinX
> -Original Message- > From: Xueming Li > Sent: Monday, April 21, 2025 10:19 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; David Christensen > ; Hemant Agrawal ; > Ian Stokes ; Jerin Jacob ; > Mcnamara, John ; Ju-Hyoung Lee > ; Kevin Traynor ; Luca > Bocc

add one example of DPI ?

2025-04-28 Thread fengchengwen
Hi all, Currently, we supported several DPI application scenarios performance tuning, in these scenarios, the DPDK library ethdev, ring, mbuf and hash APIs are used. One of the scenarios is: - |

[PATCH v6 0/2] node: add mbuf dynamic field for nodes

2025-04-28 Thread Nitin Saxena
Currently each rte_node registers separate mbuf dynamic fields for their own purpose. This leads to wastage of mbuf space as once mbuf get passed a particular node, the registered dynamic field(by that node) is no longer used. This patch series adds a global/common mbuf dynamic field which is reus

[PATCH v6 1/2] node: add global node mbuf dynfield

2025-04-28 Thread Nitin Saxena
This patch defines rte_node specific dynamic field structure (rte_node_mbuf_dynfield_t) rte_node_mbuf_dynfield_t structure holds two types of fields - Persistent data fields which are preserved across graph walk. Currently size of persistent data fields is zero. - Overloadable data fields which

[PATCH v6 2/2] node: use node mbuf dynfield in ip4 nodes

2025-04-28 Thread Nitin Saxena
- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c |

Re: [PATCH v5 1/2] node: add global node mbuf dynfield

2025-04-28 Thread Nitin Saxena
Hi Pavan, I have incorporated your comments in patch 6 Thanks for reviewing Nitin On Sat, Apr 19, 2025 at 12:33 AM Pavan Nikhilesh Bhagavatula wrote: > > > > > -Original Message- > > From: Nitin Saxena > > Sent: Wednesday, April 9, 2025 7:26 PM > > To: Nithin Kumar Dabilpuram ; Pavan N

Virtio-PMD speed limits to 100Gbps, while hardware supports 200Gbps

2025-04-28 Thread Ayshathul Thuhara
Hi Team,  I am using virtio-net, virtio-pci  drivers for a Bittware hardware. I could see the data is sent and received with the throughput of 100Gbps. But the hardware supports for 200Gbps. I am not able to get the throughput more than 200Gbps. I am using latest DPDK source files and I teste

Re: [PATCH] net/ice: fix Rx of large packets

2025-04-28 Thread Bruce Richardson
On Fri, Apr 18, 2025 at 04:04:26AM +0100, Liao, TingtingX wrote: >> -Original Message- > >> From: Bruce Richardson > >> Sent: Tuesday, April 08, 2025 23:57 > >> To: dev@dpdk.org > >> Cc: Richardson, Bruce; sta...@dpdk.org; Burakov, Anatoly >> Subject: [PATCH] net

Re: [PATCH v1] net/idpf: avoid truncation of constant value

2025-04-28 Thread Bruce Richardson
On Fri, Apr 11, 2025 at 06:51:55AM -0700, Andre Muezerie wrote: > On Fri, Apr 11, 2025 at 08:52:12AM +0200, David Marchand wrote: > > On Wed, Apr 9, 2025 at 4:27 PM Bruce Richardson > > wrote: > > > > > > On Wed, Apr 09, 2025 at 12:54:40PM +, Praveen Shetty wrote: > > > > Truncation of constan

Re: [PATCH] net/intel: fix xstats name

2025-04-28 Thread Bruce Richardson
On Thu, Apr 10, 2025 at 01:52:46PM +0800, Kaiwen Deng wrote: > The igb and igc xstats name need to be changed correctly. > tx_size_1023_to_max_packets should be tx_size_1024_to_max_packets. > > Fixes: 38552317dcef ("igb: add extended stats") > Fixes: e6defdfddc3b ("net/igc: enable statistics") > C

[DPDK/meson Bug 1703] meson: Unsupported part number for ARM Grace during meson setup

2025-04-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1703 Bug ID: 1703 Summary: meson: Unsupported part number for ARM Grace during meson setup Product: DPDK Version: 22.11 Hardware: All OS: All Status: UNCONFI

[DPDK/meson Bug 1702] meson: Unsupported part number for ARM Grace during meson setup

2025-04-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1702 Bug ID: 1702 Summary: meson: Unsupported part number for ARM Grace during meson setup Product: DPDK Version: 23.11 Hardware: ARM OS: All Status: UNCONFI

[PATCH] Add new tracepoint function for type time_t

2025-04-28 Thread changqing.li
From: Changqing Li To support Y2038 issue, for 32bit system, -D_TIME_BITS=64 is passed to gcc, struct timespec time->tv_sec is 64bit, but size_t is 32bits, so dpdk will compile failed with error: ../git/lib/ethdev/ethdev_trace.h: In function 'rte_eth_trace_timesync_write_time': ../git/lib/eal/in

[PATCH V2] Add new tracepoint function for type time_t

2025-04-28 Thread changqing.li
From: Changqing Li To support Y2038 issue, for 32bit system, -D_TIME_BITS=64 is passed to gcc, struct timespec time->tv_sec is 64bit, but size_t is 32bits, so dpdk will compile failed with error: ../git/lib/ethdev/ethdev_trace.h: In function 'rte_eth_trace_timesync_write_time': ../git/lib/eal/in

回复:[PATCH v3 1/1] bus/pci: introduce get_iova_mode for pci dev

2025-04-28 Thread Kyo.Liu
Thank you for raising this important concern. To confirm: Our vendor driver (NBL PMD) is actively being upstreamed to DPDK. This patch is required for its coexistence implementation. We kindly request to merge this foundational change first to enable the driver submission. We will follow up with

meson error on ARM Grace server 23.11/22.11

2025-04-28 Thread Patrick Robb
Hi, At the DPDK Community Lab we have been running CI tests with a new ARM Grace server for the past couple of months on main and next-* branches. I am trying to add LTS runs now, and ran into a snag with 23.11 and 22.11 for this system. Stable maintainers I'm not sure whether this should be addre

Re: [PATCH] net/e1000: fix eeprom dump failure

2025-04-28 Thread Bruce Richardson
On Tue, Apr 15, 2025 at 03:48:02PM +0800, Yuan Wang wrote: > There is a incorrect comparison in get_eeprom that cause epprom dump fail. > This patch fixes this issue. > > Fixes: 83c314da4c38 (igb: add access to specific device info) > Cc: sta...@dpdk.org > > Signed-off-by: Yuan Wang > --- > dri

Re: [PATCH v3] net/ixgbe: support Rx/Tx burst mode info

2025-04-28 Thread Bruce Richardson
On Wed, Apr 16, 2025 at 01:23:11PM -0400, Roger Melton wrote: > Return burst mode according to the selected Rx/Tx burst > function name. > Update 25.07 release notes with this information. > > Signed-off-by: Roger Melton > --- Generally looks good. Couple of nits/suggestions inline below. If you