On Tue, Apr 15, 2025 at 03:48:02PM +0800, Yuan Wang wrote: > There is a incorrect comparison in get_eeprom that cause epprom dump fail. > This patch fixes this issue. > > Fixes: 83c314da4c38 (igb: add access to specific device info) > Cc: sta...@dpdk.org > > Signed-off-by: Yuan Wang <yuanx.w...@intel.com> > --- > drivers/net/intel/e1000/igb_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/intel/e1000/igb_ethdev.c > b/drivers/net/intel/e1000/igb_ethdev.c > index cbd2f15f5f..738c0ef895 100644 > --- a/drivers/net/intel/e1000/igb_ethdev.c > +++ b/drivers/net/intel/e1000/igb_ethdev.c > @@ -5219,7 +5219,7 @@ eth_igb_get_eeprom(struct rte_eth_dev *dev, > first = in_eeprom->offset >> 1; > length = in_eeprom->length >> 1; > if ((first >= hw->nvm.word_size) || > - ((first + length) >= hw->nvm.word_size)) > + ((first + length) > hw->nvm.word_size)) > return -EINVAL; >
Fix makes sense. Acked-by: Bruce Richardson <bruce.richard...@intel.com> Applied to dpdk-next-net-intel Thanks, /Bruce
