[PATCH 1/2] net/txgbe: add support for Wangxun new NIC Amber-Lite 25g/40g

2025-04-18 Thread Zaiyu Wang
Amber-Lite is a new model of network interface card launched by Wangxun. It comes in two types: one supports 10g/25g rates, and the other supports 10g/40g rates. Signed-off-by: Zaiyu Wang --- drivers/net/txgbe/base/txgbe_devids.h | 9 +++ drivers/net/txgbe/base/txgbe_hw.c | 17 +

[PATCH 0/2] *** Wangxun new NIC support ***

2025-04-18 Thread Zaiyu Wang
We have released a new NIC series: Amber-Lite, with two models supporting 10G/25G and 10G/40G rates. Due to minimal hardware differences from existing 10G NICs, it remains supported within the txgbe driver. Zaiyu Wang (2): net/txgbe: add support for Wangxun new NIC Amber-Lite 25g/40g net/txgb

[RFC 05/18] net/hinic3: add NIC event module

2025-04-18 Thread Feifei Wang
From: Xin Wang Currently, there are two types of events: pf/vf connection status and port information printing. This patch contains related data structures and function codes. Signed-off-by: Xin Wang Reviewed-by: Yi Chen Reviewed-by: Feifei Wang --- drivers/net/hinic3/base/hinic3_nic_event.c

[RFC 07/18] net/hinic3: add mgmt module function code

2025-04-18 Thread Feifei Wang
From: Yi Chen Mgmt module is a kind of administration module for the chip. It is responsible for handling administration command from host. It mainly uses aeq to implement. This patch adds related data structures, packaged interfaces and function codes. Signed-off-by: Yi Chen Reviewed-by: Xin W

[RFC 09/18] net/hinic3: add a NIC business configuration module

2025-04-18 Thread Feifei Wang
From: Yi Chen The items of configurations and queries for NIC business include MAC, VLAN, MTU, RSS and so on. These configurations and queries are handled by mgmt module. This patch introduces related data structures and function codes. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by:

[RFC 15/18] net/hinic3: add MML and EEPROM access feature

2025-04-18 Thread Feifei Wang
From: Xin Wang Add man-machine language support and implements the get eeprom method. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c| 13 + drivers/net/hinic3/mml/hinic3_dbg.c | 171 + drivers/net/hinic3/mml/hin

[RFC 11/18] net/hinic3: add a mailbox communication module

2025-04-18 Thread Feifei Wang
From: Yi Chen This patch adds support for mailbox of hinic3 PMD driver, mailbox is used for communication between PF/VF driver and MPU. This patch provides mailbox-related data structures and functional code. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/n

Re: [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

2025-04-18 Thread Van Haaren, Harry
> From: Etelson, Gregory > Sent: Thursday, April 17, 2025 7:58 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; getel...@nvidia.com; Richardson, Bruce; owen.hily...@unh.edu > Subject: Re: [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq > > Hello Harry, > > Thank you for sharing the API

[PATCH] net/ixgbe: fix port mask default value in flow director

2025-04-18 Thread Yuan Wang
The fdir filter should mask L4 protocol in order to process raw IP packets. However, the initial value of port mask is 0xFF and the filter will not process raw IP packets if the flow rule does not change it. Fixed by setting the default value to 0. Fixes: 444505f933f1 (net/ixgbe: fix IPv6 mask in

Re: [PATCH 02/46] common/sfc_efx/base: add efsys option for Medford4

2025-04-18 Thread Andrew Rybchenko
On 4/17/25 18:07, Stephen Hemminger wrote: On Thu, 17 Apr 2025 10:08:20 +0300 Andrew Rybchenko wrote: #if EFSYS_OPT_ALLOW_UNCONFIGURED_NIC /* Support adapters with missing static config (for factory use only) */ -# if !(EFSYS_OPT_RIVERHEAD || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2) -#

[RFC 17/18] net/hinic3: add FDIR flow control module

2025-04-18 Thread Feifei Wang
From: Yi Chen Added support for flow director filters, including ethertype, IPv4, IPv6, and tunnel VXLAN. In addition, user can add or delete filters. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/net/hinic3/hinic3_ethdev.c | 82 ++ drivers/net/hinic3/hi

[PATCH 2/2] net/xsc: optimize release path

2025-04-18 Thread Renyong Wan
Optimized the code of release path to prevent potential resource leaks. Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_dev.c| 5 - drivers/net/xsc/xsc_ethdev.c | 12 ++-- drivers/net/xsc/xsc_np.c | 1 + drivers/net/xsc/xsc_vfio.c | 1 + 4 fi

[PATCH 1/2] net/xsc: fix resource leaks

2025-04-18 Thread Renyong Wan
Fixed the Coverity-detected issue that resource leaks. Coverity issue: 457741 Fixes: 3d57851720d4 ("net/xsc: check null pointer dereference") Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_rx.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-)

[PATCH 0/2] Optimize the code to void resource leaks

2025-04-18 Thread Renyong Wan
This patchset focuses on optimizing the code to avoid resource leaks. Renyong Wan (2): net/xsc: fix resource leaks net/xsc: optimize release path drivers/net/xsc/xsc_dev.c| 5 - drivers/net/xsc/xsc_ethdev.c | 12 ++-- drivers/net/xsc/xsc_np.c | 1 + drivers/net/xsc/xsc_

RE: [PATCH] net/ixgbe: fix port mask default value in flow director

2025-04-18 Thread Xu, HailinX
> -Original Message- > From: Yuan Wang > Sent: Friday, April 18, 2025 3:43 PM > To: Burakov, Anatoly ; Medvedkin, Vladimir > ; dev@dpdk.org > Cc: Wang, YuanX ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix port mask default value in flow director > > The fdir filter should mask L4 pro

[PATCH 2/3] rust: split main into example, refactor to lib.rs

2025-04-18 Thread Harry van Haaren
Signed-off-by: Harry van Haaren --- rust_api_example/examples/eth_poll.rs| 35 +++ rust_api_example/src/{main.rs => lib.rs} | 43 2 files changed, 35 insertions(+), 43 deletions(-) create mode 100644 rust_api_example/examples/eth_poll.rs rename rust_

[PATCH v4 4/4] drivers: use macro to embed information in binaries

2025-04-18 Thread Andre Muezerie
DPDK uses GCC attribute "used" through macro __rte_used to indicate that a variable not referenced in the code should be assumed being used and therefore not be optimized away. This technique is used to embed information in the binaries, by having crafted information stored in them. MSVC offers si

Re: [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

2025-04-18 Thread Etelson, Gregory
Hello Harry, Thank you for sharing the API. Please check out my comments below. Regards, Gregory On Thu, 17 Apr 2025, Harry van Haaren wrote: External email: Use caution opening links or attachments This patch is NOT to be considered for merge, it is a demo of the Rust APIs for Ethdev. Ther

[patch v6 2/6] net/netvsc: introduce get_vmbus_device to get the vmbus device

2025-04-18 Thread longli
From: Long Li Introduce a function get the vmbus device from hn_data. For secondary process, the vmbus device is in eth_dev's private region. Signed-off-by: Long Li --- drivers/net/netvsc/hn_nvs.c | 15 +++ drivers/net/netvsc/hn_nvs.h | 2 ++ 2 files changed, 17 insertions(+) dif

RE: [EXTERNAL] Re: [PATCH v1 04/12] node: add process callback for IP4 FIB

2025-04-18 Thread Ankur Dwivedi
Hi Vladimir, >> diff --git a/lib/node/ip4_lookup_fib.c b/lib/node/ip4_lookup_fib.c >> index e87864e672..c535b191f8 100644 >> --- a/lib/node/ip4_lookup_fib.c >> +++ b/lib/node/ip4_lookup_fib.c >> @@ -40,6 +40,169 @@ static struct ip4_lookup_fib_node_main >ip4_lookup_fib_nm; >> #define IP4_LOOKUP_

[RFC 00/18] add hinic3 PMD driver

2025-04-18 Thread Feifei Wang
*** BLURB HERE *** The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. Feifei Wang (3): net/hinic3: add intro doc for hinic3 net/hinic3: add dev ops net/hinic3: add Rx/Tx functions Xin Wang (7): net/hinic3

[RFC 03/18] net/hinic3: add hardware interfaces of BAR operation

2025-04-18 Thread Feifei Wang
From: Yi Chen This patch adds some HW interfaces for bar operatioin interfaces, including: mapped bar address geeting, HW attributes getting, msi-x reg operation, function type getting and so on. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/net/hinic3/bas

[RFC 02/18] net/hinic3: add basic header files

2025-04-18 Thread Feifei Wang
From: Xin Wang Add HW registers definition header file for SP series NIC. Add some headers that define commands and basic defines for use in the code. Signed-off-by: Xin Wang Reviewed-by: Yi Chen Reviewed-by: Feifei Wang --- drivers/net/hinic3/base/hinic3_cmd.h| 231

[RFC 08/18] net/hinic3: add module about hardware operation

2025-04-18 Thread Feifei Wang
From: Yi Chen Add code and data structure for hardware operation, including configuration, query, initialization and release. Signed-off-by: Yi Chen Signed-off-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/net/hinic3/base/hinic3_hw_cfg.c | 240 ++ drivers/net/hinic3/base/hinic3_

[RFC 04/18] net/hinic3: add support for cmdq mechanism

2025-04-18 Thread Feifei Wang
From: Xin Wang Micocode is named ucode in SP series NIC. Its main responsibility is data transmission and reception. But it can also handle some administration works. It uses cmdq mechanism. This patch introduces data structures, initialization, interfaces, and commands sending functions of cmdq.

[RFC 06/18] net/hinic3: add eq mechanism function code

2025-04-18 Thread Feifei Wang
From: Yi Chen Eqs include aeq and ceq. Aeq is a kind of queue for mgmt asynchronous message and mgmt command response message. This patch introduces data structures, initialization, and related interfaces about aeq. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- dr

[RFC 01/18] net/hinic3: add intro doc for hinic3

2025-04-18 Thread Feifei Wang
From: Feifei Wang This patch adds some basic files to describe the hinic3 driver. Signed-off-by: Feifei Wang Signed-off-by: Yi Chen Reviewed-by: Xin Wang --- .mailmap | 4 +- MAINTAINERS| 6 +++ doc/guides/nics/hinic3.rst

[RFC 14/18] net/hinic3: add Rx/Tx functions

2025-04-18 Thread Feifei Wang
From: Feifei Wang This patch add package sending and receiving function codes. Signed-off-by: Feifei Wang Signed-off-by: Yi Chen Reviewed-by: Xin Wang --- drivers/net/hinic3/hinic3_ethdev.c | 9 +- drivers/net/hinic3/hinic3_rx.c | 301 +++- drivers/net/hinic3/hinic3_tx.c |

[RFC 16/18] net/hinic3: add RSS promiscuous ops

2025-04-18 Thread Feifei Wang
From: Xin Wang Add RSS and promiscuous ops related function codes. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c | 370 + drivers/net/hinic3/hinic3_ethdev.h | 31 +++ 2 files changed, 401 insertions(+

[RFC 12/18] net/hinic3: add device initailization

2025-04-18 Thread Feifei Wang
From: Xin Wang This patch contains data structures and function codes related to device initialization. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c | 514 + drivers/net/hinic3/hinic3_ethdev.h | 119 +

[RFC 10/18] net/hinic3: add context and work queue support

2025-04-18 Thread Feifei Wang
From: Xin Wang Work queue is used for cmdq and tx/rx buff description. Nic business needs to configure cmdq context and txq/rxq context. This patch adds data structures and function codes for work queue and context. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- dr

[RFC 18/18] drivers/net: add hinic3 PMD build and doc files

2025-04-18 Thread Feifei Wang
From: Yi Chen The meson.build file is added to this patch to enable the hinic3 compilation function. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- doc/guides/nics/features/hinic3.ini | 9 ++ drivers/net/hinic3/base/meson.build | 50 +++

[PATCH 1/3] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

2025-04-18 Thread Harry van Haaren
This patch is NOT to be considered for merge, it is a demo of the Rust APIs for Ethdev. There is no actual implementation of the APIs against the DPDK C functions, this is Rust API only. To test/run the code (and uncomment things to see errors) just apply this patch, cd "rust_api_example" and run

[PATCH 3/3] rust: showcase port Rxq return for stop() and reconfigure

2025-04-18 Thread Harry van Haaren
Since the refactor, use this command to run/test: cargo r --example eth_poll Signed-off-by: Harry van Haaren --- rust_api_example/examples/eth_poll.rs | 45 --- rust_api_example/src/lib.rs | 52 --- 2 files changed, 88 insertions(+), 9 dele

回复: [RFC 00/18] add hinic3 PMD driver

2025-04-18 Thread wangfeifei (J)
-邮件原件- 发件人: Stephen Hemminger 发送时间: 2025年4月19日 2:19 收件人: Feifei Wang 抄送: dev@dpdk.org 主题: Re: [RFC 00/18] add hinic3 PMD driver On Fri, 18 Apr 2025 17:05:46 +0800 Feifei Wang wrote: > *** BLURB HERE *** > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver > support fo

回复: [RFC 18/18] drivers/net: add hinic3 PMD build and doc files

2025-04-18 Thread wangfeifei (J)
-邮件原件- 发件人: Stephen Hemminger 发送时间: 2025年4月19日 1:23 收件人: Feifei Wang 抄送: dev@dpdk.org; chenyi (CY) ; Wangxin(kunpeng) ; wangfeifei (J) 主题: Re: [RFC 18/18] drivers/net: add hinic3 PMD build and doc files On Fri, 18 Apr 2025 17:06:04 +0800 Feifei Wang wrote: > +cflags += [ > +'-

回复: [RFC 00/18] add hinic3 PMD driver

2025-04-18 Thread wangfeifei (J)
-邮件原件- 发件人: Stephen Hemminger 发送时间: 2025年4月19日 2:32 收件人: Feifei Wang 抄送: dev@dpdk.org 主题: Re: [RFC 00/18] add hinic3 PMD driver On Fri, 18 Apr 2025 17:05:46 +0800 Feifei Wang wrote: > *** BLURB HERE *** > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver > support fo

Re: [PATCH 3/3] app/testpmd: add a command to show VLAN filter IDs

2025-04-18 Thread Stephen Hemminger
On Fri, 11 Apr 2025 16:10:05 +0800 Chaoyong He wrote: > +static void > +rx_vft_dump_printf(int left, int right, int *c_count) > +{ > + if (left == right) > + *c_count += printf("%d,", left); > + else > + *c_count += printf("%d-%d,", left, right); > + > + if (*c

Re: [PATCH 2/3] ethdev: retrieve VLAN filter configuration

2025-04-18 Thread Stephen Hemminger
On Fri, 11 Apr 2025 16:10:04 +0800 Chaoyong He wrote: > > +RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_eth_dev_get_vlan_filter_conf, 25.07) > +int > +rte_eth_dev_get_vlan_filter_conf(uint16_t port_id, > + struct rte_vlan_filter_conf *vf_conf) > +{ > + struct rte_eth_dev *dev; > + > +

RE: [PATCH v5 1/2] node: add global node mbuf dynfield

2025-04-18 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Nitin Saxena > Sent: Wednesday, April 9, 2025 7:26 PM > To: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagavatula ; Robin Jarry > ; Christophe Fontaine > Cc: dev@dpdk.org; Jerin Jacob ; Nitin Saxena > > Subject: [PATCH v5 1/2] node: add global node mbuf

Re: [RFC 00/18] add hinic3 PMD driver

2025-04-18 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:05:46 +0800 Feifei Wang wrote: > *** BLURB HERE *** > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support > for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. You are supposed to remove the "*** BLURB HERE ***" when editing the commit mess

Re: [PATCH] net/ixgbe: fix port mask default value in flow director

2025-04-18 Thread Stephen Hemminger
On Fri, 18 Apr 2025 15:43:09 +0800 Yuan Wang wrote: > The fdir filter should mask L4 protocol in order to process raw IP packets. > However, the initial value of port mask is 0xFF and the filter will not > process raw IP packets if the flow rule does not change it. > > Fixed by setting the defau

Re: [RFC 00/18] add hinic3 PMD driver

2025-04-18 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:05:46 +0800 Feifei Wang wrote: > *** BLURB HERE *** > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support > for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. > > Feifei Wang (3): > net/hinic3: add intro doc for hinic3 > net/hinic3: add

Re: [RFC 17/18] net/hinic3: add FDIR flow control module

2025-04-18 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:06:03 +0800 Feifei Wang wrote: > From: Yi Chen > > Added support for flow director filters, including ethertype, IPv4, > IPv6, and tunnel VXLAN. In addition, user can add or delete filters. > > Signed-off-by: Yi Chen > Reviewed-by: Xin Wang > Reviewed-by: Feifei Wang

Re: [RFC 17/18] net/hinic3: add FDIR flow control module

2025-04-18 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:06:03 +0800 Feifei Wang wrote: > + /* Alloc TCAM filter memory. */ > + tcam_filter = rte_zmalloc("hinic3_fdir_filter", > + sizeof(struct hinic3_tcam_filter), 0); > + if (tcam_filter == NULL) > + return -ENOMEM; > + (

Re: [RFC 17/18] net/hinic3: add FDIR flow control module

2025-04-18 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:06:03 +0800 Feifei Wang wrote: > + u8 pause_set; /**< Flag of PAUSE frame setting. */ > + pthread_mutex_t pause_mutuex; > + struct nic_pause_config nic_pause; > + Please don't use pthread functions unless there is a special reason to do so. Why not a simple spi

Re: [RFC 17/18] net/hinic3: add FDIR flow control module

2025-04-18 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:06:03 +0800 Feifei Wang wrote: > + (void)hinic3_mutex_unlock(&nic_dev->pause_mutuex); Please don't add extra (void) here. That is an older style used when C code was using lint. And if you have an internal mutex_unlock function why is it returning a value anyway. Shou

Re: [RFC 00/18] add hinic3 PMD driver

2025-04-18 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:05:46 +0800 Feifei Wang wrote: > *** BLURB HERE *** > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support > for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. > > Feifei Wang (3): > net/hinic3: add intro doc for hinic3 > net/hinic3: add

[patch v6 4/6] bus/vmbus: support channels without monitoring enabled

2025-04-18 Thread longli
From: Long Li Hyperv host may offer channels without monitor enabled. The max monitor ID it supports is 128. Over those channels without monitor enabled, Hyperv does not send or receive large amount of data traffic and almost all the data traffic is going over the VF. Change the code to not fail

[PATCH 1/4] bus/vmbus: Align ring buffer data region to system page boundary

2025-04-18 Thread longli
From: Long Li The ring buffer data region always starts at the system page boundary after ring buffer head. The current code assumes the system page size is 4k. This is not always correct. Fix this by using system page size for addressing ring buffer data. Fixes: 831dba47bd ("bus/vmbus: add Hyp

[PATCH 0/4] Fix incorrect page size and address caclulations on systems with 64k (or other) page sizes

2025-04-18 Thread longli
From: Long Li The Hyper-V uses 4k page size regardless of system page size. This patchset fixes issues while running on systems with page sizes other than 4k. Long Li (4): bus/vmbus: Align ring buffer data region to system page boundary bus/vmbus: Define Hyper-V page size bus/vmbus: Use

[PATCH 4/4] net/netvsc: Use Hyper-V page size for the driver

2025-04-18 Thread longli
From: Long Li The driver should always use Hyper-V page size for implementing RNDIS and calculating PFN (Page Frame Number) for communicating with Hyper-V VSP. It should not use system page size as it may be different to the Hyper-V page size. Fixes: 4e9c73e96e ("net/netvsc: add Hyper-V network

[PATCH 3/4] bus/vmbus: Use Hyper-V page size for mapping to UIO pages

2025-04-18 Thread longli
From: Long Li The interrupt and monitor pages mapped from Hyper-V via kernel are always 4k in sizes. Use Hyper-V page size to map them. Fixes: 831dba47bd ("bus/vmbus: add Hyper-V virtual bus support") Cc: sta...@dpdk.org Signed-off-by: Long Li --- drivers/bus/vmbus/linux/vmbus_uio.c | 2 +- d

[PATCH 2/4] bus/vmbus: Define Hyper-V page size

2025-04-18 Thread longli
From: Long Li Hyper-V uses 4k page size, regardless of the system page size used. Define Hyper-V page size for use in drivers. Fixes: 831dba47bd ("bus/vmbus: add Hyper-V virtual bus support") Cc: sta...@dpdk.org Signed-off-by: Long Li --- drivers/bus/vmbus/bus_vmbus_driver.h | 4 1 file c