On Thu, Mar 27, 2025 at 3:52 PM Bruce Richardson
wrote:
>
> Simplify the build of the various intel base code directories, by
> clearing compiler warnings so the files can be compiled directly along
> with the regular driver files.
>
> v3: add fix for lock checker issues on FreeBSD
> v2: added mis
On Thu, Mar 27, 2025 at 3:53 PM Bruce Richardson
wrote:
>
> When building on FreeBSD, errors are reported in the base code by the
> lock checker (-Wthread-safety). For example:
>
> ../drivers/net/intel/ixgbe/base/ixgbe_osdep.c:42:1: error: mutex
> 'lock->mutex' is still held at the end of functio
The definition of IXGBE_LE32_TO_CPUS macro is meant to modify the value
in place - similar to the le32_to_cpus() macro in kernel. Fixing the
definition allows us to remove some warning flags, and removes the need
for the uintptr_t typecasts.
Fixes: aa4fc14d2cee ("ixgbe: update base driver")
Cc: st
Streamline code for AVX512 and SSE by consolidating the common code and
adding runtime check for selecting appropriate path based on CPU
capability.
Signed-off-by: Tirthendu Sarkar
---
v2:
- Addressed review comments [Bruce Richardson]
drivers/event/dlb2/dlb2.c| 199 +++
Hi all,
Here is a list of patches targeted for stable release 24.11.2.
The planned date for the final release is 14 April.
Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations
add support rss reta updata/query rss hash update/get
dev_configure add rss conf check.
Signed-off-by: Wenbo Cao
---
doc/guides/nics/features/rnp.ini| 4 +
doc/guides/nics/rnp.rst | 7 +
drivers/net/rnp/base/rnp_eth_regs.h | 16 ++
drivers/net/rnp/meson.build | 1 +
On Fri, Mar 28, 2025 at 09:20:16AM +0100, David Marchand wrote:
> On Thu, Mar 27, 2025 at 3:53 PM Bruce Richardson
> wrote:
> >
> > When building on FreeBSD, errors are reported in the base code by the
> > lock checker (-Wthread-safety). For example:
> >
> > ../drivers/net/intel/ixgbe/base/ixgbe_o
So far, each DPDK library (or driver) exposing symbols in an ABI had to
maintain a version.map and use some macros for symbol versioning,
specially crafted with the GNU linker in mind.
This series proposes to rework the whole principle, and instead rely on
marking the symbol exports in the source
Declaring inline helpers in version.map is unnecessary.
There is no exported symbol and this will probably be treated as an
error by MSVC linker.
eal_log_journal has no implementation and can be removed.
Signed-off-by: David Marchand
---
lib/eventdev/version.map | 12
lib/graph/ver
Declaring inline helpers in version.map is unnecessary.
There is no exported symbol and this will probably be treated as an
error by MSVC linker.
rte_dpaa2_dev_type is an enum token.
roc_se_ctx_swap has no implementation (leftover from a previous rework)
and can be removed.
Signed-off-by: David M
Display the version when a symbol was introduced.
This is needed for scripting the conversion from static to dynamically
generated version maps.
It is also useful when listing experimental symbols.
Signed-off-by: David Marchand
---
buildtools/map-list-symbol.sh | 2 +-
1 file changed, 1 insertio
For versioning symbols:
- MSVC uses pragmas on the symbol,
- GNU linker uses special asm directives,
To accommodate both GNU linker and MSVC linker, introduce new macros for
exporting and versioning symbols that will surround the whole function.
This has the advantage of hiding all the ugly detai
Rather than maintain a file in parallel of the code, symbols to be
exported can be marked with a token RTE_EXPORT_*SYMBOL.
>From those marks, the build framework generates map files only for
symbols actually compiled (which means that the WINDOWS_NO_EXPORT hack
becomes unnecessary).
The build fra
On Fri, Mar 28, 2025 at 10:43:48AM +, Bruce Richardson wrote:
> On Fri, Mar 28, 2025 at 09:20:16AM +0100, David Marchand wrote:
> > On Thu, Mar 27, 2025 at 3:53 PM Bruce Richardson
> > wrote:
> > >
> > > When building on FreeBSD, errors are reported in the base code by the
> > > lock checker (
Now that base-code warning flags have been removed from a number of
drivers, we can simplify their build configuration by just including the
base code files in the regular list of driver files passed back. There
is no need to use pre-compiled objects.
Signed-off-by: Bruce Richardson
---
drivers/
The fixes required to re-enable warnings in the fm10k base code are
trivial, so let's make the changes and get a clean compile without any
warning disable flags.
* provide definitions for the UNREFERENCED_PARAMETER macros
* fix the spelling of the work "fallthrough" in comments
* provide a definit
Improve base code macros to reduce the number of issues with unused
variables in the code. Issues still remain with unused-but-set
variables, but completely unused variable warnings are eliminated.
Signed-off-by: Bruce Richardson
---
drivers/net/intel/ice/base/ice_osdep.h | 6 +++---
drivers/ne
We can remove almost all of the "unused parameter" and "unused variable"
warnings by just improving the macro definitions in the osdep.h header.
Remaining two instances can be fixed by just one-line additions to the
code, so add those to give us a clean build with the warnings enabled.
Fixes: af75
When building on FreeBSD, errors are reported in the base code by the
lock checker (-Wthread-safety). For example:
../drivers/net/intel/ixgbe/base/ixgbe_osdep.c:42:1: error: mutex 'lock->mutex'
is still held at the end of function [-Werror,-Wthread-safety-analysis]
42 | }
| ^
These erro
Add a single-line fix to the base code, and then the remaining two
compiler warning disable flags can be removed from the driver base code
build file.
Fixes: 8db9e2a1b232 ("i40e: base driver")
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
drivers/net/intel/i40e/base/i40e_diag.c | 2 +
Simplify the build of the various intel base code directories, by
clearing compiler warnings so the files can be compiled directly along
with the regular driver files.
v4: replace all functions in ixgbe_osdep.c with macros, removing file.
v3: add fix for lock checker issues on FreeBSD
v2: added mi
On Fri, Mar 28, 2025 at 09:21:03AM +0100, David Marchand wrote:
> On Thu, Mar 27, 2025 at 3:52 PM Bruce Richardson
> wrote:
> >
> > Simplify the build of the various intel base code directories, by
> > clearing compiler warnings so the files can be compiled directly along
> > with the regular driv
On Fri, Mar 28, 2025 at 11:44 AM Bruce Richardson
wrote:
>
> On Fri, Mar 28, 2025 at 09:20:16AM +0100, David Marchand wrote:
> > On Thu, Mar 27, 2025 at 3:53 PM Bruce Richardson
> > wrote:
> > >
> > > When building on FreeBSD, errors are reported in the base code by the
> > > lock checker (-Wthre
On 3/28/2025 12:16 PM, Bruce Richardson wrote:
Improve base code macros to reduce the number of issues with unused
variables in the code. Issues still remain with unused-but-set
variables, but completely unused variable warnings are eliminated.
Signed-off-by: Bruce Richardson
---
Acked-by: Ana
On 3/28/2025 12:16 PM, Bruce Richardson wrote:
Now that base-code warning flags have been removed from a number of
drivers, we can simplify their build configuration by just including the
base code files in the regular list of driver files passed back. There
is no need to use pre-compiled objects
On Thu, Mar 27, 2025 at 09:34:35PM +0530, Shaiq Wani wrote:
> Merge in additional fields used by the idpf driver and then convert it
> over to using the common Tx queue structure
>
> Signed-off-by: Shaiq Wani
Acked-by: Bruce Richardson
Some comments inline below.
> ---
> drivers/net/intel/co
On Thu, Mar 27, 2025 at 09:34:37PM +0530, Shaiq Wani wrote:
> Switch the idpf driver to use the common Tx free function for
> AVX2 and AVX512
>
> Signed-off-by: Shaiq Wani
> ---
> .../net/intel/idpf/idpf_common_rxtx_avx2.c| 68 +
> .../net/intel/idpf/idpf_common_rxtx_avx512.c | 237 +--
The meson.build file in the base folder was never used, as the base
files were just included in the main sources list for iavf.
Fixes: f1fdc9ddba5e ("drivers: move iavf common folder to iavf net")
Signed-off-by: Bruce Richardson
---
drivers/net/intel/iavf/base/meson.build | 10 --
1 fil
Hi Stephen,
I wanted to extend my sincere thanks for your tremendous help and valuable
advice during patch submit.
The next submit will be soon. Thank for your patience and understanding.
Regards Wenbo
> -Original Message-
> From: Stephen Hemminger
> Sent: 2025年3月28日 1:29
> To: Wenbo Ca
Hello Bruce,
When using bindgen, are we better to take the approach (as in this patch)
of running it on everything in the headers and just excluding some things,
or taking the opposite conservative approach of just listing the functions
and defines we actually do want exposed (with wildcarding
On Thu, Mar 27, 2025 at 09:34:35PM +0530, Shaiq Wani wrote:
> Merge in additional fields used by the idpf driver and then convert it
> over to using the common Tx queue structure
>
> Signed-off-by: Shaiq Wani
> ---
> drivers/net/intel/common/tx.h | 20 +++
> drivers/net/intel
On 3/28/2025 12:16 PM, Bruce Richardson wrote:
We can remove almost all of the "unused parameter" and "unused variable"
warnings by just improving the macro definitions in the osdep.h header.
Remaining two instances can be fixed by just one-line additions to the
code, so add those to give us a cl
On Thu, Mar 27, 2025 at 09:34:36PM +0530, Shaiq Wani wrote:
> Used the common Tx entry structure and common Tx mbuf ring replenish fn
> in place of idpf-specific structure and function.
> The vector driver code paths (AVX2, AVX512) use the smaller SW
> ring structure.
>
> Signed-off-by: Shaiq Wani
On 3/28/2025 12:16 PM, Bruce Richardson wrote:
Add a single-line fix to the base code, and then the remaining two
compiler warning disable flags can be removed from the driver base code
build file.
Fixes: 8db9e2a1b232 ("i40e: base driver")
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
--
On 3/28/2025 12:16 PM, Bruce Richardson wrote:
Fix warnings about unused values - parameters, variables, etc., and
remove the warning disable flags for them. Although modifying the
base-code files is not ideal, the changes required are minor, and only
affect two files from the imported base code.
On 3/28/2025 12:16 PM, Bruce Richardson wrote:
The fixes required to re-enable warnings in the fm10k base code are
trivial, so let's make the changes and get a clean compile without any
warning disable flags.
* provide definitions for the UNREFERENCED_PARAMETER macros
* fix the spelling of the w
On Thu, Mar 27, 2025 at 09:34:33PM +0530, Shaiq Wani wrote:
> reworked the drivers to use the common functions
> and structures from drivers/net/intel/common.
>
> Shaiq Wani (4):
> net/intel: align Tx queue struct field names
> net/intel: use common Tx queue structure
> net/intel: use common
Hello Morten,
Thank you for raising these questions !
Do we want the DPDK project itself to support rust?
Or should parts of this be a DPDK hosted project, like grout?
Rust packages management is different.
Also DPDK Rust code will eventually provide a different API.
At this stage, DPDK host
On Thu, Mar 27, 2025 at 03:12:17PM +, Anatoly Burakov wrote:
> In a couple of places, we are using explicit mac type comparisons to
> trigger a VF-specific path, but we already have a function that does the
> same thing, so use it.
>
> Signed-off-by: Anatoly Burakov
> ---
Series-acked-by: Br
On 3/28/2025 12:16 PM, Bruce Richardson wrote:
The definition of IXGBE_LE32_TO_CPUS macro is meant to modify the value
in place - similar to the le32_to_cpus() macro in kernel. Fixing the
definition allows us to remove some warning flags, and removes the need
for the uintptr_t typecasts.
Fixes:
On Thu, Mar 27, 2025 at 09:34:33PM +0530, Shaiq Wani wrote:
> reworked the drivers to use the common functions
> and structures from drivers/net/intel/common.
>
> Shaiq Wani (4):
> net/intel: align Tx queue struct field names
> net/intel: use common Tx queue structure
> net/intel: use common
On Fri, Mar 28, 2025 at 02:07:23PM +0100, Burakov, Anatoly wrote:
> On 3/28/2025 12:16 PM, Bruce Richardson wrote:
> >Fix warnings about unused values - parameters, variables, etc., and
> >remove the warning disable flags for them. Although modifying the
> >base-code files is not ideal, the changes
On Fri, Mar 28, 2025 at 08:21:44AM -0700, Andre Muezerie wrote:
> On Fri, Mar 28, 2025 at 02:07:23PM +0100, Burakov, Anatoly wrote:
> > On 3/28/2025 12:16 PM, Bruce Richardson wrote:
> > >Fix warnings about unused values - parameters, variables, etc., and
> > >remove the warning disable flags for t
On Fri, Mar 28, 2025 at 4:30 PM Bruce Richardson
wrote:
>
> On Thu, Mar 27, 2025 at 09:34:33PM +0530, Shaiq Wani wrote:
> > reworked the drivers to use the common functions
> > and structures from drivers/net/intel/common.
> >
> > Shaiq Wani (4):
> > net/intel: align Tx queue struct field names
David Marchand writes:
> Switch to dynamically generated version maps.
>
> As the map files get generated, tooling around checking, converting,
> updating etc.. static version maps can be removed.
>
> Signed-off-by: David Marchand
> ---
Ugh. replied to the wrong one. Anyway, my previous note s
Acked-by: Vladimir Medvedkin
On 21/03/2025 17:12, Bruce Richardson wrote:
A number of places in the ixgbe code check for a virtual function, but
these checks were missing the identifier for the E610 VF. Add them into
the conditionals.
Fixes: f678f3dea8fd ("net/ixgbe: fix missing VF PCI ID")
Cc
On Mon, Mar 10, 2025 at 04:18:35PM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Monday, 10 March 2025 14.26
> >
> > When freeing transmitted mbufs, there is no reason to send the freed
> > mbufs directly to the ring if the cache is empty - on
On 3/28/2025 12:16 PM, Bruce Richardson wrote:
The meson.build file in the base folder was never used, as the base
files were just included in the main sources list for iavf.
Fixes: f1fdc9ddba5e ("drivers: move iavf common folder to iavf net")
Signed-off-by: Bruce Richardson
---
Acked-by: Ana
David Marchand writes:
> Switch to dynamically generated version maps.
>
> As the map files get generated, tooling around checking, converting,
> updating etc.. static version maps can be removed.
>
> Signed-off-by: David Marchand
> ---
Just a minor (non-blocking) nit below.
Otherwise,
Acked-b
On 3/28/2025 12:16 PM, Bruce Richardson wrote:
When building on FreeBSD, errors are reported in the base code by the
lock checker (-Wthread-safety). For example:
../drivers/net/intel/ixgbe/base/ixgbe_osdep.c:42:1: error: mutex 'lock->mutex'
is still held at the end of function [-Werror,-Wthread
Fix warnings about unused values - parameters, variables, etc., and
remove the warning disable flags for them. Although modifying the
base-code files is not ideal, the changes required are minor, and only
affect two files from the imported base code.
Fixes: 8db9e2a1b232 ("i40e: base driver")
Cc: s
51 matches
Mail list logo
