On Fri, Mar 28, 2025 at 09:21:03AM +0100, David Marchand wrote: > On Thu, Mar 27, 2025 at 3:52 PM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > > Simplify the build of the various intel base code directories, by > > clearing compiler warnings so the files can be compiled directly along > > with the regular driver files. > > > > v3: add fix for lock checker issues on FreeBSD v2: added missing patch > > for fm10k > > > > Bruce Richardson (9): net/fm10k/base: fix compilation warnings > > net/iavf/base: remove unused meson.build file net/ixgbe/base: correct > > definition of macro net/ixgbe/base: fix compilation warnings > > net/ixgbe/base: fix lock checker errors net/i40e/base: fix unused value > > warnings net/i40e/base: fix compiler warnings net/ice/base: reduce > > warnings for unused variables net/intel: simplify base code builds > > > > drivers/net/intel/e1000/base/meson.build | 9 ++----- > > drivers/net/intel/e1000/meson.build | 4 +-- > > drivers/net/intel/fm10k/base/fm10k_mbx.c | 2 +- > > drivers/net/intel/fm10k/base/fm10k_osdep.h | 2 +- > > drivers/net/intel/fm10k/base/fm10k_pf.c | 8 +++--- > > drivers/net/intel/fm10k/base/fm10k_type.h | 6 ++--- > > drivers/net/intel/fm10k/base/meson.build | 21 ++------------- > > drivers/net/intel/fm10k/meson.build | 4 +-- > > drivers/net/intel/i40e/base/i40e_diag.c | 2 +- > > drivers/net/intel/i40e/base/i40e_nvm.c | 2 +- > > drivers/net/intel/i40e/base/i40e_osdep.h | 4 +-- > > drivers/net/intel/i40e/base/i40e_type.h | 14 ++++++---- > > drivers/net/intel/i40e/base/meson.build | 23 ++-------------- > > drivers/net/intel/i40e/i40e_ethdev.c | 1 + > > drivers/net/intel/i40e/meson.build | 4 +-- > > drivers/net/intel/iavf/base/meson.build | 10 ------- > > drivers/net/intel/ice/base/ice_osdep.h | 6 ++--- > > drivers/net/intel/ice/base/ice_switch.c | 2 -- > > drivers/net/intel/ice/base/ice_type.h | 2 +- > > drivers/net/intel/ice/base/meson.build | 1 - > > drivers/net/intel/ice/ice_fdir_filter.c | 2 +- > > drivers/net/intel/idpf/base/meson.build | 2 +- > > drivers/net/intel/idpf/meson.build | 7 ++--- > > drivers/net/intel/ixgbe/base/ixgbe_common.c | 4 +-- > > drivers/net/intel/ixgbe/base/ixgbe_e610.c | 2 ++ > > drivers/net/intel/ixgbe/base/ixgbe_osdep.c | 20 -------------- > > drivers/net/intel/ixgbe/base/ixgbe_osdep.h | 29 ++++++++++++--------- > > drivers/net/intel/ixgbe/base/meson.build | 20 ++------------ > > drivers/net/intel/ixgbe/meson.build | 4 +-- 29 files changed, > > 69 insertions(+), 148 deletions(-) delete mode 100644 > > drivers/net/intel/iavf/base/meson.build > > I see that you kept the base/meson.build in most drivers, though those > only provides a list of base sources. Is this because you expect having > to restore this special handling in the future? > Not especially, no. I would hope we wouldn't need additional warning handling in future, though one never knows. I did consider removing them in this set, but have decided against it (for now anyway).
I am planning on doing a follow-up set to move the handling of the base code builds to the "drivers/meson.build" file. At that point, I'll maybe decide to remove the files - though again I'm in two-minds about it, still. /Bruce
