RE: [v6 0/6] crypto/virtio: enhancements for RSA and vDPA

2025-03-05 Thread Akhil Goyal
> Subject: [v6 0/6] crypto/virtio: enhancements for RSA and vDPA > > This patch series enhances virtio crypto PMD to: > * support RSA > * support packed virtio ring > * support vDPA backend > > v6: > - patches rebased. > > Gowrishankar Muthukrishnan (6): > crypto/virtio: add asymmetric RSA

Re: [PATCH] net/mana: avoid the use of variable length array

2025-03-05 Thread Andre Muezerie
On Tue, Mar 04, 2025 at 04:37:32PM -0800, lon...@linuxonhyperv.com wrote: > From: Long Li > > The pathname can be defined as name[MAX_PATH]. This makes the driver > compilable using MSVC. > > Signed-off-by: Long Li > --- > drivers/net/mana/mana.c | 7 ++- > 1 file changed, 2 insertions(+),

Re: [RFC] eal: add new function versioning macros

2025-03-05 Thread Patrick Robb
Recheck-request: iol-intel-Performance There was an infra failure with the Arm Grace server about 12 hours ago which caused this failure - sending a retest request.

Re: [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up

2025-03-05 Thread Patrick Robb
Recheck-request: iol-intel-Performance There was an infra failure with the Arm Grace server about 12 hours ago which caused this failure - sending a retest request.

Re: [PATCH] hash_multiwriter_autotest: fix printf parameters

2025-03-05 Thread Patrick Robb
Recheck-request: iol-intel-Performance There was an infra failure with the Arm Grace server about 12 hours ago which caused this failure - sending a retest request.

Re: [PATCH v2 2/2] drivers/net: remove use of non-standard array range initialization

2025-03-05 Thread Patrick Robb
Recheck-request: iol-intel-Performance There was an infra failure with the Arm Grace server about 12 hours ago which caused this failure - sending a retest request.

Re: [PATCH v2] eal: fix undetected NUMA nodes

2025-03-05 Thread Patrick Robb
Recheck-request: iol-intel-Performance There was an infra failure with the Arm Grace server about 12 hours ago which caused this failure - sending a retest request.

Re: [PATCH v9 3/3] eventdev: add atomic atq to test-eventdev app

2025-03-05 Thread Patrick Robb
Recheck-request: iol-intel-Performance There was an infra failure with the Arm Grace server about 12 hours ago which caused this failure - sending a retest request.

Re: [PATCH v3 5/5] app/test: add tests for portable version of __builtin_add_overflow

2025-03-05 Thread Patrick Robb
Recheck-request: iol-intel-Performance There was an infra failure with the Arm Grace server about 12 hours ago which caused this failure - sending a retest request.

Re: [PATCH] net/mlx5/hws: fix incorrect DV FT type convert

2025-03-05 Thread Patrick Robb
Recheck-request: iol-intel-Performance There was an infra failure with the Arm Grace server about 12 hours ago which caused this failure - sending a retest request.

Re: [PATCH v3] app/test: fix stack overflow in lpm6_perf_autotest

2025-03-05 Thread Bruce Richardson
On Wed, Dec 18, 2024 at 07:21:26AM -0800, Andre Muezerie wrote: > Test lpm6_perf_autotest was hitting a stack overflow on Windows > with both MSVC and Clang. > > The fix is to move some of the data from the stack to the heap. > > Signed-off-by: Andre Muezerie > --- > app/test/test_lpm6_perf.c |

Re: [PATCH] vhost/crypto: fix locking

2025-03-05 Thread Maxime Coquelin
On 3/5/25 10:12 AM, David Marchand wrote: vc_req_out->vq->iotlb_lock is taken twice on the same thread: vc_req_out->vq refers to vc_req->vq (after a memcpy), which itself is a reference to the vq. clang probably does not detect that the same object is already locked as it does not track objec

RE: net/mlx5: wrong Rx/Tx descriptor limits when DevX is off

2025-03-05 Thread Slava Ovsiienko
Hi, Edwin Thank you for the patch. You are quite right, “sh->cdev->config.hca_attr.log_max_wq_sz” is not set if DevX is disengaged. I found some other places where the uninitialized “log_max_wq_sz” might be used. So. I’d rather prefer to configure the “log_max_wq_sz” for IBV case as well, instea

[PATCH v3 00/14] net/zxdh: add network processor ops

2025-03-05 Thread Bingbin Chen
V3: - resolve code style. - resolve spin lock build issue. - rebase code baseline. - modify parameters of the plcr function. V2: - resolve code style and github-robot build issue. - eliminate commit warning. - remove unnecessary initialization, which first usage will set. - replace

[PATCH v3 04/14] net/zxdh: modify dtb queue ops

2025-03-05 Thread Bingbin Chen
Modify the implementation of the dtb queue request and release interfaces, and add the implementation of queue initialization. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 494 + drivers/net/zxdh/zxdh_np.h | 97 2 files changed, 483 i

[PATCH v3 03/14] net/zxdh: add agent channel

2025-03-05 Thread Bingbin Chen
Add agent channel to access (np)network processor registers that are not mapped by PCIE. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 449 +++-- drivers/net/zxdh/zxdh_np.h | 63 +- 2 files changed, 442 insertions(+), 70 deletions(-) diff --gi

[PATCH v3 02/14] net/zxdh: support compatibility check

2025-03-05 Thread Bingbin Chen
Add compatibility check between (np)network processor software and firmware. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 93 ++ drivers/net/zxdh/zxdh_np.h | 11 + 2 files changed, 104 insertions(+) diff --git a/drivers/net/zxdh/zxdh_np.c

[PATCH v3 07/14] net/zxdh: get flow tables resources

2025-03-05 Thread Bingbin Chen
Implement the flow tables resources get operation by agent channel. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_ethdev.c | 13 + drivers/net/zxdh/zxdh_ethdev.h | 1 + drivers/net/zxdh/zxdh_np.c | 490 + drivers/net/zxdh/zxdh_np.h | 337 +++

RE: [EXTERNAL] [PATCH] vhost/crypto: fix build with asserts

2025-03-05 Thread Gowrishankar Muthukrishnan
> > Fixes: d1b484bf1876 ("vhost/crypto: support asymmetric RSA") > > Signed-off-by: David Marchand Tested-by: Gowrishankar Muthukrishnan

RE: [EXTERNAL] [PATCH] vhost/crypto: fix locking

2025-03-05 Thread Gowrishankar Muthukrishnan
> > clang probably does not detect that the same object is already locked as it > does > not track object referencies. > > Finish the incomplete and incorrect cleanup and only refer to the > &vq->iotlb_lock > capability (required by vhost_iova_to_vva). > > Fixes: 88c73b5434e6 ("vhost/crypto: f

RE: [PATCH] net/mana: avoid the use of variable length array

2025-03-05 Thread Morten Brørup
> From: lon...@linuxonhyperv.com [mailto:lon...@linuxonhyperv.com] > Sent: Wednesday, 5 March 2025 01.38 > > From: Long Li > > The pathname can be defined as name[MAX_PATH]. This makes the driver > compilable using MSVC. The name is PATH_MAX, not MAX_PATH. It's correct in the code. > > Signed

[PATCH] vhost/crypto: fix build with asserts

2025-03-05 Thread David Marchand
../lib/vhost/vhost_crypto.c: In function ‘virtio_crypto_asym_rsa_der_to_xform’: ../lib/vhost/vhost_crypto.c:538:42: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare] 538 | RTE_ASSERT((tlv

RE: [PATCH] vhost/crypto: fix build with asserts

2025-03-05 Thread Ali Alnubani
> -Original Message- > From: David Marchand > Sent: Wednesday, March 5, 2025 11:43 AM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Chenbo Xia > ; Akhil Goyal ; Gowrishankar > Muthukrishnan > Subject: [PATCH] vhost/crypto: fix build with asserts > > ../lib/vhost/vhost_crypto.c: In function

Re: [PATCH] vhost/crypto: fix build with asserts

2025-03-05 Thread Thomas Monjalon
05/03/2025 10:48, Maxime Coquelin: > > On 3/5/25 10:43 AM, David Marchand wrote: > > ../lib/vhost/vhost_crypto.c: In function > > ‘virtio_crypto_asym_rsa_der_to_xform’: > > ../lib/vhost/vhost_crypto.c:538:42: warning: comparison of integer > > expressions > > of different signedness: ‘long i

Re: [PATCH] vhost/crypto: fix build with asserts

2025-03-05 Thread Maxime Coquelin
On 3/5/25 10:43 AM, David Marchand wrote: ../lib/vhost/vhost_crypto.c: In function ‘virtio_crypto_asym_rsa_der_to_xform’: ../lib/vhost/vhost_crypto.c:538:42: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘size_t’ {aka ‘long unsigned int’} [

[PATCH v3 11/14] net/zxdh: get hash table entry result

2025-03-05 Thread Bingbin Chen
Implement hash tables get operation by dtb channel. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 479 + drivers/net/zxdh/zxdh_np.h | 7 + 2 files changed, 486 insertions(+) diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net/zxdh/zxdh_np.c

[PATCH v3 14/14] net/zxdh: modify parameters of the plcr function

2025-03-05 Thread Bingbin Chen
Add dev_id to the parameter of plcr function to support multi card configuration. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_msg.c | 3 +- drivers/net/zxdh/zxdh_mtr.c | 8 +- drivers/net/zxdh/zxdh_np.c | 251 +++- drivers/net/zxdh/zxdh_np.h | 8

[PATCH v8 2/3] eventdev: add atomic queue test to test-evnetdev app

2025-03-05 Thread Luka Jankovic
Add an atomic queue test to the test-eventdev app, which is based on the order queue test that exclusively uses atomic queues. Signed-off-by: Luka Jankovic Tested-by: Pavan Nikhilesh --- app/test-eventdev/meson.build |1 + app/test-eventdev/test_atomic_queue.c | 234

[PATCH v8 3/3] eventdev: add atomic atq to test-eventdev app

2025-03-05 Thread Luka Jankovic
Add an atomic atq test to the test-eventdev app. The test works in the same way as atomic queue, the difference being that only one queue capable of all types for both stages. Signed-off-by: Luka Jankovic Tested-by: Pavan Nikhilesh --- app/test-eventdev/meson.build |1 + app

[PATCH v8 0/3] eventdev: atomic tests to test-eventdev app

2025-03-05 Thread Luka Jankovic
Add atomic tests to the test-eventdev app which correspond to the order tests but use exclusively atomic queues. The test detects if port maintenance is required, and so they are compatible with event devices such as the distributed software eventdev. To verify atomicity, a spinlock is used for e

[PATCH] eventdev: atomic common for test-eventdev app

2025-03-05 Thread Luka Jankovic
Introduce changes required for atomic tests to run atomic tests. - Producer port maintenance - Common spinlock implementation Signed-off-by: Luka Jankovic Tested-by: Pavan Nikhilesh --- app/test-eventdev/evt_common.h | 9 ++ app/test-eventdev/meson.build | 1 + app/test-ev

Re: [PATCH v3 4/5] net/intel: use portable version of __builtin_add_overflow

2025-03-05 Thread Bruce Richardson
On Wed, Mar 05, 2025 at 08:38:09AM -0800, Andre Muezerie wrote: > __builtin_add_overflow is gcc specific. It should be replaced with > a portable version that can also be used with other compilers. > > Signed-off-by: Andre Muezerie > --- > drivers/net/intel/ice/base/ice_nvm.c | 9 - > 1

Re: [PATCH v1 20/32] net/ntnic: add clock init

2025-03-05 Thread David Marchand
On Thu, Feb 20, 2025 at 11:06 PM Serhii Iliushyk wrote: > diff --git > a/drivers/net/ntnic/nthw/core/include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h > > b/drivers/net/ntnic/nthw/core/include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h > new file mode 100644 > index 00..f87828fcf

Re: [PATCH] dmadev: enable lib to be compiled with MSVC

2025-03-05 Thread David Marchand
On Tue, Mar 4, 2025 at 2:55 AM Andre Muezerie wrote: > > With the outstanding issues preventing dmadev from being compiled > with MSVC being fixed, the lib can be enabled to be compiled with MSVC. > > Signed-off-by: Andre Muezerie Applied, thanks. -- David Marchand

Re: [PATCH v4 0/5] Trace point framework enhancement for dmadev

2025-03-05 Thread David Marchand
On Tue, Mar 4, 2025 at 5:07 PM David Marchand wrote: > > dmadev trace points have been working around trace point framework > limitations. > One of this workaround blocks enabling dmadev on MSVC. > > Traces files were not checked in CI, so this series also adds a new > check. > > -- > David Marcha

[PATCH] net/mlx5/hws: fix incorrect DV FT type convert

2025-03-05 Thread Dariusz Sosnowski
From: Alex Vesker When creating a root modify/reformat action it is created for a single specific table type, current code ignored this and used the first ft_type found in if, else. Also added missing translation for non-root FDB action root dest. Fixes: f8c8a6d8440d ("net/mlx5/hws: add action o

[PATCH] vhost/crypto: fix locking

2025-03-05 Thread David Marchand
vc_req_out->vq->iotlb_lock is taken twice on the same thread: vc_req_out->vq refers to vc_req->vq (after a memcpy), which itself is a reference to the vq. clang probably does not detect that the same object is already locked as it does not track object referencies. Finish the incomplete and incor

[DPDK/meson Bug 1670] DPDK fails to compile using gcc version 8.5.0

2025-03-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1670 Bug ID: 1670 Summary: DPDK fails to compile using gcc version 8.5.0 Product: DPDK Version: 25.03 Hardware: ARM OS: Linux Status: UNCONFIRMED Severity: critical

[PATCH v2] eal: fix undetected NUMA nodes

2025-03-05 Thread Bruce Richardson
In cases where the number of cores on a given socket is greater than RTE_MAX_LCORES, then EAL will be unaware of all the sockets/numa nodes on a system. Fix this limitation by having the EAL probe the NUMA node for cores it isn't going to use, and recording that for completeness. This is necessary

Re: [PATCH v3 00/14] Remove unnecessary function pointer deref

2025-03-05 Thread David Marchand
On Thu, Feb 20, 2025 at 5:57 PM Stephen Hemminger wrote: > > A common pattern in DPDK internals is to have an array of function > pointers. When using these pointers an unnecessary derefence is done; > this is allowed in C because of a historical quirk but unnecessary. > > This fixes all instances

RE: [DPDK/meson Bug 1670] DPDK fails to compile using gcc version 8.5.0

2025-03-05 Thread Wathsala Wathawana Vithanage
> Subject: [DPDK/meson Bug 1670] DPDK fails to compile using gcc version 8.5.0 > > Bug ID 1670 > SummaryDPDK fails to compile using gcc version 8.5.0 > ProductDPDK > Version25.03 > Hardware ARM > OS Linux > Stat

[PATCH v1 1/1] baseband/acc: fix queue setup failure clean up

2025-03-05 Thread Nicolas Chautru
Incomplete clean up for vrb2 variant when queue setup fails to complete successfully. Fixes: fc65d3dcabe01 ("baseband/acc: refactor queue allocation") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

[PATCH v1 0/1] baseband/acc: fix queue setup failure clean up

2025-03-05 Thread Nicolas Chautru
Hi Maxime, This is the fix for the regression issue mentioned off list. This could notably hit when running with bbdev-test over more than 64 threads. Thanks Nic Nicolas Chautru (1): baseband/acc: fix queue setup failure clean up drivers/baseband/acc/rte_vrb_pmd.c | 2 ++ 1 file changed, 2

[PATCH v9 0/3] eventdev: atomic tests to test-eventdev app

2025-03-05 Thread ejnulak
From: Luka Jankovic Add atomic tests to the test-eventdev app which correspond to the order tests but use exclusively atomic queues. The test detects if port maintenance is required, and so they are compatible with event devices such as the distributed software eventdev. To verify atomicity, a

[PATCH v9 1/3] eventdev: atomic common for test-eventdev app

2025-03-05 Thread ejnulak
From: Luka Jankovic Introduce changes required for atomic tests to run atomic tests. - Producer port maintenance - Common spinlock implementation Signed-off-by: Luka Jankovic Tested-by: Pavan Nikhilesh --- app/test-eventdev/evt_common.h | 9 ++ app/test-eventdev/meson.build

[PATCH v2 2/2] drivers/net: remove use of non-standard array range initialization

2025-03-05 Thread Andre Muezerie
Array range initialization is non-standard and is not provided by all compilers. MSVC does not implement it and ends up emitting errors like the one below: drivers/net/r8169/r8169_phy.c(380): error C2143: syntax error: missing ':' before '...' case CFG_METHOD_48 ... CFG_METHOD_57: The fix is

[PATCH v2 0/2] remove use of non-standard array range initialization

2025-03-05 Thread Andre Muezerie
Array range initialization is non-standard and is not provided by all compilers. MSVC does not implement it and ends up emitting errors like the one below: drivers/net/r8169/r8169_phy.c(380): error C2143: syntax error: missing ':' before '...' case CFG_METHOD_48 ... CFG_METHOD_57: The fix is

[PATCH v2 1/2] app/test: remove use of non-standard array range initialization

2025-03-05 Thread Andre Muezerie
Array range initialization is non-standard and is not provided by all compilers. MSVC does not implement it and ends up emitting errors like the one below: drivers/net/r8169/r8169_phy.c(380): error C2143: syntax error: missing ':' before '...' case CFG_METHOD_48 ... CFG_METHOD_57: The fix is

Re: [PATCH v3] app/test: fix stack overflow in lpm6_perf_autotest

2025-03-05 Thread Andre Muezerie
On Wed, Mar 05, 2025 at 10:08:33AM +, Bruce Richardson wrote: > On Wed, Dec 18, 2024 at 07:21:26AM -0800, Andre Muezerie wrote: > > Test lpm6_perf_autotest was hitting a stack overflow on Windows > > with both MSVC and Clang. > > > > The fix is to move some of the data from the stack to the he

Re: [PATCH v2 2/2] app/test: add test_init_m128i using compiler intrinsic

2025-03-05 Thread Andre Muezerie
On Wed, Mar 05, 2025 at 09:20:03AM +, Bruce Richardson wrote: > On Tue, Mar 04, 2025 at 01:53:19PM -0800, Andre Muezerie wrote: > > This test initializes an __m128i data type using the old > > non-portable way used until now and the more portable way > > using compiler intrinsics. The test ensu

Re: [PATCH] ci: point at GitHub mirror.

2025-03-05 Thread Aaron Conole
David Marchand writes: > We face some random failures accessing dpdk.org git when running GHA. > Point at GitHub hosted mirror. > > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Thanks - this change makes a lot of sense to me. I was going to say we can use the ``GITHUB_REPOSITORY

Re: [PATCH v2 1/2] lib/hash: initialize __m128i data type in a portable way

2025-03-05 Thread Bruce Richardson
On Tue, Mar 04, 2025 at 01:53:18PM -0800, Andre Muezerie wrote: > The mechanism used to initialize an __m128i data type in rte_thash.h is > non-portable and MSVC does not like it. It clearly is not doing what > is desired: > > ..\lib\hash\rte_thash.h(38): warning C4305: 'initializing': > trunc

Re: [PATCH v2 2/2] app/test: add test_init_m128i using compiler intrinsic

2025-03-05 Thread Bruce Richardson
On Tue, Mar 04, 2025 at 01:53:19PM -0800, Andre Muezerie wrote: > This test initializes an __m128i data type using the old > non-portable way used until now and the more portable way > using compiler intrinsics. The test ensures the resulting > values after initialization match. > > Signed-off-by:

[PATCH] eal: fix undetected NUMA nodes

2025-03-05 Thread Bruce Richardson
In cases where the number of cores on a given socket is greater than RTE_MAX_LCORES, then EAL will be unaware of all the sockets/numa nodes on a system. Fix this limitation by having the EAL probe the NUMA node for cores it isn't going to use, and recording that for completeness. This is necessary

[PATCH v9 3/3] eventdev: add atomic atq to test-eventdev app

2025-03-05 Thread ejnulak
From: Luka Jankovic Add an atomic atq test to the test-eventdev app. The test works in the same way as atomic queue, the difference being that only one queue capable of all types for both stages. Signed-off-by: Luka Jankovic Tested-by: Pavan Nikhilesh --- app/test-eventdev/meson.build

[PATCH v9 2/3] eventdev: add atomic queue test to test-evnetdev app

2025-03-05 Thread ejnulak
From: Luka Jankovic Add an atomic queue test to the test-eventdev app, which is based on the order queue test that exclusively uses atomic queues. Signed-off-by: Luka Jankovic Tested-by: Pavan Nikhilesh --- app/test-eventdev/meson.build |1 + app/test-eventdev/test_atomic_

Re: [PATCH] vhost/crypto: fix locking

2025-03-05 Thread Thomas Monjalon
05/03/2025 10:52, Maxime Coquelin: > > On 3/5/25 10:12 AM, David Marchand wrote: > > vc_req_out->vq->iotlb_lock is taken twice on the same thread: > > vc_req_out->vq refers to vc_req->vq (after a memcpy), which itself > > is a reference to the vq. > > > > clang probably does not detect that the s

Re: [PATCH v2 2/5] lib/eal: add portable version of __builtin_add_overflow

2025-03-05 Thread Andre Muezerie
On Mon, Jan 06, 2025 at 12:58:44PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Monday, 6 January 2025 12.34 > > > > On Mon, Jan 06, 2025 at 12:21:39PM +0100, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.

[PATCH v3 0/5] add portable version of __builtin_add_overflow

2025-03-05 Thread Andre Muezerie
__builtin_add_overflow is gcc specific. There's a need for a portable version that can also be used with other compilers. v3: - Rebase on top of latest main. Andre Muezerie (5): maintainers: add portable version of __builtin_add_overflow eal: add portable version of __builtin_add_overflow d

[PATCH v3 3/5] doc/api: add portable version of __builtin_add_overflow

2025-03-05 Thread Andre Muezerie
__builtin_add_overflow is gcc specific. There's a need for a portable version that can also be used with other compilers. Signed-off-by: Andre Muezerie --- doc/api/doxy-api-index.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index b2

[PATCH v3 1/5] maintainers: add portable version of __builtin_add_overflow

2025-03-05 Thread Andre Muezerie
__builtin_add_overflow is gcc specific. There's a need for a portable version that can also be used with other compilers. Signed-off-by: Andre Muezerie --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 312e6fcee5..31c25a6fff 100644 --- a/MAINTAIN

[PATCH v3 2/5] eal: add portable version of __builtin_add_overflow

2025-03-05 Thread Andre Muezerie
__builtin_add_overflow is gcc specific. There's a need for a portable version that can also be used with other compilers. This patch introduces rte_add_overflow. Signed-off-by: Andre Muezerie --- lib/eal/include/meson.build | 1 + lib/eal/include/rte_math.h | 46 ++

[PATCH v3 5/5] app/test: add tests for portable version of __builtin_add_overflow

2025-03-05 Thread Andre Muezerie
__builtin_add_overflow is gcc specific. There's a need for a portable version that can also be used with other compilers. This patch adds tests for these new portable functions, to confirm they behave the same way across different compilers. Signed-off-by: Andre Muezerie --- app/test/meson.buil

[PATCH v3 4/5] net/intel: use portable version of __builtin_add_overflow

2025-03-05 Thread Andre Muezerie
__builtin_add_overflow is gcc specific. It should be replaced with a portable version that can also be used with other compilers. Signed-off-by: Andre Muezerie --- drivers/net/intel/ice/base/ice_nvm.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/intel/

Re: [PATCH v3] app/test: fix stack overflow in lpm6_perf_autotest

2025-03-05 Thread Medvedkin, Vladimir
Hi Andre, On 05/03/2025 14:45, Andre Muezerie wrote: On Wed, Mar 05, 2025 at 10:08:33AM +, Bruce Richardson wrote: On Wed, Dec 18, 2024 at 07:21:26AM -0800, Andre Muezerie wrote: Test lpm6_perf_autotest was hitting a stack overflow on Windows with both MSVC and Clang. The fix is to move s

Re: [PATCH 3/6] dts: add tmp directory facility

2025-03-05 Thread Dean Marx
Also, use is misspelled in the commit message

Re: [PATCH] app/test-fib: enable test-fib on Windows

2025-03-05 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 04/01/2025 22:09, Andre Muezerie wrote: Removed a few includes which were not needed and included rte_os_shim.h to handle strtok_r which does not exist on Windows with that exact name. Signed-off-by: Andre Muezerie --- app/test-fib/main.c | 8 ++--

[PATCH] hash_multiwriter_autotest: fix printf parameters

2025-03-05 Thread Andre Muezerie
Compiling with MSVC logs the warnings below, which result in build error: ../app/test/test_hash_multiwriter.c(71): warning C4476: 'printf' : unknown type field character ''' in format specifier ../app/test/test_hash_multiwriter.c(73): warning C4474: 'printf' : too many arguments passed for

[RFC] eal: add new function versioning macros

2025-03-05 Thread David Marchand
For versioning symbols: - MSVC uses pragmas on the function symbol, - GNU linker uses special asm directives, To accommodate both GNU linker and MSVC linker, introduce new macros for versioning functions that will surround the whole function. This has the advantage of hiding all the ugly details

Re: [PATCH 1/6] dts: ensure runtime working directory

2025-03-05 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH 3/6] dts: add tmp directory facility

2025-03-05 Thread Dean Marx
This makes sense, I noticed though that nothing is actually stored in these placeholder directories yet, and dpdk is built in a separate folder. Is the plan in the future to move this to the placeholder directory? Or is there a different use case? Reviewed-by: Dean Marx

Re: [PATCH 5/6] dts: enable build-less DPDK driver binding

2025-03-05 Thread Dean Marx
This looks great, one small thing I noticed though is that you don't necessarily need to build dpdk to use devbind, since it's already in the usertools directory, so this commit/series title could be misleading. Otherwise: Reviewed-by: Dean Marx

Re: [PATCH 4/6] dts: decouple DPDK runtime from build

2025-03-05 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH 2/6] dts: use topology in smoke tests

2025-03-05 Thread Dean Marx
On Mon, Feb 24, 2025 at 8:30 AM Luca Vizzarro wrote: > > The smoke tests where wrongly using all the node's ports for the smoke > tests. Ensure only the ports specified in the current topology are used. Should be were, not where > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek R

Re: [PATCH 6/6] dts: restore TG setup and teardown

2025-03-05 Thread Dean Marx
Reviewed-by: Dean Marx