On Wed, Mar 05, 2025 at 08:38:09AM -0800, Andre Muezerie wrote: > __builtin_add_overflow is gcc specific. It should be replaced with > a portable version that can also be used with other compilers. > > Signed-off-by: Andre Muezerie <andre...@linux.microsoft.com> > --- > drivers/net/intel/ice/base/ice_nvm.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/intel/ice/base/ice_nvm.c > b/drivers/net/intel/ice/base/ice_nvm.c > index 56c6c96a95..1002a6b59f 100644 > --- a/drivers/net/intel/ice/base/ice_nvm.c > +++ b/drivers/net/intel/ice/base/ice_nvm.c > @@ -3,6 +3,7 @@ > */ > > #include "ice_common.h" > +#include <rte_math.h> > > #define GL_MNG_DEF_DEVID 0x000B611C > > @@ -469,8 +470,6 @@ int ice_read_sr_word(struct ice_hw *hw, u16 offset, u16 > *data) > return status; > } > > -#define check_add_overflow __builtin_add_overflow > -
Rather than modifying the base code, can you instead add a #define to the osdep.h file in the base directory to alias the new function to __builtin_add_overflow for MSVC. The other files (other than osdep.h) in the base directory, come from a common/shared source that is not DPDK specific, so we try to avoid modifying them where possible. /Bruce
