[Patch v3] net/mana: use mana_local_data for tracking usage data for primary process

From: Long Li The driver uses mana_shared_data for tracking usage count for primary process. This is not correct as the mana_shared_data is allocated by the primary and is meant to track usage of secondary process by the primary process. And it creates a race condition when the device is removed

RE: [EXTERNAL] [Patch v2] net/mana: use mana_local_data for tracking usage data for primary process

> The DPDK has converted to using the C11 atomic's so this should use that (i.e > RTE_ATOMIC() etc) instead of the older atomic primitives. > I have sent v3.

[PATCH] net/zxdh: remove unnecessary null free checks

Remove unnecessary checks for null pointer. Found by devtools/cocci/nullfree.cocci script. Signed-off-by: Stephen Hemminger --- drivers/net/zxdh/zxdh_ethdev.c | 3 +-- drivers/net/zxdh/zxdh_np.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/zxdh/zxdh_eth

RE: [PATCH v2 00/14] Remove unnecessary function pointer deref

Series-acked-by: Morten Brørup

[PATCH] bus: invoke TAILQ_REMOVE when bus cleanup

Although eal_bus_cleanup() is not invoked for multiple times, this is a good programming habit to remove the device object from list when cleanup bus. Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Fixes: 62b906cf06ba ("bus/uacce: introduce UACCE bus") Fixes: 65780eada9d9 ("bus/vmbus: su

[PATCH] maintainers: update for Intel FPGA bus drivers

Change of maintainers' email for Intel FPGA bus drivers. Signed-off-by: Rosen Xu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 312e6fcee5..3128734a61 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -621,7 +621,7 @@ M: Xueming Li

[PATCH] maintainers: update for Intel FPGA rawdev drivers

Change of maintainers' email for Intel FPGA rawdev drivers Signed-off-by: Rosen Xu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 312e6fcee5..f6d22caa94 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1540,7 +1540,7 @@ Rawdev Dr

Re: [PATCH] power: use hugepage memory for queue list entry structure

Hi all, Kindly ping for review. 在 2024/12/19 15:53, Huisong Li 写道: The queue_list_entry structure data is used in rx_callback of io path when enable PMD Power Management. However its memory is currently from normal heap memory. For better performance, use hugepage memory to replace it. Signed

RE: [PATCH] bus: invoke TAILQ_REMOVE when bus cleanup

> From: Chengwen Feng [mailto:fengcheng...@huawei.com] > Sent: Thursday, 20 February 2025 09.09 > > Although eal_bus_cleanup() is not invoked for multiple times, this is a > good programming habit to remove the device object from list when > cleanup bus. > > Fixes: 1cab1a40ea9b ("bus: cleanup dev

Re: [PATCH v2 04/14] net/ixgbe: remove unnecessary dereference

On Wed, Feb 19, 2025 at 06:32:08PM -0800, Stephen Hemminger wrote: > The expression *dev->dev_ops->vlan_strip_queue_set and > dev->dev_ops->vlan_strip_queue are equivalent in C. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/intel/ixgbe/rte_pmd_ixgbe.c | 5 ++--- > 1 file changed, 2 in

RE: [PATCH] power: use hugepage memory for queue list entry structure

Hi > > Hi all, > > Kindly ping for review. > > > 在 2024/12/19 15:53, Huisong Li 写道: > > The queue_list_entry structure data is used in rx_callback of io path > > when enable PMD Power Management. However its memory is currently from > > normal heap memory. For better performance, use hugepag

RE: [PATCH] net/mlx5: fix err message overwrite for actions translation

> -Original Message- > From: Junfeng Guo > Sent: Thursday, February 20, 2025 08:09 > To: dev@dpdk.org > Cc: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > ; Minggang(Gavin) Li ; Jiawei(Jonny) > Wang ; sta...@dpdk.org > Subject: [PATCH] net/ml

Re: [PATCH v2 00/14] Remove unnecessary function pointer deref

On Wed, Feb 19, 2025 at 06:32:04PM -0800, Stephen Hemminger wrote: > A common pattern in DPDK internals is to have an array of function > pointers. When using these pointers an unnecessary derefence is done; > this is allowed in C because of a historical quirk but unnecessary. > > This fixes all i

Re: [External] [PATCH v2] cryptodev: not close device when secondary exit

On 2025/1/8 20:21, Akhil Goyal wrote: Caution: This is an external email. Please be very careful when clicking links or opening attachments. See http://nok.it/nsb for additional information. The secordary process should not close the crypto device when it exits because the primary process st

RE: [EXTERNAL] [RFC v7 0/4] eventdev: atomic tests to test-eventdev app

> Add atomic tests to the test-eventdev app which correspond to the order > tests but use exclusively atomic queues. > > The test detects if port maintenance is required, and so they are compatible > with event devices such as the distributed software eventdev. > > To verify atomicity, a spinlock

[PATCH 3/3] maintainers: update for Intel FPGA rawdev drivers

Change of maintainers' email for Intel FPGA rawdev drivers Signed-off-by: Rosen Xu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 979e8ffb07..82f6e2f917 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1540,7 +1540,7 @@ Rawdev Dr

[PATCH 1/3] maintainers: update for Intel ipn3ke drivers

Change of maintainers' email for Intel ipn3ke drivers. Signed-off-by: Rosen Xu --- .mailmap| 2 +- MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index a03d3cfb59..59933f9bc3 100644 --- a/.mailmap +++ b/.mailmap @@ -1325,7 +1325,7 @@ Ro

[PATCH 2/3] maintainers: update for Intel FPGA bus drivers

Change of maintainers' email for Intel FPGA bus drivers. Signed-off-by: Rosen Xu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index fc65715d39..979e8ffb07 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -621,7 +621,7 @@ M: Xueming Li

Re: [PATCH] app/testpmd: fix out-of-bound reference in offload config

LGTM, Acked-by: Huisong Li 在 2025/2/21 4:44, Stephen Hemminger 写道: When configuring offloads, need to check the port id before indexing into the ports[] array. This can easily be done by moving the call to oh_dev_conf_get_print_err() to before the checks for port stopped. Fixes: c73a9071877a ("

[PATCH v2 03/16] net/zxdh: optimize link update process

optimize link update process. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev_ops.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/net/zxdh/zxdh_ethdev_ops.c b/drivers/net/zxdh/zxdh_ethdev_ops.c index 7ebb231362..83ea1188a0 100

[PATCH v2 08/16] net/zxdh: optimize VLAN filter/offload ops

optimize VLAN filter/offload ops. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev_ops.c | 42 +++-- drivers/net/zxdh/zxdh_msg.c| 81 + drivers/net/zxdh/zxdh_msg.h| 5 +- drivers/net/zxdh/zxdh_tables.c | 139 + d

[PATCH v1 20/32] net/ntnic: add clock init

Add initialization for the clock subsystem Signed-off-by: Serhii Iliushyk --- ...00D13_U62_Si5332-GM2-RevD-1_V5-Registers.h | 425 ++ .../net/ntnic/nthw/core/include/nthw_i2cm.h | 1 + .../nthw/core/include/nthw_pcm_nt400dxx.h | 14 + .../nthw/core/include/nthw_si5332_si

[PATCH v2 06/16] net/zxdh: optimize MAC ops

optimize MAC ops Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 40 +- drivers/net/zxdh/zxdh_ethdev.h | 13 +++- drivers/net/zxdh/zxdh_ethdev_ops.c | 59 +-- drivers/net/zxdh/zxdh_msg.c| 118 + drivers/net/zxdh/

Re: [PATCH v2] examples/l3fwd: add option to set Tx burst size

On 2025/2/20 1:01, Konstantin Ananyev wrote: On 2024/12/4 10:06, Jie Hai wrote: The application send packets only when the buffer is full, or the buffer is empty and the packets to be sent extends TX_PKT_BURST. The change of MAX_PKT_BURST make TX buffer size and TX_PKT_BURST increase, while

Re: [PATCH] app/testpmd: fix fail to set queue number when attach device

在 2025/2/21 4:56, Stephen Hemminger 写道: On Tue, 18 Feb 2025 19:31:56 +0800 Huisong Li wrote: Testpmd doesn't modify the Rx/Tx queue number of all ports after attach a new device. The root cause is that "port config all rxq " would check if all ports are stopped and the status of this port is

[PATCH v2 02/16] net/zxdh: optimize queue res alloc/free process

optimize queue res alloc/free process. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_common.c | 27 ++-- drivers/net/zxdh/zxdh_ethdev.c | 200 - drivers/net/zxdh/zxdh_ethdev.h | 14 +- drivers/net/zxdh/zxdh_ethdev_ops.c | 13 +- drivers/net/zxdh

[PATCH v2 07/16] net/zxdh: optimize promisc ops

optimize promisc ops. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_msg.c| 62 ++ drivers/net/zxdh/zxdh_tables.c | 49 +++ drivers/net/zxdh/zxdh_tables.h | 3 +- 3 files changed, 113 insertions(+), 1 deletion(-) diff --git a/d

[PATCH v2 00/16] net/zxdh: updated net zxdh driver

V2: - modify CI some error results(checkpatches warnings、Wrong headline format) - fix warnings when enable extra warnings. - modify apply memcpy script for coccinelle and unnecessary init and unneccessary cast of void when use malloc. V1: - updated net zxdh driver. optimize init an

[PATCH v2 15/16] net/zxdh: provide ptypes FW version EEPROM ops

provide ptypes、FW version、EEPROM ops. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 2 + drivers/net/zxdh/zxdh_ethdev.c | 30 + drivers/net/zxdh/zxdh_ethdev_ops.c | 200 + drivers/net/zxdh/zxdh_ethdev_ops.h | 5 + drivers/net/zxdh/z

[PATCH v2 05/16] net/zxdh: provided PF/VF msg intr callback

provided PF/VF msg intr callback. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 6 +- drivers/net/zxdh/zxdh_msg.c| 186 +++-- drivers/net/zxdh/zxdh_msg.h| 9 ++ drivers/net/zxdh/zxdh_tables.c | 17 +++ drivers/net/zxdh/zxdh_tables.h |

[PATCH v2 09/16] net/zxdh: optimize RSS/RETA hash config/update/get

optimize RSS hash config/update,RETA update/get. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev_ops.c | 1 - drivers/net/zxdh/zxdh_msg.c| 129 + 2 files changed, 129 insertions(+), 1 deletion(-) diff --git a/drivers/net/zxdh/zxdh_ethdev_ops.c

[PATCH v2 13/16] net/zxdh: provided rxq/txq info get implementations

provided rxq/txq info get implementations. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 40 -- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c index 30ddb463a2..19c2

[PATCH v2 14/16] net/zxdh: provide extended stats ops implementations

provide extended stats ops implementations. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 1 + doc/guides/nics/zxdh.rst | 1 + drivers/net/zxdh/zxdh_ethdev.c | 3 + drivers/net/zxdh/zxdh_ethdev_ops.c | 265 - drivers/net/zxdh

[PATCH v2 12/16] net/zxdh: provided CSUM/TSO/LRO config

provided CSUM/TSO/LRO config. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 5 ++ doc/guides/nics/zxdh.rst | 3 + drivers/net/zxdh/zxdh_ethdev.c| 92 +++ drivers/net/zxdh/zxdh_msg.c | 15 + 4 files changed, 115 insertions

[PATCH v2 10/16] net/zxdh: optimize MTU set ops

optimize MTU set ops. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev_ops.c | 8 ++--- drivers/net/zxdh/zxdh_msg.c| 42 + drivers/net/zxdh/zxdh_tables.h | 49 +++--- 3 files changed, 90 insertions(+), 9 deletions(-) diff

Re: [PATCH v8 06/17] app/test: use unit test runner for malloc tests

On 16/02/2025 17:53, Stephen Hemminger wrote: There are several malloc tests and switching to the table driven unit test runner improves readability and makes adding new tests easier. Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

[PATCH v2 3/3] fbarray: flatten the loop in find prev n

Currently, find_prev_n() is implemented as a nested loop due to lookbehind functionality. This is not very efficient because when doing lookbehind, we essentially scan some of the indices twice, and in general the lookbehind functionality has been a source of bugs because it is overcomplicated. The

Re: [PATCH v8 05/17] eal: add new secure free function

On 16/02/2025 17:53, Stephen Hemminger wrote: Although internally rte_free does poison the buffer in most cases, it is useful to have function that explicitly does this to avoid any security issues. Name of new API is chosen to be similar to Linux kernel kfree_sensitive() to make porting drivers

[PATCH] test/crypto: remove unused variable

In the new session framework, each crypto session no longer requires the session_priv_mpool, and it is no longer referenced during testsuite setup. However, the structure `struct crypto_testsuite_params` still contains the session_priv_mpool member, which may lead to the misunderstanding that sessi

[PATCH v2 2/3] fbarray: flatten the loop in find next n

Currently, find_next_n() is implemented as a nested loop due to lookahead functionality. This is not very efficient because when doing lookahead, we essentially scan some of the indices twice, and in general the lookahead functionality has been a source of bugs because it is overcomplicated. The bi

RE: [PATCH v4 1/3] crypto/ipsec_mb: add SM4 GCM support

Hi Brian, > -Original Message- > From: Dooley, Brian > Sent: Wednesday, February 19, 2025 12:50 PM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; gak...@marvell.com; Dooley, Brian > > Subject: [PATCH v4 1/3] crypto/ipsec_mb: add SM4 GCM support > > This patch introduces SM

RE: [PATCH v4 2/3] cryptodev: add SM4 GCM

> -Original Message- > From: Dooley, Brian > Sent: Wednesday, February 19, 2025 12:50 PM > To: Akhil Goyal ; Fan Zhang > Cc: dev@dpdk.org; Ji, Kai ; De Lara Guarch, Pablo > ; Dooley, Brian > Subject: [PATCH v4 2/3] cryptodev: add SM4 GCM > > Added support for symmetric algorithm SM4

Re: [PATCH v2 01/14] ethdev: remove unnecessary deref on function pointers

On Thu, 20 Feb 2025 10:09:23 +0300 Andrew Rybchenko wrote: > On 2/20/25 05:32, Stephen Hemminger wrote: > > The expression *dev->dev_ops->rx_queue_start and > > dev->dev_ops->rx_queue_start are equivalent. > > Remove the unnecessary asterisk and parenthesis. > > > > Signed-off-by: Stephen Hemmin

RE: [PATCH] power: use hugepage memory for queue list entry structure

> -Original Message- > From: Stephen Hemminger > Sent: Thursday, February 20, 2025 4:12 PM > To: lihuisong (C) > Cc: dev@dpdk.org; tho...@monjalon.net; david.h...@intel.com; > anatoly.bura...@intel.com; sivaprasad.tumm...@amd.com; > liuyonglong > Subject: Re: [PATCH] power: use hugep

[PATCH v9 00/15] fix insecure use of memset bugs

There is an issue where calls to bzero (memset(), etc) can be eliminated due to an optimizing compiler eliminating the call to bzero() (or memset(), etc) because the arguments to the call are not subsequently used by the function. The compiler can interpret this as "no side effects", and eliminate

[PATCH v9 01/15] eal: introduce new secure memory zero

When memset() is used before a release function such as free, the compiler if allowed to optimize the memset away under the as-if rules. This is normally ok, but in certain cases such as passwords or security keys it is problematic. Introduce a DPDK wrapper which uses the bzero_explicit function o

[PATCH v9 05/15] app/test: add test for rte_free_sensitive

Similar to test for rte_memset_explicit, use a worker thread to free and then check the result. Signed-off-by: Stephen Hemminger --- app/test/test_malloc.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a/app/test/test_malloc.c b/app/test/test_mallo

[PATCH v9 02/15] app/test: remove unused variable

The buffer tmp is set but never used. This leads to warning since the memset could be eliminated by the compiler. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_cirbuf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test/test_cmdline_cirbuf.c b/app/test/test_cmdline_cirbuf

[PATCH v9 04/15] app/test: use unit test runner for malloc tests

There are several malloc tests and switching to the table driven unit test runner improves readability and makes adding new tests easier. Signed-off-by: Stephen Hemminger --- app/test/test_malloc.c | 166 + 1 file changed, 70 insertions(+), 96 deletions(-)

[PATCH v9 10/15] bus/uacce: remove memset before free

Doing memset before free maybe removed by compiler, and is flagged by security scanning tools as potential problem. In this case the memset is unnecessary. Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng --- drivers/bus/uacce/uacce.c | 1 - 1 file changed, 1 deletion(-) diff --git a/d

[PATCH v9 07/15] crypto/qat: force zero of keys

Just doing memset() on keys is not enough, compiler can optimize it away. Use new rte_memzero_explicit() and rte_free_sensitive(). Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/crypto/qat/qat_sym_session.c | 33 ++-- 1 file changed, 17 insertion

[PATCH v9 08/15] crypto/qat: fix size calculation for memset

The memset was always doing 0 bytes since size computed later. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 3a80d7fb2ecd ("crypto/qat: support SHA3 plain hash") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/crypto/qat/qat_sym_sessio

[PATCH v9 12/15] test: remove unneeded memset

Since tmp is not used later in the function, this memset is unnecessary. Even though this is harmless, it causes tools that look for security issues around memset to flag this a bug. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- app/test/test_cmdline_cirbuf.c | 2 -- 1 file ch

[PATCH v9 13/15] net/ntnic: check result of malloc

Need to check the result of malloc() before calling memset. This is only place in this driver that forgot, other code does check. Fixes: 0d9bca480e26 ("net/ntnic: add FPGA modules for initialization") cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/ntnic/nthw/nthw_rac.c | 4

[PATCH v9 15/15] devtools/cocci: add script to find problematic memset

Script that converts memset before free into rte_memset_sensitive and memset before rte_free into rte_free_sensitive Signed-off-by: Stephen Hemminger --- devtools/cocci/memset_free.cocci | 9 + 1 file changed, 9 insertions(+) create mode 100644 devtools/cocci/memset_free.cocci diff --g

[PATCH v9 14/15] net/ntnic: remove unnecessary memset

Calling memset before free() has no effect and will be flagged by security parsing tools as a potential bug. None of these data structures have sensitive information. Signed-off-by: Stephen Hemminger --- drivers/net/ntnic/nthw/core/nthw_hif.c| 5 + drivers/net/ntnic/nthw/core

Re: [PATCH] power: use hugepage memory for queue list entry structure

On Thu, 20 Feb 2025 16:39:52 + Konstantin Ananyev wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, February 20, 2025 4:12 PM > > To: lihuisong (C) > > Cc: dev@dpdk.org; tho...@monjalon.net; david.h...@intel.com; > > anatoly.bura...@intel.com; sivaprasad

[PATCH v3 00/14] Remove unnecessary function pointer deref

A common pattern in DPDK internals is to have an array of function pointers. When using these pointers an unnecessary derefence is done; this is allowed in C because of a historical quirk but unnecessary. This fixes all instances of PVS Studio checker warning: https://pvs-studio.com/en/docs/warni

[PATCH v3 02/14] eventdev: remover unnecessary deref on function pointers

The expression *dev_dev_ops->foo and dev->dev_ops->foo are equivalent. Cleanup the result by removing unneeded parenthesis and make lines compact. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eventdev/rte_event_crypto_adapter.c | 37 ++ lib/e

[PATCH v3 01/14] ethdev: remove unnecessary deref on function pointers

The expression *dev->dev_ops->rx_queue_start and dev->dev_ops->rx_queue_start are equivalent. Remove the unnecessary asterisk and parenthesis. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/ethdev/ethdev_driver.c |

[PATCH v3 07/14] cryptodev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_gets and dev->dev_ops->dev_info_gets are equivalent. Cleanup and remove unnecessary parenthesis as well. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/cryptodev/rte_cryptodev.c | 72 +--

[PATCH v3 04/14] net/ixgbe: remove unnecessary dereference

The expression *dev->dev_ops->vlan_strip_queue_set and dev->dev_ops->vlan_strip_queue are equivalent in C. Signed-off-by: Stephen Hemminger Reviewed-by: Bruce Richardson Acked-by: Morten Brørup --- drivers/net/intel/ixgbe/rte_pmd_ixgbe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(

[PATCH v3 08/14] crypto/scheduler: remove unnecessary dereference

The expression *dev->dev_ops->sym_session_get_size and dev->dev_ops->sym_session_get_size are equivalent. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- .../scheduler/rte_cryptodev_scheduler.c | 8 +++--- drivers/crypto/scheduler/scheduler_pmd_op

[PATCH v3 09/14] compressdev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_gets and dev->dev_ops->info_get are equivalent. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/compressdev/rte_compressdev.c | 56 +++ 1 file changed, 28 insertions(+), 28 deletions(

[PATCH v3 10/14] dmadev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent. Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/dmadev/rte_dmadev.c | 38 +- 1 file changed, 17 ins

[PATCH v3 11/14] rawdev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_configure and dev->dev_ops->dev_configure are equivalent. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/rawdev/rte_rawdev.c | 99 - 1 file changed, 48 insertions(+), 51 delet

[PATCH v3 12/14] mldev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/mldev/rte_mldev.c | 88 +-- 1 file changed, 44 insertions(+), 44 de

[PATCH v3 13/14] regexdev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/regexdev/rte_regexdev.c | 72 ++--- 1 file changed, 36 insertions(+), 36 de

[PATCH v3 14/14] security: remove unnecessary dereference

The expressions *instance->ops->set_pkt_metadata and instance->ops->set_pkt_metadata are equivalent in C. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/security/rte_security.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a

RE: [PATCH] power: use hugepage memory for queue list entry structure

> > > -Original Message- > > > From: Stephen Hemminger > > > Sent: Thursday, February 20, 2025 4:12 PM > > > To: lihuisong (C) > > > Cc: dev@dpdk.org; tho...@monjalon.net; david.h...@intel.com; > > > anatoly.bura...@intel.com; sivaprasad.tumm...@amd.com; > > > liuyonglong > > > Subje

[PATCH v9 03/15] eal: add new secure free function

Although internally rte_free does poison the buffer in most cases, it is useful to have function that explicitly does this to avoid any security issues. Name of new API is chosen to be similar to Linux kernel kfree_sensitive() to make porting drivers easier. Signed-off-by: Stephen Hemminger Acke

[PATCH v3 05/14] net/ipn3ke: remove unnecessary dereference

Since it is a function pointer, the expression *hw->f_mac_read and hw->f_mac_read are equivalent in C. Remove excession indentation here. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- drivers/net/intel/ipn3ke/ipn3ke_ethdev.c | 27 +

[PATCH v3 03/14] net/bonding: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- drivers/net/bonding/rte_eth_bond_pmd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v3 06/14] net/memif: remove unnecessary deref of function pointers

Since queue release functions are local to driver, prefer those over dereferencing the dev_ops table. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- drivers/net/memif/rte_eth_memif.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --gi

[PATCH v9 11/15] compress/octeontx: remove unnecessary memset

Calling memset before rte_free not necessary, and could be removed by the compiler. In this case, the data is not security sensitive so the memset can be removed. Some security scanning tools will flag this. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/compress/octeon

Re: [PATCH v13 00/28] [v13]drivers/net Add Support mucse N10 Pmd Driver

Ran PVS studio against this patchset. The resulting warnings for drivers/net/rnp were: MESSAGES LocationCodeMessage Fails/Info rnp_mac.c (251) V610 Undefined behavior. Check the shift operator '>>='. The right operand ('' = [0..65535]) is greate

[PATCH v9 09/15] crypto/qat: use secure free for keys

Regular memset maybe removed by compiler if done before a free function. Use new rte_free_sensitive instead. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/crypto/qat/qat_asym.c| 5 + drivers/crypto/qat/qat_sym_session.c | 8 2 files changed, 5 inse

Re: [PATCH v7 2/4] lib: fix comparison between devices

On Wed, 12 Feb 2025 18:38:33 +0200 Shani Peretz wrote: > DPDK supports multiple formats for specifying buses, > (such as ":08:00.0" and "08:00.0" for PCI). > This flexibility can lead to inconsistencies when using one > format while running testpmd, then attempts to use the other > format in

[PATCH v9 06/15] common/cnxk: remove unused variable

A couple places in this code were generating warnings from PVS studio about memset potentially being ignored. This is because the ipv6_buf was declared but never used. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_npc_utils.c | 4 1 file changed, 4 deletions(-) diff --git a/

[PATCH v3 3/6] eal: update versioning macros

When compiling with MSVC the error below shows up due to function versioning: ../lib/net/rte_net_crc.c(418): error C2061: syntax error: identifier '__attribute__' MSVC allows alias function names to be exported, but the mechanism is different than the one used by gcc. It was considered to enh

[PATCH v3 0/6] mbuf: enable to be compiled with MSVC

When compiling with MSVC the error below shows up due to function versioning: ../lib/net/rte_net_crc.c(418): error C2061: syntax error: identifier '__attribute__' MSVC allows alias function names to be exported, but the mechanism is different than the one used by gcc. It was considered to enh

[PATCH v3 2/6] buildtools: update map_to_win.py to use optional map file

When compiling with MSVC the error below shows up due to function versioning: ../lib/net/rte_net_crc.c(418): error C2061: syntax error: identifier '__attribute__' MSVC allows alias function names to be exported, but the mechanism is different than the one used by gcc. It was considered to enh

[PATCH v3 1/6] doc: update guide on versioning macros

Added explanation about new macro MAP_STATIC_BASE_SYMBOL. Signed-off-by: Andre Muezerie --- doc/guides/contributing/abi_versioning.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/contributing/abi_versioning.rst b/doc/guides/contributing/abi_versioning.rst index 7afd1c18

[PATCH v3 6/6] mbuf: enable to be compiled with MSVC

Now that the issues preventing this lib from be compiled with MSVC are fixed it can be included in the compilation. The "net" library will automatically get compiled as well as it has a dependency on "mbuf" which will now get fulfilled. Signed-off-by: Andre Muezerie Acked-by: Bruce Richardson -

[PATCH v3 5/6] net: update use of versioning macros

When compiling with MSVC the error below shows up due to function versioning: ../lib/net/rte_net_crc.c(418): error C2061: syntax error: identifier '__attribute__' MSVC allows alias function names to be exported, but the mechanism is different than the one used by gcc. It was considered to enh

[PATCH] app/testpmd: fix out-of-bound reference in offload config

When configuring offloads, need to check the port id before indexing into the ports[] array. This can easily be done by moving the call to oh_dev_conf_get_print_err() to before the checks for port stopped. Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") Cc: sta...@dpdk.or

Re: [PATCH 0/2] fix testpmd DCB command

On Thu, 20 Feb 2025 15:06:49 +0800 Chengwen Feng wrote: > This patchset contains two commit which found when debug DCB module. > > Chengwen Feng (2): > app/testpmd: support display DCB all priority's TC map > app/testpmd: fix segment fault when config DCB > > app/test-pmd/cmdline.c | 6 +++

Re: [PATCH] app/testpmd: fix fail to set queue number when attach device

On Tue, 18 Feb 2025 19:31:56 +0800 Huisong Li wrote: > Testpmd doesn't modify the Rx/Tx queue number of all ports after attach a > new device. The root cause is that "port config all rxq " would > check if all ports are stopped and the status of this port is still in > 'RTE_PORT_HANDLING'. This s

[PATCH v4 1/2] dts: add clearing port stats to testpmd shell

Methods currently exist for querying the statistics of a port in testpmd, but there weren't methods added for clearing the current statistics on a port. This patch adds methods that allow you to clear the statistics of a single port or all ports to account for situations where the user only wants t

[PATCH v4 2/2] dts: add port stats checks test suite

This patch adds a new test suite to DTS that validates the accuracy of the port statistics using testpmd. The functionality is tested by sending a packet of a fixed side to the SUT and verifying that the statistic for packets received, received bytes, packets sent, and sent bytes all update accordi

[PATCH v4 02/10] test_alarm: avoid warning about different qualifiers

Compiling with MSVC results in the warning below: app/test/test_alarm.c(54): warning C4090: 'function': different '_Atomic' qualifiers The fix is to use a macro to explicitly drop the qualifier. Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test/test_alarm.c | 12

[PATCH v4 00/10] enable "app" to be compiled with MSVC

v4: - add explanation about the expression used in __rte_constant during v3. v3: - use clever expression with _Generic for __rte_constant and use it where __builtin_constant_p was being used. - use %u in csumonly.c and just cast variables to unsigned int. v2: - use lcore_count as atomic always,

[PATCH v4 05/10] test-pmd: avoid undefined behavior

Compiling with MSVC results in warnings like below: app/test-pmd/cmdline.c(9023): warning C5101: use of preprocessor directive in function-like macro argument list is undefined behavior Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 12

[PATCH v4 04/10] test-pmd: do explicit 64-bit shift to avoid implicit conversion

Compiling with MSVC results in warnings like the one below: app/test-pmd/util.c(201): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test

[PATCH v4 01/10] eal: add workaround for __builtin_constant_p

There's no MSVC equivalent for compiler extension __builtin_constant_p, but the same result can be obtained through a clever expression using _Generic. This patch redefines the macro __rte_constant when msvc is used and uses it as a replacement for __builtin_constant_p. Signed-off-by: Andre Mueze

[PATCH v4 07/10] test-pmd: don't return value from void function

Compiling with MSVC results in the warning below: app/test-pmd/cmdline_flow.c(13964): warning C4098: 'cmd_set_raw_parsed': 'void' function returning a value Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test-pmd/cmdline_flow.c | 12 -

[PATCH v4 09/10] test: add workaround for __builtin_constant_p in test_memcpy_perf

There's no MSVC equivalent for compiler extension __builtin_constant_p, so a workaround is needed. Signed-off-by: Andre Muezerie --- app/test/test_memcpy_perf.c | 54 ++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/app/test/test_memcpy_perf.c

[PATCH v4 03/10] test-pmd: fix printf format string mismatch

Compiling with MSVC results in warnings like the one below: app/test-pmd/csumonly.c(1085): warning C4477: 'printf' : format string '%d' requires an argument of type 'int', but variadic argument 1 has type 'uint64_t' Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/tes

[PATCH v4 06/10] test-pmd: avoid non-constant initializer

Compiling with MSVC results in errors like the one below: app/test-pmd/cmdline_flow.c(8819): error C2099: initializer is not a constant Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline_flow.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-

[PATCH v4 0/2] dts: add stats checks test suite

v3: * fix name of the first patch v4: * rebase and refactor off next-dts Dean Marx (2): dts: add clearing port stats to testpmd shell dts: add port stats checks test suite dts/framework/remote_session/testpmd_shell.py | 57 -- dts/tests/TestSuite_port_stats_checks.py | 168 +++

  1   2   >