RE: [PATCH 2/2] lib/hash: avoid implicit conversion to 64 bit number

2025-01-25 Thread Morten Brørup
> > How about reducing the formula to directly shift the sizeof() > instead, i.e.: > > sizeof(uint32_t) << ctx->reta_sz_log, > > Shifting the sizeof() directly is better indeed. Let me know how we > should > proceed. Do you want me to send out a new series incorporating this > suggestion? Yes, pl

[PATCH v6 04/15] lpm: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where lpm table is allocated but not freed correctly. Signed-off-by: Stephen Hemminger --- lib/lpm/rte_lpm.h | 23 --- lib/lpm/rte_lpm6.h | 23 --- 2 files changed, 24 insertions(+), 22 deletions(-) diff --git a/lib

[PATCH v6 02/15] rib: annotate rib allocation functions

2025-01-25 Thread Stephen Hemminger
Add function attributes to catch cases where rib is allocated and not freed correctly. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib.h | 26 +++--- lib/rib/rte_rib6.h | 24 +--- 2 files changed, 28 insertions(+), 22 deletions(-) diff --git a/lib/r

[PATCH v6 01/15] fib: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where fib table is allocated but not freed correctly. Signed-off-by: Stephen Hemminger --- lib/fib/rte_fib.h | 26 +++--- lib/fib/rte_fib6.h | 24 +--- lib/fib/trie.h | 7 --- 3 files changed, 32 insertions(

[PATCH v6 06/15] bitratestats: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where bitratestats is allocated but not freed correctly. Signed-off-by: Stephen Hemminger --- lib/bitratestats/rte_bitrate.h | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/lib/bitratestats/rte_bitrate.h b/lib/bi

[PATCH v6 09/15] eventdev: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where eventdev is allocated but not freed correctly. Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_ring.h | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/lib/eventdev/rte_event_ring.h b/lib/eve

[PATCH v6 08/15] mempool: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where mempool is allocated but not freed correctly. Signed-off-by: Stephen Hemminger Reviewed-by: Morten Brørup Acked-by: Konstantin Ananyev --- lib/mempool/rte_mempool.h | 37 - 1 file changed, 20 insertions(+), 17 del

[PATCH v6 05/15] acl: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where acl table is allocated but not freed correctly. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/acl/rte_acl.h | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/lib/acl/rte_acl.h b/

[PATCH v6 10/15] ring: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where ring is allocated but not freed correctly. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/ring/rte_ring.h | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/lib/ring/rte_ring.h b/lib/r

[PATCH v6 07/15] member: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where member table is allocated but not freed correctly. Signed-off-by: Stephen Hemminger --- lib/member/rte_member.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/member/rte_member.h b/lib/member/rte_mem

[PATCH v6 11/15] reorder: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where reorder table is allocated but not freed correctly. Signed-off-by: Stephen Hemminger Acked-by: Volodymyr Fialko --- lib/reorder/rte_reorder.h | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/lib/reorder/r

[PATCH v6 13/15] telemetry: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where telemetry data is allocated but not freed correctly. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/telemetry/rte_telemetry.h | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/lib/telemet

[PATCH v6 14/15] sched: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where sched port config is allocated but not freed correctly. Signed-off-by: Stephen Hemminger --- lib/sched/rte_sched.h | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/lib/sched/rte_sched.h b/lib/sched/rte_sch

[PATCH v6 15/15] doc: add release note about allocation attributes

2025-01-25 Thread Stephen Hemminger
Since many functions now have allocation attribute, add a release note to inform users. Signed-off-by: Stephen Hemminger --- doc/guides/rel_notes/release_25_03.rst | 30 ++ 1 file changed, 30 insertions(+) diff --git a/doc/guides/rel_notes/release_25_03.rst b/doc/guides

[PATCH v6 12/15] compressdev: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where compressdev is allocated but not freed correctly. Signed-off-by: Stephen Hemminger --- lib/compressdev/rte_comp.h | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/lib/compressdev/rte_comp.h b/lib/comp

Re: compilation|FAILURE| pw(150482) sid(34444) job(PER_PATCH_BUILD14715)[v6, 25/25] net/intel: extract common Rx vector criteria

2025-01-25 Thread Liao, TingtingX
Sorry. There is no error with this series. The error is caused by the CI doesn't apply any changes with doc/*. Community decided to exclude doc/*, as doc/* change frequently, especially the release notes, cause a lot of conflict with main tree. Thanks, Tingting F

[PATCH v6 00/15] Add allocation annotation to more functions

2025-01-25 Thread Stephen Hemminger
This patch series builds on the allocation function attributes added in 24.11 release. These annotations will allow for compiler to flag cases where a pointer is allocated with one function but incorrectly passed to a different free function. The current code base does this correctly now, but addi

[PATCH v6 03/15] hash: add allocation function attributes

2025-01-25 Thread Stephen Hemminger
Use function attributes to catch cases where hash table is allocated but not freed correctly. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/hash/rte_fbk_hash.h | 25 ++--- lib/hash/rte_hash.h | 22 -- 2 files changed, 26 insert