RE: [PATCH v15 1/3] eal: add diagnostics macros to make code portable

> From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > Sent: Tuesday, 21 January 2025 15.28 > > On Tue, Jan 21, 2025 at 10:53:14AM +0100, Morten Brørup wrote: > > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > > > Sent: Saturday, 18 January 2025 22.55 > > > > > > It was a c

[PATCH v0 1/1] dma/cnxk: increase vchan count

From: Vamsi Attunuru Increase vchan count to 128 to enable the DPDK applications to leverage the max number the vchan instances. Signed-off-by: Vamsi Attunuru --- drivers/dma/cnxk/cnxk_dmadev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/cnxk/cnxk_dmadev.h b

Re: [PATCH v1] common/iavf: introduce hardware clock ID in PTP caps

On Wed, Jan 15, 2025 at 07:23:23AM +, Soumyadeep Hore wrote: > From: Jun Zhang > > When there are at least two VFs on a single adapter and both are used in > the same VM, each of them will register its own PTP clock. However, every > E810/E822 adapter has only one PHC clock that we use. In or

Re: [PATCH v1] net/ice: fix incorrect reading of PHY timestamp

On Tue, Sep 03, 2024 at 09:54:40AM +0100, Hore, Soumyadeep wrote: > Hi Bruce, > > Let's keep it separate for better tracking of the bug fix. > Hi, For 25.03 release, can this bug fix please be rolled into a base code update, since some of the code looks DPDK-specific despite being in a "base" di

RE: [PATCH v15 1/3] eal: add diagnostics macros to make code portable

> From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > Sent: Saturday, 18 January 2025 22.55 > > It was a common pattern to have "GCC diagnostic ignored" pragmas > sprinkled over the code and only activate these pragmas for certain > compilers (gcc and clang). Clang supports GCC's pragma f

RE: [EXTERNAL] [PATCH v2 2/2] eventdev: add standard aliases for telemetry commands

> -Original Message- > From: Bruce Richardson > Sent: Wednesday, November 6, 2024 10:01 PM > To: dev@dpdk.org > Cc: Bruce Richardson ; Jerin Jacob > > Subject: [EXTERNAL] [PATCH v2 2/2] eventdev: add standard aliases for > telemetry commands > > Most other device classes in DPDK which of

Re: [PATCH v2 2/2] net/af_xdp: Refactor af_xdp_tx_zc()

Hi Maryam, On Mon, Jan 20, 2025 at 4:28 PM Maryam Tahhan wrote: > > On 16/01/2025 17:51, Ariel Otilibili wrote: > This ends up duplicating the if condition `if (mbuf->pool == > umem->mb_pool) {` twice in `af_xdp_tx_zc`. Which is messy to read tbh... > > I think it would be better to create an in

[PATCH v3] mbuf: add fast free bulk and raw alloc bulk functions

When putting an mbuf back into its mempool, there are certain requirements to the mbuf. Specifically, some of its fields must be initialized. These requirements are in fact invariants about free mbufs, held in mempools, and thus also apply when allocating an mbuf from a mempool. With this in mind,

Re: [PATCH v15 1/3] eal: add diagnostics macros to make code portable

On Tue, 21 Jan 2025 06:28:16 -0800 Andre Muezerie wrote: > On Tue, Jan 21, 2025 at 10:53:14AM +0100, Morten Brørup wrote: > > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > > > Sent: Saturday, 18 January 2025 22.55 > > > > > > It was a common pattern to have "GCC diagnostic ignor

Re: [PATCH] net/ice: fix memory leak in scalar Rx

On Fri, Jan 17, 2025 at 05:52:05PM +, Vladimir Medvedkin wrote: > If the buffer splitting feature is configured and the payload mbuf > allocation fails, the previously allocated header mbuf may be returned not > fully initialized or a memory leak may occur. > This patch handles this case correc

Re: [PATCH v15 1/3] eal: add diagnostics macros to make code portable

On Tue, Jan 21, 2025 at 10:53:14AM +0100, Morten Brørup wrote: > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > > Sent: Saturday, 18 January 2025 22.55 > > > > It was a common pattern to have "GCC diagnostic ignored" pragmas > > sprinkled over the code and only activate these pragm

Re: [PATCH v2] net/af_packet: provide packet drop stats

On Tue, 21 Jan 2025 13:26:16 +0100 Stefan Laesser wrote: > + /* query dropped packets counter from socket */ > + if (internal->rx_queue[i].sockfd != -1 && > + getsockopt(internal->rx_queue[i].sockfd, SOL_PACKET, > +

Re: compilation|FAILURE| pw(150284) sid(34398) job(PER_PATCH_BUILD14646)[v5, 25/25] net/intel/common: extract common Rx vector criteria

On Tue, Jan 21, 2025 at 02:26:59AM +, Liao, TingtingX wrote: >Sorry. There is no error with this series. > >The error is caused by the CI doesn't apply any changes with doc/*. > >Community decided to exclude doc/*, as doc/* change frequently, >especially the release notes, ca

Re: [PATCH v2 1/2] net/af_xdp: fix use after free in af_xdp_tx_zc()

Hi Maryam, On Mon, Jan 20, 2025 at 3:54 PM Maryam Tahhan wrote: > I think that you could've just set tx_bytes to the desc->len as this is > being set in all scenarios... > > tx_bytes += desc->len; > Thanks for your feedback. I'll change that.

[PATCH v1 06/31] net/ntnic: fix array index verification

From: Danylo Vodopianov CI found couple coverity problems which were fixed in this commit. CID: 448983 Out-of-bounds write (OVERRUN). These issues were fixed with updating index verification statement. Coverity issue: 448983 Fixes: 96c8249be53e ("net/ntnic: learn flow queue handling") Signed-

[PATCH v1 05/31] net/ntnic: fix realloc memory leak

From: Danylo Vodopianov Issue was fixed with verification in case of the successful memory re-allocation. Coverity issue: 448959 Fixes: 4033e0539435 ("net/ntnic: add flow meter") Signed-off-by: Danylo Vodopianov --- .../profile_inline/flow_api_profile_inline.c | 15 ++- 1 fil

[PATCH v1 14/31] net/ntnic: add null checking

From: Danylo Vodopianov Add null checking for fpga var. Coverity issue: 448916 Fixes: 30b2f87ac650 ("net/ntnic: add GMF module") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/link_mgmt/link_100g/nt4ga_link_100g.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH v1 12/31] net/ntnic: fix overflow issue

From: Danylo Vodopianov Fix overflow issue with checking max bit shifting value. Coverity issue: 448921 Fixes: 833962ebb893 ("net/ntnic: add CAT module") Signed-off-by: Danylo Vodopianov --- .../nthw/flow_api/profile_inline/flow_api_profile_inline.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH v1 03/31] net/ntnic: add return code handling

From: Danylo Vodopianov CI found couple coverity problems which were fixed in this commit. CID: 448984, 448982, 448975, 448969, 448968, 448967 API usage errors (BAD_COMPARE). Add memcmp return value checking. Coverity issue: 448984 Fixes: 6e8b7f11205f ("net/ntnic: add categorizer (CAT) FPGA m

[PATCH v1 04/31] net/ntnic: add array index verification

From: Danylo Vodopianov CI found couple coverity problems which were fixed in this commit. CID: 448983, 448980 Memory - corruptions (OVERRUN) Add check both indices within bounds before calling the macro Coverity issue: 448983 Fixes: 6e8b7f11205f ("net/ntnic: add categorizer (CAT) FPGA module

[PATCH v1 08/31] net/ntnic: add proper var freed

From: Danylo Vodopianov p_fpga_mgr is properly freed when it's no longer needed CID 440546: Resource leak (RESOURCE_LEAK) Fixes: ddf184d0b6c2 ("net/ntnic: add FPGA initialization") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/core/nthw_fpga.c | 2 ++ 1 file changed, 2 insertion

[PATCH v1 09/31] net/ntnic: remove deadcode

From: Danylo Vodopianov Deadcode was removed. CID: 448981 Logically dead code (DEADCODE) Coverity issue: 448981 Fixes: e02fdb65c2a8 ("net/ntnic: add flow create/destroy") Signed-off-by: Danylo Vodopianov --- .../flow_api/profile_inline/flow_api_profile_inline.c| 9 ++--- 1 file chang

[PATCH v1 17/31] net/ntnic: fix var overflow

From: Danylo Vodopianov Casting either buf_size and num_descr to uint64_t before performing the multiplication was done. Coverity issue: 446740 Fixes: 6b0047fadf41 ("net/ntnic: add queue setup operations") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/ntnic_ethdev.c | 2 +- 1 file ch

[PATCH v1 15/31] net/ntnic: move null checking

From: Danylo Vodopianov Move null checking before using Coverity issue: 446759 Fixes: f0fe222ea9cf ("net/ntnic: add releasing virtqueues") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v1 13/31] net/ntnic: fix untrusted loop bound

From: Danylo Vodopianov Replace while with if statement to avoid infinite loop in case ther_type will be modified with extenral source. Coverity issue: 448917 Fixes: c6821abf58e8 ("net/ntnic: add flow items GTP and actions raw encap/decap") Signed-off-by: Danylo Vodopianov --- drivers/net/nt

[PATCH v1 19/31] net/ntnic: remove convert error func

From: Danylo Vodopianov convert_error func was removed as far as this approach was deprecated. Coverity issue: 448973 Fixes: e526adf1fdef ("net/ntnic: add minimal create/destroy flow operations") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/create_elements.h | 1 - drive

[PATCH v1 16/31] net/ntnic: fix var size

From: Danylo Vodopianov Function operate with uint16_r value, meanwhile return value with uint32_t size. This conversion was aligned to the uint8_t as far as max value of the return value could be equal 16. Coverity issue: 446747 Fixes: 67aee0a69665 ("net/ntnic: add used writer data handling")

[PATCH v1 25/31] net/ntnic: refactor RSS implementation

From: Danylo Vodopianov Virtualization backward compatible RSS implementation is no longer needed, thus RSS was refactored as follows: * conversion of RTE_ETH_RSS fields into HSH registers was moved to separate files * profile wrapper for RSS configuration was removed * flow_nic_set_hasher(), t

[PATCH v1 30/31] net/ntnic: refactoring of the FPGA initialization

Remove unnecessary checks and logs. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/nthw/core/nthw_fpga.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/net/ntnic/nthw/core/nthw_fpga.c b/drivers/net/ntnic/nthw/core/nthw_fpga.c index 88641145ec..5ca

[PATCH v1 22/31] net/ntnic: remove extra address-of operator

From: Oleksandr Kolomeiets Macro DO_COMPARE_INDEXS expects pointer to array. If condition is true, one of array's elements get overwritten. Misinterpreting pointer to pointer as pointer to array may result in out-of-bounds access. Coverity issue: 448966, 448970, 448971, 448972 Fixes: 6e8b7f11205

[PATCH v1 26/31] net/ntnic: fix age timeout recalculation into fpga unit

From: Danylo Vodopianov The FPGA scrub T parameter shall be encoded timeout using internal unit, which is measured in 2^30 nanoseconds. It is approx 1.074 times longer than age timeout specified in seconds. Internal method hw_mod_flm_inf_sta_data_update_get() was updated to perform conversion bet

[PATCH v1 24/31] net/ntnic: remove unused code

From: Danylo Vodopianov NTNIC currently cupport only 100G link. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c b/drivers/net/ntnic/adapter/nt4g

[PATCH v1 29/31] net/ntnic: extend module mapping

FPGA module mapping(to string) was extended with new fpga's modules. Signed-off-by: Serhii Iliushyk --- .../nthw/supported/nthw_fpga_mod_str_map.c| 24 +++ 1 file changed, 24 insertions(+) diff --git a/drivers/net/ntnic/nthw/supported/nthw_fpga_mod_str_map.c b/drivers/net/n

[PATCH v1 28/31] net/ntnic: fix group print

From: Danylo Vodopianov Flow dump output was fixed to show original group number for `jumps` stored in action and match sets. Fixes: 6f0fe142caed ("net/ntnic: add flow dump") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api_engine.h | 2 ++ drivers/net/ntnic/nthw/flo

[PATCH v1 11/31] net/ntnic: add null checking

From: Danylo Vodopianov Fix issue with potential rereferencing a pointer that might be NULL p->m_rpp_lr when calling nthw_module_query_register CID 448923: Dereference null return value (NULL_RETURNS) Coverity issue: 448923 Fixes: f543ca6b9ab2 ("net/ntnic: add RPP local retransmit (RPP LR) flo

[PATCH v1 20/31] net/ntnic: fix array verification

From: Danylo Vodopianov if statement was modify to ensure that word_off doesn't exceed the size of the array Coverity issue: 448958 Fixes: 7fa0bf29e667 ("net/ntnic: add hash module") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/flow_api/hw_mod/hw_mod_hsh.c | 2 +- 1 file change

[PATCH v1 21/31] net/ntnic: fix memory leak

From: Danylo Vodopianov free for kvlist was added before return to avoid memory leak. Coveriry issue: 446751 Fixes: fe91ade9f5db ("net/ntnic: add basic queue operations") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/ntnic_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v1 18/31] net/ntnic: remove dead code

From: Danylo Vodopianov Dead code path in the condition irq_vector >= 0 because the condition irq_vector < 0 is already established Coverity issue: 446745 Fixes: 01e34ed9c756 ("net/ntnic: add availability monitor management") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/nt

[PATCH v1 23/31] net/ntnic: remove extra check for null

From: Oleksandr Kolomeiets pld_ptr points to mp_port_load's element, which is initialized during driver's probe, otherwise probe fails and xstats_get_by_id is not called. Coverity issue: 448945 Fixes: cf6007eac498 ("net/ntnic: add xstats") Signed-off-by: Oleksandr Kolomeiets --- drivers/net/n

[PATCH v1 10/31] net/ntnic: fix potentially overflow

From: Danylo Vodopianov Issue with potentially overflow was fixed. CID 448944: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) Coverity issue: 448944 Fixes: 339ca124e659 ("net/ntnic: add flow action modify field") Signed-off-by: Danylo Vodopianov --- .../nthw/flow_api/profile_inline/f

[PATCH v1 27/31] net/ntnic: rework age event generation

From: Danylo Vodopianov Add age event generating only for physical ports. Fixes: 4033e0539435 ("net/ntnic: add flow meter") Signed-off-by: Danylo Vodopianov --- .../nthw/flow_api/profile_inline/flow_api_profile_inline.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH] event/dlb2: fix event weight handling in SSE code path

Commit 6e2e98d6775b ("event/dlb2: support independent enqueue") updated the avx512 code path with support for the event, or "qe" weights. However, the SSE code path looks to have been missed in the update. Update the SSE "build_hcws" function to match the changes made to the AVX-512 version. Bugzi

[PATCH v1 01/31] net/ntnic: fix index verification

From: Danylo Vodopianov CI found couple coverity problems which were fixed in this commit. CID: 448974, 448977, 448978 (OVERRUN). These issues were fixed with updating index verification statement. Coverity issue: 448974 Fixes: effa04693274 ("net/ntnic: add statistics") Signed-off-by: Danylo

[PATCH v6 2/2] dts: add flow create/delete to testpmd shell

Add flow create/delete methods to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 51 +++ 1 file changed, 51 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/rem

[PATCH v6 1/2] dts: add flow rule dataclass to testpmd shell

Add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 52 ++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH v1 02/31] net/ntnic: add thread check return code

On Tue, 21 Jan 2025 18:07:40 +0100 Serhii Iliushyk wrote: > From: Danylo Vodopianov > > CI found couple coverity problems which were fixed in this commit. > > CID: 448965 Error handling issues (CHECKED_RETURN). > > Thread return code check was added. > > Coverity issue: 448965 > Fixes: a1ba8

Re: [PATCH v1 03/31] net/ntnic: add return code handling

On Tue, 21 Jan 2025 18:07:41 +0100 Serhii Iliushyk wrote: > From: Danylo Vodopianov > > CI found couple coverity problems which were fixed in this commit. > > CID: 448984, 448982, 448975, 448969, 448968, 448967 > API usage errors (BAD_COMPARE). > > Add memcmp return value checking. > > Cove

[DPDK/DTS Bug 1617] Python 3.13 DTS docs generation error

https://bugs.dpdk.org/show_bug.cgi?id=1617 Bug ID: 1617 Summary: Python 3.13 DTS docs generation error Product: DPDK Version: 25.03 Hardware: All OS: All Status: UNCONFIRMED Severity: minor Prior

[PATCH v1 00/31] net/ntnic: bugfixes and refactoring

These patches include fixes for issues detected by the Coverity Scan tool and internal tests. Danylo Vodopianov (26): net/ntnic: fix index verification net/ntnic: add thread check return code net/ntnic: add return code handling net/ntnic: add array index verification net/ntnic: fix real

[PATCH v1 07/31] net/ntnic: add var definition transparently

From: Danylo Vodopianov set eth_base to NULL after freeing to prevent use-after-free CID: 446746 Use after free (USE_AFTER_FREE) Coverity issue: 446746 Fixes: 1d3f62a0c4f1 ("net/ntnic: add base init and deinit of flow API") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/flow_api

RE: [EXTERNAL] [PATCH v24 05/13] common/zsda: add definition and use of msg chan.

> Add msg chan functions and the use to get > hardware information or operate hardware. > > Signed-off-by: Hanxiao Li Please rebase and fix 65 | } __rte_packed; | ^~~~ In file included from ../drivers/common/zsda/zsda_qp.h:8, from ../drivers/common/zsda/zsda_q

RE: [EXTERNAL] [PATCH v24 11/13] compress/zsda: add zsda compressdev enqueue datapath

> Add zsda compressdev enqueue datapath. > > Signed-off-by: Hanxiao Li > --- > drivers/common/zsda/meson.build | 2 +- > drivers/common/zsda/zsda_qp.c | 106 > drivers/common/zsda/zsda_qp.h | 13 +- > drivers/common/zsda/zsda_qp_common.c | 72 > d

Re: [PATCH v15 1/3] eal: add diagnostics macros to make code portable

On Tue, Jan 21, 2025 at 03:41:09PM +0100, Morten Brørup wrote: > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > > Sent: Tuesday, 21 January 2025 15.28 > > > > On Tue, Jan 21, 2025 at 10:53:14AM +0100, Morten Brørup wrote: > > > > From: Andre Muezerie [mailto:andre...@linux.microsof

[PATCH] net/i40e: reduce log level of global register update msg

The modifying of a global register value, which has an affect on multiple ports is an important change to HW. However, the actual details of that change is only relevant to developers and not general users. Therefore reduce the log level from "warning" - which implies something is wrong - to "info"

[PATCH] build: allow disabling avx512 support via compiler flag

DPDK build checks for build support for various instruction sets by checking both the target machine and the compiler for support. However, any disabling of instruction sets via compiler flags was not taken into account in many cases. For AVX512 support, check for a user-specified "no-avx512f" flag

Re: net/i40e: unhelpful warning messages

On Fri, Jan 10, 2025 at 06:11:29PM -0800, Stephen Hemminger wrote: > Got new machine setup with XL710 NIC's and testing out DPDK. > > When device is first used by DPDK see these messages. > Which are at warning level which by definition means something is wrong. > And the messages are unhelpful; t

[PATCH v1 31/31] net/ntnic: remove tag EXPERIMENTAL

Since nitnic PMD driver for is fully added and verified, the tag EXPERIMENTAL may be removed Signed-off-by: Serhii Iliushyk --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b86cdd266b..b04951de85 100644 --- a/MAINTAINERS +++ b/MA

[PATCH v1 02/31] net/ntnic: add thread check return code

From: Danylo Vodopianov CI found couple coverity problems which were fixed in this commit. CID: 448965 Error handling issues (CHECKED_RETURN). Thread return code check was added. Coverity issue: 448965 Fixes: a1ba8c473f5c ("net/ntnic: add statistics poll") Signed-off-by: Danylo Vodopianov --

Re: [v24,01/13] config: add zsda device number

Hi, Maintainer: > > > > Not Found > > > Not FoundThe requested resource was not found on this > server. > > Do we need to solve this error? We haven't found the detailed reason for the error in the output log. I noticed that the patches submitted by others also have this error. Than

RE: [EXTERNAL] [PATCH 12/15] reorder: add allocation function attributes

> Use function attributes to catch cases where reorder table is allocated > but not freed correctly. > > Signed-off-by: Stephen Hemminger > --- > lib/reorder/rte_reorder.h | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-) Acked-by: Volodymyr Fialko

Re: [PATCH v2] net/i40e/base: fix the debug print format

On Wed, Jan 15, 2025 at 03:44:17PM +0800, Jaroslaw Ilgiewicz wrote: > This patch modifies format specifier in debug prints to match to the > change of time variables from 64 bit to 32 bit. > > Fixes: d980a401b137 ("net/i40e/base: add NVM acquire with custom timeout") > Cc: sta...@dpdk.org > > Sig

Re: [PATCH v3] net/iavf: support rte flow with mask for FDIR

On Thu, Aug 29, 2024 at 10:14:38AM +0200, David Marchand wrote: > Hello, > > On Fri, Dec 15, 2023 at 4:19 AM Zhichao Zeng > wrote: > > > > This patch supports rte flow with mask for FDIR, including > > eth/ipv4/ipv6/tcp/udp flow items, where src/dst for ipv4/ipv6 and > > sport/dport for tcp/udp a

[PATCH v2] net/af_packet: provide packet drop stats

The Linux kernel provides the ability to query the packet drop counter of a socket. This information can be provided when the user requests stats. It is important to note that each call to getsockopt with PACKET_STATISTICS resets the internal counters. So the caller needs to keep track of the tota

[PATCH] net/nfp: fix misuse of function return values

From: Zerun Fu The 'nfp_ct_offload_add()' return 0 means the result is right while return negative number means the wrong result. The caller assigns the 'int' variable to the 'bool' variable. So the negative number will be transform to 'true'. This will cause an error because 'true' will be rega

[PATCH 2/2] net/nfp: support load firmware for card without DDR

The original logic don't support load firmware for cards which has no DDR, add the related logic to make it can load firmware successfully. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfpcore/nfp_nsp.c | 131 +- 1 file

[PATCH 1/2] net/nfp: fix logic of load firmware from flash

The firmware load policy 'NFP_NSP_APP_FW_LOAD_FLASH' means first try to load from file system, if failed then try to load from flash. The original logic will cause load firmware fail if any mistake occurs in the load from file system process. Fix this by relocated the related logic. Fixes: 08ea4

[PATCH 0/2] modify logic of load firmware from flash

This patch series aims to support load firmware for card without DDR chip. Chaoyong He (2): net/nfp: fix logic of load firmware from flash net/nfp: support load firmware for card without DDR drivers/net/nfp/nfp_ethdev.c | 30 +++ drivers/net/nfp/nfpcore/nfp_nsp.c | 131

Re: [PATCH v2] eal: fix unused memseg length

Hi experts, is there any chance to review and accept this patch? On 2025/1/2 16:58, Yang Ming wrote: Fix the issue where OS memory is mistakenly freed with rte_free by setting the length (len) of unused memseg to 0. When `eal_legacy_hugepage_init()` releases the VA space for unused memseg lists

[PATCH] net/nfp: fix multiple PFs check from NSP

From: Zerun Fu Fix multiple PFs check from NSP problem in the logic of PF initialization. Fixes: 8ad2cc8fec37 ("net/nfp: add flag for multiple PFs support") Cc: peng.zh...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng

RE: [RFC PATCH] eventdev: adapter API to configure multiple Rx queues

> -Original Message- > From: Shijith Thotton > Sent: Monday, January 20, 2025 11:53 PM > To: Naga Harish K, S V ; dev@dpdk.org > Cc: Pavan Nikhilesh Bhagavatula ; Pathak, > Pravin ; Hemant Agrawal > ; Sachin Saxena ; > Mattias R_nnblom ; Jerin Jacob > ; Liang Ma ; Mccarthy, Peter > ; Van

[PATCH] net/nfp: set the correct control flag

From: Peng Zhang In the original logic of 'nfp_net_start()', we don't set the 'NFP_NET_CFG_CTRL_MULTI_PF' flag when using multi-pf firmware. Fix it by adding the missing logic. Fixes: 95f978efab42 ("net/nfp: enable multiple PF in application firmware") Cc: sta...@dpdk.org Signed-off-by: Peng Z

[PATCH v3] net/af_packet: provide packet drop stats

The Linux kernel provides the ability to query the packet drop counter of a socket. This information can be provided when the user requests stats. It is important to note that each call to getsockopt with PACKET_STATISTICS resets the internal counters. So the caller needs to keep track of the tota

Re: [v9,00/15] net/zxdh: updated net zxdh driver

May I ask if there are any modifications needed? If not, We hope to submit an update to the latest driver based on this version, which includes complete functionality; We are also fully prepared for the split patch.

[PATCH v16 3/3] drivers/net: add diagnostics macros to make code portable

It was a common pattern to have "GCC diagnostic ignored" pragmas sprinkled over the code and only activate these pragmas for certain compilers (gcc and clang). Clang supports GCC's pragma for compatibility with existing source code, so #pragma GCC diagnostic and #pragma clang diagnostic are synonym

[PATCH v16 2/3] drivers/common: add diagnostics macros to make code portable

It was a common pattern to have "GCC diagnostic ignored" pragmas sprinkled over the code and only activate these pragmas for certain compilers (gcc and clang). Clang supports GCC's pragma for compatibility with existing source code, so #pragma GCC diagnostic and #pragma clang diagnostic are synonym

[PATCH v16 1/3] eal: add diagnostics macros to make code portable

It was a common pattern to have "GCC diagnostic ignored" pragmas sprinkled over the code and only activate these pragmas for certain compilers (gcc and clang). Clang supports GCC's pragma for compatibility with existing source code, so #pragma GCC diagnostic and #pragma clang diagnostic are synonym

[PATCH v16 0/3] add diagnostics macros to make code portable

v16: * Updated comment for RTE_CAST_PTR. v15: * Fixed a comment in rte_common.h to make Doxygen happy. * Fixed a typo (extra comma). * Added missing RTE_PTR_UNQUAL needed for ARM64. v14: * Renamed RTE_PTR_DROP_QUALIFIERS into RTE_PTR_UNQUAL to more resemble C23 typeof_unqual. * Added mac

RE: [PATCH v2] test/bonding: fix active backup rx test

> -Original Message- > From: Stephen Hemminger > Sent: Saturday, December 14, 2024 1:17 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; sta...@dpdk.org; > Chas Williams ; Min Hu (Connor) ; > Richardson, Bruce ; Chengwen Feng > > Subject: [PATCH v2] test/bonding: fix active backup rx tes

RE: [PATCH v2] net/af_packet: provide packet drop stats

> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, January 21, 2025 4:48 PM > To: Stefan Lässer > Cc: dev@dpdk.org > Subject: Re: [PATCH v2] net/af_packet: provide packet drop stats > > On Tue, 21 Jan 2025 13:26:16 +0100 > Stefan Laesser wrote: > > > + /* quer