[DPDK/vhost/virtio Bug 1603] net/vhost: some devargs are not documented

2024-12-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1603 Bug ID: 1603 Summary: net/vhost: some devargs are not documented Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: 22.11.7 patches review and test

2024-12-13 Thread David Marchand
Hello LTS maintainers, Stephen, On Fri, Dec 13, 2024 at 2:01 AM Xu, HailinX wrote: > > Hi all, > > > > Here is a list of patches targeted for stable release 22.11.7. > > > > The planned date for the final release is December 17th. > > > > Please help with testing and validation of your use cases

[v2 1/1] app/test: remove useless calls to rte_bitmap_free

2024-12-13 Thread Ariel Otilibili
* rte_bitmap_free is only useful for its return value * and its return value is not used. ``` $ < lib/eal/include/rte_bitmap.h sed -ne '/bitmap_free/,/^}/p' rte_bitmap_free(struct rte_bitmap *bmp) { /* Check input arguments */ if (bmp == NULL) { return -1;

[v2 0/1] app/test: remove useless calls to rte_bitmap_free

2024-12-13 Thread Ariel Otilibili
*** BLURB HERE *** Ariel Otilibili (1): app/test: remove useless calls to rte_bitmap_free app/test/test_bitmap.c | 2 -- 1 file changed, 2 deletions(-) -- v2: * fix style issues. 2.47.1

Re: [PATCH v1 1/4] net/e1000: prevent crashes in secondary processes

2024-12-13 Thread Burakov, Anatoly
On 12/12/2024 7:02 PM, Stephen Hemminger wrote: On Thu, 12 Dec 2024 16:19:03 + Anatoly Burakov wrote: Currently, the architecture of the base driver is such that it uses function pointers internally. These are not guaranteed to be valid in secondary processes, which can lead to crashes. Th

[PATCH 1/2] net/mlx5: improve socket file path

2024-12-13 Thread Yang Ming
1. /var/tmp is hard code which is not a good style 2. /var/tmp may be not allowed to be written via container's read only mode. Signed-off-by: Yang Ming --- drivers/net/mlx5/linux/mlx5_socket.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/linux/ml

[PATCH 2/2] net/mlx5: improve log file path

2024-12-13 Thread Yang Ming
1. /var/log is hard code which is not a good coding style. 2. /var/log may be not allowed to be written via container's read-only mode. Signed-off-by: Yang Ming --- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/d

Re: 22.11.7 patches review and test

2024-12-13 Thread Kevin Traynor
On 13/12/2024 08:33, David Marchand wrote: > Hello LTS maintainers, Stephen, > > On Fri, Dec 13, 2024 at 2:01 AM Xu, HailinX wrote: >>> Hi all, >>> >>> Here is a list of patches targeted for stable release 22.11.7. >>> >>> The planned date for the final release is December 17th. >>> >>> Please he

Re: [PATCH] app/test: fix stack overflow in lpm6_perf_autotest

2024-12-13 Thread Medvedkin, Vladimir
Hi Andre, On 13/12/2024 02:39, Andre Muezerie wrote: Test lpm6_perf_autotest was hitting a stack overflow on Windows with both MSVC and Clang. The fix is to move some of the data from the stack to the heap. Signed-off-by: Andre Muezerie --- app/test/test_lpm6_perf.c | 11 +-- 1 fil

Re: GCP cloud : Virtio-PMD performance Issue

2024-12-13 Thread Maxime Coquelin
(with DPDK ML that got removed) On 12/13/24 11:46, Maxime Coquelin wrote: On 12/13/24 11:21, Mukul Sinha wrote: Thanks @joshw...@google.com @Maxime Coquelin for the inputs. @Maxime Coquelin

Re: [PATCH v2 0/3] Improve lock annotations

2024-12-13 Thread David Marchand
On Thu, Dec 12, 2024 at 5:02 PM David Marchand wrote: > > A recent bug (see 22aa9a9c7099 ("vhost: fix deadlock in Rx async path")) > made more visible a gap in the clang thread safety annotations that > DPDK uses: no distinction is made between releasing a read lock and > releasing a write lock. >

[PATCH v2 6/6] buildtools: externally check exported headers

2024-12-13 Thread David Marchand
At the moment, the headers check (triggered via the check_includes meson option) is run "internally", iow with compilation flags and include path coming from the meson components. One issue is that both internal and public headers are usually stored in a single directory in the DPDK components. If

[PATCH v2 4/6] drivers: fix exported headers

2024-12-13 Thread David Marchand
Those headers could not be included individually as they were not including their dependencies, or were subject to some build warnings. Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Fixes: 5b2a1a02dcaf ("crypto/cnxk: fix experimental version for PMD API") Fixes: e5abbfa5 (

[PATCH v2 3/6] eventdev: do not include driver header in DMA adapter

2024-12-13 Thread David Marchand
The dma adapter header does not require including rte_dmadev_pmd.h which is a driver header. Fixes: 66a30a29387a ("eventdev/dma: introduce DMA adapter") Signed-off-by: David Marchand Acked-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.h | 2 +- 1 file changed, 1 insertion(+),

[PATCH v2 1/6] baseband/acc: fix exported header

2024-12-13 Thread David Marchand
rte_acc_cfg.h relies on rte_acc_common_cfg.h. Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code") Signed-off-by: David Marchand --- drivers/baseband/acc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/meson.build b/driv

[PATCH v2 2/6] drivers: drop export of driver headers

2024-12-13 Thread David Marchand
Many classes are exposing driver only headers as public headers. Move them to the driver_sdk_headers list. Signed-off-by: David Marchand --- lib/bbdev/meson.build| 5 ++--- lib/ethdev/meson.build | 6 +++--- lib/mldev/meson.build| 5 + lib/rawdev/meson.build | 3 ++- lib/regexdev

[PATCH v2 0/6] Add a stricter headers check

2024-12-13 Thread David Marchand
As explained in patch 6, the current headers check can not catch issues when a public header includes an internal header. Fixing this from meson does not seem an easy task. This series approach is to reimplement the check in a Makefile invoked out of DPDK (like what is done for external compilatio

Re: [PATCH v2 1/6] baseband/acc: fix exported header

2024-12-13 Thread Bruce Richardson
On Fri, Dec 13, 2024 at 11:50:05AM +0100, David Marchand wrote: > rte_acc_cfg.h relies on rte_acc_common_cfg.h. > > Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code") > > Signed-off-by: David Marchand > --- Indeed it does depend on it! Acked-by: Bruce Richardson

Re: [PATCH v2 3/6] eventdev: do not include driver header in DMA adapter

2024-12-13 Thread Bruce Richardson
On Fri, Dec 13, 2024 at 11:50:07AM +0100, David Marchand wrote: > The dma adapter header does not require including rte_dmadev_pmd.h which > is a driver header. > > Fixes: 66a30a29387a ("eventdev/dma: introduce DMA adapter") > > Signed-off-by: David Marchand > Acked-by: Amit Prakash Shukla Ack

[PATCH v2 5/6] build: install indirect headers to a dedicated directory

2024-12-13 Thread David Marchand
The headers check currently skips "indirect" headers as instructed via the indirect_headers meson variable. This headers check has some limitation that will be addressed in a next change by inspected all exported headers. However, exported headers lack the information about "indirect" quality. Se

Re: [PATCH v2 2/6] drivers: drop export of driver headers

2024-12-13 Thread Bruce Richardson
On Fri, Dec 13, 2024 at 11:50:06AM +0100, David Marchand wrote: > Many classes are exposing driver only headers as public headers. > Move them to the driver_sdk_headers list. > > Signed-off-by: David Marchand > --- LGTM. The names of most of the headers are pretty clear that they should be sdk-o

Re: [PATCH v2 4/6] drivers: fix exported headers

2024-12-13 Thread Bruce Richardson
On Fri, Dec 13, 2024 at 11:50:08AM +0100, David Marchand wrote: > Those headers could not be included individually as they were not > including their dependencies, or were subject to some build warnings. > > Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") > Fixes: 5b2a1a02dcaf (

Re: [PATCH v2 0/6] Add a stricter headers check

2024-12-13 Thread Bruce Richardson
On Fri, Dec 13, 2024 at 11:50:04AM +0100, David Marchand wrote: > As explained in patch 6, the current headers check can not catch > issues when a public header includes an internal header. > Fixing this from meson does not seem an easy task. > > This series approach is to reimplement the check in

[PATCH 0/1] app/test: remove useless calls to rte_bitmap_free

2024-12-13 Thread Ariel Otilibili
Hello, This patch fixes the Coverity IDs 357712 & 357737. Afterwards the application compiles without warnings. Thank you, Ariel Otilibili (1): app/test: remove useless calls to rte_bitmap_free app/test/test_bitmap.c | 2 -- 1 file changed, 2 deletions(-) -- 2.47.1

[PATCH 1/1] app/test: remove useless calls to rte_bitmap_free

2024-12-13 Thread Ariel Otilibili
* rte_bitmap_free is only useful for its return value * and its return value is not used. ``` $ < lib/eal/include/rte_bitmap.h sed -ne '/bitmap_free/,/^}/p' rte_bitmap_free(struct rte_bitmap *bmp) { /* Check input arguments */ if (bmp == NULL) { return -1;

[PATCH v1 1/2] crypto/ipsec_mb: add SM4 GCM support

2024-12-13 Thread Brian Dooley
This patch introduces SM4 GCM algorithm support to the AESNI_MB PMD. SM4 GCM is available in the v2.0 release of Intel IPsec MB. Signed-off-by: Brian Dooley --- doc/guides/cryptodevs/aesni_mb.rst | 1 + doc/guides/cryptodevs/features/aesni_mb.ini | 1 + doc/guides/cryptodevs/features/

[PATCH v1 2/2] app/test: add SM4 GCM tests

2024-12-13 Thread Brian Dooley
Added SM4-GCM tests for the AESNI MB PMD. Signed-off-by: Brian Dooley --- app/test/test_cryptodev.c | 158 + app/test/test_cryptodev_aead_test_vectors.h | 708 2 files changed, 866 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cr

Re: [PATCH 1/1] app/test: remove useless calls to rte_bitmap_free

2024-12-13 Thread Ariel Otilibili-Anieli
On Friday, December 13, 2024 17:59 CET, Stephen Hemminger wrote: > On Fri, 13 Dec 2024 12:30:00 +0100 > Ariel Otilibili wrote: > > > * rte_bitmap_free is only useful for its return value > > * and its return value is not used. > > > > ``` > > $ < lib/eal/include/rte_bitmap.h sed -ne '/bitmap_

[PATCH 3/5] net/dpaa2: remove unneeded deferred start check

2024-12-13 Thread Stephen Hemminger
Already checked in ethdev now. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index a9bce854c3..8624bba0ce 100644 --- a/drivers/net/dpaa2/

[PATCH 4/5] net/enetfec: remove unneeded deferred start check

2024-12-13 Thread Stephen Hemminger
Already checked in ethdev now. Signed-off-by: Stephen Hemminger --- drivers/net/enetfec/enet_ethdev.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/enetfec/enet_ethdev.c b/drivers/net/enetfec/enet_ethdev.c index 91c0f60490..d8c81f4a70 100644 --- a/drivers/net/enet

[PATCH 0/5] centralize deferred start checks

2024-12-13 Thread Stephen Hemminger
Recent zxdh driver review raised the question of why should drivers have to check rx_conf for deferred start support. This can be better handled across all drivers at ethdev level. Stephen Hemminger (5): ethdev: check that device supports deferred start net/dpaa: remove unnecessary deferred st

[PATCH 0/2] clear out Coverity issues 384444 & 451221

2024-12-13 Thread Ariel Otilibili
Hello, This series clears out the Coverity issues 38 & 451221. Being one-liners, as advised by David Marchand, it is backported onto stable. Thank you, Link: https://inbox.dpdk.org/dev/cajfav8yeawsx2kdianwukx7zsvtenrvovjnzaoq_ocdzm8z...@mail.gmail.com/ Ariel Otilibili (2): examples/flow

[PATCH 2/5] net/dpaa: remove unnecessary deferred start check

2024-12-13 Thread Stephen Hemminger
This check is now done in ethdev layer. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index e8d34e5898..ce48f0 100644 --- a/drivers/net/dpaa/dp

[PATCH 5/5] net/virtio: remove unneeded deferred start check

2024-12-13 Thread Stephen Hemminger
Already checked in ethdev now. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_rxtx.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index b67f063b31..6ae3a6eb12 100644 --- a/drivers/net/virtio/vir

[PATCH 2/2] drivers/net/sfc: remove unused value

2024-12-13 Thread Ariel Otilibili
Coverity issue: 38 Fixes: a62ec90522a ("net/sfc: add port representors infrastructure") Cc: Andrew Rybchenko Cc: sta...@dpdk.org Signed-off-by: Ariel Otilibili --- drivers/net/sfc/sfc_repr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc

Re: [PATCH v2 06/15] net/zxdh: dev start/stop ops implementations

2024-12-13 Thread Stephen Hemminger
On Tue, 10 Dec 2024 13:53:24 +0800 Junlong Wang wrote: > v start/stop implementations, start/stop the rx/tx queues. > > Signed-off-by: Junlong Wang > --- If I re-enable the warnings for format and unaligned packed then this shows up: ../drivers/net/zxdh/zxdh_queue.c: In function ‘zxdh_dev_rx_

Re: [PATCH v2 03/15] net/zxdh: port tables init implementations

2024-12-13 Thread Stephen Hemminger
On Tue, 10 Dec 2024 13:53:21 +0800 Junlong Wang wrote: > insert port tables in host. > > Signed-off-by: Junlong Wang > --- > drivers/net/zxdh/meson.build | 1 + > drivers/net/zxdh/zxdh_ethdev.c | 23 ++ > drivers/net/zxdh/zxdh_msg.c| 63 > drivers/net/zxdh/zxdh_msg.h| 72 ++

Re: [PATCH v2 02/15] net/zxdh: zxdh np uninit implementation

2024-12-13 Thread Stephen Hemminger
On Tue, 10 Dec 2024 13:53:20 +0800 Junlong Wang wrote: > +static uint32_t > +zxdh_np_comm_read_bits(uint8_t *p_base, uint32_t base_size_bit, > + uint32_t *p_data, uint32_t start_bit, uint32_t end_bit) > +{ > + uint32_t len = 0; > + uint32_t start_byte_index

Re: [PATCH v2 09/15] net/zxdh: link info update, set link up/down

2024-12-13 Thread Stephen Hemminger
On Tue, 10 Dec 2024 13:53:27 +0800 Junlong Wang wrote: > provided link info update, set link up /down, > and link intr. > > Signed-off-by: Junlong Wang > --- > doc/guides/nics/features/zxdh.ini | 2 + > doc/guides/nics/zxdh.rst | 3 + > drivers/net/zxdh/meson.build | 1 +

Re: [PATCH v2 02/15] net/zxdh: zxdh np uninit implementation

2024-12-13 Thread Stephen Hemminger
On Tue, 10 Dec 2024 13:53:20 +0800 Junlong Wang wrote: > (np)network processor release resources in host. > > Signed-off-by: Junlong Wang > --- > drivers/net/zxdh/zxdh_ethdev.c | 48 > drivers/net/zxdh/zxdh_np.c | 494 - > drivers/net/zxdh/zxdh_np.h

Re: [PATCH v2 09/15] net/zxdh: link info update, set link up/down

2024-12-13 Thread Stephen Hemminger
On Tue, 10 Dec 2024 13:53:27 +0800 Junlong Wang wrote: > provided link info update, set link up /down, > and link intr. > > Signed-off-by: Junlong Wang > --- > doc/guides/nics/features/zxdh.ini | 2 + > doc/guides/nics/zxdh.rst | 3 + > drivers/net/zxdh/meson.build | 1 +

Re: [PATCH v2 04/15] net/zxdh: port tables unint implementations

2024-12-13 Thread Stephen Hemminger
On Tue, 10 Dec 2024 13:53:22 +0800 Junlong Wang wrote: > elete port tables in host. > > Signed-off-by: Junlong Wang > --- > drivers/net/zxdh/zxdh_ethdev.c | 19 ++ > drivers/net/zxdh/zxdh_msg.h| 1 + > drivers/net/zxdh/zxdh_np.c | 113 + > drivers

[PATCH 1/5] ethdev: check that device supports deferred start

2024-12-13 Thread Stephen Hemminger
The check for supporting deferred start should be handled at the ethdev level for all devices. Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 6413c54e3b..7768058f

[PATCH 1/2] examples/flow_filtering: remove unused variable

2024-12-13 Thread Ariel Otilibili
Coverity issue: 451221 Fixes: 16158f3490 ("examples/flow_filtering: introduce use cases snippets") Cc: Ori Kam Cc: sta...@dpdk.org Signed-off-by: Ariel Otilibili --- examples/flow_filtering/snippets/snippet_match_ipv4.c | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/flow_filtering/s

Re: 23.11.3 patches review and test

2024-12-13 Thread Xueming Li
Hi Ali, Thanks very much for your help and confirmation! Regards, Xueming From: Ali Alnubani Sent: Friday, December 13, 2024 12:25 AM To: Xueming Li ; sta...@dpdk.org Cc: dev@dpdk.org ; Abhishek Marathe ; David Christensen ; Hemant Agrawal ; Ian Stokes ; Jer

Re: [PATCH 1/1] buildtools: clear out regex syntax warnings

2024-12-13 Thread Ariel Otilibili-Anieli
On Friday, December 13, 2024 15:07 CET, "Robin Jarry" wrote: > Ariel Otilibili, Dec 08, 2024 at 03:25: > > * invalid escape sequences now generate SyntaxWarning > > * therefore changed syntax to raw string noration. > > > > Link: https://docs.python.org/3/library/re.html#module-re > > Signed-off-

Re: [PATCH 1/1] app/test: remove useless calls to rte_bitmap_free

2024-12-13 Thread Stephen Hemminger
On Fri, 13 Dec 2024 12:30:00 +0100 Ariel Otilibili wrote: > * rte_bitmap_free is only useful for its return value > * and its return value is not used. > > ``` > $ < lib/eal/include/rte_bitmap.h sed -ne '/bitmap_free/,/^}/p' > > rte_bitmap_free(struct rte_bitmap *bmp) > { > /* Check inp

[PATCH v2 1/1] buildtools: clear out regex syntax warnings

2024-12-13 Thread Ariel Otilibili
* invalid escape sequences now generate SyntaxWarning * therefore changed syntax to raw string noration. Link: https://docs.python.org/3/library/re.html#module-re Fixes: 0aeaf75df87 ("test: define unit tests suites based on test types") Fixes: 25065ef1f6c ("test: emit warning for orphaned tests")

[PATCH v2 0/1] buildtools: clear out regex syntax warnings

2024-12-13 Thread Ariel Otilibili
Hello, This is my first patch to the list; your feedback is much appreciated. My aim is to understand the internals of DPDK. While compiling from scratch, I came across these Python warnings. Thank you, Ariel Otilibili (1): buildtools: clear out regex syntax warnings buildtools/get-test-s

Re: [PATCH] devtools: enhance the license check

2024-12-13 Thread David Marchand
On Wed, Dec 11, 2024 at 4:01 PM Thomas Monjalon wrote: > > 11/12/2024 15:55, Stephen Hemminger: > > On Wed, 11 Dec 2024 10:00:38 +0100 > > David Marchand wrote: > > > > > On Tue, Dec 10, 2024 at 6:00 PM Stephen Hemminger > > > wrote: > > > > > > > > On Tue, 10 Dec 2024 10:10:39 +0100 > > > > Dav

Re: 22.11.7 patches review and test

2024-12-13 Thread Luca Boccassi
On Fri, 13 Dec 2024 at 01:01, Xu, HailinX wrote: > > > -Original Message- > > From: luca.bocca...@gmail.com > > Sent: Sunday, December 1, 2024 8:24 AM > > To: sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; > > Ali Alnubani ; David Christensen > > ; Hemant Agrawal ; > > Stokes, I

Re: [PATCH 1/1] buildtools: clear out regex syntax warnings

2024-12-13 Thread David Marchand
On Fri, Dec 13, 2024 at 3:11 PM Ariel Otilibili-Anieli wrote: > > On Friday, December 13, 2024 15:07 CET, "Robin Jarry" > wrote: > > > Ariel Otilibili, Dec 08, 2024 at 03:25: > > > * invalid escape sequences now generate SyntaxWarning > > > * therefore changed syntax to raw string noration. > >

Re: 22.11.7 patches review and test

2024-12-13 Thread Xueming Li
Hi All, Thanks for the veri6ficiation and suggestion, queued patch to revert on 23.11: Revert "test/bonding: fix loop on members" - dpdk-stable - Data Plane Development Kit - stable branches __

Re: [PATCH v2 0/6] Add a stricter headers check

2024-12-13 Thread David Marchand
On Fri, Dec 13, 2024 at 12:27 PM Bruce Richardson wrote: > > On Fri, Dec 13, 2024 at 11:50:04AM +0100, David Marchand wrote: > > As explained in patch 6, the current headers check can not catch > > issues when a public header includes an internal header. > > Fixing this from meson does not seem an

Re: [PATCH 1/1] buildtools: clear out regex syntax warnings

2024-12-13 Thread Robin Jarry
Ariel Otilibili, Dec 08, 2024 at 03:25: * invalid escape sequences now generate SyntaxWarning * therefore changed syntax to raw string noration. Link: https://docs.python.org/3/library/re.html#module-re Signed-off-by: Ariel Otilibili Hi Ariel, thanks for the fix! Acked-by: Robin Jarry If y

Re: [PATCH v5] graph: mcore: optimize graph search

2024-12-13 Thread David Marchand
On Fri, Dec 13, 2024 at 3:22 AM Huichao Cai wrote: > diff --git a/lib/graph/rte_graph_worker_common.h > b/lib/graph/rte_graph_worker_common.h > index d3ec88519d..aef0f65673 100644 > --- a/lib/graph/rte_graph_worker_common.h > +++ b/lib/graph/rte_graph_worker_common.h > @@ -110,6 +110,7 @@ struct

Re: [PATCH v2 1/1] buildtools: clear out regex syntax warnings

2024-12-13 Thread Robin Jarry
Ariel Otilibili, Dec 13, 2024 at 15:40: * invalid escape sequences now generate SyntaxWarning * therefore changed syntax to raw string noration. Link: https://docs.python.org/3/library/re.html#module-re Fixes: 0aeaf75df87 ("test: define unit tests suites based on test types") Fixes: 25065ef1f6c

[PATCH] net/iavf: remove reset of Tx prepare function ptr

2024-12-13 Thread Bruce Richardson
The iavf driver only contains a single Tx prepare function, so when selecting the Tx path, there is no need to reset and reassign the function pointer in the ethdev structure. This fixes an issue where the pointer was reset to NULL, but never assigned back later on function selection. Fixes: 5712b

Re: [PATCH v2 4/6] drivers: fix exported headers

2024-12-13 Thread David Marchand
On Fri, Dec 13, 2024 at 12:15 PM Bruce Richardson wrote: > > On Fri, Dec 13, 2024 at 11:50:08AM +0100, David Marchand wrote: > > Those headers could not be included individually as they were not > > including their dependencies, or were subject to some build warnings. > > > > Fixes: 831dba47bd36 (

Re: 22.11.7 patches review and test

2024-12-13 Thread Luca Boccassi
Thanks, reverted On Fri, 13 Dec 2024 at 13:36, Xueming Li wrote: > > Hi All, > > Thanks for the veri6ficiation and suggestion, queued patch to revert on 23.11: > Revert "test/bonding: fix loop on members" - dpdk-stable - Data Plane > Development Kit - stable branches > >

Re: [PATCH v2 4/6] drivers: fix exported headers

2024-12-13 Thread Stephen Hemminger
On Fri, 13 Dec 2024 11:50:08 +0100 David Marchand wrote: > @@ -496,6 +501,7 @@ rte_pmd_bphy_intr_mem_get(uint16_t dev_id, struct > cnxk_bphy_mem *mem) > { > struct cnxk_bphy_irq_msg msg = { > .type = CNXK_BPHY_IRQ_MSG_TYPE_MEM_GET, > + .data = NULL, > }; >

Re: [PATCH] app/test: fix stack overflow in lpm6_perf_autotest

2024-12-13 Thread Andre Muezerie
On Fri, Dec 13, 2024 at 10:22:20AM +, Medvedkin, Vladimir wrote: > Hi Andre, > > On 13/12/2024 02:39, Andre Muezerie wrote: > >Test lpm6_perf_autotest was hitting a stack overflow on Windows > >with both MSVC and Clang. > > > >The fix is to move some of the data from the stack to the heap. > >

Re: [PATCH] app/test: fix stack overflow in lpm6_perf_autotest

2024-12-13 Thread Stephen Hemminger
On Fri, 13 Dec 2024 10:22:20 + "Medvedkin, Vladimir" wrote: > Hi Andre, > > On 13/12/2024 02:39, Andre Muezerie wrote: > > Test lpm6_perf_autotest was hitting a stack overflow on Windows > > with both MSVC and Clang. > > > > The fix is to move some of the data from the stack to the heap. > >

[PATCH v2] app/test: fix stack overflow in lpm6_perf_autotest

2024-12-13 Thread Andre Muezerie
Test lpm6_perf_autotest was hitting a stack overflow on Windows with both MSVC and Clang. The fix is to move some of the data from the stack to the heap. Signed-off-by: Andre Muezerie --- app/test/test_lpm6_perf.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] app/test: fix stack overflow in lpm6_perf_autotest

2024-12-13 Thread Stephen Hemminger
On Fri, 13 Dec 2024 09:08:22 -0800 Andre Muezerie wrote: > + struct rte_ipv6_addr *ip_batch = > + (struct rte_ipv6_addr *)rte_malloc("ip_batch", > + sizeof(struct rte_ipv6_addr) * NUM_IPS_ENTRIES, 0 Cast is not needed here. If you are going to allocate

Re: [PATCH 1/2] net/mlx5: improve socket file path

2024-12-13 Thread Bruce Richardson
On Fri, Dec 13, 2024 at 09:12:39AM -0800, Stephen Hemminger wrote: > On Fri, 13 Dec 2024 17:24:42 +0800 > Yang Ming wrote: > > > 1. /var/tmp is hard code which is not a good style > > 2. /var/tmp may be not allowed to be written via container's > > read only mode. > > > > Signed-off-by: Yang Min

[PATCH v2] test/bonding: fix active backup rx test

2024-12-13 Thread Stephen Hemminger
The test had incorrect assumptions about how active backup should work. When in active backup mode, the secondary (not primary) ports should be ignored. The test was always broken since initially written but earlier bug was masking the part of the test which tested non-primary ports. Bugzilla ID:

Re: [PATCH] test/bonding: fix active backup rx test

2024-12-13 Thread Stephen Hemminger
On Fri, 13 Dec 2024 14:57:23 +0800 "lihuisong (C)" wrote: > Hi Stephen, > > This patch looks good to me. > > But this test case still runs failure when I run "link_bonding_autotest" > twice. like: > --> > ... > EAL: Test assert configure_ethdev line 181 failed: rte_eth_dev_configure > for p