1. /var/tmp is hard code which is not a good style 2. /var/tmp may be not allowed to be written via container's read only mode.
Signed-off-by: Yang Ming <ming.1.y...@nokia-sbell.com> --- drivers/net/mlx5/linux/mlx5_socket.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_socket.c b/drivers/net/mlx5/linux/mlx5_socket.c index 6ce0e59643..7fa6e5345c 100644 --- a/drivers/net/mlx5/linux/mlx5_socket.c +++ b/drivers/net/mlx5/linux/mlx5_socket.c @@ -20,7 +20,7 @@ /* PMD socket service for tools. */ -#define MLX5_SOCKET_PATH "/var/tmp/dpdk_net_mlx5_%d" +#define MLX5_SOCKET_FNAME "dpdk_net_mlx5" #define MLX5_ALL_PORT_IDS 0xffff int server_socket = -1; /* Unix socket for primary process. */ @@ -177,8 +177,8 @@ mlx5_pmd_socket_init(void) ret = fcntl(server_socket, F_SETFL, flags | O_NONBLOCK); if (ret < 0) goto close; - snprintf(sun.sun_path, sizeof(sun.sun_path), MLX5_SOCKET_PATH, - getpid()); + snprintf(sun.sun_path, sizeof(sun.sun_path), "%s/%s_%d", + rte_eal_get_runtime_dir(), MLX5_SOCKET_FNAME, getpid()); remove(sun.sun_path); ret = bind(server_socket, (const struct sockaddr *)&sun, sizeof(sun)); if (ret < 0) { @@ -223,6 +223,7 @@ mlx5_pmd_socket_uninit(void) mlx5_pmd_socket_handle, NULL); claim_zero(close(server_socket)); server_socket = -1; - MKSTR(path, MLX5_SOCKET_PATH, getpid()); + MKSTR(path, "%s/%s_%d", rte_eal_get_runtime_dir(), MLX5_SOCKET_FNAME, + getpid()); claim_zero(remove(path)); } -- 2.34.1