Since firmware version 0x20010, GPIO interrupt enable is set to 0xd by
default, which means enable bit 0 'tx_fault'. And GPIO interrupt polarity
is set to 0xd by default too, which means these interrupts are rising-edge
sensitive.
So when unplug the SFP module, GPIO line 0 'tx_fault' is 0 -> 1 tri
On Thu, Nov 14, 2024 at 11:24:59AM -0800, Stephen Hemminger wrote:
> Do not use same variable for outer and inner loop in bonding test.
> Since the loop is just freeing the resulting burst use bulk free.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: 92073ef961ee ("bond: unit
On Thu, Nov 14, 2024 at 11:25:01AM -0800, Stephen Hemminger wrote:
> The parenthesis were in the wrong place so that comparison
> took precedence over assignment in handling IPv6 extension
> headers. Break up the loop condition to avoid the problem.
>
> Link: https://pvs-studio.com/en/blog/posts/
On Thu, Nov 14, 2024 at 11:25:02AM -0800, Stephen Hemminger wrote:
> The event_dev_config initialization had duplicate assignments
> to the same element. Change to use structure initialization
> so that compiler will catch this type of bug.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
On Thu, Nov 14, 2024 at 11:25:04AM -0800, Stephen Hemminger wrote:
> The test loop was much shorter than desired because when
> MAX_NUM is defined with out paren's the divide operator /
> takes precedence over shift.
>
> But when MAX_NUM is fixed, some tests take too long
> and have to modified to
On Thu, Nov 14, 2024 at 11:25:05AM -0800, Stephen Hemminger wrote:
> The expression for checking which lcore is enabled for 0-7
> was wrong (missing case for 6).
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: b0209034f2bb ("test/eal: check number of cores before running
> su
On Thu, Nov 14, 2024 at 11:25:06AM -0800, Stephen Hemminger wrote:
> The loop over policy actions will always exit when it sees
> the flow end action, so the next check is redundant.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: f29fa2c59b85 ("app/testpmd: support policy act
On Thu, Nov 14, 2024 at 11:25:08AM -0800, Stephen Hemminger wrote:
> There was useless loop when looking at the DMA address.
> It looks like it was meant to skip whitespace before
> calling strtok.
>
> Good time to replace strtok with strtok_r as well.
>
> Link: https://pvs-studio.com/en/blog/pos
On Thu, Nov 14, 2024 at 11:25:07AM -0800, Stephen Hemminger wrote:
> The order of comparison is wrong, and potentially allows
> referencing past the array.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: 3e3edab530a1 ("ethdev: add flow quota")
> Cc: getel...@nvidia.com
> Cc: s
>-Original Message-
>From: Stephen Hemminger
>Sent: Wednesday, November 13, 2024 12:10 AM
>To: Tomasz Duszynski
>Cc: Jerin Jacob ; Sunil Kumar Kori ;
>Tyler Retzlaff
>; ruifeng.w...@arm.com;
>bruce.richard...@intel.com;
>david.march...@redhat.com; dev@dpdk.org; konstantin.v.anan...@yand
On Thu, Nov 14, 2024 at 10:05:42PM -0800, Stephen Hemminger wrote:
> There are two branches in the cascading if/else that have same
> condition and code; remove one. Update the code to follow DPDK
> style where all statements in if should have brackets if any
> leg requires them.
>
Not actually D
On Fri, 15 Nov 2024, Stephen Hemminger wrote:
> Need to include to get the prototype rte_get_tsc_cycles()
When I compile locally (on x86), it compiles successfully whether or not
is included.
However, cloud testing indicates that compilation fails on other
architectures when is not include
Hi,
> -Original Message-
> From: Danylo Vodopianov
> Sent: Thursday, October 31, 2024 16:00
> To: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam
> ; mko-...@napatech.com; c...@napatech.com; sil-
> p...@napatech.com
> Cc: dev@dpdk.org
Hi,
> -Original Message-
> From: Danylo Vodopianov
> Sent: Thursday, October 31, 2024 16:00
> To: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam
> ; mko-...@napatech.com; c...@napatech.com; sil-
> p...@napatech.com
> Cc: dev@dpdk.org;
The order of comparison is wrong, and potentially allows
referencing past the array.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 3e3edab530a1 ("ethdev: add flow quota")
Cc: getel...@nvidia.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
---
Update HWRM API to select ring profile.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/hsi_struct_def_dpdk.h | 71 +-
1 file changed, 69 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h
b/drivers/net/bnxt/hsi_struct_def_dpdk.h
index 8
Some firmware versions can support the selection of Rx profile
during Rx and AGG ring allocation.
Check if the firmware sets the
HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT3_RX_RATE_PROFILE_SEL_SUPPORTED flag
and set the new Rx profile.
Signed-off-by: Ajit Khaparde
Reviewed-by: Andy Gospodarek
---
drivers
Because of misuse of & vs && operator, the member code would
always use the primary bucket.
Fixes: 904ec78a239c ("member: implement HT mode")
Cc: yipeng1.w...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
lib/member/rte_member_ht.c | 2 +-
1 file changed, 1 insertion(+), 1
https://bugs.dpdk.org/show_bug.cgi?id=1583
Bug ID: 1583
Summary: lib/mldev: conditional expression always true
Product: DPDK
Version: 24.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
The test suite served as a demonstration of the Scapy traffic generator
implementation. Now that we have a test suite that uses DPDK code (via
testpmd), there is no reason to keep the test suite, as there's no
expectation it'll be actually used in any setup.
Signed-off-by: Juraj Linkeš
Signed-off
Reviewed-by: Patrick Robb
On Mon, 28 Oct 2024 19:55:52 +
Sivaprasad Tummala wrote:
> + /* Auto Detect Environment */
> + RTE_TAILQ_FOREACH(ops, &uncore_ops_list, next)
> + if (ops) {
> + POWER_LOG(INFO,
> + "Attempting to initialise %s power
> manage
https://bugs.dpdk.org/show_bug.cgi?id=1582
Bug ID: 1582
Summary: virtio: reader/writer lock mismatch
Product: DPDK
Version: 24.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: major
Priorit
On Fri, 15 Nov 2024, Stephen Hemminger wrote:
> Need to include to get the prototype rte_get_tsc_cycles()
For the code without could run on x86, I think I have found
the reason. Through the path -> ->
, the is included.
is independent on each architecture. And on x86 the
includes its
Morten Brørup, Nov 14, 2024 at 15:35:
RTE_IPV4 is only useful to define addresses in unit tests.
There are plenty of special IP addresses and subnets, where a shortcut
macro makes the address easier readable in the code.
OK, let me reformulate. I didn't mean to say that RTE_IPV4 is useless.
> On Nov 14, 2024, at 8:41 AM, Konstantin Ananyev
> wrote:
>
> Hi everyone,
>
> Looking at implementation of cryptodev callbacks
> (it uses DPDK RCU), it seems like there is a bug here:
>
> at init time we don't call rte_rcu_qsbr_thread_register().
> As I understand without it rte_rcu_qsbr_c
../lib/rcu/rte_rcu_qsbr.c(101): warning C4334: '<<': result of 32-bit
shift implicitly converted to 64 bits (was 64-bit shift intended?)
../lib/rcu/rte_rcu_qsbr.c(107): warning C4334: '<<': result of 32-bit
shift implicitly converted to 64 bits (was 64-bit shift intended?)
../lib/rcu/rte_rcu_qsbr
On Fri, Nov 15, 2024 at 03:21:42PM +0100, David Marchand wrote:
> On Wed, Nov 13, 2024 at 5:24 PM Andre Muezerie
> wrote:
> >
> > ../lib/rcu/rte_rcu_qsbr.c(101): warning C4334: '<<': result of 32-bit
> > shift implicitly converted to 64 bits (was 64-bit shift intended?)
> > ../lib/rcu/rte_rcu_qsb
On Tue, Nov 12, 2024 at 11:48 PM Andre Muezerie
wrote:
>
> The issues that were preventing argparser from getting compiled with
> MSVC were fixed, so now it should not be excluded from the
> compilation anymore.
Just to be sure, it relates to fixes of bz 1409, right?
It's cool no new regression
> From: Robin Jarry [mailto:rja...@redhat.com]
> Sent: Friday, 15 November 2024 14.02
>
> Morten Brørup, Nov 14, 2024 at 15:35:
> >> RTE_IPV4 is only useful to define addresses in unit tests.
> >
> > There are plenty of special IP addresses and subnets, where a
> shortcut
> > macro makes the addre
Morten Brørup, Nov 15, 2024 at 14:52:
Robin, you've totally won me over on this endian discussion. :-)
Especially the IPv6 comparison make it clear why IPv4 should also be
network byte order.
API/ABI stability is a pain... we're stuck with host endian IPv4
addresses; e.g. for the RTE_IPV4() m
>-Original Message-
>From: Konstantin Ananyev
>Sent: Tuesday, November 5, 2024 11:58 AM
>To: Tomasz Duszynski ; Thomas Monjalon
>
>Cc: ruifeng.w...@arm.com; bruce.richard...@intel.com;
>david.march...@redhat.com; dev@dpdk.org;
>Jerin Jacob ; konstantin.v.anan...@yandex.ru;
>mattias.ronn
On Fri, Nov 15, 2024 at 02:52:57PM +0100, Morten Brørup wrote:
> > From: Robin Jarry [mailto:rja...@redhat.com]
> > Sent: Friday, 15 November 2024 14.02
> >
> > Morten Brørup, Nov 14, 2024 at 15:35:
> >
> > On that same topic, I wonder if it would make sense to change the API
> > parameters to
On Wed, Nov 13, 2024 at 5:24 PM Andre Muezerie
wrote:
>
> ../lib/rcu/rte_rcu_qsbr.c(101): warning C4334: '<<': result of 32-bit
> shift implicitly converted to 64 bits (was 64-bit shift intended?)
> ../lib/rcu/rte_rcu_qsbr.c(107): warning C4334: '<<': result of 32-bit
> shift implicitly converte
Is it good to go?
15/11/2024 02:55, Huichao Cai:
> The members "dispatch" and "xstat_off" of the structure "rte_node"
> can be min cache aligned to make room for future expansion and to
> make sure have better performance. Add corresponding comments.
>
> Signed-off-by: Huichao Cai
> ---
> doc/
https://bugs.dpdk.org/show_bug.cgi?id=1580
Stephen Hemminger (step...@networkplumber.org) changed:
What|Removed |Added
Resolution|--- |FIXED
'i40e_get_outer_vlan()' does not check 'i40e_aq_debug_read_register()'
return value. This patch fixes this issue.
Coverity issue: 445518
Fixes: 86eb05d6350b ("net/i40e: add flow validate function")
Cc: beilei.x...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Vladimir Medvedkin
---
drivers/net/
The loop over policy actions will always exit when it sees
the flow end action, so the next check is redundant.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color")
Cc: haif...@nvidia.com
Signed-off-by: Stephen Hemminger
Acked
There was useless loop when looking at the DMA address.
It looks like it was meant to skip whitespace before
calling strtok.
Good time to replace strtok with strtok_r as well.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test"
The expression for checking which lcore is enabled for 0-7
was wrong (missing case for 6).
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: b0209034f2bb ("test/eal: check number of cores before running subtests")
Cc: msant...@redhat.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemmi
The test loop was much shorter than desired because when
MAX_NUM is defined with out paren's the divide operator /
takes precedence over shift.
But when MAX_NUM is fixed, some tests take too long
and have to be modified to avoid running over full N^2
space of 1<<20.
Note: this is a very old bug,
Do not use same variable for outer and inner loop in bonding test.
Since the loop is just freeing the resulting burst use bulk free.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 92073ef961ee ("bond: unit tests")
Cc: declan.dohe...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Steph
The first argument of 'memcmp' function was equal to the second argument.
Therefore ASSERT would always be true.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 92073ef961ee ("bond: unit tests")
Cc: declan.dohe...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
a
The parenthesis were in the wrong place so that comparison
took precedence over assignment in handling IPv6 extension
headers. Break up the loop condition to avoid the problem.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 15ccc647526e ("test/security: test inline reassembly with m
The code was duplicating the same condition three times?
Reading the commit message, the intention was:
Add unit tests to verify the zero len TLS records. Zero len packets are
allowed when content type is app data while zero packet length with
other content type (such as handshake) wou
Recent blog post from PVS studio referenced lots bugs found by
their analyzer against DPDK. This set addresses the ones in
the test suite.
v3 - minimize change to test-dma-perf
Stephen Hemminger (10):
app/test: do not duplicate loop variable
app/test: fix typo in address compare
app/test: f
On Fri, 15 Nov 2024 15:28:33 +0100
"Robin Jarry" wrote:
> Morten Brørup, Nov 15, 2024 at 14:52:
> > Robin, you've totally won me over on this endian discussion. :-)
> > Especially the IPv6 comparison make it clear why IPv4 should also be
> > network byte order.
> >
> > API/ABI stability is a pai
> -Original Message-
> From: Thomas Monjalon
> Sent: Friday, November 15, 2024 7:54 PM
> To: Jerin Jacob ; Nithin Kumar Dabilpuram
>
> Cc: Kiran Kumar Kokkilagadda ;
> yanzhirun_...@163.com; dev@dpdk.org; Huichao Cai
> Subject: [EXTERNAL] Re: [PATCH v5 1/1] graph: improve node layout
Reviewed-by: Luca Vizzarro
On Fri, 15 Nov 2024 15:50:08 +0800
Congjie Zhou wrote:
> diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c
> index e354efc..367d401 100644
> --- a/lib/eal/linux/eal_memalloc.c
> +++ b/lib/eal/linux/eal_memalloc.c
> @@ -16,6 +16,7 @@
> #include
> #include
> #include
>
The event_dev_config initialization had duplicate assignments
to the same element. Change to use structure initialization
so that compiler will catch this type of bug.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: f8f9d233ea0e ("test/eventdev: add unit tests")
Cc: jerin.ja...@cavium
On Fri, Nov 15, 2024 at 12:08 PM Stephen Hemminger
wrote:
>
> The loop over policy actions will always exit when it sees
> the flow end action, so the next check is redundant.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per
On Fri, 15 Nov 2024 15:50:08 +0800
Congjie Zhou wrote:
> add the tsc into the name.
>
> Suggested-by: Stephen Hemminger
> Signed-off-by: Congjie Zhou
> ---
>
> When multiple secondary processes run in different containers, names
> identified by PIDs are not unique due to the pid namespace.
>
On Fri, 15 Nov 2024 09:13:12 +
Bruce Richardson wrote:
> On Thu, Nov 14, 2024 at 11:25:08AM -0800, Stephen Hemminger wrote:
> > There was useless loop when looking at the DMA address.
> > It looks like it was meant to skip whitespace before
> > calling strtok.
> >
> > Good time to replace st
On Fri, 15 Nov 2024 09:07:42 +
Bruce Richardson wrote:
> On Thu, Nov 14, 2024 at 11:25:05AM -0800, Stephen Hemminger wrote:
> > The expression for checking which lcore is enabled for 0-7
> > was wrong (missing case for 6).
> >
> > Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
> >
> >
add the tsc into the name.
Suggested-by: Stephen Hemminger
Signed-off-by: Congjie Zhou
---
When multiple secondary processes run in different containers, names
identified by PIDs are not unique due to the pid namespace.
So Add tsc to redefine a unique name.
v1: use monotonic time to redefine
56 matches
Mail list logo
