>-----Original Message----- >From: Stephen Hemminger <step...@networkplumber.org> >Sent: Wednesday, November 13, 2024 12:10 AM >To: Tomasz Duszynski <tduszyn...@marvell.com> >Cc: Jerin Jacob <jer...@marvell.com>; Sunil Kumar Kori <sk...@marvell.com>; >Tyler Retzlaff ><roret...@linux.microsoft.com>; ruifeng.w...@arm.com; >bruce.richard...@intel.com; >david.march...@redhat.com; dev@dpdk.org; konstantin.v.anan...@yandex.ru; >mattias.ronnb...@ericsson.com; m...@smartsharesystems.com; >tho...@monjalon.net; zhou...@loongson.cn >Subject: [EXTERNAL] Re: [PATCH v15 4/4] eal: add PMU support to tracing library > >On Fri, 25 Oct 2024 10: 54: 14 +0200 Tomasz Duszynski <tduszynski@ marvell. >com> wrote: > In order >to profile app one needs to store significant amount of samples > somewhere >for an analysis later >on. Since trace library supports > >On Fri, 25 Oct 2024 10:54:14 +0200 >Tomasz Duszynski <tduszyn...@marvell.com> wrote: > >> In order to profile app one needs to store significant amount of >> samples somewhere for an analysis later on. Since trace library >> supports storing data in a CTF format lets take advantage of that and >> add a dedicated PMU tracepoint. >> >> Signed-off-by: Tomasz Duszynski <tduszyn...@marvell.com> >> --- >> app/test/test_trace_perf.c | 10 ++++ >> doc/guides/prog_guide/profile_app.rst | 5 ++ >> doc/guides/prog_guide/trace_lib.rst | 32 +++++++++++ >> lib/eal/common/eal_common_trace.c | 5 +- >> lib/eal/common/eal_common_trace_pmu.c | 38 ++++++++++++++ >> lib/eal/common/eal_common_trace_points.c | 5 ++ >> lib/eal/common/eal_trace.h | 4 ++ >> lib/eal/common/meson.build | 1 + >> lib/eal/include/rte_eal_trace.h | 11 ++++ >> lib/eal/version.map | 1 + >> lib/pmu/rte_pmu.c | 67 +++++++++++++++++++++++- >> lib/pmu/rte_pmu.h | 24 +++++++-- >> lib/pmu/version.map | 1 + >> 13 files changed, 198 insertions(+), 6 deletions(-) create mode >> 100644 lib/eal/common/eal_common_trace_pmu.c > > >There is an issue with calling a rte_experimental function. > >-------------------------------BEGIN LOGS---------------------------- >#################################################################################### >#### [Begin job log] "ubuntu-22.04-gcc-debug+doc+examples+tests" at step Build >and test >#################################################################################### >[3384/6468] Compiling C object >buildtools/chkincs/chkincs.p/meson-generated_rte_pmu.c.o >FAILED: buildtools/chkincs/chkincs.p/meson-generated_rte_pmu.c.o >ccache gcc -Ibuildtools/chkincs/chkincs.p -Ibuildtools/chkincs >-I../buildtools/chkincs - >Iexamples/l3fwd -I../examples/l3fwd -I../examples/common -Idrivers/bus/vdev >-I../drivers/bus/vdev - >I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include >-Ilib/eal/linux/include - >I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include >-Ilib/eal/common - >I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs >-Ilib/log -I../lib/log - >Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/pmu >-I../lib/pmu - >Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci >-I../lib/pci - >Idrivers/bus/vmbus -I../drivers/bus/vmbus -I../drivers/bus/vmbus/linux >-Ilib/argparse - >I../lib/argparse -Ilib/ptr_compress -I../lib/ptr_compress -Ilib/ring >-I../lib/ring -Ilib/rcu - >I../lib/rcu -Ilib/mempool -I../lib/mempool -Ilib/mbuf -I../lib/mbuf -Ilib/net >-I../lib/net - >Ilib/meter -I../lib/meter -Ilib/ethdev -I../lib/ethdev -Ilib/cmdline >-I../lib/cmdline -Ilib/hash - >I../lib/hash -Ilib/timer -I../lib/timer -Ilib/acl -I../lib/acl -Ilib/bbdev >-I../lib/bbdev - >Ilib/bitratestats -I../lib/bitratestats -Ilib/bpf -I../lib/bpf -Ilib/cfgfile >-I../lib/cfgfile - >Ilib/compressdev -I../lib/compressdev -Ilib/cryptodev -I../lib/cryptodev >-Ilib/distributor - >I../lib/distributor -Ilib/dmadev -I../lib/dmadev -Ilib/efd -I../lib/efd >-Ilib/eventdev - >I../lib/eventdev -Ilib/dispatcher -I../lib/dispatcher -Ilib/gpudev >-I../lib/gpudev -Ilib/gro - >I../lib/gro -Ilib/gso -I../lib/gso -Ilib/ip_frag -I../lib/ip_frag >-Ilib/jobstats -I../lib/jobstats >-Ilib/latencystats -I../lib/latencystats -Ilib/lpm -I../lib/lpm -Ilib/member >-I../lib/member - >Ilib/pcapng -I../lib/pcapng -Ilib/power -I../lib/power -Ilib/rawdev >-I../lib/rawdev -Ilib/regexdev >-I../lib/regexdev -Ilib/mldev -I../lib/mldev -Ilib/rib -I../lib/rib >-Ilib/reorder -I../lib/reorder >-Ilib/sched -I../lib/sched -Ilib/security -I../lib/security -Ilib/stack >-I../lib/stack -Ilib/vhost >-I../lib/vhost -Ilib/ipsec -I../lib/ipsec -Ilib/pdcp -I../lib/pdcp -Ilib/fib >-I../lib/fib - >Ilib/port -I../lib/port -Ilib/pdump -I../lib/pdump -Ilib/table -I../lib/table >-Ilib/pipeline - >I../lib/pipeline -Ilib/graph -I../lib/graph -Ilib/node -I../lib/node >-fdiagnostics-color=always - >pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -g >-include rte_config.h - >Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security >-Wmissing-declarations - >Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith >-Wsign-compare - >Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member >-Wno-packed-not-aligned - >Wno-missing-field-initializers -D_GNU_SOURCE -march=corei7 -mrtm -MD -MQ >buildtools/chkincs/chkincs.p/meson-generated_rte_pmu.c.o -MF >buildtools/chkincs/chkincs.p/meson- >generated_rte_pmu.c.o.d -o >buildtools/chkincs/chkincs.p/meson-generated_rte_pmu.c.o -c >buildtools/chkincs/chkincs.p/rte_pmu.c >In file included from buildtools/chkincs/chkincs.p/rte_pmu.c:1: >/home/runner/work/dpdk/dpdk/lib/pmu/rte_pmu.h: In function ‘rte_pmu_read’: >/home/runner/work/dpdk/dpdk/lib/pmu/rte_pmu.h:214:17: error: >‘__rte_pmu_enable_group’ is >deprecated: Symbol is not yet part of stable ABI >[-Werror=deprecated-declarations] > 214 | ret = __rte_pmu_enable_group(group); > | ^~~ >/home/runner/work/dpdk/dpdk/lib/pmu/rte_pmu.h:132:1: note: declared here > 132 | __rte_pmu_enable_group(struct rte_pmu_event_group *group); > | ^~~~~~~~~~~~~~~~~~~~~~ >/home/runner/work/dpdk/dpdk/lib/pmu/rte_pmu.h:222:9: error: >‘__rte_pmu_read_userpage’ is >deprecated: Symbol is not yet part of stable ABI >[-Werror=deprecated-declarations] > 222 | return __rte_pmu_read_userpage(group->mmap_pages[index]); > | ^~~~~~ >/home/runner/work/dpdk/dpdk/lib/pmu/rte_pmu.h:86:1: note: declared here > 86 | __rte_pmu_read_userpage(struct perf_event_mmap_page *pc) > | ^~~~~~~~~~~~~~~~~~~~~~~ >cc1: all warnings being treated as errors [3385/6468] Compiling C object >buildtools/chkincs/chkincs.p/meson-generated_rte_byteorder.c.o >[3386/6468] Compiling C object >buildtools/chkincs/chkincs.p/meson-generated_rte_atomic.c.o >[3387/6468] Compiling C object >buildtools/chkincs/chkincs.p/meson-generated_rte_rtm.c.o >[3388/6468] Compiling C object >buildtools/chkincs/chkincs.p/meson-generated_rte_memcpy.c.o >[3389/6468] Compiling C object app/dpdk-test.p/test_test_memcpy_perf.c.o >ninja: build stopped: subcommand failed. >##[error]Process completed with exit code 1.
Right, this indeed pops up with -Dcheck_includes=true. Will fix this in v16. Thanks.
