Re: [PATCH 1/2] ethdev: add Rx packet type offload control flag

2024-09-22 Thread Ferruh Yigit
On 6/19/2024 11:11 AM, Chaoyong He wrote: > From: Long Wu > > The Rx packet type offload feature may affect the performance, > so add a control flag for applications to turn it on or off. > > Signed-off-by: Long Wu > --- > lib/ethdev/rte_ethdev.h | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [PATCH v6 00/14] Enhance the bond framework to support offload

2024-09-22 Thread Ferruh Yigit
On 12/26/2023 7:28 AM, Chaoyong He wrote: > This patch series try to enhance the bond framework to support the > offload feature better: > * Add new API to make the member port can access some information of the > bond port which belongs. > * Add new API to get the result of whether bond port is

Re: [PATCH v2 1/3] ethdev: add frequency adjustment API

2024-09-22 Thread Ferruh Yigit
On 9/10/2024 10:13 AM, Mingjin Ye wrote: > This patch adds freq adjustment API for PTP high accuracy. > > Signed-off-by: Simei Su > Signed-off-by: Mingjin Ye <...> > diff --git a/doc/guides/rel_notes/release_24_11.rst > b/doc/guides/rel_notes/release_24_11.rst > index 0ff70d9057..10ac35e5c0 1

Re: [PATCH v2 0/3] add frequency adjustment support for PTP

2024-09-22 Thread Ferruh Yigit
On 9/10/2024 10:13 AM, Mingjin Ye wrote: > [1/3] ethdev: add frequency adjustment API > [2/3] net/ice: add frequency adjustment support for PTP > [3/3] examples/ptpclient: add frequency adjustment support > --- > v2: rte_eth_timesync_adjust_freq marked as experimental. > > Mingjin Ye (3): > ethd

Re: [PATCH v7 2/8] ethdev: add telemetry cmd for registers

2024-09-22 Thread Jie Hai
Hi, fengchengwen, Thanks for your review, all will change in next version. Thanks, Jie Hai On 2024/9/14 16:20, fengchengwen wrote: On 2024/9/14 15:13, Jie Hai wrote: This patch adds a telemetry command for registers dump, and supports obtaining the registers of a specified module. In one way,

Re: [PATCH v7 0/8] support dump reigser names and filter

2024-09-22 Thread Jie Hai
Hi, Stephen Hemminger On 2024/9/14 23:00, Stephen Hemminger wrote: On Sat, 14 Sep 2024 15:13:12 +0800 Jie Hai wrote: The registers can be dumped through the API rte_eth_dev_get_reg_info. However, only register values are exported, which is inconvenient for users to interpret. Therefore, an ex

RE: [PATCH v2 0/3] add frequency adjustment support for PTP

2024-09-22 Thread Ye, MingjinX
Hi Yigit, Ok, I will describe the documentation in detail to avoid confusion. Thanks for the review. Regards, Mingjin > -Original Message- > From: Ferruh Yigit > Sent: Monday, September 23, 2024 3:06 AM > To: Ye, MingjinX ; dev@dpdk.org > Cc: Richardson, Bruce > Subject: Re: [PATCH v2

Re: [PATCH v2 1/3] ethdev: add frequency adjustment API

2024-09-22 Thread fengchengwen
Hi Mingjin, Why we need this API? What's the use-case? Thanks On 2024/9/10 17:13, Mingjin Ye wrote: > This patch adds freq adjustment API for PTP high accuracy. > > Signed-off-by: Simei Su > Signed-off-by: Mingjin Ye > --- > doc/guides/nics/features.rst | 4 +++- > doc/guides/re

Re: [PATCH v7 2/8] ethdev: add telemetry cmd for registers

2024-09-22 Thread Ferruh Yigit
On 9/14/2024 8:13 AM, Jie Hai wrote: > This patch adds a telemetry command for registers dump, > and supports obtaining the registers of a specified module. > > In one way, the number of registers that can be exported > is limited by the number of elements carried by dict and > container. In anoth

Re: [PATCH v7 0/8] support dump reigser names and filter

2024-09-22 Thread Ferruh Yigit
On 9/14/2024 8:13 AM, Jie Hai wrote: > The registers can be dumped through the API rte_eth_dev_get_reg_info. > However, only register values are exported, which is inconvenient for > users to interpret. Therefore, an extension of the structure > "rte_dev_reg_info" and a new API rte_eth_dev_get_reg_

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-09-22 Thread Ferruh Yigit
On 7/26/2024 9:01 PM, Wathsala Wathawana Vithanage wrote: >> rte_eth_X_get_capability() >> > > rte_eth_dev_stashing_hints_discover is somewhat similar. > >> Instead of adding RTE_ETH_DEV_CAPA_ macro and contaminating >> 'rte_eth_dev_info' with this edge use case, what do you think follow above >>

Re: [RFC 2/2] ethdev: add data size field to GENEVE option item

2024-09-22 Thread Ferruh Yigit
On 4/17/2024 8:23 AM, Michael Baum wrote: > The "rte_flow_item_geneve_opt" structure has field for option length. > This field has 2 different usages which might limit each other: > > 1. field to matching with value/mask. > 2. descriptor for data array size. > > This patch adds a new field "dat

Re: [RFC] ethdev: introduce PTP device capability

2024-09-22 Thread Ferruh Yigit
On 1/30/2024 3:58 AM, Huisong Li wrote: > Currently, the PTP feature is a little messy and has some issue. > 1> There is different implementation for PTP. This feature of some >hardware depends on the Rx HW timestamp offload, and use this >offload to detect if enable PTP feature. Others can

Re:[PATCH] raw/zxdh: introduce zxdh raw device driver

2024-09-22 Thread Yong Zhang
Hi thomas, Could you please provide feedback on the patch I submitted on August 12? Any suggestions for improvement would be appreciated. Thanks

Re: [PATCH 0/5] Increase minimum meson version

2024-09-22 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/9/20 20:57, Bruce Richardson wrote: > This patchset proposed increasing the minimum meson version to 0.57 > and makes changes to update our build files appropriately for that > change: replacing deprecated functions, removing unnecessary version > checks and taking

Re: [PATCH v2 0/3] alarm test fixes

2024-09-22 Thread fengchengwen
LGTM Series-acked-by: Chengwen Feng On 2024/8/9 23:24, Stephen Hemminger wrote: > This is the set of things which stood out as needing fixing when > looking at the rte_eal_alarm tests. > > v2 - drop cleanup of eal alarm code for later >- add RTE_ATOMIC() to fix clang build > > Stephen Hemmi

Re: [PATCH 0/5] Increase minimum meson version

2024-09-22 Thread fengchengwen
It should be series-ack, Series-acked-by: Chengwen Feng On 2024/9/23 9:59, fengchengwen wrote: > Acked-by: Chengwen Feng > > On 2024/9/20 20:57, Bruce Richardson wrote: >> This patchset proposed increasing the minimum meson version to 0.57 >> and makes changes to update our build files appropr

Re: [PATCH v7 1/8] ethdev: support report register names and filter

2024-09-22 Thread Ferruh Yigit
On 9/14/2024 8:13 AM, Jie Hai wrote: > This patch adds "filter" and "names" fields to "rte_dev_reg_info" > structure. Names of registers in data fields can be reported and > the registers can be filtered by their module names. > > The new API rte_eth_dev_get_reg_info_ext() is added to support > re

RE: [PATCH v2 1/3] ethdev: add frequency adjustment API

2024-09-22 Thread Ye, MingjinX
Hi Chengwen, This API is used to synchronise the frequency of the slave node with the master node. use-case: https://patchwork.dpdk.org/project/dpdk/patch/20240910091328.922082-4-mingjinx...@intel.com/ Also, I will refine the description file to avoid confusion. Regards, Mingjin > -Origi

RE: [PATCH v4 1/1] testpmd: add hairpin-map parameter

2024-09-22 Thread Etelson, Gregory
On Fri, 20 Sep 2024, Singh, Aman Deep wrote: External email: Use caution opening links or attachments Hi Gregory, Can you please resolve the compilation issues seen with this patch. Hello, I've posted v5. Regards, Gregory

Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API

2024-09-22 Thread Ferruh Yigit
On 9/22/2024 5:40 AM, Hemant Agrawal wrote: > HI Ferruh, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Sunday, September 22, 2024 8:44 AM >> To: Hemant Agrawal ; dev@dpdk.org >> Cc: ferruh.yi...@intel.com; Vinod Pullabhatla ; >> Rohit Raj >> Subject: Re: [PATCH v2 14/18] net/dpa

Re: [PATCH v2 0/9] net/mlx5: cumulative fix series for flex item

2024-09-22 Thread Raslan Darawsheh
Hi, From: Slava Ovsiienko Sent: Wednesday, September 18, 2024 4:46 PM To: dev@dpdk.org Cc: Matan Azrad; Raslan Darawsheh; Ori Kam; Dariusz Sosnowski Subject: [PATCH v2 0/9] net/mlx5: cumulative fix series for flex item There is a series of independent patches related to the flex item. There is

Re: [PATCH v5 1/2] ethdev: Add link_speed lanes support

2024-09-22 Thread Ferruh Yigit
On 9/4/2024 6:50 PM, Damodharam Ammepalli wrote: > Update the eth_dev_ops structure with new function vectors > to get, get capabilities and set ethernet link speed lanes. > Update the testpmd to provide required config and information > display infrastructure. > > The supporting ethernet controll

Re: [PATCH 4/4] ethdev: add traffic manager query function

2024-09-22 Thread Ferruh Yigit
On 8/6/2024 4:24 PM, Bruce Richardson wrote: > +/** > + * Return information about a traffic management node > + * > + * Return information about a hierarchy node, using the same format of > parameters > + * as was passed to the rte_rm_node_add() function. > + * Each of the "out" parameters pointe

Re: [PATCH 1/4] ethdev: make parameters to TM node add fn constant

2024-09-22 Thread Ferruh Yigit
On 8/7/2024 8:27 AM, Xu, Rosen wrote: > Hi, > >> -Original Message- <...> >> Subject: [PATCH 1/4] ethdev: make parameters to TM node add fn constant >> >> The function to add a new scheduling node in rte_tm should not (and does >> not) modify the actual node parameters passed in via struct

Re: [PATCH 2/4] ethdev: make parameters to TM profile add fn constant

2024-09-22 Thread Ferruh Yigit
On 8/7/2024 8:27 AM, Xu, Rosen wrote: > Hi, > >> -Original Message- <...> >> Subject: [PATCH 2/4] ethdev: make parameters to TM profile add fn constant >> >> The function to add a new profile in rte_tm should not (and does not) modify >> the profile parameters passed in via struct pointer.

Re: [PATCH 3/4] ethdev: make TM shaper parameters constant

2024-09-22 Thread Ferruh Yigit
On 8/7/2024 8:29 AM, Xu, Rosen wrote: > Hi, > >> -Original Message- <...> >> Subject: [PATCH 3/4] ethdev: make TM shaper parameters constant >> >> The function to add a new shaper profile in rte_tm should not (and does >> not) modify the profile parameters passed in via struct pointer. We

[RFC PATCH v4] mempool: fix mempool cache size

2024-09-22 Thread Morten Brørup
This patch refactors the mempool cache to fix two bugs: 1. When a mempool is created with a cache size of N objects, the cache was actually created with a size of 1.5 * N objects. 2. The mempool cache field names did not reflect their purpose; the "flushthresh" field held the size, and the "size" f

Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API

2024-09-22 Thread Ferruh Yigit
On 9/22/2024 5:40 AM, Hemant Agrawal wrote: > HI Ferruh, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Sunday, September 22, 2024 8:44 AM >> To: Hemant Agrawal ; dev@dpdk.org >> Cc: ferruh.yi...@intel.com; Vinod Pullabhatla ; >> Rohit Raj >> Subject: Re: [PATCH v2 14/18] net/dpa

Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API

2024-09-22 Thread Ferruh Yigit
On 9/22/2024 2:27 PM, Ferruh Yigit wrote: > On 9/22/2024 5:40 AM, Hemant Agrawal wrote: >> HI Ferruh, >> >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Sunday, September 22, 2024 8:44 AM >>> To: Hemant Agrawal ; dev@dpdk.org >>> Cc: ferruh.yi...@intel.com; Vinod Pullabhatla ; >>>

Re: [PATCH v2 15/18] bus/dpaa: add OH port mode for dpaa eth

2024-09-22 Thread Ferruh Yigit
On 8/23/2024 8:32 AM, Hemant Agrawal wrote: > @@ -78,7 +78,7 @@ TAILQ_HEAD(rte_fman_if_list, __fman_if); > > /* Represents the different flavour of network interface */ > enum fman_mac_type { > - fman_offline_internal = 0, > + fman_offline = 0, > fman_mac_1g, > fman_mac_10g,