Hi Yigit, Ok, I will describe the documentation in detail to avoid confusion. Thanks for the review.
Regards, Mingjin > -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@amd.com> > Sent: Monday, September 23, 2024 3:06 AM > To: Ye, MingjinX <mingjinx...@intel.com>; dev@dpdk.org > Cc: Richardson, Bruce <bruce.richard...@intel.com> > Subject: Re: [PATCH v2 0/3] add frequency adjustment support for PTP > > On 9/10/2024 10:13 AM, Mingjin Ye wrote: > > [1/3] ethdev: add frequency adjustment API [2/3] net/ice: add > > frequency adjustment support for PTP [3/3] examples/ptpclient: add > > frequency adjustment support > > --- > > v2: rte_eth_timesync_adjust_freq marked as experimental. > > > > Mingjin Ye (3): > > ethdev: add frequency adjustment API > > net/ice: add frequency adjustment support for PTP > > examples/ptpclient: add frequency adjustment support > > > > Hi Mingjin, > > Overall OK to have the API, and except from a minor documentation issue > patch is OK. > > Only lets try to make describe it a little more detail, so users and driver > developers can use is better without confusion.