[PATCH v2] examples/ipsec-secgw: fix dequeue count from cryptodev

Setting dequeue packet count to max of MAX_PKT_BURST size instead of MAX_PKTS. Dequeue from cryptodev is called with MAX_PKTS but routing functions allocate hop/dst_ip arrays of size MAX_PKT_BURST. This can corrupt stack causing stack smashing error when more than MAX_PKT_BURST packets are returne

Re: [PATCH v2 1/4] power: refactor core power management library

在 2024/9/12 19:17, Tummala, Sivaprasad 写道: [AMD Official Use Only - AMD Internal Distribution Only] Hi Huisong, Please find my response inline. -Original Message- From: lihuisong (C) Sent: Tuesday, August 27, 2024 1:51 PM To: Tummala, Sivaprasad Cc: dev@dpdk.org; david.h...@intel.

Re: 21.11.8 patches review and test

RedHat QE tested below 18 scenarios on RHEL 9.4 and didn't find any new dpdk issues. - VM with device assignment(PF) throughput testing(1G hugepage size): PASS - VM with device assignment(PF) throughput testing(2M hugepage size) : PASS - VM with device assignment(VF) throughput test

Re: [PATCH v3] doc: add new driver guidelines

On 9/13/2024 5:19 AM, WanRenyong wrote: > On 2024/9/13 4:26, Stephen Hemminger wrote >> + >> +Finalizing >> +-- >> + >> +Once the driver has been upstreamed, the author has >> +a responsibility to the community to maintain it. >> + >> +This includes the public test report. Authors must send

Re: [PATCH v2 1/1] net/ixgbe: update base code README

On Mon, Sep 09, 2024 at 09:47:32AM +0100, Anatoly Burakov wrote: > When last driver update was performed, README was not updated with data on > latest shared code package generation date. Update README to reflect the > date of last shared code package generation. > > Signed-off-by: Anatoly Burakov

[DPDK/meson Bug 1542] [dpdk21.11.8-rc1] meson build failed on Ubuntu24.04 and Fedora40

https://bugs.dpdk.org/show_bug.cgi?id=1542 Bug ID: 1542 Summary: [dpdk21.11.8-rc1] meson build failed on Ubuntu24.04 and Fedora40 Product: DPDK Version: 21.11 Hardware: x86 OS: Linux Status: UNCO

RE: 21.11.8 patches review and test

Update the test status for Intel part. completed dpdk21.11.8-rc1 all validation, Found one new issue. issue: Bug 1542 - [dpdk21.11.8-rc1] meson build failed on Ubuntu24.04 and Fedora40 # Basic Intel(R) NIC testing * Build & CFLAG compile: cover the build test combination with latest GCC/Clan

RE: [PATCH v2 2/2] app/testpmd: add set dev led on/off command

> On 2024/9/12 14:54, Chaoyong He wrote: > > From: James Hershaw > > > > Add command to change the state of a controllable LED on an ethdev > > port to on/off. This is for the purpose of identifying which physical > > port is associated with an ethdev. > > > > usage: > > testpmd> set port led

RE: [PATCH v2 1/2] app/testpmd: add support for setting device EEPROM

> On 2024/9/12 14:54, Chaoyong He wrote: > > From: James Hershaw > > > > There is currently no means to test the .set_eeprom function callback > > of a given PMD in drivers/net/. This patch adds functionality to allow > > a user to set device eeprom from the testpmd cmdline. > > > > usage: > > t

Re: [PATCH v3 00/12] Align ICE shared code with Base driver

On Wed, Aug 28, 2024 at 05:42:24PM +0100, Bruce Richardson wrote: > On Fri, Aug 23, 2024 at 09:56:38AM +, Soumyadeep Hore wrote: > > Updating the latest shared code patches to ICE base driver. > > > > --- > > v3: > > - Addressed comments givn by reviewer > > --- > > v2: > > - Addressed comment

Re: [PATCH v4] net/ice: support customized search path for DDP package

On Fri, Sep 13, 2024 at 02:15:37PM +0800, Zhichao Zeng wrote: > This patch adds support for customizing firmware search path for > DDP package like the kernel behavior, it will read the search path > from "/sys/module/firmware_class/parameters/path", and try to load > DDP package. > > Also, update

Re: [PATCH v3 3/7] eal: add lcore variable performance test

On Fri, Sep 13, 2024 at 12:17 PM Mattias Rönnblom wrote: > > On 2024-09-12 17:11, Jerin Jacob wrote: > > On Thu, Sep 12, 2024 at 6:50 PM Mattias Rönnblom > > wrote: > >> > >> On 2024-09-12 15:09, Jerin Jacob wrote: > >>> On Thu, Sep 12, 2024 at 2:34 PM Mattias Rönnblom > >>> wrote: > > >>>

[RFC v0 1/1] dmadev: provide priority configuration support

From: Vamsi Attunuru Some DMA controllers offer the ability to configure priority level for the hardware command queues, allowing for the prioritization of DMA command execution based on queue importance. This patch introduces the necessary fields in the dmadev structures to retrieve information

[PATCH 1/2] pcapng: fix handling of chained mbufs

The pcapng generates corrupted files when dealing with chained mbufs. This issue arises because in rte_pcapng_copy the length of the EPB block is incorrectly calculated using the data_len of the first mbuf instead of the pkt_len, despite that rte_pcapng_write_packets correctly writing the mbuf chai

[PATCH v2 1/2] pcapng: fix handling of chained mbufs

The pcapng generates corrupted files when dealing with chained mbufs. This issue arises because in rte_pcapng_copy the length of the EPB block is incorrectly calculated using the data_len of the first mbuf instead of the pkt_len, despite that rte_pcapng_write_packets correctly writing the mbuf chai

[PATCH v2 2/2] test/pcapng: test chained mbufs

Adjust test to check if pcapng works with chained mbufs Signed-off-by: Oleksandr Nahnybida --- app/test/test_pcapng.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/app/test/test_pcapng.c b/app/test/test_pcapng.c index 2665b08c76..b219873c3a 100644 --- a/app/te

Re: Unable to access DPDK KMODS folder

Hi Team I have subscribed to the mailer lists. And hence re-adding the request below. As part of DPDK-22.11.2, we were downloading the dpdk-kmods folder from the following link: http://dpdk.org/git/dpdk-kmods. Off late, this link is down and even the alternate link: https://git.dpdk.org/dpdk-km

[PATCH v2 2/2] test/pcapng: test chained mbufs

Adjust test to check if pcapng works with chained mbufs Signed-off-by: Oleksandr Nahnybida --- Resending PATCH v2 2/2 as the previous submission was incorrectly threaded to the v1. Please ignore the earlier email app/test/test_pcapng.c | 12 ++-- 1 file changed, 10 insertions(+), 2 dele

[PATCH v2 2/2] test/pcapng: test chained mbufs

Adjust test to check if pcapng works with chained mbufs Signed-off-by: Oleksandr Nahnybida --- Sorry for the mess. Resending PATCH v2 2/2 as the previous submission was incorrectly threaded to the v1. Please ignore the earlier email app/test/test_pcapng.c | 12 ++-- 1 file changed, 10 i

Re: [PATCH v2 1/1] drivers/baseband: device queues initialization

On 8/23/24 16:56, Hernan Vargas wrote: Cosmetic change to keep code consistency in PMD for queue initialization set to zero. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 1 + drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c

Re: [PATCH v2 0/3] bbdev: sdditional queue stats

On 8/13/24 01:41, Nicolas Chautru wrote: v2: update to ABI doc suggested by Maxime. These series include introducing a new paramter in the queue stat which can be used to monitor the number of available enqueue still possible. The acc PMD is then refactored to use a set of common function t

Re: [PATCH v1 0/3] bbdev: new k0 parameter

On 7/1/24 23:27, Nicolas Chautru wrote: Hi Maxime, Hemant, Capturing below an extension for 24.11. This includes bbdev api change and related change for test application and acc/vrb PMD. This provides the ability which was introduced in 3gPP standard to have an alternate way to compute k0 no

Re: [PATCH] baseband/fpga_5gnr_fec: remove useless cast

On 7/25/24 19:17, Stephen Hemminger wrote: The rte_pktmbuf_mtod_offset macro already includes a type cast so casting the result just adds extra cast. Found by cocci/mtod-offset.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 4 ++-- 1 file c

Re: [PATCH v3 1/1] bbdev: removing unnecessary symbols from version map

On 8/28/24 01:06, Nicolas Chautru wrote: A number of inline functions should not be in the version map since ABI versioning would be irrelevant. Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.h| 1 - lib/bbdev/rte_bbdev_op.h | 2 -- lib/bbdev/version.map| 24 +--

Re: [PATCH v2 1/2] bbdev: add new function to dump debug information

On 8/29/24 22:06, Nicolas Chautru wrote: This provides a new API to dump more debug information related to the status on a given bbdev queue. Some of this information is visible at bbdev level. This also provides a new option dev op, to print more information at the lower PMD level. This helps

Re: [RFC 0/2] introduce LLC aware functions

On 9/12/2024 1:50 PM, Varghese, Vipin wrote: [Public] Snipped Based on the discussions we agreed on sharing version-2 FRC for extending API as `rte_get_next_lcore_extnd` with extra argument as `flags`. As per my ideation, for the API ` rte_get_next_sibling_core`, the above

Re: [PATCH v2 2/2] baseband/acc: improvement to logging mechanism

On 8/29/24 22:06, Nicolas Chautru wrote: Support the new dev op to dump operations information related to a given queue and information on previous errors detected by the driver and tracked internally in PMD. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 37 +

RE: [PATCH v3 3/7] eal: add lcore variable performance test

> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Friday, 13 September 2024 13.24 > > On Fri, Sep 13, 2024 at 12:17 PM Mattias Rönnblom > wrote: > > > > On 2024-09-12 17:11, Jerin Jacob wrote: > > > On Thu, Sep 12, 2024 at 6:50 PM Mattias Rönnblom > wrote: > > >> > > >> On 2024-09-12 15

Re: [PATCH v1 01/10] baseband/acc: fix access to deallocated mem

On 8/30/24 22:09, Hernan Vargas wrote: Prevent op_addr access during queue_stop operation, as this memory may have been deallocated. Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 36

RE: [PATCH v7] mempool: test performance with larger bursts

PING for apply. Patch has 2 acks. And since it was signed off by a co-maintainer (myself), I don't think an ack from the other co-maintainer (Andrew) is required. Please correct me if I'm wrong? -Morten > -Original Message- > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Se

Re: [PATCH 1/2] pcapng: fix handling of chained mbufs

On Fri, 13 Sep 2024 15:19:18 +0300 Oleksandr Nahnybida wrote: > The pcapng generates corrupted files when dealing with chained mbufs. > This issue arises because in rte_pcapng_copy the length of the EPB block > is incorrectly calculated using the data_len of the first mbuf instead > of the pkt_le

Re: [PATCH v3] doc: add new driver guidelines

On Fri, 13 Sep 2024 10:07:26 +0100 Ferruh Yigit wrote: > > 4. If a distribution does not include > the dependency, I redistribute > it with the dependency and open source, > > this is somewhat similar to mlnx_ofed, is it publicly or freely? > > > > All looks good from DPDK perspective, alth

Re: Unable to access DPDK KMODS folder

On 9/13/2024 1:48 PM, Pavithra Raghavendran wrote: > Hi Team > > I have subscribed to the mailer lists. And hence re-adding the request > below. > > As part of DPDK-22.11.2, we were downloading the dpdk-kmods folder from > the following link: http://dpdk.org/git/dpdk-kmods

[DPDK/DTS Bug 1543] [DTS] [Bug] Correctly gather linux interface logical name from lshw when a list is returned

https://bugs.dpdk.org/show_bug.cgi?id=1543 Bug ID: 1543 Summary: [DTS] [Bug] Correctly gather linux interface logical name from lshw when a list is returned Product: DPDK Version: unspecified Hardware: All O

[PATCH] ethdev: optimize activation of fast-path tracepoints

From: Adel Belkhiri Split the tracepoints rte_ethdev_trace_rx_burst and rte_eth_trace_call_rx_callbacks into two separate ones for empty and non-empty calls to avoid saturating quickly the trace buffer. Signed-off-by: Adel Belkhiri --- .mailmap | 1 + lib/ethdev/ethdev

RE: [PATCH v2 2/2] baseband/acc: improvement to logging mechanism

Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, September 13, 2024 7:18 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: hemant.agra...@nxp.com; Marchand, David > ; Vargas, Hernan > Subject: Re: [PATCH v2 2/2] baseband/acc: improvement to logging > mechanism > >

RE: [PATCH] ethdev: optimize activation of fast-path tracepoints

> +++ b/lib/ethdev/version.map > @@ -207,7 +207,8 @@ EXPERIMENTAL { > rte_flow_dev_dump; > > # added in 20.05 > - __rte_ethdev_trace_rx_burst; > + __rte_ethdev_trace_rx_burst_empty; > + __rte_ethdev_trace_rx_burst_nonempty; These two should be moved down below "# added in

[PATCH v3 0/2] bbdev: dump debug information

v3: updated based on Maxime comments related to passing string through function prototype. Thanks v2: updated with comments from Hemant and rebased. v1: Hi Maxime. Adding new support to support troubleshooting. This provides to the application an API to dump into file information to help troubl

[PATCH v3 1/2] bbdev: add new function to dump debug information

This provides a new API to dump more debug information related to the status on a given bbdev queue. Some of this information is visible at bbdev level. This also provides a new option dev op, to print more information at the lower PMD level. This helps user to troubleshoot issues related to previo

[PATCH v3 2/2] baseband/acc: improvement to logging mechanism

Support the new dev op to dump operations information related to a given queue and information on previous errors detected by the driver and tracked internally in PMD. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 38 + drivers/baseband/acc/rte_vrb_pmd.c | 129

RE: [PATCH v2 1/2] bbdev: add new function to dump debug information

Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, September 13, 2024 7:10 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: hemant.agra...@nxp.com; Marchand, David > ; Vargas, Hernan > Subject: Re: [PATCH v2 1/2] bbdev: add new function to dump debug > information >

[PATCH v3 0/2] add two commands for testpmd application

This patch series aims to add two commands for the testpmd application: - testpmd> set port eeprom magic \ value offset - testpmd> set port led --- v3: * Add acknowledgement for the set eeprom command. * Modify logic following the request from reviewer. v2: * Solve the conflict in

[PATCH v3 1/2] app/testpmd: add support for setting device EEPROM

From: James Hershaw There is currently no means to test the .set_eeprom function callback of a given PMD in drivers/net/. This patch adds functionality to allow a user to set device eeprom from the testpmd cmdline. Usage: testpmd> set port eeprom magic \ value offset - i

[PATCH v3 2/2] app/testpmd: add set dev led on/off command

From: James Hershaw Add command to change the state of a controllable LED on an ethdev port to on/off. This is for the purpose of identifying which physical port is associated with an ethdev. Usage: testpmd> set port led Signed-off-by: James Hershaw Reviewed-by: Chaoyong He --- app/test-

Re: [PATCH v2 05/19] net/xsc: add ioctl command interface

On Fri, 13 Sep 2024 10:55:08 +0800 "WanRenyong" wrote: > > > >> Ioctl API is used for interaction between PMD and kernel driver. As you > >> said, ioctl is > >> > >> the worst API, should I consider using read and write instead? > > It seemed the ioctl couldn't handle VF located in VM, and in

Re: [PATCH v2 05/19] net/xsc: add ioctl command interface

On 2024/9/14 10:54, Stephen Hemminger wrote: > On Fri, 13 Sep 2024 10:55:08 +0800 > "WanRenyong" wrote: > >>> Ioctl API is used for interaction between PMD and kernel driver. As you said, ioctl is the worst API, should I consider using read and write instead? >>> It seemed