RE: [PATCH 07/11] net/txgbe: move wrapper to base driver

2024-09-09 Thread Jiawen Wu
On Mon, Sep 9, 2024 2:51 PM, David Marchand wrote: > On Mon, Sep 9, 2024 at 8:18 AM Jiawen Wu wrote: > > > > On Sat, Sep 7, 2024 10:54 PM, David Marchand wrote: > > > BP_LOG() is only used in the base driver. > > > > > > Signed-off-by: David Marchand > > > --- > > > drivers/net/txgbe/base/txgbe

Re: [PATCH 11/11] drivers: use per line logging in helpers

2024-09-09 Thread Andrew Rybchenko
On 9/9/24 09:55, David Marchand wrote: On Sun, Sep 8, 2024 at 10:55 AM Andrew Rybchenko wrote: On 9/7/24 17:54, David Marchand wrote: Use RTE_LOG_LINE in existing macros that append a \n. Signed-off-by: David Marchand [snip] diff --git a/drivers/common/sfc_efx/sfc_efx_log.h b/drivers/c

Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-09-09 Thread Juraj Linkeš
On 6. 9. 2024 18:46, Luca Vizzarro wrote: On 23/08/2024 13:16, Juraj Linkeš wrote: As Jeremy mentioned, adding the verify argument may be worthwhile, but maybe only if we actually identify a usecase where we wouldn't want to do the verification. Yeah, as I pointed out, it feels unlikely to

Re: [RFC v2 0/3] Import Kernel uAPI header files

2024-09-09 Thread Maxime Coquelin
On 9/9/24 02:31, Stephen Hemminger wrote: On Fri, 6 Sep 2024 17:23:34 +0200 Maxime Coquelin wrote: This series enables importing Linux Kernel uAPI headers into the DPDK repository. It aims at solving alignment issues between the build system and the system applications linked ot DPDK libra

Re: [RFC PATCH v1 4/5] eal: rename --socket-mem/--socket-limit

2024-09-09 Thread fengchengwen
On 2024/9/6 19:47, Anatoly Burakov wrote: > Currently, --socket-mem and --socket-limit EAL flags effectively refer to > NUMA nodes, not CPU sockets. Update the flag names to reflect this. Old > flag names are still supported for backward compatibility. > > Signed-off-by: Anatoly Burakov > --- >

Re: [RFC 1/3] uapi: introduce kernel uAPI headers importation

2024-09-09 Thread Maxime Coquelin
On 9/9/24 02:02, Stephen Hemminger wrote: On Fri, 6 Sep 2024 00:15:26 +0200 Maxime Coquelin wrote: This patch introduces uAPI headers importation into the DPDK repository. This import is possible thanks to Linux Kernel licence exception for syscalls: https://git.kernel.org/pub/scm/linux/k

Re: [RFC PATCH v1 5/5] lcore: store physical package ID internally

2024-09-09 Thread fengchengwen
It seemed there is no usage scenario of the new field, suggest add it when we indeed need it. On 2024/9/6 19:47, Anatoly Burakov wrote: > This patch introduces a new field in the lcore structure that stores the > physical package ID of the core. This field is populated during EAL init. > It is no

Re: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK

2024-09-09 Thread fengchengwen
for commit 1~4, Acked-by: Chengwen Feng On 2024/9/6 19:47, Anatoly Burakov wrote: > While initially, DPDK has used the term "socket ID" to refer to physical > package > ID, the last time DPDK read "physical_package_id" for socket ID was ~9 years > ago, so it's been a while since we've actually s

[PATCH v4 1/8] zsda: Introduce zsda device drivers

2024-09-09 Thread Hanxiao Li
Introduce driver support for ZSDA which can help to accelerate storage data process. Signed-off-by: Hanxiao Li --- MAINTAINERS | 4 + config/rte_config.h | 4 + drivers/common/zsda/meson.build | 25 +++ drivers/common/zsda/zsda_common.c | 168 ++

[PATCH v4 5/8] zsda: modify files for introducing zsda cryptodev

2024-09-09 Thread Hanxiao Li
It is necessary to make necessary modifications to existing files based on the newly introduced content Signed-off-by: Hanxiao Li --- MAINTAINERS | 3 ++ drivers/common/zsda/zsda_common.h | 50 +++ drivers/common/zsda/zsda_device.c | 42 +++-

[PATCH v4 4/8] zsda: add zsda compressdev driver and interface

2024-09-09 Thread Hanxiao Li
Add zsda compressdev driver and enqueue, dequeue interface. Signed-off-by: Hanxiao Li --- drivers/compress/zsda/zsda_comp.c | 320 ++ drivers/compress/zsda/zsda_comp.h | 27 ++ drivers/compress/zsda/zsda_comp_pmd.c | 453 ++ drivers/compress/zsda/

[PATCH v4 3/8] zsda: add support for queue operation

2024-09-09 Thread Hanxiao Li
Add queue initialization, release, enqueue, dequeue and other interface. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_qp.c | 720 ++ drivers/common/zsda/zsda_qp.h | 160 2 files changed, 880 insertions(+) create mode 100644 drivers/common/zsda/

[PATCH v4 2/8] zsda: add support for zsdadev operations

2024-09-09 Thread Hanxiao Li
Add support for zsdadev operations such as dev_start and dev_stop. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_device.c | 476 ++ drivers/common/zsda/zsda_device.h | 103 +++ 2 files changed, 579 insertions(+) create mode 100644 drivers/common/zsda/zsd

[PATCH v4 6/8] zsda: add zsda crypto-pmd

2024-09-09 Thread Hanxiao Li
Add new file zsda_sym_pmd.c, zsda_sym_pmd.h in drivers/crypto/zsda Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_sym_capabilities.h | 112 + drivers/crypto/zsda/zsda_sym_pmd.c | 429 drivers/crypto/zsda/zsda_sym_pmd.h | 35 ++ 3 files changed,

[PATCH v4 7/8] zsda: add zsda crypto-sym

2024-09-09 Thread Hanxiao Li
Add new file zsda_sym.c, zsda_sym.h in drivers/crypto/zsda Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_sym.c | 286 + drivers/crypto/zsda/zsda_sym.h | 25 +++ 2 files changed, 311 insertions(+) create mode 100644 drivers/crypto/zsda/zsda_sym.c create

[PATCH v4 8/8] zsda: add zsda crypto-session and compile file

2024-09-09 Thread Hanxiao Li
Add new file zsda_sym_session.c, zsda_symsession.h and modify drivers/common/zsda/meson.build Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build| 17 +- drivers/common/zsda/zsda_device.h | 1 - drivers/crypto/zsda/zsda_sym_session.c | 503 + dri

Re: [PATCH v1 0/1] dts: fix hugepage mounting

2024-09-09 Thread Juraj Linkeš
Reviewed-by: Juraj Linkeš On 12. 8. 2024 17:04, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Currently in the DTS framework there are some commands used for remounting hugepages that require super-user privileges but do not use them, causing them to throw errors whenever they are run as a

Re: Does DPDK provide RX timestamps?

2024-09-09 Thread fengchengwen
On 2024/9/9 8:13, Stephen Hemminger wrote: > On Sun, 8 Sep 2024 23:31:36 +0100 > Dpdk Newbie wrote: > >> Hi. I am using Intel (i210) and AWS ENA network interface cards. >> >> I would like to measure the following RX latencies: >> >> 1) NIC to DPDK packet ring buffer >> 2) DPDK packet ring buffer

RE: Does DPDK provide RX timestamps?

2024-09-09 Thread Brandes, Shai
> מאת: Dpdk Newbie > > תאריך: 9 בספט׳ 2024 01:32 > נושא: [EXTERNAL] Does DPDK provide RX timestamps? > אל: dev@dpdk.org > ‏עותק: > > > > Hi. I am using Intel (i210) and AWS ENA network interface cards. > > > > I would like to measure the

Re: [PATCH] raw/zxdh: introduce zxdh raw device driver

2024-09-09 Thread David Marchand
Hello, On Fri, Sep 6, 2024 at 8:20 AM Yong Zhang wrote: > > I recently submitted a patch based on your suggestions. Could you please > review it and let me know if any changes are needed? > Looking forward to your feedback! Sorry, I don't have enough bandwidth to do an in-depth review. -- Da

Re: [PATCH] app/testpmd: add L4 port to verbose output

2024-09-09 Thread Juraj Linkeš
On 16. 8. 2024 13:46, Luca Vizzarro wrote: On 15/08/2024 16:22, Stephen Hemminger wrote: The verbose output is already too verbose. Maybe you would like the simpler format (which does include the port number) see the network packet dissector patches. Hi Stephen, Thank you for the reply y

[PATCH v1 1/1] net/ixgbe: update base code README

2024-09-09 Thread Anatoly Burakov
When last driver update was performed, README was not updated with data on latest shared code package generation date. Update README to reflect the date of last shared code package generation. Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/README | 4 ++-- 1 file changed, 2 insertions

Re: [PATCH v3 1/8] build: split dependencies into mandatory and optional

2024-09-09 Thread Burakov, Anatoly
On 9/6/2024 4:51 PM, Bruce Richardson wrote: On Wed, Sep 04, 2024 at 04:08:29PM +0100, Anatoly Burakov wrote: Allow specifying dependencies as either mandatory or optional. This does not change anything about the build, but it is useful for tooling to know if a dependency is required or not.

Re: [PATCH v1 1/1] net/ixgbe: update base code README

2024-09-09 Thread Burakov, Anatoly
On 9/9/2024 10:36 AM, Anatoly Burakov wrote: When last driver update was performed, README was not updated with data on latest shared code package generation date. Update README to reflect the date of last shared code package generation. Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/ba

[PATCH v2 1/1] net/ixgbe: update base code README

2024-09-09 Thread Anatoly Burakov
When last driver update was performed, README was not updated with data on latest shared code package generation date. Update README to reflect the date of last shared code package generation. Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/README | 4 ++-- 1 file changed, 2 insertions

[DPDK/cryptodev Bug 1537] Failure to enqueue packets for cryptodev-scheduler_multicore can lead to program crashes

2024-09-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1537 Bug ID: 1537 Summary: Failure to enqueue packets for cryptodev-scheduler_multicore can lead to program crashes Product: DPDK Version: 22.11 Hardware: All

Re: [PATCH v3 1/8] build: split dependencies into mandatory and optional

2024-09-09 Thread Bruce Richardson
On Mon, Sep 09, 2024 at 10:41:25AM +0200, Burakov, Anatoly wrote: > On 9/6/2024 4:51 PM, Bruce Richardson wrote: > > On Wed, Sep 04, 2024 at 04:08:29PM +0100, Anatoly Burakov wrote: > > > Allow specifying dependencies as either mandatory or optional. This does > > > not change anything about the bu

Re:[PATCH] raw/zxdh: introduce zxdh raw device driver

2024-09-09 Thread Yong Zhang
Hi thomas, Could you please provide feedback on the patch I submitted on August 12? Any suggestions for improvement would be appreciated. Thanks

Re: [PATCH v2 2/6] crypto/openssl: support EDDSA

2024-09-09 Thread Jack Bond-Preston
Hi, On 05/09/2024 14:39, Gowrishankar Muthukrishnan wrote: Support EDDSA crypto algorithm in OpenSSL PMD. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/openssl/openssl_pmd_private.h | 13 ++ drivers/crypto/openssl/rte_openssl_pmd.c | 223 +++ drivers/cry

Re: [PATCH] dts: add l2fwd test suite

2024-09-09 Thread Luca Vizzarro
On 09/08/2024 16:27, Jeremy Spewock wrote: Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- Depends-on: series-32714 ("dts: add pktgen and testpmd changes") Out of my own curiosity, are depends on supposed to be outside of the commit body? I don't think it really matters for auto

[PATCH v3 0/5] dts: add pktgen and testpmd changes

2024-09-09 Thread Luca Vizzarro
v3: - add Args to decorators docstring - added `ports_started` class stub - rebased v2: - rebased Luca Vizzarro (6): dts: add ability to send/receive multiple packets dts: add random generation seed setting dts: add random packet generator dts: add ability to start/stop testpmd ports dts

[PATCH v3 1/5] dts: add ability to send/receive multiple packets

2024-09-09 Thread Luca Vizzarro
The framework allows only to send one packet at once via Scapy. This change adds the ability to send multiple packets, and also introduces a new fast way to verify if we received several expected packets. Moreover, it reduces code duplication by keeping a single packet sending method only at the t

[PATCH v3 2/5] dts: add random generation seed setting

2024-09-09 Thread Luca Vizzarro
When introducing pseudo-random generation in the test runs we need to ensure that these can be reproduced by setting a pre-defined seed. This commits adds the ability to set one or allow for one to be generated and reported back to the user. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepan

[PATCH v3 3/5] dts: add random packet generator

2024-09-09 Thread Luca Vizzarro
Add a basic utility that can create random L3 and L4 packets with random payloads and port numbers (if L4). Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Alex Chapman Reviewed-by: Jeremy Spewock Reviewed-by: Juraj Linkeš --- dts/framework/utils.py | 79 ++

[PATCH v3 4/5] dts: add ability to start/stop testpmd ports

2024-09-09 Thread Luca Vizzarro
Add testpmd commands to start and stop all the ports, so that they can be configured. Because there is a distinction of commands that require the ports to be stopped and started, also add decorators for commands that require a specific state, removing this logic from the test writer's duty. Signed

[PATCH v3 5/5] dts: add testpmd set ports queues

2024-09-09 Thread Luca Vizzarro
Add a facility to update the number of TX/RX queues during the runtime of testpmd. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/remote_session/testpmd_shell.py | 16 1 file changed, 16 insertions(+) diff --git a/dts/framework/remote_session/testp

[PATCH] net/iavf: delay VF reset command

2024-09-09 Thread Bruce Richardson
Commit 0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF"), introduced a VF-reset adminq call into the reset sequence for iavf. However, that call was very early in the sequence before other adminq commands had been sent. To delay the VF reset, we can put the message sending in the "dev_close"

Re: [PATCH v2] net/sxe: add net driver sxe

2024-09-09 Thread Thomas Monjalon
07/09/2024 01:39, Jie Liu: > MAINTAINERS|2 +- > doc/guides/nics/features/sxe.ini |1 + > drivers/net/sxe-dpdk-0.0.0.0-src.tar.gz| Bin 0 -> 196888 bytes > drivers/net/sxe.zip| Bin 0 -> 193908 bytes Please do not subm

Re: [PATCH v3 1/1] dts: add text parser for testpmd verbose output

2024-09-09 Thread Juraj Linkeš
diff --git a/dts/framework/parser.py b/dts/framework/parser.py index 741dfff821..0b39025a48 100644 --- a/dts/framework/parser.py +++ b/dts/framework/parser.py @@ -160,6 +160,36 @@ def _find(text: str) -> Any: return ParserFn(TextParser_fn=_find) +@staticmethod +def find

Re: [PATCH v3 4/5] dts: add ability to start/stop testpmd ports

2024-09-09 Thread Juraj Linkeš
On 9. 9. 2024 13:01, Luca Vizzarro wrote: Add testpmd commands to start and stop all the ports, so that they can be configured. Because there is a distinction of commands that require the ports to be stopped and started, also add decorators for commands that require a specific state, removing

Re: [PATCH v3 5/5] dts: add testpmd set ports queues

2024-09-09 Thread Juraj Linkeš
On 9. 9. 2024 13:01, Luca Vizzarro wrote: Add a facility to update the number of TX/RX queues during the runtime of testpmd. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš

Re: [PATCH v3 0/5] Improve EAL bit operations API

2024-09-09 Thread Mattias Rönnblom
On 2024-09-05 10:10, David Marchand wrote: Hello, On Tue, Aug 20, 2024 at 7:05 PM Mattias Rönnblom wrote: On 2024-08-12 14:49, Mattias Rönnblom wrote: This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits.

Re: [PATCH v2] net/ice: support customized search path for DDP package

2024-09-09 Thread Bruce Richardson
On Thu, Aug 29, 2024 at 11:41:58AM +0800, Zhichao Zeng wrote: > This patch adds support for customizing firmware search path for > DDP package like the kernel behavior, it will read the search path > from "/sys/module/firmware_class/parameters/path", > and try to load DDP package. > > Signed-off-b

Re: [PATCH 1/1] dts: add binding to different drivers to TG node

2024-09-09 Thread Juraj Linkeš
On 12. 8. 2024 19:22, jspew...@iol.unh.edu wrote: From: Jeremy Spewock The DTS framework in its current state supports binding ports to different drivers on the SUT node but not the TG node. The TG node already has the information that it needs about the different drivers that it has availab

Re: [PATCH v3 0/5] Improve EAL bit operations API

2024-09-09 Thread Thomas Monjalon
09/09/2024 14:04, Mattias Rönnblom: > What one should do is to have extern "C" linkage only on functions which > the include file in question (e.g., rte_foo.h) itself declares. > > -- > /* rte_bar.h */ > #include > > #ifdef __cplusplus > extern "C" { > #endif > > void > rte_foo_do(void); > >

Re: [PATCH v3 0/5] Improve EAL bit operations API

2024-09-09 Thread David Marchand
On Mon, Sep 9, 2024 at 2:05 PM Mattias Rönnblom wrote: > > Mattias, there are issues reported by the CI (compilation on Ubuntu > > 22.04 in GHA, and unit test failure in UNH), please have a look. > > > > > > Standard practice in DPDK header files is the following: > > -- > /* rte_bar.h */ > #ifdef

Re: [PATCH v4 1/1] dts: add methods for modifying MTU to testpmd shell

2024-09-09 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v4 1/1] dts: add methods for modifying MTU to testpmd shell

2024-09-09 Thread Luca Vizzarro
On 06/09/2024 19:00, jspew...@iol.unh.edu wrote: From: Jeremy Spewock There are methods within DTS currently that support updating the MTU of ports on a node, but the methods for doing this in a linux session rely on the ip command and the port being bound to the kernel driver. Since test suite

Re: [PATCH v3 0/5] Improve EAL bit operations API

2024-09-09 Thread Mattias Rönnblom
On 2024-09-09 14:25, David Marchand wrote: On Mon, Sep 9, 2024 at 2:05 PM Mattias Rönnblom wrote: Mattias, there are issues reported by the CI (compilation on Ubuntu 22.04 in GHA, and unit test failure in UNH), please have a look. Standard practice in DPDK header files is the following: --

[PATCH] examples/flow_filtering: introduce use cases snippets

2024-09-09 Thread Shani Peretz
These code snippets demonstrate rule creation using template and non-template APIs. They include functions that enable developers to create rules. The purpose of providing these snippets is to allow developers to reuse them, thereby saving time and effort during the implementation of flow rules. T

Re: [PATCH v2 1/5] dts: add ability to send/receive multiple packets

2024-09-09 Thread Jeremy Spewock
On Fri, Sep 6, 2024 at 12:23 PM Luca Vizzarro wrote: > > On 09/08/2024 16:10, Jeremy Spewock wrote: > > > >> +def match_all_packets( > >> +self, expected_packets: list[Packet], received_packets: > >> list[Packet] > >> +) -> None: > > > > This is a very interesting approach to com

RE: [RFC 0/2] introduce LLC aware functions

2024-09-09 Thread Varghese, Vipin
[AMD Official Use Only - AMD Internal Distribution Only] > > >> Yes, this does help clarify things a lot as to why current NUMA > >> support would be insufficient to express what you are describing. > >> > >> However, in that case I would echo sentiment others have expressed > >> already as thi

Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-09-09 Thread Jeremy Spewock
On Fri, Sep 6, 2024 at 12:46 PM Luca Vizzarro wrote: > > On 23/08/2024 13:16, Juraj Linkeš wrote: > > As Jeremy mentioned, adding the verify argument may be worthwhile, but > > maybe only if we actually identify a usecase where we wouldn't want to > > do the verification. > > Yeah, as I pointed ou

Re: [PATCH v3 4/5] dts: add ability to start/stop testpmd ports

2024-09-09 Thread Jeremy Spewock
On Mon, Sep 9, 2024 at 7:03 AM Luca Vizzarro wrote: > > Add testpmd commands to start and stop all the ports, so that they can > be configured. Because there is a distinction of commands that require > the ports to be stopped and started, also add decorators for commands > that require a specific

Re: [PATCH v3 5/5] dts: add testpmd set ports queues

2024-09-09 Thread Jeremy Spewock
On Mon, Sep 9, 2024 at 7:03 AM Luca Vizzarro wrote: > > Add a facility to update the number of TX/RX queues during the runtime > of testpmd. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek Reviewed-by: Jeremy Spewock

RE: [RFC 0/2] introduce LLC aware functions

2024-09-09 Thread Varghese, Vipin
[AMD Official Use Only - AMD Internal Distribution Only] > > > > > > Thank you Mattias for the comments and question, please let me try to > > explain the same below > > > >> We shouldn't have a separate CPU/cache hierarchy API instead? > > > > Based on the intention to bring in CPU lcores whic

Re: [RFC 0/2] introduce LLC aware functions

2024-09-09 Thread Mattias Rönnblom
On 2024-09-09 16:22, Varghese, Vipin wrote: [AMD Official Use Only - AMD Internal Distribution Only] Thank you Mattias for the comments and question, please let me try to explain the same below We shouldn't have a separate CPU/cache hierarchy API instead? Based on the intention to bring

Re: [PATCH] dts: add l2fwd test suite

2024-09-09 Thread Patrick Robb
Reviewed-by: Patrick Robb Tested-by: Patrick Robb Ran on a Broadcom 57414 2x25G NIC on an Intel x86 server. I'll follow up with a review on the pktgen and testpmd changes series as obviously we want to move that to next-dts. Thanks! On Tue, Aug 6, 2024 at 8:53 AM Luca Vizzarro wrote: > +d

[PATCH v4 3/6] eal: add unit tests for bit operations

2024-09-09 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_[test|set|clear|assign|flip]() functions. The tests are converted to use the test suite runner framework. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v6: * Test rte_bit_*test()

[PATCH v4 2/6] eal: extend bit manipulation functionality

2024-09-09 Thread Mattias Rönnblom
Add functionality to test and modify the value of individual bits in 32-bit or 64-bit words. These functions have no implications on memory ordering, atomicity and does not use volatile and thus does not prevent any compiler optimizations. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup

[PATCH v4 6/6] eal: extend bitops to handle volatile pointers

2024-09-09 Thread Mattias Rönnblom
Have rte_bit_[test|set|clear|assign|flip]() and rte_bit_atomic_*() handle volatile-marked pointers. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Jack Bond-Preston -- PATCH v3: * Updated to reflect removed 'fun' parameter in __RTE_GEN_BIT_*() (Jack Bond-Preston). PATC

[PATCH v4 4/6] eal: add atomic bit operations

2024-09-09 Thread Mattias Rönnblom
Add atomic bit test/set/clear/assign/flip and test-and-set/clear/assign/flip functions. All atomic bit functions allow (and indeed, require) the caller to specify a memory order. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston --

[PATCH v4 5/6] eal: add unit tests for atomic bit access functions

2024-09-09 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --

[PATCH v4 0/6] Improve EAL bit operations API

2024-09-09 Thread Mattias Rönnblom
This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. All new functionality is exposed to the user as generic selection macros, delegating the actual work to private (__-marked) static inline functions. Public fun

Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-09-09 Thread Juraj Linkeš
On 9. 9. 2024 16:20, Jeremy Spewock wrote: On Fri, Sep 6, 2024 at 12:46 PM Luca Vizzarro wrote: On 23/08/2024 13:16, Juraj Linkeš wrote: As Jeremy mentioned, adding the verify argument may be worthwhile, but maybe only if we actually identify a usecase where we wouldn't want to do the veri

Re: [PATCH v1 1/1] dts: add admin privileges to hugepage mounting

2024-09-09 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v1 1/1] dts: add admin privileges to hugepage mounting

2024-09-09 Thread Juraj Linkeš
On 12. 8. 2024 17:04, jspew...@iol.unh.edu wrote: From: Jeremy Spewock There were two different commands in the hugepage mounting process that were not using super-user privileges; one for unmounting hugepages and another for re-mounting them. This patch adds the flag that enables enhanced pe

Re: [PATCH 0/4] dts: add pktgen and testpmd changes

2024-09-09 Thread Juraj Linkeš
Series applied to next-dts, thanks. On 6. 8. 2024 14:14, Luca Vizzarro wrote: From: Luca Vizzarro Hello, sending some framework changes that will be required in my upcoming l2fwd test suite. Best, Luca Luca Vizzarro (5): dts: add ability to send/receive multiple packets dts: add rando

Re: [PATCH v1] dts: fix testpmd port device error handling mode

2024-09-09 Thread Juraj Linkeš
Applied to next-dts, thanks. On 23. 8. 2024 9:45, Juraj Linkeš wrote: Make device_error_handling_mode of testpmd port optional as it may not be present, e.g. in VM ports. Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell") Signed-off-by: Juraj Linkeš --- dts/framework/remote

Re: [PATCH v1] dts: add testpmd port information caching

2024-09-09 Thread Juraj Linkeš
Applied to next-dts, thanks. On 23. 8. 2024 9:41, Juraj Linkeš wrote: When using port information multiple times in a testpmd shell instance lifespan, it's desirable to not get the information each time, so caching is added. In case the information changes, there's a way to force the update with

[PATCH v11 0/3] Independent Enqueue Support

2024-09-09 Thread Abdullah Sevincer
v11: Address comments. v10: Add acked-by reviewer name. v9: Address comments. v8: Address build issues. v7: Address documentation reviews. v6: Update patch with more documentation v5: Address build issues v4: Address comments v3: Fix CI/build issues v2: Fix CI/build issues v1: Initial patchset Abd

[PATCH v11 1/3] eventdev: add support for independent enqueue

2024-09-09 Thread Abdullah Sevincer
This commit adds support for independent enqueue feature and updates Event Device and PMD feature list. A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced. It allows out-of-order enqueuing of RTE_EVENT_OP_FORWARD or RELEASE type events on an event port where this capability is enable

[PATCH v11 2/3] event/dlb2: add support for independent enqueue

2024-09-09 Thread Abdullah Sevincer
DLB devices need events to be enqueued in the same order they are dequeued. Applications are not suppose to change event order between dequeue and to enqueue. Since Eventdev standard does not add such restrictions independent enqueue support is needed for DLB PMD so that it restores dequeue order o

[PATCH v11 3/3] event/dsw: add capability for independent enqueue

2024-09-09 Thread Abdullah Sevincer
To use independent enqueue capability applications need to set flag RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ during port setup only if the capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ exists. Hence, this commit adds the capability of independent enqueue to the DSW driver. Signed-off-by: Abdullah Sevince

Re: [PATCH v4 0/1] dts: allow for updating MTU with testpmd

2024-09-09 Thread Juraj Linkeš
Applied to next-dts, thanks. On 6. 9. 2024 20:00, jspew...@iol.unh.edu wrote: From: Jeremy Spewock v4: * add dependency on port caching patch to avoid the need for the if-statement that was added in the last version. Jeremy Spewock (1): dts: add methods for modifying MTU to testpmd s

Re: [PATCH v1 0/1] dts: fix hugepage mounting

2024-09-09 Thread Juraj Linkeš
Applied to next-dts, thanks. On 12. 8. 2024 17:04, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Currently in the DTS framework there are some commands used for remounting hugepages that require super-user privileges but do not use them, causing them to throw errors whenever they are run as

Re: [PATCH 1/1] dts: add binding to different drivers to TG node

2024-09-09 Thread Jeremy Spewock
On Mon, Sep 9, 2024 at 8:16 AM Juraj Linkeš wrote: > > > > On 12. 8. 2024 19:22, jspew...@iol.unh.edu wrote: > > From: Jeremy Spewock > > > > The DTS framework in its current state supports binding ports to > > different drivers on the SUT node but not the TG node. The TG node > > already has the

[PATCH v12 2/3] event/dlb2: add support for independent enqueue

2024-09-09 Thread Abdullah Sevincer
DLB devices need events to be enqueued in the same order they are dequeued. Applications are not suppose to change event order between dequeue and to enqueue. Since Eventdev standard does not add such restrictions independent enqueue support is needed for DLB PMD so that it restores dequeue order o

[PATCH v12 0/3] Independent Enqueue Support

2024-09-09 Thread Abdullah Sevincer
v12: Address comments. v11: Address comments. v10: Add acked-by reviewer name. v9: Address comments. v8: Address build issues. v7: Address documentation reviews. v6: Update patch with more documentation. v5: Address build issues. v4: Address comments. v3: Fix CI/build issues. v2: Fix CI/build issue

[PATCH v12 1/3] eventdev: add support for independent enqueue

2024-09-09 Thread Abdullah Sevincer
This commit adds support for independent enqueue feature and updates Event Device and PMD feature list. A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced. It allows out-of-order enqueuing of RTE_EVENT_OP_FORWARD or RELEASE type events on an event port where this capability is enable

[PATCH v12 3/3] event/dsw: add capability for independent enqueue

2024-09-09 Thread Abdullah Sevincer
To use independent enqueue capability applications need to set flag RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ during port setup only if the capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ exists. Hence, this commit adds the capability of independent enqueue to the DSW driver. Signed-off-by: Abdullah Sevince

RE: [PATCH v4 1/6] dpdk: do not force C linkage on include file dependencies

2024-09-09 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Monday, 9 September 2024 16.58 > > Assure that 'extern "C" { /../ }' do not cover files included from a > particular header file, and address minor issues resulting from this > change of order. > > Dealing with C++ should del

[PATCH] Coverity issue: Failure to enqueue packets for cryptodev-scheduler_multicore can lead to program crashes Bugzilla ID: 1537 Fixes: replace `pending_deq_ops` with `pending_enq_ops` Cc: sta...@dp

2024-09-09 Thread Yong Liang
Signed-off-by: Yong Liang <1269690...@qq.com> --- drivers/crypto/scheduler/scheduler_multicore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/scheduler/scheduler_multicore.c b/drivers/crypto/scheduler/scheduler_multicore.c index a21b522f9f..70f8a25b70 100

[PATCH] Coverity issue: Failure to enqueue packets for cryptodev-scheduler_multicore can lead to program crashes Bugzilla ID: 1537 Fixes: replace `pending_deq_ops` with `pending_enq_ops` Cc: sta...@dp

2024-09-09 Thread Yong Liang
Signed-off-by: Yong Liang <1269690...@qq.com> --- drivers/crypto/scheduler/scheduler_multicore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/scheduler/scheduler_multicore.c b/drivers/crypto/scheduler/scheduler_multicore.c index a21b522f9f..70f8a25b70 100

[DPDK/DTS Bug 1538] [DTS] [Doc] add section below "How to write a testsuite" for how to do traffic validation and/or testsuite validation

2024-09-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1538 Bug ID: 1538 Summary: [DTS] [Doc] add section below "How to write a testsuite" for how to do traffic validation and/or testsuite validation Product: DPDK Version: unspeci

Re: [PATCH] Coverity issue: Failure to enqueue packets for cryptodev-scheduler_multicore can lead to program crashes Bugzilla ID: 1537 Fixes: replace `pending_deq_ops` with `pending_enq_ops` Cc: sta..

2024-09-09 Thread Stephen Hemminger
On Tue, 10 Sep 2024 00:48:22 +0800 Yong Liang <1269690...@qq.com> wrote: > Signed-off-by: Yong Liang <1269690...@qq.com> This is not the correct way to put the covertity and bugzilla information into the patch. The infrastruture expects: 1. Put the short description in the Subject line of the e

Re: [PATCH v3 1/5] dts: add ability to send/receive multiple packets

2024-09-09 Thread Patrick Robb
Reviewed-by: Patrick Robb The only thought I had from this was that with more methods being added to the framework for packet construction and validation (in this case, your random packets utils.py method and the testsuite.match_all_packets() strategy), and with multiple reference solutions being

Re: Does DPDK provide RX timestamps?

2024-09-09 Thread Dpdk Newbie
I was looking at the source code but I'm more OOP C++ than C. I found eth_ena_recv_pkts but is it possible for me to add a software timestamp before the mbuf is added to the ring buffer? This would be incredibly useful. On Mon, 9 Sept 2024 at 09:31, Brandes, Shai wrote: > > > > מאת: Dpdk Newbie

Re: [PATCH] dts: add l2fwd test suite

2024-09-09 Thread Nicholas Pratte
Just a few clarifying questions below. Otherwise, (Test cases was run on Connect_x5 and Broadcom P225p devices). Reviewed-by: Nicholas Pratte Tested-by: Nicholas Pratte > + > +with TestPmdShell( > +self.sut_node, > +lcore_filter_specifier=LogicalCoreCount(cores

Re: [PATCH v4 2/2] dts: mac filter test suite refactored for new dts

2024-09-09 Thread Dean Marx
On Fri, Jul 26, 2024 at 12:46 PM Nicholas Pratte wrote: > The mac address filter test suite, whose test cases are based on old > DTS's test cases, has been refactored to interface with the new DTS > framework. > > In porting over this test suite into the new framework, some > adjustments were mad

Re: [PATCH v4 1/2] dts: add methods for setting mac and multicast addresses

2024-09-09 Thread Dean Marx
On Fri, Jul 26, 2024 at 12:45 PM Nicholas Pratte wrote: > New methods have been added to TestPMDShell in order to produce the mac > filter's individual test cases: > - set_mac_addr > - set_multicast_mac_addr > > set_mac_addr and set_multicast_addr were created for the mac filter test > suite, e

Re: [PATCH 2/2] dts: add blocklist test suite

2024-09-09 Thread Dean Marx
On Tue, Jun 25, 2024 at 8:38 AM Luca Vizzarro wrote: > This test suite tests the port blocklisting functionality built in > testpmd. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > Reviewed-by: Dean Marx

Re: [PATCH 1/2] dts: add blocked ports to EalParams

2024-09-09 Thread Dean Marx
On Tue, Jun 25, 2024 at 8:38 AM Luca Vizzarro wrote: > Make the "ports" attribute of EalParams as it actually is to > "allowed_ports", and add "blocked_ports". > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > Reviewed-by: Dean Marx

[PATCH v2] service: extend service function call statistics

2024-09-09 Thread Mattias Rönnblom
Add two new per-service counters. RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function invocations where no work was performed. RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations resulting in an error. The semantics of RTE_SERVICE_ATTR_CALL_COUNT remains the same (

Re: [PATCH v1 1/1] dts: add send_packets to test suites and rework packet addressing

2024-09-09 Thread Dean Marx
On Wed, Sep 4, 2024 at 11:28 AM wrote: > From: Jeremy Spewock > > Currently the only method provided in the test suite class for sending > packets sends a single packet and then captures the results. There is, > in some cases, a need to send multiple packets at once while not really > needing to

Re: [PATCH v4 1/6] dpdk: do not force C linkage on include file dependencies

2024-09-09 Thread fengchengwen
On 2024/9/9 22:57, Mattias Rönnblom wrote: > diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h > index 5474a5281d..11b72b0f2d 100644 > --- a/lib/dmadev/rte_dmadev.h > +++ b/lib/dmadev/rte_dmadev.h > @@ -149,10 +149,6 @@ > #include > #include > > -#ifdef __cplusplus > -extern "C"

Re: [PATCH v2] service: extend service function call statistics

2024-09-09 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/9/10 3:11, Mattias Rönnblom wrote: > Add two new per-service counters. > > RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function > invocations where no work was performed. > > RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations > resu

Re: [PATCH v9 1/2] power: introduce PM QoS API on CPU wide

2024-09-09 Thread fengchengwen
Hi Huisong Please see comments inline. Thanks On 2024/8/9 17:50, Huisong Li wrote: > The deeper the idle state, the lower the power consumption, but the longer > the resume time. Some service are delay sensitive and very except the low > resume time, like interrupt packet receiving mode. > > An

Re: [PATCH v9 2/2] examples/l3fwd-power: add PM QoS configuration

2024-09-09 Thread fengchengwen
Hi Huisong, On 2024/8/9 17:50, Huisong Li wrote: > Add PM QoS configuration to declease the delay after sleep in case of > entering deeper idle state. > > Signed-off-by: Huisong Li > Acked-by: Morten Brørup > --- > examples/l3fwd-power/main.c | 24 > 1 file changed, 24

Re: [PATCH v3 04/26] config: add separate defines for max Rx and Tx queues

2024-09-09 Thread fengchengwen
On 2024/8/14 18:49, Bruce Richardson wrote: > Rather than having a single define for maximum queues per ethernet port, > we can set the max values for Rx queues and Tx queue independently. This > allows future memory saving for apps which only need large numbers of Rx > queues or only large numbers

  1   2   >