I think we already discussed this same patch in previous emails
(Aug-Oct 2023) at
https://mails.dpdk.org/archives/dev/2023-October/279390.html and
concluded that it is not needed ?
Did anything change from then ?
--
Nithin
On Thu, Aug 22, 2024 at 9:03 PM Alexander Kozyrev wrote:
>
> Support the
Hi David, Stephen,
Could you please provide any feedback on the patch I submitted on August
12th?
Thanks
I use the dpdk-23-11 version, system debian11, network card i210, CPU
Cortex-A55. After the dpdk-23-11 service is compiled and installed, Start
dpdk-23-11/examples/multi-process/cron_derve_mp/mp_derver/ build/mpuserver -l
1-2 -n 4 -- -p 1- n 1. Because dpdk only takes over one network card, I
c
Update the i40e base driver to the latest version of the snapshot.
Aleksandr Loktionov (3):
net/i40e/base: remove non-inclusive language
net/i40e/base: fix misleading debug logs and comments
net/i40e/base: make semaphore timeout 32-bit
Anatoly Burakov (6):
net/i40e/base: adjust whitespace
There are some miscellaneous differences in whitespace between shared code
and DPDK snapshot. Adjust whitespace differences to make base code driver
updates easier in the future by reducing the diff between the two.
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_adminq.c | 7
From: Aleksandr Loktionov
Replace usages of the term "master" with "primary".
Signed-off-by: Aleksandr Loktionov
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_common.c | 4 ++--
drivers/net/i40e/base/i40e_status.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff
When generating base code updates, the codebase gets stripped from all of
the define tags that are not needed for that driver version. However, some
tags were left in the code for various reasons, and then force-defined in
the meson build file to make sure the code still compiles. Get rid of all
of
From: Krzysztof Galazka
At one point, there was functionality that was no longer used and was
removed. However, while removing unused logic from the
i40e_validate_filter_settings function, some intermediate variables were
missed and were still being set. Also remove macro definitions for the
regi
The functionality to set i40e_hw's flags was moved to its own function in
AQ a while ago:
commit 37b091c75b13 ("net/i40e/base: extend PHY access AQ command")
However, the setting of hw->flags for X722 was not removed, even though it
has become unnecessary.
Signed-off-by: Anatoly Burakov
---
dr
From: Aleksandr Loktionov
Both comments and debug logs for i40e_read_nvm_aq refer to writing, when
in actuality it's a read function. Fix both comments and debug logs.
Signed-off-by: Aleksandr Loktionov
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_nvm.c | 16
Commit c0ce1c4677fd ("net/i40e: add new X722 device") added a new X722
define as well as one for X710T*L (that wasn't called out in commit
message), however it was not added to the I40E_IS_X710TL_DEVICE check.
This patch adds the missing define to the check.
Fixes: c0ce1c4677fd ("net/i40e: add new
From: Przemyslaw Gierszynski
Added I40E_DEV_ID_XXV710_N3000 (Device ID 0x0D58) as a 25G device to the
i40e_is_25G_device macro.
Signed-off-by: Przemyslaw Gierszynski
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_devids.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
In one of the earlier commits, definitions for X722 were added. However,
code enabling setting MAC type for a particular variant of X722 device
was missed. Add the missing case statement to set the MAC type for that
device.
Fixes: c0ce1c4677fd ("net/i40e: add new X722 device")
Signed-off-by: Anat
From: Lukasz Cieplicki
Add defines related to GL_RXEER1 register. GL_RXEER1 register is composed
of two 32 bits registers (H and L). Receive Error Counter 1
(GL_RXERR1{H,L}) contains count of dropped packets due to one of the
following exceptions:
- Packet size is larger than RXMAX of the queue
From: Eryk Rybak
On x722 with x557 PHY LEDs do not blink under certain circumstances,
because the function was attempting to avoid triggering LED activity when
it detected that LED was already active. Fix it to just always trigger
LED blinking regardless of the LED state.
Signed-off-by: Eryk Ryb
From: Przemyslaw Patynowski
Add VLAN bit used during flow director programming, as a part of
input set for HW.
Signed-off-by: Przemyslaw Patynowski
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_type.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/i40e/base/
From: Dawid Łukwiński
Provide an API to allow reading LED blink setting.
Signed-off-by: Dawid Łukwiński
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_common.c| 29 ++
drivers/net/i40e/base/i40e_prototype.h | 1 +
2 files changed, 30 insertions(+)
From: Artur Tyminski
Packages with reserved track IDs should not be loaded, yet currently, the
driver will only check one of the reserved ID's, but not the other.
Fix the DDP package loading to also check for the other reserved track ID.
Signed-off-by: Artur Tyminski
Signed-off-by: Anatoly Bura
From: Artur Tyminski
This patch adds definitions related to DDP package type.
Signed-off-by: Artur Tyminski
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_type.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/i40e/base/i40e_type.h
b/drivers/net/i40e/base/i40
From: Slawomir Laba
Add X722 input set mask for RSS and flow director.
X722 family is using different shifts on the registers
from X710 NIC family.
Signed-off-by: Slawomir Laba
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_type.h | 4
1 file changed, 4 insertions(+)
diff
From: Björn Töpel
Add i40e_16b_rx_wb_qw0 and raw structs to i40e_16byte_rx_desc, to allow
access both as 16-byte descriptor, and as raw data.
Signed-off-by: Björn Töpel
Signed-off-by: Michal Jaron
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_type.h | 5 -
1 file changed,
From: Vignesh Sridhar
Adding typecast to variables to avoid compiler warnings generated on
certain platforms and compilers if variables of a particular data type
are assigned to ones of a smaller data type.
Signed-off-by: Vignesh Sridhar
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/bas
From: Radoslaw Tyl
Add definitions for register dump for some PHY registers in order to
assist field debugging of link issues.
Signed-off-by: Radoslaw Tyl
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_register.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/driver
From: Michal Nowak
The I40E_PFPM_APM, I40E_PFPM_WUC, I40E_PFPM_WUFC, and I40E_PFPM_WUS should
read bits per PF.
Signed-off-by: Michal Nowak
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_register.h | 8
drivers/net/i40e/i40e_regs.h | 8
2 files change
From: Radoslaw Tyl
Currently, when registers are dumped, the data inside them is changed, so
repeated dumps lead to unexpected results. Fix this by making register list
read-only.
Signed-off-by: Radoslaw Tyl
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_diag.c | 12 ++-
From: Barbara Skobiej
Static analysis tools have reported an unchecked return value warning.
Address the warning by checking return value.
Signed-off-by: Barbara Skobiej
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletio
From: Barbara Skobiej
An unchecked value used as a loop bound. Add verification if value of
'next_to_clean' variable is greater than 2^10 (next_to_clean is 10 bits).
Also, refactored loop so that it reads the head value only once, and also
checks if head is invalid.
Signed-off-by: Barbara Skobi
From: Aleksandr Loktionov
Decrease hw_semaphore_timeout size down to 32bits, because FW
I40E_GLVFGEN_TIMER register is 32bits only anyway, and having both
variables as same 32-bit size simplifies code. Also, fix FW write semaphore
expiration condition, taking into account that I40E_GLVFGEN_TIMER
From: Piotr Skajewski
These registers are relevant to MAC source pruning feature.
Signed-off-by: Piotr Skajewski
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_register.h | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/i40e/base/i40e_register.h
b/driver
From: Midde Ajijur Rehaman
On some platforms, during NVM update the adapter is getting disabled for
long time due to lock in OID_INTEL_FLASH_INFO. At this time, access to
NVM is locked by the tool that updates NVM. As result, driver is unable to
access NVM and it should timeout quickly. This patc
From: Jaroslaw Ilgiewicz
Time variables were designed for 32 bit and 64 bit variables are not
necessary. Changed all to 32 bit.
Signed-off-by: Jaroslaw Ilgiewicz
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/i40e_common.c| 2 +-
drivers/net/i40e/base/i40e_nvm.c | 6 +++---
From: Jedrzej Jagielski
Some driver versions need to use "Read alternate - Indirect" command
in order to get the content of trace buffer. This patch adds a couple of
defines related to that functionality.
Signed-off-by: Jedrzej Jagielski
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/bas
From: Bartosz Jakub Rosadzinski
This commit introduces a definition of the 5th Free Provisioning Area
pointer in Shadow RAM. 5th PFA is used during NVM update for storing
X710-T2L/X710-T4L's Phy Firmware.
Signed-off-by: Bartosz Jakub Rosadzinski
Signed-off-by: Anatoly Burakov
---
drivers/net/
Update README with the date of when the latest snapshot was generated.
Signed-off-by: Anatoly Burakov
---
drivers/net/i40e/base/README | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README
index 2e4fa5a921..c40573e62
Reviewed-by: Luca Vizzarro
Reviewed-by: Luca Vizzarro
Reviewed-by: Luca Vizzarro
On 8/30/2024 3:29 AM, Chaoyong He wrote:
> This patch series increase rxq/txq number of representor ports, aims to
> increase the speed of slow path.
>
> Long Wu (3):
> net/nfp: remove restrictions on port queue number
> net/nfp: increase representor port rxq number
> net/nfp: increase repre
Lots of developers (myself included) uses Visual Studio Code as their primary
IDE for DPDK development. I have been successfully using various incarnations of
this script internally to quickly set up my development trees whenever I need a
new configuration, so this script is being shared in hopes t
A lot of developers use Visual Studio Code as their primary IDE. This
script will be called from within meson build process, and will generate
a configuration file for VSCode that sets up basic build tasks, launch
tasks, as well as C/C++ code analysis settings that will take into
account compile_co
Good one.
Reviewed-by: Luca Vizzarro
Reviewed-by: Luca Vizzarro
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> Sent: Friday, 9 August 2024 22.15
>
> Introduce a set of functions and macros that operate on sets of bits,
> kept in arrays of 64-bit words.
This could be 32-bit words on 32 bit architectures. Just an idea.
>
> RTE bitset is des
Currently, when binding a device to VFIO, the UID/GID for the device will
always stay as system default (`root`). Yet, when running DPDK as non-root
user, one has to change the UID/GID of the device to match the user's
UID/GID to use the device.
This patch adds an option to `dpdk-devbind.py` to ch
On 9/2/2024 3:08 AM, Varghese, Vipin wrote:
Thank you Antaloy for the response. Let me try to share my understanding.
I recently looked into how Intel's Sub-NUMA Clustering would work within
DPDK, and found that I actually didn't have to do anything, because the
SNC "clusters" present themsel
On 8/2/2024 2:44 PM, Bruce Richardson wrote:
As meson processes our DPDK source tree it manages dependencies
specified by each individual driver. To enable future analysis of the
dependency links between components, log the dependencies of each DPDK
component as it gets processed. This could pote
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> Sent: Monday, 6 May 2024 10.27
>
> This RFC presents a new API for static per-lcore id
> data allocation.
>
> Please refer to the API documentation for both a
> rationale for this new API, and a comparison to the alternatives
> a
On 2024-09-02 15:55, Morten Brørup wrote:
From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
Sent: Friday, 9 August 2024 22.15
Introduce a set of functions and macros that operate on sets of bits,
kept in arrays of 64-bit words.
This could be 32-bit words on 32 bit architectures. Ju
> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Thursday, 21 September 2023 10.27
>
> Hello,
>
> On Mon, Aug 7, 2023 at 10:12 AM Tomasz Duszynski
> wrote:
> > >Ping for update
> > >What is the status of this feature?
> >
> > I'll re-spin the series soon.
>
> -rc1 is getting cl
On 2024-09-02 15:55, Morten Brørup wrote:
-->
With or without considering the above ideas, this library is a good addition to
DPDK.
> For the series,
Acked-by: Morten Brørup
Thomas and David, what else need I do to get this merged?
I have the same question for the bitops patch set.
Than
I recently looked into how Intel's Sub-NUMA Clustering would work
within
DPDK, and found that I actually didn't have to do anything, because the
SNC "clusters" present themselves as NUMA nodes, which DPDK already
supports natively.
yes, this is correct. In Intel Xeon Platinum BIOS one can e
On Sat, 31 Aug 2024 09:44:21 +0800
"李勇" <1054946...@qq.com> wrote:
> I use the dpdk-23-11 version, system debian11, network card i210, CPU
> Cortex-A55. After the dpdk-23-11 service is compiled and installed, Start
> dpdk-23-11/examples/multi-process/cron_derve_mp/mp_derver/ build/mpuserver -l
On 8/30/2024 12:28 PM, Chaoyong He wrote:
> This patch series add support of match flow rule Ethernet type field,
> also do some needed refactor.
>
> ---
> v3:
> * Add the version number.
> v2:
> * Fix compile problem of 'dangling-pointer'.
> ---
>
> Long Wu (2):
> net/nfp: refactor flow item c
This patch series add support of a new card which using the NFP 3800 chip.
Because it has different configure BAR size and flow steering rules
limit, we also do some refactor to the related logic.
Chaoyong He (4):
net/nfp: add a new flag to indicate PF
net/nfp: refactor the firmware version lo
Add a new flag field 'is_pf' into 'struct nfp_net_hw_priv', to indicate
if the device is PF or not.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/nfp_ethdev.c | 2 ++
drivers/net/nfp/nfp_net_common.c | 6 +++---
drivers/net/nfp/nfp_net_common.h | 2 ++
3 files changed,
Move the 'ver' data field from 'struct nfp_net_hw' into
'struct nfp_pf_dev', also modify the related logic.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/flower/nfp_flower.c | 30 ++---
drivers/net/nfp/flower/nfp_flower_ctrl.c | 8 ++--
drivers/net/nfp/flower
A new NIC is introduced with different configuration
BAR size other than 32K, and this is distinguished by
the application firmware's class version ABI.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/common/nfp/nfp_common_ctrl.h | 10 +-
drivers/net/nfp/flower/nfp_flower.c
Get the flow steering rules limit from the firmware rather than
the hard coded.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/common/nfp/nfp_common_ctrl.h | 3 +-
drivers/net/nfp/nfp_net_common.h | 4 +--
drivers/net/nfp/nfp_net_flow.c | 51
For some platform, the warm restart of host doesn't trigger
the reset of NIC, which causes the initialize process of NIC
not executed with the right expansion ROM mapping. Consequently,
the PXE boot won't work in this case.
Now reserve BAR 2.0 which used by expansion ROM so that the
mapping is fix
If BSP not support a command and the driver send it to BSP, some
unhappy thing will happen and the logic will go wrong.
Fix it by make sure the BSP does support the command before driver
send it to BSP.
Fixes: b301fd736003 ("net/nfp: add force reload firmware option")
Cc: peng.zh...@corigine.com
C
This patch series add the needed logic to support load firmware from the
flash in card.
Chaoyong He (3):
net/nfp: fix potential problem on certain version BSP
net/nfp: add two APIs of the NSP module
net/nfp: support load firmware from flash
drivers/net/nfp/nfp_ethdev.c | 235 +
Add two APIs of the NSP module, also modify the logic to use the
argument to control the log switch for NSP command.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfpcore/nfp_nsp.c | 86 ++-
drivers/net/nfp/nfpcore/nfp_n
Add the logic to support load firmware from flash, also do some refactor
to the related logic at the same time.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_ethdev.c | 233 ++-
1 file changed, 202 insertions(+),
63 matches
Mail list logo
