[V1] app/testpmd: restore VXLAN-GPE support

VXLAN-GPE support was removed from testpmd recently. Drivers which are not migrated are still using VXLAN-GPE in tests. This commit is to restore the support for VXLAN-GPE in testpmd. Fixes: da118115d95c ("app/testpmd: support matching any VXLAN field") Signed-off-by: Gavin Li --- app/test-pmd/

Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

On 7/16/2024 5:33 PM, Patrick Robb wrote: > On Wed, Feb 14, 2024 at 3:17 PM Patrick Robb wrote: >> >> >> >> On Wed, Feb 14, 2024 at 3:00 PM Dumitrescu, Cristian >> wrote: >>> >>> >>> >>> [Cristian] >>> Yes, you are right, we do have a DTS test suite for the pipeline library. >>> >>> It would be

Re: [PATCH v2] net/ark: fix index arithmetic optimization bug

On 7/16/2024 10:39 PM, Ed Czeck wrote: > fix for compiler optimizer error using int32_t. > (a - b) > 0 can behave differently under optimization > at values near max and min bounds. > Hi Ed, Is this compiler optimization error, or can it be related to the undefined behavior of signed integer over

RE: [PATCH 3/3] examples/l3fwd: fix maximum acceptable port ID in routes

> Application is accepting routes for port ID up to UINT8_MAX > for LPM amd EM routes on parsing the given rule file, but only > up to 32 ports can be enabled as per the variable enabled_port_mask > which is defined as uint32_t. > > This patch restricts the rules parsing code to accept routes f

Re: [PATCH v2 2/2] net/ngbe: disable LLDP by default

On 7/17/2024 3:14 AM, Jiawen Wu wrote: > On Tue, Jul 16, 2024 7:06 PM, Ferruh Yigit wrote: >> On 7/16/2024 9:16 AM, Jiawen Wu wrote: >>> --- a/drivers/net/ngbe/base/ngbe_hw.h >>> +++ b/drivers/net/ngbe/base/ngbe_hw.h >>> @@ -84,8 +84,8 @@ s32 ngbe_enable_rx_dma(struct ngbe_hw *hw, u32 regval); >>>

RE: [RFC v2] ethdev: an API for cache stashing hints

> An application provides cache stashing hints to the ethernet devices to > improve memory access latencies from the CPU and the NIC. This patch > introduces three distinct hints for this purpose. > > The RTE_ETH_DEV_STASH_HINT_HOST_WILLNEED hint indicates that the host > (CPU) requires the data

Re: [PATCH] net/hns3: add Rx DMA address align check

On 7/15/2024 3:04 AM, Jie Hai wrote: > From: Chengwen Feng > > The network engine has Rx DMA address align requirement, if this > requirement is violated, the Rx function will be abnormal. The detail > requirement is: > 1) For HIP08 platform, require 64-bytes alignment. > 2) For later platform, r

Re: [PATCH] doc: clarify mempool striding optimisation on Arm

On Tue, Jul 16, 2024 at 07:25:41PM -0700, Stephen Hemminger wrote: > On Mon, 15 Jul 2024 15:44:20 +0100 > Jack Bond-Preston wrote: > > > The mempool memory channel striding optimisation is not necessary on > > Arm platforms. > > Update the Programmer's Guide's mempool section to clarify this. > >

Re: [PATCH v2 1/3] net/ice: fix possible memory leak

On Mon, Jul 15, 2024 at 06:04:39PM +, Vladimir Medvedkin wrote: > This patch fixes possible memory leak inside the > ice_hash_parse_raw_pattern() due to the lack of a call to rte_free() > for previously allocated pkt_buf and msk_buf. > > Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic

Re: [PATCH v2 2/3] net/ice: refactor raw pattern parsing function

On Mon, Jul 15, 2024 at 06:04:40PM +, Vladimir Medvedkin wrote: > Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern. > > Signed-off-by: Vladimir Medvedkin > --- Acked-by: Bruce Richardson > drivers/net/ice/ice_hash.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 del

Re: [PATCH v2 3/3] net/ice: fix return value for raw pattern parsing function

On Mon, Jul 15, 2024 at 06:04:41PM +, Vladimir Medvedkin wrote: > If the parser was not initialized when calling ice_hash_parse_raw_pattern() > -rte_errno was returned. Replace returning rte_errno with ENOTSUP since > rte_errno is meaningless in the context of ice_hash_parse_raw_pattern(). > >

Re: [PATCH v2 1/2] net/txgbe: disable LLDP by default

On 7/16/2024 9:16 AM, Jiawen Wu wrote: > In the new firmware versions, LLDP is enabled by default to implement > new features in other drivers. But it is useless in DPDK. So disable > it in device initialization to prevent it from affecting hardware > default behavior. > > Signed-off-by: Jiawen Wu

RE: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch

>-Original Message- >From: Ankur Dwivedi >Sent: Friday, December 15, 2023 12:14 PM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >Ankur Dwivedi >Subject: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch > >This patch series adds a validation in checkpa

[PATCH] doc: document mlx5 HWS actions order

Add actions order supported in mlx5 PMD when HW steering flow engine is used. This limitation existed since HW Steering flow engine was introduced. Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- do

[PATCH] doc: document mlx5 HWS actions order

Add actions order supported in mlx5 PMD when HW steering flow engine is used. This limitation existed since HW Steering flow engine was introduced. Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- d

[PATCH v10 03/21] net/ntnic: add minimal initialization for PCI device

add implementation for probe/init and remove/deinit of the PCI device. proper device deinitialization will be added letter. Signed-off-by: Serhii Iliushyk --- v6 * Add driver deinitialization * Add API rte_eth_dev_probing_finish * Add correct API for finishing probing the device *

[PATCH v10 02/21] net/ntnic: add logging implementation

Adds ntnic specific implementation for logging. NT NIC uses this logging abstraction layer to ensure that FPGA module implementations function both within and outside in DPDK environment Signed-off-by: Serhii Iliushyk --- v6 * Logging header file was moved * Default log type was set to NOTICE v10

[PATCH v10 04/21] net/ntnic: add utilities implementation

Add ntnic utilities. Signed-off-by: Serhii Iliushyk --- v6 * NT utils header file was moved v10 * Remove "NT" from the commit message title * Use 8 spaces as indentation in meson --- drivers/net/ntnic/meson.build | 2 ++ drivers/net/ntnic/ntnic_ethdev.c | 2 ++ drivers/net/ntnic/ntutil/

[PATCH v10 06/21] net/ntnic: add basic eth dev ops

Adds support for eth_dev configure, start, stop, close, and infos_get. The internal structs of ntnic is also added and initialized. Signed-off-by: Serhii Iliushyk --- v6 * Replace if_index with n_intf_no * Unnecessry resources free was fixed * Fix typo * Useless vars were removed v9 * Remove if_i

[PATCH v10 07/21] net/ntnic: add core platform structures

Adds many of the high level structures needed by the ntnic FPGA modules and adapter control. This is considered the first part of the skeleton of ntnic FPGA support Signed-off-by: Serhii Iliushyk --- v10 * Use 8 spaces as indentation in meson --- drivers/net/ntnic/include/ntos_drv.h | 2 +

[PATCH v10 08/21] net/ntnic: add adapter initialization

Add interfaces for initialize the adapter Add proper PCI device deinitialization Signed-off-by: Serhii Iliushyk --- v6 * Function for global var clearing was removed v9 * Fix PCI devide deinitialization * Fix p_hw_info usage v10 * Use 8 spaces as indentation in meson --- drivers/net/ntnic/adapte

[PATCH v10 05/21] net/ntnic: add VFIO module

Adds VFIO functionality and the DMA it requires. The VFIO context is initialized during ntnic ethdev startup. Signed-off-by: Serhii Iliushyk --- v10 * Use 8 spaces as indentation in meson --- drivers/net/ntnic/meson.build | 1 + drivers/net/ntnic/ntnic_ethdev.c | 22 +++ drivers/net/nt

[PATCH v10 12/21] net/ntnic: add support of the NT200A0X smartNIC

Add ntnic support for NT200A0X NIC Signed-off-by: Serhii Iliushyk --- v10 * Use 8 spaces as indentation in meson --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 6 +++ drivers/net/ntnic/meson.build | 1 + .../net/ntnic/nthw/core/include/nthw_fpga.h | 7 +++ .../nthw/core

[PATCH v10 16/21] net/ntnic: add link 100G module ops

As the ntnic can support different speeds, an abstraction layer for 100G speed is needed. Signed-off-by: Serhii Iliushyk --- v10 * Use 8 spaces as indentation in meson --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 12 - .../link_mgmt/link_100g/nt4ga_link_100g.c | 49 +++

[PATCH v10 10/21] net/ntnic: add FPGA modules for initialization

New ntnic FPGA modules: - Host Interface (HIF): Basic FPGA info such as prod ID and build time. - Inter-Integrated Circuit Controller (IIC): Use the FPGA to access the other integrated circuits on the ntnic. - PCI Express Gen3 (PCIE3): The FPGA part of PCIe3 initialization, speed te

[PATCH v10 13/21] net/ntnic: add startup and reset sequence for NT200A0X

Adds reset (RST) module for FW 9563. Also adds SDRAM Controller (SDC) module, as it is part of the startup and reset sequence. Signed-off-by: Serhii Iliushyk --- v5 * Fix Typo/Spelling v10 * Use 8 spaces as indentation in meson --- .../include/ntnic_nthw_fpga_rst_nt200a0x.h| 81 +++ drivers

[PATCH v10 15/21] net/ntnic: add link management skeleton

Add functionality to read and control the link-state of the ntnic. Note that must functions are not implemented yet. Adds the following eth_dev_ops: - dev_set_link_up - dev_set_link_down - link_update - mac_addr_add - mac_addr_set - set_mc_addr_list - promiscuous_enable Signed-off-by: Serhii Iliu

[PATCH v10 14/21] net/ntnic: add clock profile for the NT200A0X smartNIC

Because the ntnic hardware supports multiple different FPGAs with different pipelines and port speeds, the clock profile is not hardcoded into the product, and need to be initialized from software. The clock profile itself is an array of integers that was generated by Silicon Labs ClockBuilder. S

[PATCH v10 19/21] net/ntnic: add QSFP28 support

Includes support for QSFP28 Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/ntnic_nim.h| 21 ++ drivers/net/ntnic/link_mgmt/nt4ga_link.c | 25 +++ drivers/net/ntnic/nim/i2c_nim.c | 267 ++- drivers/net/ntnic/nim/nim_defines.h | 1 + 4 files

[PATCH v10 11/21] net/ntnic: add FPGA initialization functionality

Enable FPGA initialization and adds ethdev fw_version_get. Signed-off-by: Serhii Iliushyk --- v5 * Fix Typo/Spelling v7 * Add FW update feature to documentation - INI and RST files v10 * Use 8 spaces as indentation in meson --- doc/guides/nics/features/ntnic.ini| 1 + doc/guides/ni

[PATCH v10 17/21] net/ntnic: add generic NIM and I2C modules

As the ntnic can support different port speeds, it also needs to support different NIMs (Network Interface Module). This commit add the generic NIM support for ntnic, such that the specific modules, such as QSFP28 can be added later. The communication with NIMs is in the form of I2C, so support fo

[PATCH v10 18/21] net/ntnic: add QSFP support

Includes support for QSFP and QSFP+. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/ntnic_nim.h | 10 + .../link_mgmt/link_100g/nt4ga_link_100g.c | 12 +- drivers/net/ntnic/nim/i2c_nim.c | 310 +- drivers/net/ntnic/nim/i2c_nim.h

[PATCH v10 01/21] net/ntnic: add ethdev and makes PMD available

Add initial ntnic ethdev skeleton and register PCI probe functions Update documentation: Device description and feature list Signed-off-by: Serhii Iliushyk --- v6 * Remove unused includes * Remove EOF markers * Remove unnecesarry commpiller flags * Update documentation INI and RST files *

[PATCH v10 21/21] net/ntnic: add physical layer control module

Adds functionality to control the physical layer of the OSI model. This takes the form of the module MAC PCS (Media Access Control Physical Coding Sublayer). The functionality is used by the 100G link functionality to establish link. Signed-off-by: Serhii Iliushyk --- v10 * Remove GTY_RX_BUF_STAT

[PATCH v10 20/21] net/ntnic: add GPIO communication for NIMs

For NIM reset sequence GPIO communication is used. After this commit the NIMs supported by ntnic is able to start up and be controlled fully by the adapter. Signed-off-by: Serhii Iliushyk --- v5 * Fix Typo/Spelling v10 * Use 8 spaces as indentation in meson --- drivers/net/ntnic/include/nt4ga_li

Re: [PATCH v7 01/21] net/ntnic: add ethdev and makes PMD available

On Mon, Jul 15, 2024 at 10:38 PM zhoumin wrote: > > Hi Patrick, > > Thanks for giving the link of commit `a6c3ec342ee1`. > > However I cannot checkout this commit in the next-net repository because > the commit ID is not exist in the history of next-net repository. Could > you find it? > > It seem

[PATCH] app/testpmd: add postpone option to async flow destroy

The potpone option is not available in the async flow destroy CLI. Only flow creation can be postponed in the testpmd application. Insert this option into the async flow destroy CLI before the rule ID. Fixes: ecdc927b99 ("app/testpmd: add async flow create/destroy operations") Signed-off-by: Alex

[PATCH] net/mlx5: fix end condition of reading xstats

The "mlx5_stats_n" in the "struct mlx5_xstats_ctrl" is the number of device stats identified by PMD. Right now, the mapping of device stats to the xstats is not compact. The "input index" of the device stats would remain UINT16_MAX and be skipped when reading counters. If some DPDK stats cannot be

[PATCH] net/mlx5: fix the uplink port probing in bond mode

In the HW-LAG bonding mode, the representor port can be from both slave PFs. When probing a representor (REP), the UPLINK (proxy) port always needs to be probed firstly before any REP port. In the current implementation, when probing a device with the following format: -a :XX:00.0,dv_flow_e

[PATCH] common/mlx5: remove unneeded field when modify RQ table

The attribute "rqt_max_size" of the RQT(RQ table) context is only needed by when creating a new one. When modifying an old one, there is no need to set this attribute. The firmware usually ignored this unneeded field. When enabling some extra check, an error will be returned to prevent the code fr

RE: [PATCH v1 1/1] drivers/baseband: fix device queues initialization

Hi David, Hernan, This is not a fix per se (ie. no bug vulnerability), just keeping code consistent as the PMDs already set such unused queues to zero in the code (see existing code). Just keeping that existing coding style for the new operation for code consistency. We probably don’t have to

Re: [PATCH v2 1/3] dts: add boolean to adjust addresses

> It might also be worth naming what the default is in the doc-string > (by which I mean that the parameter defaults to True, not the default > address scheme). I can fix that.

[PATCH 0/4] gve GQ ring size modification

This patch series adds the abiltiy to modify the ring size when using the GQ queue format for the GVE driver. Before this change, the GQ driver supported only 1024 descriptors in a ring. With this change, ring sizes can be as low or has as is specfied by the device. If the device does not specify l

[PATCH 1/4] net/gve: add ring size device option

This patch allows the device to report the maximum rx and tx ring sizes to the driver via a device option. The driver can use the information allow users to change the ring size of the device when using the GQ queue format. DQ will be unaffected, as it already allows DPDK programs to use a ring siz

[PATCH 2/4] net/gve: remove explicit field for Rx pages per QPL

priv->rx_data_slot_cnt is a field that holds the number of pages per RX QPL as passed by the device. With the modify ring size feature, this field no longer makes sense, as there is a clearly defined relationship on GQ between the ring size and the number of pages per RX QPL (1:1). As such, when a

[PATCH 3/4] net/gve: add min ring size support

This change adds support for parsing the minimum ring size from the modify_ring_size device option. Like the maximum ring size, this field will help allow the alteration of the ring size on the GQ driver. Note that it is optional whether the ring size is passed from the device or not. If the devic

[PATCH 4/4] net/gve: add ability to modify ring size in GQ format

Before this patch, the GQ format only supported a static ring size provided by the device. Using the maximum and minimum ring sizes provided in the modify_ring_size adminq command, this patch enables the ability to change the ring size within those bounds for the GQ queue format. Note that the rin

Re: [PATCH v2 2/3] dts: add testpmd methods for test suite

On Thu, Jul 11, 2024 at 3:33 PM Jeremy Spewock wrote: > > There were a few emails that came through for this series but this was > the most recent one so I went with reviewing this one, but it looks > like the more descriptive commit subject got lost in this iteration. > It would probably be worth

[PATCH v3] net/ark: fix index arithmetic bug

Behavior for signed integer overflow is not defined which can causes undesired behavior at values near max and min bounds. The used of unsigned is defined as to use modulo arithmetic which is the desired behavior. This patch replaces int32_t with uint32_t except for necessary casts. Fixes: 9ee9e0d

[PATCH v7 1/3] dts: add functions to testpmd shell

added set promisc, set verbose, and port stop commands to testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 192 ++ 1 file changed, 192 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_sess

[PATCH v7 2/3] dts: initial queue start/stop suite implementation

This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Signed-off-by: Dean Marx --- dts/tests/TestSuite_queue_start_stop.py | 94 + 1 file changed, 94 insertions(+) create mode 100644 dts/tests/TestSuite_queue_start_stop.py di

[PATCH v7 3/3] dts: queue suite conf schema

Configuration schema for the queue_start_stop suite. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f02a31

[PATCH v4] net/ark: fix index arithmetic bug

Behavior for signed integer overflow is not defined which can causes undesired behavior at values near max and min bounds. The used of unsigned is defined as to use modulo arithmetic which is the desired behavior. This patch replaces int32_t with uint32_t except for necessary casts. Fixes: 9ee9e0d

[PATCH v11 1/3] dts: add VLAN methods to testpmd shell

added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, port stop/start all/port, tx vlan set/reset, set promisc/verbose fixed: bug in vlan_offload for show port info, removed $ at end of regex Signed-off-by: Dean Marx --- dts/framework/

[PATCH v11 2/3] dts: VLAN test suite implementation

Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Signed-off-by: Dean Marx --- dts/tests/TestSuite_vlan.py | 170 1 file changed, 170 insertions(+) create mode 100644 dts/tests/TestSuite_vlan.py diff --git

[PATCH v11 3/3] dts: config schema

Configuration to run vlan test suite Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f02a310bb5..cd45902cc4

[PATCH v5] net/ark: fix index arithmetic bug

Behavior for signed integer overflow is not defined which can causes undesired behavior at values near max and min bounds. The used of unsigned is defined as to use modulo arithmetic which is the desired behavior. This patch replaces int32_t with uint32_t except for necessary casts. Fixes: 9ee9e0d

Re: [PATCH] common/mlx5: remove unneeded field when modify RQ table

Rerunning the CI Test for Broadcom Performance, which appears to be a false failure.

Re: release candidate 24.07-rc2

IBM - Power Systems Testing DPDK 24.07-rc2 * Build CI on Fedora 30,37,39,40 container images for ppc64le * Basic PF on Mellanox: No issue found * Performance: not tested. * OS:- RHEL 9.4 kernel: 5.14.0-427.13.1.el9_4.ppc64le with gcc version 11.4.1 20231218 (Red Hat 11.4.1-3) - RH

Re: [PATCH] dma/hisilicon: remove support for HIP09 platform

Kindly ping. Best regards Chengwen Feng On 2024/7/4 10:53, Chengwen Feng wrote: > The DMA for HIP09 is no longer available, so delete it. > > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > --- > doc/guides/dmadevs/hisilicon.rst | 1 - > doc/guides/rel_notes/release_24_07.rst |

[DPDK/eventdev Bug 1497] [dpdk-24.07] [ABI][meson test] driver-tests/event_dma_adapter_autotest test hang when do ABI testing

https://bugs.dpdk.org/show_bug.cgi?id=1497 Bug ID: 1497 Summary: [dpdk-24.07] [ABI][meson test] driver-tests/event_dma_adapter_autotest test hang when do ABI testing Product: DPDK Version: 24.07 Hardware

RE: [PATCH] common/mlx5: remove unneeded field when modify RQ table

Hi Patrick, It seems to be so. The patch is only for mlx5 slow path configuration. There is no reason that such change will impact the BRCM NIC performance. Thanks. BR. Bing > -Original Message- > From: Patrick Robb > Sent: Thursday, July 18, 2024 4:58 AM > To: Bing Zhao > Cc: Slava

[PATCH] net/gve: Update Rx/Tx functions for RTE_PROC_SECONDARY

>From 9fa6f7d425d66a00c3f63c7a3033eb06fd6b1852 Mon Sep 17 00:00:00 2001 From: priyadarshitathagat Date: Wed, 17 Jul 2024 18:53:47 + Subject: [PATCH] net/gve: Update Rx/Tx functions for RTE_PROC_SECONDARY The RSS support for GVE allows multiple CPU cores to handle the rx/tx queues as pollers.

RE: [PATCH 3/3] examples/l3fwd: fix maximum acceptable port ID in routes

Hi, > -Original Message- > From: Konstantin Ananyev > Sent: Wednesday, July 17, 2024 3:48 PM > To: Gagandeep Singh ; dev@dpdk.org; Konstantin Ananyev > ; Sean Morrissey > > Cc: sta...@dpdk.org > Subject: RE: [PATCH 3/3] examples/l3fwd: fix maximum acceptable port ID in > routes > > >

[PATCH v1] common/cnxk: fix integer overflow

The expression flow_age->aging_poll_freq * NPC_AGE_WAIT_TIMEOUT_US is evaluated using 32 bit arithmetic. An integer overflow may occur when the value is too large to fit in 32 bits. This patch resolves this by casting flow_age->aging_poll_freq to 64 bit. Coverity issue: 428156 Fixes: a4878294318e