On 7/17/2024 3:14 AM, Jiawen Wu wrote: > On Tue, Jul 16, 2024 7:06 PM, Ferruh Yigit wrote: >> On 7/16/2024 9:16 AM, Jiawen Wu wrote: >>> --- a/drivers/net/ngbe/base/ngbe_hw.h >>> +++ b/drivers/net/ngbe/base/ngbe_hw.h >>> @@ -84,8 +84,8 @@ s32 ngbe_enable_rx_dma(struct ngbe_hw *hw, u32 regval); >>> void ngbe_map_device_id(struct ngbe_hw *hw); >>> >>> void ngbe_read_efuse(struct ngbe_hw *hw); >>> -u32 ngbe_fmgr_cmd_op(struct ngbe_hw *hw, u32 cmd, u32 cmd_addr); >>> -u32 ngbe_flash_read_dword(struct ngbe_hw *hw, u32 addr); >>> +s32 ngbe_fmgr_cmd_op(struct ngbe_hw *hw, u32 cmd, u32 cmd_addr); >>> +s32 ngbe_flash_read_dword(struct ngbe_hw *hw, u32 addr, u32 *data); >>> void ngbe_set_ncsi_status(struct ngbe_hw *hw); >>> >> >> Hi Jiawen, >> >> Are above changes, and related changed caused by it, relevant to this >> patch? Changes seems unrelated with main functionality of this patch. > > These changes are due to a flash read failure in the flow of disabling LLDP. > For the sake of this case, change the original flash read function. >
ack
