Re: [PATCH] test-pmd: add more packet decode options (verbose)

2024-07-05 Thread David Marchand
On Tue, Mar 12, 2024 at 11:01 PM Stephen Hemminger wrote: > > The existing verbose levels 1..3 provide a messy multi-line > output per packet. This is unhelpful when diagnosing many > types of problems like packet flow. > > This patch adds two new levels: > 4: one line per packet is printed in a f

[v2 0/7] DPAA specific fixes

2024-07-05 Thread vanshika . shukla
From: Vanshika Shukla This series includes fixes for NXP DPAA drivers. V2 changes: Removed "mempool/dpaax: cache free optimization" patch. Apeksha Gupta (2): bus/dpaa: fix resource leak in variable dev common/dpaax: fix array overrun issue Gagandeep Singh (3): bus/dpaa: fix bus scan for

[v2 1/7] bus/dpaa: fix bus scan for DMA devices

2024-07-05 Thread vanshika . shukla
From: Gagandeep Singh if there is no sec devices available, code is not scanning QDMA dev This patch fix this problem by adding a goto statement instead of return in case no sec device available. Fixes: 583f3732974f ("dma/dpaa: introduce DPAA DMA driver skeleton") Cc: sta...@dpdk.org Signed-off

[v2 2/7] bus/dpaa: fix resource leak in variable dev

2024-07-05 Thread vanshika . shukla
From: Apeksha Gupta Resource leak: variable dev is going out of scope leaks the storage. Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Cc: hka...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/dpaa_

[v2 3/7] common/dpaax: fix IOVA table cleanup

2024-07-05 Thread vanshika . shukla
From: Gagandeep Singh Fixes incorrect structure free Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh Signed-off-by: Vanshika Shukla --- drivers/common/dpaax/dpaax_iova_table.c | 7 ++- 1 file changed, 2 inse

[v2 4/7] common/dpaax: fix array overrun issue

2024-07-05 Thread vanshika . shukla
From: Apeksha Gupta Out-of-bounds read, Overrunning dynamic array nodes at offset corresponding to index variable j. Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/commo

[v2 5/7] bus/dpaa: remove redundant file descriptor check

2024-07-05 Thread vanshika . shukla
From: Rohit Raj This patch removes the redundant file descriptor check Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Rohit Raj Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/process.c | 7 --- 1 file chang

[v2 6/7] bus/dpaa: remove unused code

2024-07-05 Thread vanshika . shukla
From: Gagandeep Singh The slow poll code is not being used in DPDK DPAA driver sub-system. Signed-off-by: Gagandeep Singh Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/qman.c | 31 - drivers/bus/dpaa/include/fsl_qman.h | 31 ---

[v2 7/7] net/dpaa: restrict MTU config for shared intf

2024-07-05 Thread vanshika . shukla
From: Rohit Raj Since DPDK was able to configure mtu in VSP/Shared interface mode, it was causing misconfiguration of the hw which further caused crashes. This patch allow only kernel to config MTU in such cases Signed-off-by: Rohit Raj Signed-off-by: Vanshika Shukla --- drivers/net/dpaa/dp

Re: [PATCH] baseband/la12xx: fix issue with secondary process

2024-07-05 Thread Maxime Coquelin
On 7/2/24 08:09, Hemant Agrawal wrote: The la12xx driver do not have any checks for secondary process and it causes the system to try to initialize the driver, causing segmentation faults. LA12xx driver do not support multi-processing. Return when not called from Primary process. Fixes: f218a

Re: [PATCH] net/virtio-user: fix control queue allocation for non-vDPA

2024-07-05 Thread Maxime Coquelin
On 7/3/24 18:27, Maxime Coquelin wrote: For non-vDPA backends, where the backend does not support control queue, it is still emulated in the Virtio-user layer to handle multiqueue feature. The frontend setups a control queue, which is hidden to the device. It means the number of vrings metadat

RE: [PATCH 00/19] Wangxun fixes and supports

2024-07-05 Thread Jiawen Wu
Hi, > -Original Message- > From: Jiawen Wu > Sent: Tuesday, June 25, 2024 9:51 AM > To: dev@dpdk.org > Subject: RE: [PATCH 00/19] Wangxun fixes and supports > > Hi, > > > -Original Message- > > From: Jiawen Wu > > Sent: Tuesday, June 18, 2024 3:12 PM > > To: dev@dpdk.org > > Cc

[PATCH] driver: crypto: scheduler: fix session size computation

2024-07-05 Thread jhascoet
The crypto scheduler session size computation was taking into account only the worker session sizes and not its own. Fixes: e2af4e403c1 ("crypto/scheduler: support DOCSIS security protocol") Cc: sta...@dpdk.org Signed-off-by: Julien Hascoet --- drivers/crypto/scheduler/scheduler_pmd_ops.c | 2 +

Re: [PATCH 0/4] cfgfile: enhance error detecting

2024-07-05 Thread Bruce Richardson
On Thu, Jul 04, 2024 at 02:40:55PM -0700, Stephen Hemminger wrote: > On Tue, 20 Feb 2024 03:58:36 + > Chengwen Feng wrote: > > > When I was trying to debug a problem introduced by config.ini in > > test-dma-perf, I found the cfgfile library should enhance error > > detecting, so got this patc

[PATCH v3] buildtools: fix invalid symbols

2024-07-05 Thread Mingjin Ye
In scenarios where a higher clang compiler is used and ASAN is enabled, the generated ELF file will additionally insert undefined debug symbols with the same prefix. This causes duplicate C code to be generated. This patch fixes this issue by skipping the unspecified symbol type. Fixes: 6c4bf8f42

[DPDK/other Bug 1465] rte_bpf_load() hangs with six IPv6 addresses in the filter causing dumpcap to fail

2024-07-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1465 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Resolution|--- |FIXED St

[PATCH] telemetry: lower log level when legacy is not configured

2024-07-05 Thread Robin Jarry
When starting any DPDK application, this warning log is displayed: TELEMETRY: No legacy callbacks, legacy socket not created This brings unnecessary attention, lower the log level to DEBUG. Signed-off-by: Robin Jarry --- doc/guides/contributing/unit_test.rst | 1 - doc/guides/nics/cnxk.rst

Re: [PATCH] telemetry: lower log level when legacy is not configured

2024-07-05 Thread Bruce Richardson
On Fri, Jul 05, 2024 at 11:00:20AM +0200, Robin Jarry wrote: > When starting any DPDK application, this warning log is displayed: > > TELEMETRY: No legacy callbacks, legacy socket not created > > This brings unnecessary attention, lower the log level to DEBUG. > > Signed-off-by: Robin Jarry >

[PATCH v3 1/2] net/cpfl: fix check for opcodes of received ctlq messages

2024-07-05 Thread Soumyadeep Hore
cpfl_process_rx_ctlq_msg() is used to check error status returned for specific opcodes and return error messages accordingly. Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/cpfl/cpfl_fxp_rule.c | 52

[PATCH v3 0/2] Avoid rule duplication in CPFL PMD

2024-07-05 Thread Soumyadeep Hore
This patchset avoids flow rule duplication which was possible previously in CPFL PMD. --- v2: * Addressed review comments * Added Fixes tags * Fixed CI warnings --- v3: * Addressed pending review comments --- Soumyadeep Hore (2): net/cpfl: fix check for opcodes of received ctlq messages net/c

[PATCH v3 2/2] net/cpfl: fix +ve error codes for received ctlq messages

2024-07-05 Thread Soumyadeep Hore
Previously error codes were only -ve for cpfl_receive_ctlq_msg() but now there are +ve error codes. Hence code changes are made accordingly. Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/cpfl/cpfl_

[PATCH v2 2/4] cfgfile: support verify name and value

2024-07-05 Thread Chengwen Feng
This patch supports verify section's name, entry's name and entry's value validity. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- lib/cfgfile/rte_cfgfile.c | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/cfgfile/rte_cfgfile.c b/lib/

[PATCH v2 3/4] cfgfile: verify add section and entry result

2024-07-05 Thread Chengwen Feng
The rte_cfgfile_add_section() and _add_entry()'s result were not verified, so that potential errors may not be detected. This commit adds the verification. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- lib/cfgfile/rte_cfgfile.c | 19 ++- 1 fi

[PATCH v2 4/4] cfgfile: add strict parse flag

2024-07-05 Thread Chengwen Feng
The cfgfile supports duplicate section name and entry name when parsing config file, which may confused and hard to debug when accidentally set duplicate name. So add strict parse flag, it will treat as error if encounter duplicate section name or entry name. Cc: sta...@dpdk.org Signed-off-by: C

[PATCH v2 0/4] cfgfile: enhance error detecting

2024-07-05 Thread Chengwen Feng
When I was trying to debug a problem introduced by config.ini in test-dma-perf, I found the cfgfile library should enhance error detecting, so got this patchset. Chengwen Feng (4): cfgfile: remove dead code cfgfile: support verify name and value cfgfile: verify add section and entry result

[PATCH v2 1/4] cfgfile: remove dead code

2024-07-05 Thread Chengwen Feng
This memchr() will never return NULL because rte_cfgfile_load() function will skip lines without useful content. Fixes: 74e0d3a17461 ("cfgfile: fix null pointer dereference in parsing") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- lib/cfgfile/rte_cfgfile.c |

Re: [PATCH 4/4] cfgfile: add unique name flag

2024-07-05 Thread fengchengwen
Hi Stephen, On 2024/7/5 5:36, Stephen Hemminger wrote: > On Tue, 20 Feb 2024 03:58:40 + > Chengwen Feng wrote: > >> The cfgfile supports duplicate section name and entry name when parsing >> config file, which may confused and hard to debug when accidentally set >> duplicate name. >> >> So a

Re: [PATCH v3 1/2] net/cpfl: fix check for opcodes of received ctlq messages

2024-07-05 Thread Bruce Richardson
On Fri, Jul 05, 2024 at 08:30:31AM +, Soumyadeep Hore wrote: > cpfl_process_rx_ctlq_msg() is used to check error status > returned for specific opcodes and return error messages > accordingly. > > Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying") > Cc: sta...@dpdk.or

[DPDK/ethdev Bug 1483] mlx5 PMD does not apply MTU from rte_eth_conf.rxmode.mtu on rte_eth_dev_configure()

2024-07-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1483 Bug ID: 1483 Summary: mlx5 PMD does not apply MTU from rte_eth_conf.rxmode.mtu on rte_eth_dev_configure() Product: DPDK Version: unspecified Hardware: All OS: All

Re: [PATCH] app/testpmd: handle IEEE1588 init fail

2024-07-05 Thread Ferruh Yigit
On 4/5/2024 4:36 PM, Singh, Aman Deep wrote: > On 3/30/2024 1:14 PM, Dengdui Huang wrote: >> When the port's timestamping function failed to initialize >> (for example, the device does not support PTP), the packets >> received by the hardware do not contain the timestamp. >> In this case, IEEE1588

Re: [PATCH v2 1/2] net/bonding: introduce direct link bonding mode

2024-07-05 Thread Ferruh Yigit
On 4/12/2024 1:27 PM, Kamil Vojanec wrote: > This patch adds a new bonding mode: 'direct'. The purpose of this mode > is to redirect output packets to the same member port on which they were > received. In case the requested port is not among the member ports, > round robin TX mode is used as a fal

Re: [PATCH v2] doc: remove empty section from testpmd guide

2024-07-05 Thread Ferruh Yigit
On 5/24/2024 5:02 PM, Thomas Monjalon wrote: > When removing the documentation for the obsolete flow filtering, > the related section was kept almost empty. > It can be safely removed. > > Fixes: 5007ac13189d ("ethdev: remove deprecated Flow Director configuration") > Cc: sta...@dpdk.org > > Sign

Re: [PATCH 0/2] support new firmware name scheme

2024-07-05 Thread Ferruh Yigit
On 5/28/2024 2:29 AM, Chaoyong He wrote: > This patch series refator the firmware load logic and add support of > the fourth firmware name scheme, and this name scheme takes the third > priority. > > Chaoyong He (2): > net/nfp: refactor the firmware load logic > net/nfp: support new firmware n

Re: [PATCH] app/testpmd: support retrying device stop

2024-07-05 Thread Ferruh Yigit
On 6/3/2024 6:09 PM, Stephen Hemminger wrote: > On Sun, 2 Jun 2024 13:30:35 +0300 > Maayan Kashani wrote: > >> From: Dariusz Sosnowski >> >> In some cases rte_eth_dev_stop() can fail with EBUSY error code meaning >> that port cannot be stopped, because of other resources referencing this >> port

Re: [PATCH] app/testpmd: fix parsing for connection tracking item

2024-07-05 Thread Ferruh Yigit
On 6/2/2024 11:23 AM, Maayan Kashani wrote: > In command line translation there were missing fields for > connection tracking item, as a result this item was not parsed > and was missing from the items list received from test-pmd. > > Fixes: 4d07cbefe3ba ("app/testpmd: add commands for conntrack")

RE: [PATCH] app/testpmd: support retrying device stop

2024-07-05 Thread Dariusz Sosnowski
> -Original Message- > From: Ferruh Yigit > Sent: Friday, July 5, 2024 13:29 > To: Stephen Hemminger ; Maayan Kashani > > Cc: dev@dpdk.org; Dariusz Sosnowski ; Raslan > Darawsheh ; Aman Singh ; > Yuying Zhang > Subject: Re: [PATCH] app/testpmd: support retrying device stop > > On 6/3/20

[PATCH] driver: crypto: scheduler: fix session size computation

2024-07-05 Thread jhascoet
From: jhascoet The crypto scheduler session size computation was taking into account only the worker session sizes and not its own. Fixes: e2af4e403c1 ("crypto/scheduler: support DOCSIS security protocol") Cc: sta...@dpdk.org Signed-off-by: Julien Hascoet --- drivers/crypto/scheduler/schedule

[PATCH] net/mlx5: fix data access race condition for shared Rx queue

2024-07-05 Thread Jiawei Wang
The rxq_data resources were shared for shared Rx queue with the same group and queue ID. The cq_ci:24 of rxq_data was unalignment with other fields in the one 32-bit data, like the dynf_meta and delay_drop. 32bit: xxxI IIIx ^ .

[PATCH v4 0/2] Avoid rule duplication in CPFL PMD

2024-07-05 Thread Soumyadeep Hore
This patchset avoids flow rule duplication which was possible previously in CPFL PMD. --- v4: * Addressed pending review comments --- v3: * Addressed pending review comments --- v2: * Addressed review comments * Added Fixes tags * Fixed CI warnings --- Soumyadeep Hore (2): net/cpfl: fix check f

[PATCH v4 1/2] net/cpfl: fix check for opcodes of received ctlq messages

2024-07-05 Thread Soumyadeep Hore
Include checks for error status returned for specific opcodes and display error messages accordingly. Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/cpfl/cpfl_fxp_rule.c | 8 drivers/net/c

[PATCH v4 2/2] net/cpfl: fix +ve error codes for received ctlq messages

2024-07-05 Thread Soumyadeep Hore
Previously error codes were only -ve for cpfl_receive_ctlq_msg() but now there are +ve error codes. Hence code changes are made accordingly. Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/cpfl/cpfl_

Re: [PATCH] eal: make dev_sigbus static

2024-07-05 Thread David Marchand
On Wed, Jul 3, 2024 at 5:17 PM Stephen Hemminger wrote: > > Only used in one file, and not an exported symbol should be static. > > Signed-off-by: Stephen Hemminger Applied, thanks. -- David Marchand

Re: [PATCH v3 0/2] malloc type cleanups

2024-07-05 Thread David Marchand
On Tue, Jun 18, 2024 at 4:45 PM Stephen Hemminger wrote: > > The type parameter for malloc is only used for tracing. > Fix documentation and don't pass through heap routines. > > Stephen Hemminger (2): > rte_malloc: document that type is for tracing > eal: remove type argument from internal ro

Re: [PATCH v4 1/2] net/cpfl: fix check for opcodes of received ctlq messages

2024-07-05 Thread Bruce Richardson
On Fri, Jul 05, 2024 at 01:05:14PM +, Soumyadeep Hore wrote: > Include checks for error status returned for specific > opcodes and display error messages accordingly. > > Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying") > Cc: sta...@dpdk.org > > Signed-off-by: Soum

Re: [PATCH v4 0/2] Avoid rule duplication in CPFL PMD

2024-07-05 Thread Bruce Richardson
On Fri, Jul 05, 2024 at 01:05:13PM +, Soumyadeep Hore wrote: > This patchset avoids flow rule duplication which was possible > previously in CPFL PMD. > > --- > v4: > * Addressed pending review comments > --- > v3: > * Addressed pending review comments > --- > v2: > * Addressed review comments

[PATCH v6] graph: expose node context as pointers

2024-07-05 Thread Robin Jarry
In some cases, the node context data is used to store two pointers because the data is larger than the reserved 16 bytes. Having to define intermediate structures just to be able to cast is tedious. And without intermediate structures, casting to opaque pointers is hard without violating strict ali

Re: [PATCH v5] net/cpfl: get running host ID for CPFL PMD

2024-07-05 Thread Bruce Richardson
On Thu, Jun 06, 2024 at 10:44:22AM +, Shaiq Wani wrote: > Check whether CPFL PMD runs on Host or ACC > > --- > v2 Changes: > -Changed implementation based on review comment. > v3 Changes: > -Fixed indentation. > v4 Changes: > -Fix ipu_imc and ipu_acc to ipu-imc and ipu-acc. > v5 Changes: > -Up

Re: [PATCH v5] net/cpfl: get running host ID for CPFL PMD

2024-07-05 Thread Bruce Richardson
On Thu, Jun 06, 2024 at 10:44:22AM +, Shaiq Wani wrote: > Check whether CPFL PMD runs on Host or ACC > > --- > v2 Changes: > -Changed implementation based on review comment. > v3 Changes: > -Fixed indentation. > v4 Changes: > -Fix ipu_imc and ipu_acc to ipu-imc and ipu-acc. > v5 Changes: > -Up

[PATCH] checkpatches: verify in-reply-to header when possible

2024-07-05 Thread Robin Jarry
When using checkpatches.sh locally, verify that there is an In-Reply-To header when the patch is a respin (i.e. v2, v3, etc.). This is currently only enforced by the upstream CI but cannot be verified locally. This cannot be verified when checking commit ids since --in-reply-to is a git-format-pat

Re: [PATCH v10 3/3] dts: config schema

2024-07-05 Thread Patrick Robb
Recheck-request: iol-unit-amd64-testing

RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-05 Thread Wathsala Wathawana Vithanage
> > We are using this flag to allow application to choose between WFE and non- > WFE code path. > The non-WFE path performs slightly better. > Is it correct if I assume that this flag is not used to indicate the availability of WFE instruction in any of your platforms? If so, then its usage is

RE: [EXTERNAL] Re: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-05 Thread Pavan Nikhilesh Bhagavatula
> 04/07/2024 16:55, Stephen Hemminger: > > On Thu, 04 Jul 2024 16:14:42 +0200 > > Thomas Monjalon wrote: > > > > > > > Let’s ask Pavan why this flag is used in cn10k driver. > > > > > > > > > > From our perspective, WFE is available on all the supported arm > platforms in > > > > > DPDK. > > > > >

RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-05 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Wathsala Wathawana Vithanage > Sent: Friday, July 5, 2024 9:32 PM > To: Pavan Nikhilesh Bhagavatula ; > tho...@monjalon.net > Cc: Tyler Retzlaff ; Ruifeng Wang > ; dev@dpdk.org; nd ; Dhruv > Tripathi ; Honnappa Nagarahalli > ; Jack Bond-Preston pres...@foss

RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-05 Thread Wathsala Wathawana Vithanage
> > > > We are using this flag to allow application to choose between WFE > > > > and > > non- > WFE code path. > The non-WFE path performs slightly better. > > > Is it correct if I assume that this flag is not used to indicate the > > availability > > > > > > > > We are using this flag to allow a

[PATCH v2 0/6] dts: Remove Excess Attributes From User Config

2024-07-05 Thread Nicholas Pratte
v2: * Patch series has been rebased to release candidate one. * Added functionality to make 'test_suites' optional, based on certain conditions. * Aggregated all of the DPDK documentation into one holistic patch. Nicholas Pratte (6): dts: Remove build target config and list of devices

[PATCH v2 1/6] dts: Remove build target config and list of devices

2024-07-05 Thread Nicholas Pratte
Remove the list of devices from the schema, as these are unuesed. Likewise, removed build-target information since these is not currently used, and it is unlikely to be used in the future. Adjustments to the dts.rst are made to reflect these changes. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratt

[PATCH v2 2/6] dts: Use First Core Logic Change

2024-07-05 Thread Nicholas Pratte
Removed use_first_core from the conf.yaml in favor of determining this within the framework. use_first_core continue to serve a purpose in that it is only enabled when core 0 is explicitly provided in the configuration. Any other configuration, including "" or "any," will omit core 0. Documentatio

[PATCH v2 3/6] dts: Self-Discovering Architecture Change

2024-07-05 Thread Nicholas Pratte
The 'arch' attribute in the conf.yaml is unnecessary, as this can be readily discovered within the constructor of any given node. Since OS is determined within user configuration, finding system arch can be done both reliably and easily within the framework. For Linux/Posix systems, the 'uname' co

[PATCH v2 4/6] dts: Rework DPDK Attributes In SUT Node Config

2024-07-05 Thread Nicholas Pratte
Rework 'lcores' and 'memory_channels' into a new 'dpdk_config' subsection in an effort to make these attributes SUT specific; the traffic generator, more often than not, does not need this information. Ideally, if such information is needed, then it will be listed in the 'traffic_generator' compone

[PATCH v2 5/6] dts: add conditional behavior for test suite

2024-07-05 Thread Nicholas Pratte
There is some odd functionality/behavior in how the --test-suite parameters interacts in conjunction with the 'test_suites' attribute in the config file. If a user leaves an empty list underneath 'test_suites,' or if they negate the attribute entirely, even if said user adds test suites via the --t

[PATCH v2 6/6] doc: dpdk documentation changes for new dts config

2024-07-05 Thread Nicholas Pratte
Adjusted DPDK documentation to reflect the changes made to the dts conf.yaml configuration file. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- doc/guides/tools/dts.rst | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/doc/guides/tools/dts.rs

Re: [PATCH 0/4] support generic flow item

2024-07-05 Thread Ferruh Yigit
On 5/28/2024 2:55 AM, Chaoyong He wrote: > This patch series add the support of some generic flow items, namely > flow items with a NULL 'item->spec' value, including: > - ETH flow item > - TCP flow item > - UDP flow item > - SCTP flow item > > Chaoyong He (4): > net/nfp: support generic ETH fl

Re: zxdh: add zxdh poll mode driver

2024-07-05 Thread Ferruh Yigit
On 6/6/2024 1:02 PM, Junlong Wang wrote: >>> +Prerequisites >>> +- >>> + >>> +This PMD driver need NPSDK library for system initialization and  >>>allocation of resources. >>> +Communication between PMD and kernel modules is mediated by zxdh Kernel  >>>modules. >>> +The NPSDK library an

Re: [PATCH 1/1] net/ena: restructure the llq policy user setting

2024-07-05 Thread Ferruh Yigit
On 6/6/2024 2:33 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > Replaced `enable_llq`, `normal_llq_hdr` and `large_llq_hdr` > devargs with a new shared devarg named `llq_policy` that > implements the same logic and accepts the following values: > 0 - Disable LLQ. > Use with extreme c

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-07-05 Thread Ferruh Yigit
On 6/26/2024 3:19 AM, huangdengdui wrote: > > On 2024/6/26 5:07, Damodharam Ammepalli wrote: >> On Wed, Jun 19, 2024 at 8:23 PM huangdengdui wrote: >>> >>> Hi Damodharam >>> Here are some suggestions. See below. >>> >> Thank you for the review. >> >>> On 2024/6/18 4:34, Damodharam Ammepalli wrote

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-07-05 Thread Ferruh Yigit
On 6/17/2024 9:34 PM, Damodharam Ammepalli wrote: > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * Set speed lanes supported by the NIC. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param speed

Re: [PATCH v10 1/4] hash: pack the hitmask for hash in bulk lookup

2024-07-05 Thread Yoan Picchi
I'll push a v11 tonight. There is a couple of comments I disagree with tough: On 7/4/24 21:31, David Marchand wrote: Hello Yoan, On Wed, Jul 3, 2024 at 7:13 PM Yoan Picchi wrote: Current hitmask includes padding due to Intel's SIMD implementation detail. This patch allows non Intel SIMD imp

[PATCH v11 1/7] hash: make compare signature function enum private

2024-07-05 Thread Yoan Picchi
enum rte_hash_sig_compare_function is only used internally. This patch move it out of the public ABI and into the C file. Signed-off-by: Yoan Picchi --- lib/hash/rte_cuckoo_hash.c | 10 ++ lib/hash/rte_cuckoo_hash.h | 10 +- 2 files changed, 11 insertions(+), 9 deletions(-) diff

[PATCH v11 0/7] hash: add SVE support for bulk key lookup

2024-07-05 Thread Yoan Picchi
This patchset adds SVE support for the signature comparison in the cuckoo hash lookup and improves the existing NEON implementation. These optimizations required changes to the data format and signature of the relevant functions to support dense hitmasks (no padding) and having the primary and seco

[PATCH v11 2/7] hash: split compare signature into arch-specific files

2024-07-05 Thread Yoan Picchi
Move the compare_signatures function into architecture-specific files They all have the default scalar option as an option if we disable vectorisation. Signed-off-by: Yoan Picchi --- .mailmap | 1 + lib/hash/compare_signatures_arm_pvt.h | 55

[PATCH v11 3/7] hash: add a check on hash entry max size

2024-07-05 Thread Yoan Picchi
If were to change RTE_HASH_BUCKET_ENTRIES to be over 8, it would no longer fit in the vector (8*16b=128b), therefore failing to check some of the signatures. This patch adds a compile time check to fallback to scalar code in this case. Signed-off-by: Yoan Picchi --- lib/hash/compare_signatures_a

[PATCH v11 4/7] hash: pack the hitmask for hash in bulk lookup

2024-07-05 Thread Yoan Picchi
Current hitmask includes padding due to Intel's SIMD implementation detail. This patch allows non Intel SIMD implementations to benefit from a dense hitmask. In addition, the new dense hitmask interweave the primary and secondary matches which allow a better cache usage and enable future improvemen

[PATCH v11 5/7] hash: optimize compare signature for NEON

2024-07-05 Thread Yoan Picchi
Upon a successful comparison, NEON sets all the bits in the lane to 1 We can skip shifting by simply masking with specific masks. Signed-off-by: Yoan Picchi Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- lib/hash/compare_signatures_arm_pvt.h | 22 +++--- 1 file changed

[PATCH v11 7/7] hash: add SVE support for bulk key lookup

2024-07-05 Thread Yoan Picchi
- Implemented SVE code for comparing signatures in bulk lookup. - New SVE code is ~5% slower than optimized NEON for N2 processor for 128b vectors. Signed-off-by: Yoan Picchi Signed-off-by: Harjot Singh Reviewed-by: Nathan Brown Reviewed-by: Ruifeng Wang --- lib/hash/compare_signatures_arm_pv

[PATCH v11 6/7] test/hash: check bulk lookup of keys after collision

2024-07-05 Thread Yoan Picchi
This patch adds unit test for rte_hash_lookup_bulk(). It also update the test_full_bucket test to the current number of entries in a hash bucket. Signed-off-by: Yoan Picchi Signed-off-by: Harjot Singh Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- .mailmap | 1 + app/tes

RE: [PATCH v3] buildtools: fix invalid symbols

2024-07-05 Thread Ali Alnubani
> -Original Message- > From: Mingjin Ye > Sent: Friday, July 5, 2024 11:26 AM > To: dev@dpdk.org > Cc: david.march...@redhat.com; Ali Alnubani ; Mingjin Ye > ; sta...@dpdk.org; Dmitry Kozlyuk > > Subject: [PATCH v3] buildtools: fix invalid symbols > > In scenarios where a higher clang co

[PATCH v2 1/6] dts: Remove build target config and list of devices

2024-07-05 Thread Nicholas Pratte
Remove the list of devices from the schema, as these are unuesed. Likewise, removed build-target information since these is not currently used, and it is unlikely to be used in the future. Adjustments to the dts.rst are made to reflect these changes. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratt

[PATCH v2 1/6] dts: Remove build target config and list of devices

2024-07-05 Thread Nicholas Pratte
Remove the list of devices from the schema, as these are unuesed. Likewise, removed build-target information since these is not currently used, and it is unlikely to be used in the future. Adjustments to the dts.rst are made to reflect these changes. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratt

[PATCH v2 2/6] dts: Use First Core Logic Change

2024-07-05 Thread Nicholas Pratte
Removed use_first_core from the conf.yaml in favor of determining this within the framework. use_first_core continue to serve a purpose in that it is only enabled when core 0 is explicitly provided in the configuration. Any other configuration, including "" or "any," will omit core 0. Documentatio

[PATCH v2 3/6] dts: Self-Discovering Architecture Change

2024-07-05 Thread Nicholas Pratte
The 'arch' attribute in the conf.yaml is unnecessary, as this can be readily discovered within the constructor of any given node. Since OS is determined within user configuration, finding system arch can be done both reliably and easily within the framework. For Linux/Posix systems, the 'uname' co

[PATCH v2 4/6] dts: Rework DPDK Attributes In SUT Node Config

2024-07-05 Thread Nicholas Pratte
Rework 'lcores' and 'memory_channels' into a new 'dpdk_config' subsection in an effort to make these attributes SUT specific; the traffic generator, more often than not, does not need this information. Ideally, if such information is needed, then it will be listed in the 'traffic_generator' compone

[PATCH v2 5/6] dts: add conditional behavior for test suite

2024-07-05 Thread Nicholas Pratte
There is some odd functionality/behavior in how the --test-suite parameters interacts in conjunction with the 'test_suites' attribute in the config file. If a user leaves an empty list underneath 'test_suites,' or if they negate the attribute entirely, even if said user adds test suites via the --t

[PATCH v2 6/6] doc: dpdk documentation changes for new dts config

2024-07-05 Thread Nicholas Pratte
Adjusted DPDK documentation to reflect the changes made to the dts conf.yaml configuration file. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- doc/guides/tools/dts.rst | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/doc/guides/tools/dts.rs

Re: [PATCH v4] net/mana: fix uninitialized scalar variable

2024-07-05 Thread Ferruh Yigit
On 6/14/2024 6:47 AM, Long Li wrote: >> Subject: [PATCH v4] net/mana: fix uninitialized scalar variable >> >> [You don't often get email from mahmoudmatook...@gmail.com. Learn why >> this is important at https://aka.ms/LearnAboutSenderIdentification ] >> >> in case we didn't enter or finished the l

Re: [PATCH v2] r8125: add r8125 ethernet poll mode driver

2024-07-05 Thread Ferruh Yigit
On 6/13/2024 4:36 AM, Howard Wang wrote: > r8125 is for Realtek 2.5 Gigabit Ethernet NICs. > > Signed-off-by: Howard Wang > Hi Howard, Thanks for contributing to DPDK. I remember Realtek drivers mentioned a few times in the past, it is great to see it will be publicly available. Can you please

Re: [PATCH v2] net/gve: change QPLs to be queue resources

2024-07-05 Thread Ferruh Yigit
On 6/14/2024 12:53 AM, Joshua Washington wrote: > Prior to this change, queue page lists (QPLs) were kept as device > resources, being stored in the gve_priv struct. This does not make > sense because each QPL inherently belongs to a single queue. > > This change moves all QPL resources into the q

RE: [PATCH v2] bus/vmbus: add device_order field to rte_vmbus_dev

2024-07-05 Thread Long Li
Hi Vladimir, Is there another way that you can determine the device probe order from your application? (like going through the /sys/class/uio devices) Long From: Vladimir Ratnikov Sent: Tuesday, June 25, 2024 4:50 AM To: Stephen Hemminger Cc: Long Li ; dev@dpdk.org Subject: Re: [PATCH v2] bus

Re: [PATCH 00/19] Wangxun fixes and supports

2024-07-05 Thread Ferruh Yigit
On 7/5/2024 9:11 AM, Jiawen Wu wrote: > Hi, > >> -Original Message- >> From: Jiawen Wu >> Sent: Tuesday, June 25, 2024 9:51 AM >> To: dev@dpdk.org >> Subject: RE: [PATCH 00/19] Wangxun fixes and supports >> >> Hi, >> >>> -Original Message- >>> From: Jiawen Wu >>> Sent: Tuesday, J

Re: [PATCH] net/ring: Set mbuf->port for received packets

2024-07-05 Thread Ferruh Yigit
On 6/18/2024 8:14 PM, Sriram Yagnaraman wrote: > Hi Morten, > >> -Original Message- >> From: Morten Brørup >> Sent: Tuesday, 18 June 2024 18:01 >> To: Sriram Yagnaraman >> Cc: dev@dpdk.org; Bruce Richardson >> Subject: RE: [PATCH] net/ring: Set mbuf->port for received packets >> >> [Du

Re: [PATCH] net/ring: Set mbuf->port for received packets

2024-07-05 Thread Ferruh Yigit
On 6/19/2024 7:48 AM, Morten Brørup wrote: >> From: Sriram Yagnaraman [mailto:sriram.yagnara...@ericsson.com] >> >> Hi Morten, >> >>> From: Morten Brørup >>> From: Sriram Yagnaraman [mailto:sriram.yagnara...@ericsson.com] When using ring based ethdev, mbuf->port is not set on receiv

Re: [PATCH v5] net/af_xdp: parse umem map info from mempool range api

2024-07-05 Thread Ferruh Yigit
On 6/20/2024 8:10 AM, Morten Brørup wrote: >> From: Frank Du [mailto:frank...@intel.com] >> >> The current calculation assumes that the mbufs are contiguous. However, >> this assumption is incorrect when the mbuf memory spans across huge page. >> >> Correct to directly read with mempool get range A

RE: [PATCH 1/1] net/ena: restructure the llq policy user setting

2024-07-05 Thread Brandes, Shai
Sure, thanks! בתאריך 5 ביולי 2024 20:32,‏ Ferruh Yigit כתב: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 6/6/2024 2:33 PM, shaib...@amazon.com wrote: > From: Shai Bra