On 6/13/2024 4:36 AM, Howard Wang wrote: > r8125 is for Realtek 2.5 Gigabit Ethernet NICs. > > Signed-off-by: Howard Wang <howard_w...@realsil.com.cn> >
Hi Howard, Thanks for contributing to DPDK. I remember Realtek drivers mentioned a few times in the past, it is great to see it will be publicly available. Can you please give some more details which devices, SoC or specific boards etc supported with these driver(s) (r8125 & r8126 in other patch)? What is the motivation for the upstreaming, like is this for a customer or to enable people experiment DPDK on boards with Realtek NICs etc..? Btw, there were some offline suggestions from David & Thomas, let me try to summurise them first here: - Can r8125 & r8126 drivers combined into single driver, perhaps with some common code? Assuming two drivers are common enough to put together. - Can you please split the patch into multiple commits, so that it becomes easier to review and analyze later. There is another driver upstreaming in progress, you can check it as sample: https://patches.dpdk.org/project/dpdk/list/?series=32313&state=%2A&archive=both - Use a real person as maintainer, and in .mailmap file instead of alias Also I can see some binary data in the driver, are they necessary to keep in the driver, like: mcu_patch_code_8125a_2() rtl8125_real_set_phy_mcu_8125a_1() rtl8125_real_set_phy_mcu_8125a_2() phy_mcu_ram_code_8125b_1 ... phy_mcu_ram_code_8125d_1_1 ... They are taking space and as they are binary there is no way for driver to understand / update / fix them.. For both this one and r8126, I will wait for next version to review further. Thanks, ferruh
