On 10/05/2024 16:06, Stephen Hemminger wrote:
You don't have to use local statistic for this, there already is one in the dev
struct
i.e dev->data->rx_mbuf_alloc_failed. The problem is you need the DPDK port
number to find
what dev is.
I think the diff id that dev->data->rx_mbuf_alloc_failed
On Wed, May 8, 2024 at 12:50 PM Bruce Richardson
wrote:
>
> On Wed, May 08, 2024 at 11:52:14AM +0200, David Marchand wrote:
> > Ubuntu 24.04 started to compress firmwares with ZSTD compression.
> >
> > Bugzilla ID: 1437
> >
> > Signed-off-by: David Marchand
> > ---
> > lib/eal/unix/eal_firmware.
What's the difference between this version and v4?
On Tue, May 7, 2024 at 7:44 PM Nicholas Pratte wrote:
>
> In order to prevent accidental misconfiguration of hugepages at runtime,
> the following changes are made to only allow for configuration of 2MB
> hugepages within the DTS config.yaml. In
In the previous implementation, the maximum reclamation size was set
to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
uses the configuration argument to set the maximum reclamation size.
Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
Cc: dharmik.thak...@arm
On Tue, May 7, 2024 at 3:00 PM Bruce Richardson
wrote:
>
> On Tue, May 07, 2024 at 01:43:30PM +0100, Luca Vizzarro wrote:
> > On 07/05/2024 13:05, Bruce Richardson wrote:
> > > Sorry to be late to the reviews here, but since this is a countable value
> > > -
> > > as you state in the cover letter
Ubuntu 24.04 started to compress firmware files with ZSTD compression.
Bugzilla ID: 1437
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
Chances since v1:
- fixed link issue when libarchive is not available,
- Cc'd sta...@dpdk.org,
---
lib/eal/unix/eal_firmware.c | 24 ++-
On Mon, May 13, 2024 at 01:12:04PM +0200, David Marchand wrote:
> Ubuntu 24.04 started to compress firmware files with ZSTD compression.
>
> Bugzilla ID: 1437
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
> ---
> Chances since v1:
> - fixed link issue when libarchive is not available,
Hello Bruce,
On Mon, May 13, 2024 at 1:37 PM Bruce Richardson
wrote:
> > @@ -16,6 +16,8 @@
> > #include "eal_firmware.h"
> > #include "eal_private.h"
> >
> > +static const char * const compression_algorithms[] = { "xz", "zst" };
> Very minor nit: these are the suffixes used to find the files, m
> -Original Message-
> From: Minggang(Gavin) Li
> Sent: Thursday, May 9, 2024 14:45
> To: Matan Azrad ; Slava Ovsiienko
> ; Ori Kam ; NBU-Contact-
> Thomas Monjalon (EXTERNAL) ; Dariusz Sosnowski
> ; Suanming Mou ;
> Itamar Gozlan
> Cc: dev@dpdk.org; Raslan Darawsheh ; Bing Zhao
>
> Subj
On 5/8/2024 10:19 PM, Abdullah Ömer Yamaç wrote:
> clang-format is a tool to format C/C++/Objective-C code. It can be used
> to reformat code to match a given coding style, or to ensure that code
> adheres to a specific coding style. It helps to maintain a consistent
> coding style across the DPDK
Hi Abdullah,
I do not see the changes I suggested in this version.
> On May 13, 2024, at 5:00 AM, Abdullah Ömer Yamaç wrote:
>
> In the previous implementation, the maximum reclamation size was set
> to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
> uses the config
Other than the one minor documentation nitpick,
Reviewed-by: Juraj Linkeš
> diff --git a/dts/framework/remote_session/interactive_shell.py
> b/dts/framework/remote_session/interactive_shell.py
> @@ -124,20 +130,34 @@ def send_command(self, command: str, prompt: str | None
> = None) -> str:
>
Reviewed-by: Juraj Linkeš
On Wed, May 1, 2024 at 6:17 PM wrote:
>
> From: Jeremy Spewock
>
> When this XML-RPC server implementation was added, the docstring had to
> be shortened in order to reduce the chances of this race condition being
> encountered. Now that this race condition issue is re
Good idea. And again, with the one minor point below,
Reviewed-by: Juraj Linkeš
> diff --git a/dts/framework/remote_session/interactive_shell.py
> b/dts/framework/remote_session/interactive_shell.py
> index 0b0ccdb545..eb9c9b6843 100644
> --- a/dts/framework/remote_session/interactive_shell.py
>
https://bugs.dpdk.org/show_bug.cgi?id=1439
Bug ID: 1439
Summary: Unmounting hugepages doesn't have admin privileges
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: no
Hello,
I saw two comments, and the first one
" Please add:
sta...@dpdk.org to the Cc list" then I added sta...@dpdk.org to Cc. Would
you like me to add it to the commit?
Second one :
“Set the maximum reclamation size to user provided value” I set this
comment to the header. I thought it was more
Hello,
That's my mistake and I will discard the lookup part. While I was
implementing these parts, I thought that readers should not be in a
quiescent state, and I just wanted to make sure that these values were in
use and the reader was in the critical section.
Thanks I will fix ASAP
On Mon, May
Hi All,
I have a crash inside of rte_mempool_create which happens when I allocate
multiple big mem pools(multiple GB each), in particular first argument of
function alloc_seg(LINUX) is null, I investigated a little bit and it seems
like there is a bug inside of rte_fbarray_find_next_n_free.
Insid
On Mon, 13 May 2024 09:23:08 +0100
Maryam Tahhan wrote:
> On 10/05/2024 16:06, Stephen Hemminger wrote:
> > You don't have to use local statistic for this, there already is one in the
> > dev struct
> > i.e dev->data->rx_mbuf_alloc_failed. The problem is you need the DPDK port
> > number to fin
On Mon, 13 May 2024 14:08:07 +0100
Ferruh Yigit wrote:
> 2. Double tab indentation vs parenthesis align
> if (iter->bus != NULL &&
> - /* not in middle of rte_eth_dev iteration, */
> - iter->class_device == NULL) {
> + /* not in mi
I reviewed and made small syntax and grammatical edits
to sections in the programmer's guide and the design section of
the contributor's guidelines.
Nandini Persad (9):
doc: reword design section in contributors guidelines
doc: reword pmd section in prog guide
doc: reword argparse section in
minor editing for grammar and syntax of design section
Signed-off-by: Nandini Persad
---
.mailmap | 1 +
doc/guides/contributing/design.rst | 79 ++
doc/guides/linux_gsg/sys_reqs.rst | 2 +-
3 files changed, 38 insertions(+), 44 deletions(
minor changes made for syntax in the log library section and 7.1
section of the programmer's guide. A couple sentences at the end of the
trace library section were also edited.
Signed-off-by: Nandini Persad
---
doc/guides/prog_guide/cmdline.rst | 24 +++---
doc/guides/prog_guid
made small edits to sections 6.1 and 6.2 intro
Signed-off-by: Nandini Persad
---
doc/guides/prog_guide/argparse_lib.rst | 72 +-
1 file changed, 35 insertions(+), 37 deletions(-)
diff --git a/doc/guides/prog_guide/argparse_lib.rst
b/doc/guides/prog_guide/argparse_lib.rs
made small edits to section 15.1 and 15.5
Signed-off-by: Nandini Persad
---
doc/guides/prog_guide/poll_mode_drv.rst | 151
1 file changed, 73 insertions(+), 78 deletions(-)
diff --git a/doc/guides/prog_guide/poll_mode_drv.rst
b/doc/guides/prog_guide/poll_mode_drv.rst
i
minor change made to wording
Signed-off-by: Nandini Persad
---
doc/guides/prog_guide/stack_lib.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/prog_guide/stack_lib.rst
b/doc/guides/prog_guide/stack_lib.rst
index 975d3ad796..a51df60d13 100644
--- a/doc/guid
made minor syntax edits to sect 9.1-9.7 of prog guide
Signed-off-by: Nandini Persad
---
doc/guides/prog_guide/trace_lib.rst | 50 ++---
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/doc/guides/prog_guide/trace_lib.rst
b/doc/guides/prog_guide/trace_lib.r
made minor syntax changes to section 8 of programmer's guide, service cores
Signed-off-by: Nandini Persad
---
doc/guides/prog_guide/service_cores.rst | 32 -
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/doc/guides/prog_guide/service_cores.rst
b/doc/gui
minor syntax edits
Signed-off-by: Nandini Persad
---
doc/guides/prog_guide/cmdline.rst | 34 +++
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/doc/guides/prog_guide/cmdline.rst
b/doc/guides/prog_guide/cmdline.rst
index 6b10ab6c99..8aa1ef180b 100644
simple syntax changes made to rcu library sectionin programmer's guide
Signed-off-by: Nandini Persad
---
doc/guides/prog_guide/rcu_lib.rst | 77 ---
1 file changed, 40 insertions(+), 37 deletions(-)
diff --git a/doc/guides/prog_guide/rcu_lib.rst
b/doc/guides/prog_gu
> diff --git a/dts/framework/runner.py b/dts/framework/runner.py
> index db8e3ba96b..d74f1871db 100644
> --- a/dts/framework/runner.py
> +++ b/dts/framework/runner.py
> @@ -23,7 +23,7 @@
> import re
> import sys
> from pathlib import Path
> -from types import MethodType
> +from types import Func
2024-05-13 18:37 (UTC+0300), Oleksandr Nahnybida:
[snip]
> I think ignore_msk |= last_msk; should be replaced by cur_msk &=
> last_msk; I tried this and dpdk doesn't crash anymore and seems to
> work fine, but I'd like someone else familiar with this code to take a look
> at this.
I confirm this
> diff --git a/dts/framework/testbed_model/traffic_generator/__init__.py
> b/dts/framework/testbed_model/traffic_generator/__init__.py
> @@ -39,8 +39,8 @@ def create_traffic_generator(
> Returns:
> A traffic generator capable of capturing received packets.
> """
> -match tra
> On May 13, 2024, at 10:22 AM, Abdullah Ömer Yamaç
> wrote:
>
> Hello,
> I saw two comments, and the first one
> " Please add:
> sta...@dpdk.org to the Cc list" then I added sta...@dpdk.org to Cc. Would you
> like me to add it to the commit?
I thought it needs to be added to the commit mess
https://bugs.dpdk.org/show_bug.cgi?id=1440
Bug ID: 1440
Summary: use after free in af_xdp
Product: DPDK
Version: 24.03
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Set the maximum reclamation size to user provided value
Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
Cc: sta...@dpdk.org
Cc: dharmik.thak...@arm.com
Cc: Honnappa Nagarahalli
Cc: Yipeng Wang
Cc: Sameh Gobriel
Cc: Bruce Richardson
Cc: Vladimir Medvedkin
Signed-off-by: Abdu
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Sunday, May 5, 2024 7:32 PM
> To: dev@dpdk.org
> Cc: gak...@marvell.com; Power, Ciara ; Kusztal,
> ArkadiuszX
> Subject: [PATCH v2] common/qat: add legacy algorithm option
>
> This commit adds legacy algorithms flag to the qat_d
Hi Tyler,
Still some issues with indentation when the sed is causing split across 2
lines.
Please fix indentation, nack like that.
Thanks
Nic
> -Original Message-
> From: Tyler Retzlaff
> Sent: Monday, May 6, 2024 10:58 AM
> To: dev@dpdk.org
> Cc: Mattias Rönnblom ; Morten Brørup
>
This is second attempt to demonstrate:
- generic counters for SW drivers, the example does covers:
af_packet, af_xdp, tap, ring but could be applied to virtio, etc.
- counters are safe against 64 bit tearing on 32 bit platform
v2 - renamed and reorganized
- put counters in eal, stats i
This header implements 64 bit counters that are NOT atomic
but are safe against load/store splits on 32 bit platforms.
Signed-off-by: Stephen Hemminger
---
lib/eal/include/meson.build | 1 +
lib/eal/include/rte_counter.h | 91 +++
2 files changed, 92 insertions
This clones the staistic update code from virtio for use
by other drivers. It also uses native uint64_t on 64 bit platform
but atomic operations on 32 bit platforms.
Signed-off-by: Stephen Hemminger
ethdev: use atomic on 32
---
lib/ethdev/ethdev_swstats.c | 270 +
Use the new generic SW stats.
Signed-off-by: Stephen Hemminger
---
drivers/net/af_packet/rte_eth_af_packet.c | 95 +++
1 file changed, 29 insertions(+), 66 deletions(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
b/drivers/net/af_packet/rte_eth_af_packet.c
index
Use new common sw statistics.
Signed-off-by: Stephen Hemminger
---
drivers/net/tap/rte_eth_tap.c | 102 +++---
drivers/net/tap/rte_eth_tap.h | 15 +
2 files changed, 34 insertions(+), 83 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/r
Use common statistics for SW drivers.
Signed-off-by: Stephen Hemminger
---
drivers/net/pcap/pcap_ethdev.c | 146 +++--
1 file changed, 47 insertions(+), 99 deletions(-)
diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index bfec085045..872
Use common code for all SW stats.
Signed-off-by: Stephen Hemminger
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 115 +++-
1 file changed, 44 insertions(+), 71 deletions(-)
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
b/drivers/net/af_xdp/rte_eth_af_xdp.c
index 268a130c
Use generic per-queue infrastructure.
Signed-off-by: Stephen Hemminger
---
drivers/net/ring/rte_eth_ring.c | 85 +
1 file changed, 44 insertions(+), 41 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 48953dd7a0..5
Tyler, it looks like the line continuations in
/drivers/baseband/acc/rte_vrb_pmd.c are indented with four spaces instead of
double .
Med venlig hilsen / Kind regards,
-Morten Brørup
> From: Chautru, Nicolas [mailto:nicolas.chau...@intel.com]
> Sent: Monday, 13 May 2024 20.13
>
> Hi Tyler,
>
>
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, 13 May 2024 17.55
>
> On Mon, 13 May 2024 14:08:07 +0100
> Ferruh Yigit wrote:
>
> > 2. Double tab indentation vs parenthesis align
> > if (iter->bus != NULL &&
> > - /* not in middle of
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, 13 May 2024 20.52
>
> This header implements 64 bit counters that are NOT atomic
> but are safe against load/store splits on 32 bit platforms.
>
> Signed-off-by: Stephen Hemminger
> ---
As an initial reaction I would
Support VxLAN all fields support.
To match GBP or GPE extension, the user needs to set
the right UDP destination port plus the desired VxLAN
flag bits.
Signed-off-by: Rongwei Liu
Reviewed-by: Alex Vesker
Acked-by: Dariusz Sosnowski
---
doc/guides/nics/mlx5.rst | 18 +++---
50 matches
Mail list logo
