> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 13 May 2024 20.52 > > This header implements 64 bit counters that are NOT atomic > but are safe against load/store splits on 32 bit platforms. > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > ---
As an initial reaction I would have preferred get() instead of fetch(); get() being more common in DPDK function naming. However, atomic functions use the name fetch(), not get(), and these are functions are slightly related to atomic functions. So, after further consideration, it seems fetch() is the better choice. Acked-by: Morten Brørup <m...@smartsharesystems.com> PS: Although I'm usually strongly opposed to EAL bloat... As long as the EAL also serves as a the library for simple utility functions, this belongs in the EAL. Specific optimizations for various 32 bit architectures may be added later.
