RE: [EXTERNAL] [PATCH v2] graph: avoid accessing graph list when getting stats

2024-04-03 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: Robin Jarry > Sent: Tuesday, April 2, 2024 2:07 AM > To: dev@dpdk.org; Jerin Jacob ; Kiran Kumar > Kokkilagadda ; Nithin Kumar Dabilpuram > ; Zhirun Yan > Subject: [EXTERNAL] [PATCH v2] graph: avoid accessing graph list when getting > stats > > Prioritize

[DPDK/DTS Bug 1410] TestPmdShell.set_forward_mode verify argument is not used

2024-04-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1410 Bug ID: 1410 Summary: TestPmdShell.set_forward_mode verify argument is not used Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFI

Re: [PATCH v1 1/2] dts: Improve output gathering in interactive shells

2024-04-03 Thread Juraj Linkeš
On Tue, Mar 12, 2024 at 6:26 PM wrote: > > From: Jeremy Spewock > > The current implementation of consuming output from interactive shells > relies on being able to find an expected prompt somewhere within the > output buffer after sending the command. This is useful in situations > where the pro

[PATCH v2 0/5] vhost: FD manager improvements

2024-04-03 Thread Maxime Coquelin
This series aims at improving the Vhost FD manager. The fdset internals is hidden from its callers, the notification/synchronization is made systematic for every FD add/del operations and finally the code is reworked to make use of epoll insteal of poll which reduces the complexity (less locks invo

[PATCH v2 1/5] vhost: rename polling mutex

2024-04-03 Thread Maxime Coquelin
This trivial patch fixes a typo in fd's manager polling mutex name. Reviewed-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/fd_man.c | 8 lib/vhost/fd_man.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/vhost/fd_man.c b/lib/vhost/fd_man.c i

[PATCH v2 2/5] vhost: make use of FD manager init function

2024-04-03 Thread Maxime Coquelin
Instead of statically initialize the fdset, this patch converts VDUSE and Vhost-user to use fdset_init() function, which now also initialize the mutexes. This is preliminary rework to hide FDs manager pipe from its users. Signed-off-by: Maxime Coquelin --- lib/vhost/fd_man.c | 11 +-- l

[PATCH v2 3/5] vhost: hide synchronization within FD manager

2024-04-03 Thread Maxime Coquelin
This patch forces synchronization for all FDs additions or deletions in the FD set. With that, it is no more necessary for the user to know about the FD set pipe, so hide its initialization in the FD manager. Signed-off-by: Maxime Coquelin --- lib/vhost/fd_man.c | 180 ---

[PATCH v2 4/5] vhost: improve fdset initialization

2024-04-03 Thread Maxime Coquelin
This patch heavily reworks fdset initialization: - fdsets are now dynamically allocated by the FD manager - the event dispatcher is now created by the FD manager - struct fdset is now opaque to VDUSE and Vhost Signed-off-by: Maxime Coquelin --- lib/vhost/fd_man.c | 177 +++-- lib

[PATCH v2 5/5] vhost: manage FD with epoll

2024-04-03 Thread Maxime Coquelin
From: David Marchand Switch to epoll so that the concern over the poll() fd array is removed. Add a simple list of used entries and track the next free entry. epoll() is thread safe, we no more need a synchronization mechanism and so can remove the notification pipe. Signed-off-by: David Marcha

Re: [PATCH] vhost: fix crash caused by accessing a freed vsocket

2024-04-03 Thread Maxime Coquelin
Hi Gongming, It's the 9th time the patch has been sent. I'm not sure whether there are changes between them or these are just re-sends, but that's something to avoid. If there are differences, you should use versionning to highlight it. If unsure, please check the contributions guidelines first.

Re: [PATCH] vhost: optimize mbuf allocation in virtio Tx packed path

2024-04-03 Thread Maxime Coquelin
On 3/29/24 00:33, Andrey Ignatov wrote: Currently virtio_dev_tx_packed() always allocates requested @count of packets, no matter how many packets are really available on the virtio Tx ring. Later it has to free all packets it didn't use and if, for example, there were zero available packets on

[PATCH 1/5] net/hns3: fix offload flag of IEEE 1588

2024-04-03 Thread Jie Hai
From: Dengdui Huang Currently, the RTE_MBUF_F_RX_IEEE1588_TMST offload flag will not be set when the scatter algorithm is used. This patch fixes it. Fixes: 4801f0403b58 ("net/hns3: fix IEEE 1588 PTP for scalar scattered Rx") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Jie H

[PATCH 0/5] net/hns3: add some bugfix

2024-04-03 Thread Jie Hai
This patchset adds some bugfixes. Dengdui Huang (4): net/hns3: fix offload flag of IEEE 1588 net/hns3: fix read Rx timestamp handle net/hns3: fix double free for Rx/Tx queue net/hns3: fix variable overflow Jie Hai (1): net/hns3: disable SCTP verification Tag for RSS hash input drivers

[PATCH 3/5] net/hns3: fix double free for Rx/Tx queue

2024-04-03 Thread Jie Hai
From: Dengdui Huang The Pointers to some resources on the Rx/Tx queue need to be set to NULL after free inside the hns3_rx/tx_queue_release(), as this function is called from multiple threads (reset thread, device config thread, etc), leading to double memory free error. Fixes: bba636698316 ("ne

[PATCH 2/5] net/hns3: fix read Rx timestamp handle

2024-04-03 Thread Jie Hai
From: Dengdui Huang The flag RTE_MBUF_F_RX_IEEE1588_PTP depends on the packet type and does not need to be set when reading Rx timestamp. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_

[PATCH 4/5] net/hns3: fix variable overflow

2024-04-03 Thread Jie Hai
From: Dengdui Huang the function strtoul() returns an unsigned long, which should be received using the variable uint64_t. Fixes: 2fc3e696a7f1 ("net/hns3: add runtime config for mailbox limit time") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Jie Hai --- drivers/net/hns3/

[PATCH 5/5] net/hns3: disable SCTP verification Tag for RSS hash input

2024-04-03 Thread Jie Hai
When the symmetric RSS algorithm is used, the same packet is expected to be hashed to the same queue in the upstream and downstream directions. The problem is that it could map the packets in the same SCTP connection to different NIC RX queues depending on the direction of packets. This is because

reg. Flow director rule create on LACP Bond

2024-04-03 Thread Balakrishnan K
Hi All, I am trying to create Flow director rule to select the specific RX queue. Example: flow create 0 ingress pattern eth / ipv4 src is 20.20.20.2 dst is 20.20.20.5 / end actions queue index 1 / end Tested with LINK create and applied the mentioned rule , traffic with src 20.20.20.2 and d

webinar - DPDK in clouds - April 10

2024-04-03 Thread Thomas Monjalon
Interested in exploring use cases for DPDK in cloud environments? Join us for a candid discussion with expert panelists: - Rushil Gupta (Google) - Brian Denton (Microsoft) - Jim Thompson (Netgate) Honnappa Nagarahalli (Arm) will moderate the discussion focusing on use case

RE: [PATCH v16 1/8] net/ntnic: initial commit which adds register defines

2024-04-03 Thread Mykola Kostenok
Hi, Ferruh. Yes, we plan to send new 'ntnic' patch series into v24.07 Right now, we are doing refactoring of 'ntnic' code to make it modular. So, we will send it split into smaller patches. Best regards,  Mykola Kostenok. > -Original Message- > From: Ferruh Yigit > Sent: Friday, March 2

Re: Issues around packet capture when secondary process is doing rx/tx

2024-04-03 Thread Ferruh Yigit
On 1/8/2024 3:13 PM, Konstantin Ananyev wrote: > > >> I have been looking at a problem reported by Sandesh >> where packet capture does not work if rx/tx burst is done in secondary >> process. >> >> The root cause is that existing rx/tx callback model just doesn't work >> unless the process doin

Re: Issues around packet capture when secondary process is doing rx/tx

2024-04-03 Thread Ferruh Yigit
On 1/8/2024 10:41 AM, Morten Brørup wrote: >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Monday, 8 January 2024 02.59 >> >> I have been looking at a problem reported by Sandesh >> where packet capture does not work if rx/tx burst is done in secondary >> process. >> >> The

Re: [PATCH v5 7/8] net/tap: use libbpf to load new BPF program

2024-04-03 Thread Luca Boccassi
On Tue, 2024-04-02 at 10:12 -0700, Stephen Hemminger wrote: > There were multiple issues in the RSS queue support in the TAP > driver. This required extensive rework of the BPF support. > > Change the BPF loading to use bpftool to > create a skeleton header file, and load with libbpf. > The BPF is

[PATCH] net/fm10k: fix cleanup during init failure

2024-04-03 Thread Julien Meunier
Cleanup was not done on this PMD if a error is seen during the init: - possible memory leak due to a missing free - interrupt handler was not disabled: if an IRQ is received after the init, a SIGSEGV can be seen (private data stored in rte_eth_devices[port_id] is pointing to NULL) Fixes: a6061

Re: Issues around packet capture when secondary process is doing rx/tx

2024-04-03 Thread Ferruh Yigit
On 1/9/2024 11:07 PM, Stephen Hemminger wrote: > On Tue, 9 Jan 2024 15:06:47 -0800 > Stephen Hemminger wrote: > >> On Mon, 8 Jan 2024 15:13:25 + >> Konstantin Ananyev wrote: >> I have been looking at a problem reported by Sandesh where packet capture does not work if rx/tx burst is

Re: Issues around packet capture when secondary process is doing rx/tx

2024-04-03 Thread Ferruh Yigit
On 1/10/2024 8:11 PM, Konstantin Ananyev wrote: > > >> -Original Message- >> From: Stephen Hemminger >> Sent: Tuesday, January 9, 2024 11:07 PM >> To: Konstantin Ananyev >> Cc: dev@dpdk.org; arshdeep.k...@intel.com; Gowda, Sandesh >> ; Reshma Pattan >> >> Subject: Re: Issues around pa

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Thomas Monjalon
03/04/2024 15:59, Marek Pazdan: > There are link settings parameters available from PMD drivers level > which are currently not exposed to the user via consistent interface. > When interface is available for system level those information can > be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-03 Thread Thomas Monjalon
02/04/2024 18:03, Ashish Sadanandan: > Hi everyone, > I've made the updates as suggested. Could someone please review the latest > patchset? Not sure if I followed the new patchset instructions correctly, > I've always had trouble with that part. I remember we were discussing about aligning all fi

Re: [PATCH v5 7/8] net/tap: use libbpf to load new BPF program

2024-04-03 Thread Stephen Hemminger
On Wed, 03 Apr 2024 12:50:35 +0100 Luca Boccassi wrote: > On Tue, 2024-04-02 at 10:12 -0700, Stephen Hemminger wrote: > > There were multiple issues in the RSS queue support in the TAP > > driver. This required extensive rework of the BPF support. > > > > Change the BPF loading to use bpftool to

Re: [PATCH] vhost: fix crash caused by accessing a freed vsocket

2024-04-03 Thread Gongming Chen
Hi Maxime, Thanks for review. > On Apr 3, 2024, at 5:39 PM, Maxime Coquelin > wrote: > > Hi Gongming, > > It's the 9th time the patch has been sent. > I'm not sure whether there are changes between them or these are just > re-sends, but that's something to avoid. > Sorry, there's something w

Re: [PATCH v5 7/8] net/tap: use libbpf to load new BPF program

2024-04-03 Thread Stephen Hemminger
On Wed, 03 Apr 2024 12:50:35 +0100 Luca Boccassi wrote: > Using bpftool to generate the header at build time is a bit icky, > because it will look at sysfs on the build system, which is from the > running kernel. But a build system's kernel might be some ancient LTS, > and even be a completely di

RE: The effect of inlining

2024-04-03 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Monday, 1 April 2024 17.20 > > On 2024-03-29 14:42, Morten Brørup wrote: > > +CC techboard > > > >> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > >> Sent: Friday, 29 March 2024 14.05 > >> > >> Hi Stephen, > >> > >> On 3/

[PATCH v1] vhost: fix crash caused by accessing a freed vsocket

2024-04-03 Thread Gongming Chen
From: Gongming Chen When a vhost user message handling error in the event dispatch thread, vsocket reconn is added to the reconnection list of the reconnection thread. Since the reconnection, event dispatching and app configuration thread do not have common thread protection restrictions, the app

[PATCH] lib: add get/set link settings interface

2024-04-03 Thread Marek Pazdan
There are link settings parameters available from PMD drivers level which are currently not exposed to the user via consistent interface. When interface is available for system level those information can be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/ ETHTOOL_GLINKSETTINGS).

[PATCH] lib: add get/set link settings interface

2024-04-03 Thread Marek Pazdan
There are link settings parameters available from PMD drivers level which are currently not exposed to the user via consistent interface. When interface is available for system level those information can be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/ ETHTOOL_GLINKSETTINGS).

RES: [PATCH] net/ice: fix vlan stripping in double VLAN mode

2024-04-03 Thread Carlos de Souza Moraes Neto
Hi David, I verified using testpmd and my application and worked fine. Thank you for your help, Sincerely Carlos Moraes. -Mensagem original- De: David Marchand Enviada em: quinta-feira, 28 de março de 2024 08:16 Para: Vladimir Medvedkin Cc: dev@dpdk.org; Carlos de Souza Moraes Neto ;

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Marek Pazdan
Hi Thomas, Information like advertising: speed, pause, autonegotiation etc. and that same for link partner advertising. I try to mimic ethtool since it's a common, well known and widely used tool so adding an API which provides the same set of information in case the interface is passthrough to dp

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Thomas Monjalon
03/04/2024 16:59, Marek Pazdan: > Hi Thomas, > > Information like advertising: speed, pause, autonegotiation etc. and that > same for link partner advertising. speed and duplex are already provided in some existing API. > I try to mimic ethtool since it's a common, well known and widely used to

[PATCH] doc: update required Mingw version

2024-04-03 Thread Stephen Hemminger
Some new patches were failing on the very old version of mingw that is being used by the CI system. But there was no required version for mingw listed in the documentation, so add one. The version is selected is the version available for Debian oldstable (Bullseye) as listed on: https://www.ming

[PATCH 0/2] uuid: enhancements and tests

2024-04-03 Thread Stephen Hemminger
The DPDK version of uuid was missing tests and a way to generate uuid's. Add both. Stephen Hemminger (2): eal: add functions to generate uuid values test: add functional test for uuid app/test/meson.build | 1 + app/test/test_uuid.c | 135 ++

[PATCH 1/2] eal: add functions to generate uuid values

2024-04-03 Thread Stephen Hemminger
Useful to be able to generate uuid values for tests or for interaction with other subsystems as magic cookie. Naming and overall algorithm come from libuuid which is used by permission of original author. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_uuid.c | 56

[PATCH 2/2] test: add functional test for uuid

2024-04-03 Thread Stephen Hemminger
The uuid functions in EAL were not covered by any current functional tests. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_uuid.c | 135 +++ 2 files changed, 136 insertions(+) create mode 100644 app/test/test_uuid.c diff

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Tyler Retzlaff
On Wed, Apr 03, 2024 at 06:40:24AM -0700, Marek Pazdan wrote: > There are link settings parameters available from PMD drivers level > which are currently not exposed to the user via consistent interface. > When interface is available for system level those information can > be acquired with 'et

Re: [PATCH v1 0/2] deque: add multithread unsafe deque library

2024-04-03 Thread Honnappa Nagarahalli
> On Apr 1, 2024, at 9:53 PM, Stephen Hemminger > wrote: > > On Tue, 2 Apr 2024 02:14:06 + > Honnappa Nagarahalli wrote: > >>> On Apr 1, 2024, at 9:00 PM, Stephen Hemminger >>> wrote: >>> >>> On Tue, 2 Apr 2024 01:35:28 + >>> Honnappa Nagarahalli wrote: >>> > On Apr 1, 2024,

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Stephen Hemminger
On Wed, 3 Apr 2024 16:59:08 +0200 Marek Pazdan wrote: > Hi Thomas, > > Information like advertising: speed, pause, autonegotiation etc. and that > same for link partner advertising. > I try to mimic ethtool since it's a common, well known and widely used tool > so adding an API which provides th

Re: [PATCH v1 0/2] deque: add multithread unsafe deque library

2024-04-03 Thread Tyler Retzlaff
On Wed, Apr 03, 2024 at 04:50:02PM +, Honnappa Nagarahalli wrote: > > > > On Apr 1, 2024, at 9:53 PM, Stephen Hemminger > > wrote: > > > > On Tue, 2 Apr 2024 02:14:06 + > > Honnappa Nagarahalli wrote: > > > >>> On Apr 1, 2024, at 9:00 PM, Stephen Hemminger > >>> wrote: > >>> > >>>

[PATCH v10 1/4] net/i40e: use inline prefetch function

2024-04-03 Thread Tyler Retzlaff
Don't directly access the cacheline1 field in rte_mbuf struct for prefetch instead just use rte_mbuf_prefetch_part2() to prefetch. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- drivers/net/i40e/i40e_rxtx_vec_avx512.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v10 0/4] remove use of RTE_MARKER fields in libraries

2024-04-03 Thread Tyler Retzlaff
As per techboard meeting 2024/03/20 adopt hybrid proposal of adapting descriptor fields and removing cachline fields. RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields. For cacheline{0,1} fields remove fields entirely and use inline functions to prefetch. Prov

[PATCH v10 3/4] security: remove rte marker fields

2024-04-03 Thread Tyler Retzlaff
RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- doc/guides/rel_

[PATCH v10 2/4] mbuf: remove rte marker fields

2024-04-03 Thread Tyler Retzlaff
RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Provide new rearm_data and rx_descriptor_fields1 fields in anonymous unions as

[PATCH v10 4/4] cryptodev: remove rte marker fields

2024-04-03 Thread Tyler Retzlaff
RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- doc/guides/rel_

[PATCH v2] build: exclude rather than include libs in MSVC build

2024-04-03 Thread Tyler Retzlaff
Some libraries that could be built with MSVC were not being built. Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds. With this change we now get immediate CI build coverage for the libs meter, timer, pci, cfgfile

[PATCH v2] build: exclude rather than include libs in MSVC build

2024-04-03 Thread Tyler Retzlaff
Some libraries that could be built with MSVC were not being built. Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- lib/argparse/meson.build | 6 +

RE: [PATCH v2] build: exclude rather than include libs in MSVC build

2024-04-03 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 3 April 2024 20.23 > > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Win

RE: [PATCH v10 2/4] mbuf: remove rte marker fields

2024-04-03 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 3 April 2024 19.54 > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 al

Re: [PATCH v5 7/8] net/tap: use libbpf to load new BPF program

2024-04-03 Thread Luca Boccassi
On Wed, 3 Apr 2024 at 16:55, Stephen Hemminger wrote: > > On Wed, 03 Apr 2024 12:50:35 +0100 > Luca Boccassi wrote: > > > Using bpftool to generate the header at build time is a bit icky, > > because it will look at sysfs on the build system, which is from the > > running kernel. But a build syst

Re: [PATCH v10 1/4] net/i40e: use inline prefetch function

2024-04-03 Thread Stephen Hemminger
On Wed, 3 Apr 2024 10:53:33 -0700 Tyler Retzlaff wrote: > Don't directly access the cacheline1 field in rte_mbuf struct for > prefetch instead just use rte_mbuf_prefetch_part2() to prefetch. > > Signed-off-by: Tyler Retzlaff > Reviewed-by: Morten Brørup Acked-by: Stephen Hemminger

Re: [PATCH v10 2/4] mbuf: remove rte marker fields

2024-04-03 Thread Stephen Hemminger
On Wed, 3 Apr 2024 10:53:34 -0700 Tyler Retzlaff wrote: > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 alignas(RTE_CACHE_LINE_MIN_SIZE). > > Provid

Re: [PATCH v10 3/4] security: remove rte marker fields

2024-04-03 Thread Stephen Hemminger
On Wed, 3 Apr 2024 10:53:35 -0700 Tyler Retzlaff wrote: > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 alignas(RTE_CACHE_LINE_MIN_SIZE). > > Signed

Re: [PATCH v10 4/4] cryptodev: remove rte marker fields

2024-04-03 Thread Stephen Hemminger
On Wed, 3 Apr 2024 10:53:36 -0700 Tyler Retzlaff wrote: > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 alignas(RTE_CACHE_LINE_MIN_SIZE). > > Signed

Re: [PATCH v2] build: exclude rather than include libs in MSVC build

2024-04-03 Thread Stephen Hemminger
On Wed, 3 Apr 2024 11:23:19 -0700 Tyler Retzlaff wrote: > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > With this change we now g

[PATCH v2 0/2] uuid: add generate functions and tests

2024-04-03 Thread Stephen Hemminger
The DPDK version of uuid was missing tests and a way to generate uuid's. Add both. v2 - use RTE_ATOMIC to get _Atomic in clang Stephen Hemminger (2): eal: add functions to generate uuid values test: add functional test for uuid app/test/meson.build | 1 + app/test/test_uuid.c

[PATCH v2 1/2] eal: add functions to generate uuid values

2024-04-03 Thread Stephen Hemminger
Useful to be able to generate uuid values for tests or for interaction with other subsystems as magic cookie. Naming and overall algorithm come from libuuid which is used by permission of original author. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_uuid.c | 56

[PATCH v2 2/2] test: add functional test for uuid

2024-04-03 Thread Stephen Hemminger
The uuid functions in EAL were not covered by existing functional tests. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_uuid.c | 135 +++ 2 files changed, 136 insertions(+) create mode 100644 app/test/test_uuid.c diff --

Re: [PATCH v10 2/4] mbuf: remove rte marker fields

2024-04-03 Thread Tyler Retzlaff
On Wed, Apr 03, 2024 at 09:32:21PM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 3 April 2024 19.54 > > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > > RTE_MARKER fields from rte_mbuf struct. > > > > Mai

Re: [PATCH] doc: update required Mingw version

2024-04-03 Thread Tyler Retzlaff
On Wed, Apr 03, 2024 at 09:28:51AM -0700, Stephen Hemminger wrote: > Some new patches were failing on the very old version of mingw that > is being used by the CI system. But there was no required version > for mingw listed in the documentation, so add one. > > The version is selected is the versi

22.11.5 patches review and test

2024-04-03 Thread luca . boccassi
Hi all, Here is a list of patches targeted for stable release 22.11.5. The planned date for the final release is April 18th. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validatio

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Stephen Hemminger
On Thu, 4 Apr 2024 00:08:41 +0200 Marek Pazdan wrote: > I can remove this part (rte_eth_config), but the new API provides other > link information which is not available from the existing API, like > supported/advertising/partner_advertising link modes. > Additionally from what I see, rte_eth_con

Re: [PATCH v5 7/8] net/tap: use libbpf to load new BPF program

2024-04-03 Thread Stephen Hemminger
On Wed, 3 Apr 2024 22:19:20 +0100 Luca Boccassi wrote: > On Wed, 3 Apr 2024 at 16:55, Stephen Hemminger > wrote: > > > > On Wed, 03 Apr 2024 12:50:35 +0100 > > Luca Boccassi wrote: > > > > > Using bpftool to generate the header at build time is a bit icky, > > > because it will look at sysfs

Variable name issues with codespell.

2024-04-03 Thread Stephen Hemminger
On Wed, 3 Apr 2024 00:12:19 + Honnappa Nagarahalli wrote: > > https://en.cppreference.com/w/cpp/container/deque > > > > The root cause of my complaint is the codespell dictionary used in the > > patchwork tests. > > It is a bit of twisted path to fix this though. CI runs checkpatch.sh whi

Re: [PATCH v5 7/8] net/tap: use libbpf to load new BPF program

2024-04-03 Thread Luca Boccassi
On Thu, 4 Apr 2024 at 00:41, Stephen Hemminger wrote: > > On Wed, 3 Apr 2024 22:19:20 +0100 > Luca Boccassi wrote: > > > On Wed, 3 Apr 2024 at 16:55, Stephen Hemminger > > wrote: > > > > > > On Wed, 03 Apr 2024 12:50:35 +0100 > > > Luca Boccassi wrote: > > > > > > > Using bpftool to generate th

RE: reg. Flow director rule create on LACP Bond

2024-04-03 Thread Balakrishnan K
Can anyone help on the below issue , is flow create with specific pattern supported in LACP Bond? From: Balakrishnan K Sent: Wednesday, April 3, 2024 4:14 PM To: dev@dpdk.org Cc: Stephen Hemminger Subject: reg. Flow director rule create on LACP Bond Hi All, I am trying to create Flow direc