03/04/2024 16:59, Marek Pazdan: > Hi Thomas, > > Information like advertising: speed, pause, autonegotiation etc. and that > same for link partner advertising.
speed and duplex are already provided in some existing API. > I try to mimic ethtool since it's a common, well known and widely used tool > so adding an API which provides the same set of information in case the > interface is passthrough to dpdk will be useful I think. DPDK API is widely used as well :) I am not sure adding a new API for the same thing is a good idea. > I've 2 more patches dependent on the one we are discussing now, but I need > patchwork id to add dependency information. I need moderator approval for > the current patch. I've approved your mails, but you would not need a manual approval if you register. Note that you can disable receiving other threads in ML options. See an explanation here: https://www.dpdk.org/first-patch-submission-to-the-dpdk-open-source-project/ > On Wed, Apr 3, 2024 at 4:48 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > > 03/04/2024 15:59, Marek Pazdan: > > > There are link settings parameters available from PMD drivers level > > > which are currently not exposed to the user via consistent interface. > > > When interface is available for system level those information can > > > be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/ > > > ETHTOOL_GLINKSETTINGS). There are use cases where > > > physical interface is passthrough to dpdk driver and is not available > > > from system level. Information provided by ioctl carries information > > > useful for link auto negotiation settings among others. > > > > Which information is missing exactly? > > Why are you trying to mimic ethtool API? > > > > Please let's add what is missing instead of adding a full new API.
