[PATCH] net/nfp: fix representor port release queue problem

From: Long Wu The PF representor port's queue is different from the VF/physical representor port. So the release process in close port should be different too. Fixes: 39b3951 ("net/nfp: fix resource leak for exit of flower firmware") Cc: chaoyong...@corigine.com Cc: sta...@dpdk.org Signed-off-b

RE: [PATCH v5 1/6] examples/l3fwd: fix lcore ID restriction

> From: Sivaprasad Tummala [mailto:sivaprasad.tumm...@amd.com] > Sent: Monday, 18 March 2024 18.32 > > Currently the config option allows lcore IDs up to 255, > irrespective of RTE_MAX_LCORES and needs to be fixed. > > The patch allows config options based on DPDK config. > > Fixes: af75078fece3

RE: [PATCH 01/13] net/mlx5/hws: move warn into debug level when needed

Hi, > -Original Message- > From: Thomas Monjalon > Sent: Monday, March 18, 2024 4:49 PM > To: Itamar Gozlan ; Erez Shitrit ; > Hamdan Agbariya ; Yevgeny Kliteynik > ; Alex Vesker ; Raslan Darawsheh > > Cc: Slava Ovsiienko ; Dariusz Sosnowski > ; Ori Kam ; Suanming Mou > ; Matan Azrad ; M

RE: [PATCH v9 5/5] eal: add option to put timestamp on console output

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 18 March 2024 23.03 > > When debugging driver or startup issues, it is useful to have > a timestamp on each message printed. The messages in syslog > already have a timestamp, but often syslog is not available > during t

RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption

> > > + if (options->test == CPERF_TEST_TYPE_THROUGHPUT && > > > + (options->aead_op == RTE_CRYPTO_AEAD_OP_DECRYPT || > > > + options->cipher_op == RTE_CRYPTO_CIPHER_OP_DECRYPT) && > > > + !options->out_of_place) { > > > + RTE_LOG(ERR, USER1, "Only out-of-place is a

fib{,6}: questions and proposals

Hi Vladimir, I have been using rte_fib for a while and stumbled upon a few quirks. I was wondering if you would answer some questions: 1) Is it OK/safe to share the same fib to perform route lookups from multiple lcores in parallel? So far my observations seem to validate that assumption

Re: Email based retest request process: proposal for new pull/re-apply feature

On Mon, Mar 18, 2024 at 3:59PM, Patrick Robb wrote: On Thu, Mar 7, 2024 at 12:06 PM Adam Hassick wrote: I'm not opposed to having the contexts be a key-value pair argument like the others, however that does break backwards compatibility with our existing syntax. If we don't care very much ab

[PATCH] net/nfp: fix uninitialized variable

CI found in the logic of 'nfp_aesgcm_iv_update()', the variable 'cfg_iv' may used uninitialized in some case. Coverity issue: 415808 Fixes: 36361ca7fea2 ("net/nfp: fix data endianness problem") Cc: shihong.w...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Rev

Re: [PATCH] doc: add dma perf feature details

On Mon, Mar 18, 2024 at 6:17PM, Amit Prakash Shukla wrote: Update dma perf test document with below support features: 1. Memory-to-device and device-to-memory copy. 2. Skip support. 3. Scatter-gather support. Signed-off-by: Amit Prakash Shukla --- doc/guides/tools/dmaperf.rst | 89 +

RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption

> -Original Message- > From: Akhil Goyal > Sent: Tuesday, March 19, 2024 4:23 PM > To: Suanming Mou ; Anoob Joseph > ; ciara.po...@intel.com > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption > > > > > + if (options->test == CPERF_

RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption

> > Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP > decryption > > > > > > > + if (options->test == CPERF_TEST_TYPE_THROUGHPUT && > > > > > + (options->aead_op == RTE_CRYPTO_AEAD_OP_DECRYPT || > > > > > + options->cipher_op == RTE_CRYPTO_CIPHER_OP_DECRYPT)

[PATCH] app/testpmd: fix releasing action handle flush memory

The memory of the indirect action handles should be freed after being destroyed in the flush. The behavior needs to be consistent with the single handle destroy. Or else, there will be some unexpected error when the action handle is destroyed for the 2nd time, for example, the port needs to be clo

RE: [PATCH 0/2] Tx path check mbuf sub-segment

> -Original Message- > From: Mingjin Ye > Sent: Friday, March 15, 2024 6:24 PM > To: dev@dpdk.org > Cc: Ye, MingjinX > Subject: [PATCH 0/2] Tx path check mbuf sub-segment > > Add check mbuf sub-segment to Tx diagnostic path. > > Mingjin Ye (2): > net/i40e: Tx path check mbuf sub-segme

RE: [PATCH v2] dmadev: fix structure alignment

> -Original Message- > From: Ma, WenwuX > Sent: Friday, March 15, 2024 9:44 AM > To: dev@dpdk.org; fengcheng...@huawei.com > Cc: Jiale, SongX ; Ma, WenwuX > ; sta...@dpdk.org > Subject: [PATCH v2] dmadev: fix structure alignment > > The structure rte_dma_dev needs only 8 byte alignment. >

RE: [PATCH] net/iavf: fix fail to reset vf when using dcf

> -Original Message- > From: Kaiwen Deng > Sent: Thursday, March 14, 2024 9:01 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhou, YidingX ; Deng, KaiwenX > ; Wu, Jingjing ; Zeng, > ZhichaoX ; Zhang, Qi Z > Subject: [PATCH] net/iavf: fix fail to reset vf when using dcf > > On the latest i

RE: [PATCH v7 1/4] hash: pack the hitmask for hash in bulk lookup

Hi, > Current hitmask includes padding due to Intel's SIMD > implementation detail. This patch allows non Intel SIMD > implementations to benefit from a dense hitmask. > In addition, the new dense hitmask interweave the primary > and secondary matches which allow a better cache usage and > enabl

Re: [PATCH] net/nfp: fix representor port release queue problem

On 3/19/2024 7:07 AM, Chaoyong He wrote: > From: Long Wu > > The PF representor port's queue is different from the VF/physical > representor port. So the release process in close port should > be different too. > > Fixes: 39b3951 ("net/nfp: fix resource leak for exit of flower firmware") > Cc: c

RE: [PATCH] net/nfp: fix representor port release queue problem

> On 3/19/2024 7:07 AM, Chaoyong He wrote: > > From: Long Wu > > > > The PF representor port's queue is different from the VF/physical > > representor port. So the release process in close port should be > > different too. > > > > Fixes: 39b3951 ("net/nfp: fix resource leak for exit of flower > >

[PATCH v2] net/mlx5: fix sync meter action

PMD implements sync METER flow action as async. Queue selected for sync operations is `MLX5_HW_INV_QUEUE`. That dummy queue value is translated into `CTRL_QUEUE_ID(priv)`. Async job allocation converts INV queue into the real value, but job release does not. This patch fixes the queue value provid

RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption

> -Original Message- > From: Akhil Goyal > Sent: Tuesday, March 19, 2024 5:32 PM > To: Suanming Mou ; Anoob Joseph > ; ciara.po...@intel.com > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption > > > > Subject: RE: [EXT] [PATCH] app/test-c

[PATCH v2] app/test-crypto-perf: add throughput OOP decryption

During throughput running, re-filling the test data will impact the performance test result. So for now, to run decrypt throughput testing is not supported since the test data is not filled. But if user requires OOP(out-of-place) mode, the test data from source mbuf will never be modified, and if

Re: [dpdk-dev] [v6] doc: define qualification criteria for external library

On 1/9/2024 2:10 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > Define qualification criteria for external library > based on a techboard meeting minutes [1] and past > learnings from mailing list discussion. > > [1] > http://mails.dpdk.org/archives/dev/2019-June/135847.html > https://mai

Re: [PATCH] net/nfp: fix uninitialized variable

On 3/19/2024 8:55 AM, Chaoyong He wrote: > CI found in the logic of 'nfp_aesgcm_iv_update()', the variable > 'cfg_iv' may used uninitialized in some case. > > Coverity issue: 415808 > Fixes: 36361ca7fea2 ("net/nfp: fix data endianness problem") > Cc: shihong.w...@corigine.com > Cc: sta...@dpdk.org

Re: [PATCH v1 1/1] iavf: document limitation on MTU

On Wed, Mar 13, 2024 at 03:43:35PM +, Anatoly Burakov wrote: > When configuring a port, the configured MTU will > not include VLAN tag size, but the physical > function driver will add it automatically if the > port has VLAN filtering configured, which may > result in seemingly valid MTU to be

RE: [RFC v5 1/6] eal: add static per-lcore memory allocation facility

Hi Mattias, > Introduce DPDK per-lcore id variables, or lcore variables for short. > > An lcore variable has one value for every current and future lcore > id-equipped thread. > > The primary use case is for statically allocating > small chunks of often-used data, which is related logically, bu

Re: [PATCH v7 1/4] hash: pack the hitmask for hash in bulk lookup

On 3/19/24 10:41, Konstantin Ananyev wrote: Hi, Current hitmask includes padding due to Intel's SIMD implementation detail. This patch allows non Intel SIMD implementations to benefit from a dense hitmask. In addition, the new dense hitmask interweave the primary and secondary matches which al

RE: [PATCH v7 1/4] hash: pack the hitmask for hash in bulk lookup

> > > > Hi, > > > >> Current hitmask includes padding due to Intel's SIMD > >> implementation detail. This patch allows non Intel SIMD > >> implementations to benefit from a dense hitmask. > >> In addition, the new dense hitmask interweave the primary > >> and secondary matches which allow a bett

[PATCH v3] net/netvsc: fix number Tx queues > Rx queues

The previous code allowed the number of Tx queues to be set higher than the number of Rx queues. If a packet was sent on a Tx queue with index >= number Rx queues there was a segfault. This commit fixes the issue by creating an Rx queue for every Tx queue meaning that an event buffer is allocated

RE: [PATCH v2] net/netvsc: fix number Tx queues > Rx queues

Thanks for the feedback Long. I've made both changes you suggested, plus one additional one to not try and allocate an mbuf if the pool is null. This means if a packet is received on a Rx queue that isn't being polled we will see it appear as "mbuf allocation failed" rather than causing a segfa

Re: [PATCH] app/testpmd: fix releasing action handle flush memory

On 3/19/2024 9:32 AM, Bing Zhao wrote: > The memory of the indirect action handles should be freed after > being destroyed in the flush. The behavior needs to be consistent > with the single handle destroy. > > Or else, there will be some unexpected error when the action handle > is destroyed for

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

On 3/18/2024 9:21 AM, Shani Peretz wrote: > In the process of auto completion of a command in testpmd, > the parser splits the command into tokens, where each token > represents an argument and defines a parsing function. > The parsing function of the indirect_list action argument was returning > b

Re: [PATCH] net/igc: fix disabling timesync

On Mon, Mar 18, 2024 at 04:11:14AM +, Liao, TingtingX wrote: >Tested-by: Tingting Liao > __ > >> -Original Message- > >> From: Ma, WenwuX > >> Sent: Friday, March 15, 2024 09:06 > >> To: dev@d

RE: [PATCH v2] app/test-crypto-perf: add throughput OOP decryption

> -Original Message- > From: Suanming Mou > Sent: Tuesday, March 19, 2024 11:46 AM > To: gak...@marvell.com; Power, Ciara > Cc: dev@dpdk.org > Subject: [PATCH v2] app/test-crypto-perf: add throughput OOP decryption > > During throughput running, re-filling the test data will impact th

Re: [PATCH v1 1/1] iavf: document limitation on MTU

On Tue, Mar 19, 2024 at 12:14:53PM +, Bruce Richardson wrote: > On Wed, Mar 13, 2024 at 03:43:35PM +, Anatoly Burakov wrote: > > When configuring a port, the configured MTU will > > not include VLAN tag size, but the physical > > function driver will add it automatically if the > > port has

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

On 3/19/2024 2:51 PM, Ferruh Yigit wrote: > On 3/18/2024 9:21 AM, Shani Peretz wrote: >> In the process of auto completion of a command in testpmd, >> the parser splits the command into tokens, where each token >> represents an argument and defines a parsing function. >> The parsing function of the

Re: [PATCH] doc: deprecate graph data structures

On Tue, 19 Mar 2024 08:52:13 +0530 Jerin Jacob wrote: > On Wed, Feb 21, 2024 at 9:43 PM wrote: > > > > From: Pavan Nikhilesh > > > > Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats > > structures as will be extended to include node specific error counters > > and error de

Re: [PATCH v9 5/5] eal: add option to put timestamp on console output

On Tue, 19 Mar 2024 08:37:30 +0100 Morten Brørup wrote: > > static ssize_t > > console_log_write(__rte_unused void *c, const char *buf, size_t size) > > { > > + struct timespec ts; > > ssize_t ret; > > > > - /* write on stderr */ > > - ret = fwrite(buf, 1, size, stderr); > > + if

Re: [PATCH v7 1/4] hash: pack the hitmask for hash in bulk lookup

On Tue, 12 Mar 2024 15:42:12 + Yoan Picchi wrote: > + static_assert(sizeof(*hitmask_buffer) >= 2*(RTE_HASH_BUCKET_ENTRIES/8), Space around math operations please.

RE: [PATCH v9 5/5] eal: add option to put timestamp on console output

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 19 March 2024 16.52 > > On Tue, 19 Mar 2024 08:37:30 +0100 > Morten Brørup wrote: > > > > static ssize_t > > > console_log_write(__rte_unused void *c, const char *buf, size_t > size) > > > { > > > + struct timespec

[PATCH] net/ixgbe: using dpdk-dumpcap capture packet coredump

Signed-off-by: Jun Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 73 1 file changed, 37 insertions(+), 36 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index c61c52b..0e624f5 100644 --- a/drivers/net/ixgbe/ixg

Re: fib{,6}: questions and proposals

Hi Robin, On 19/03/2024 08:30, Robin Jarry wrote: Hi Vladimir, I have been using rte_fib for a while and stumbled upon a few quirks. I was wondering if you would answer some questions: 1) Is it OK/safe to share the same fib to perform route lookups from   multiple lcores in parallel? So far

Re: Email based retest request process: proposal for new pull/re-apply feature

On Tue, Mar 19, 2024 at 4:37 AM zhoumin wrote: > > > One more thing I want to confirm is whether we should apply the patch > onto the branch commit which existed at the time when that patch was > submitted or onto the latest tip of branch if users request doing > rebase. Users probably request a r

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

On 3/19/2024 3:29 PM, Ferruh Yigit wrote: > On 3/19/2024 2:51 PM, Ferruh Yigit wrote: >> On 3/18/2024 9:21 AM, Shani Peretz wrote: >>> In the process of auto completion of a command in testpmd, >>> the parser splits the command into tokens, where each token >>> represents an argument and defines a

Re: Email based retest request process: proposal for new pull/re-apply feature

Patrick Robb writes: > On Tue, Mar 19, 2024 at 4:37 AM zhoumin wrote: >> >> >> One more thing I want to confirm is whether we should apply the patch >> onto the branch commit which existed at the time when that patch was >> submitted or onto the latest tip of branch if users request doing >> reb

RE: [PATCH v3] net/netvsc: fix number Tx queues > Rx queues

> Subject: [PATCH v3] net/netvsc: fix number Tx queues > Rx queues > > The previous code allowed the number of Tx queues to be set higher than the > number of Rx queues. If a packet was sent on a Tx queue with index > >= number Rx queues there was a segfault. > > This commit fixes the issue by c

Re: [PATCH v5 0/6] fix lcore ID restriction

On 3/18/2024 5:31 PM, Sivaprasad Tummala wrote: > With modern CPUs, it is possible to have higher > CPU count thus we can have higher RTE_MAX_LCORES. > In DPDK sample applications, the current config > lcore options are hard limited to 255. > > The patchset fixes these constraints by allowing >

[DPDK/DTS Bug 1404] Ensure primary applications such as testpmd are properly cleaned up

https://bugs.dpdk.org/show_bug.cgi?id=1404 Bug ID: 1404 Summary: Ensure primary applications such as testpmd are properly cleaned up Product: DPDK Version: unspecified Hardware: All OS: All Statu

[DPDK/DTS Bug 1383] DTS: clean up old tarball before copying a new one over

https://bugs.dpdk.org/show_bug.cgi?id=1383 Patrick Robb (pr...@iol.unh.edu) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|U

Re: fib{,6}: questions and proposals

Hi Vladimir, Medvedkin, Vladimir, Mar 19, 2024 at 18:16: > 2) Is it OK/safe to modify a fib from a control thread (read/write) >while it is used by data path threads (read only)? This part is a bit more complicated. In practice, I would say yes, however, there is a possibility that if the

RE: [PATCH v2] app/test-crypto-perf: add throughput OOP decryption

> -Original Message- > From: Power, Ciara > Sent: Tuesday, March 19, 2024 11:15 PM > To: Suanming Mou ; gak...@marvell.com > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] app/test-crypto-perf: add throughput OOP decryption > > > > > -Original Message- > > From: Suanming Mou > >

Re: [PATCH v2] app/dma-perf: calrify incorrect NUMA config

Thank you Konstantin for the reply, Adding back the comments as it is not reflected the mail thread diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c index 9b1f58c78c..b6d0dbe4c0 100644 --- a/app/test-dma-perf/benchmark.c +++ b/app/test-dma-perf/benchmark.c @@ -311,9

Re: [PATCH 1/3] ethdev: support setting lanes

On 2024/3/19 11:02, Stephen Hemminger wrote: > On Tue, 12 Mar 2024 15:52:36 +0800 > Dengdui Huang wrote: > >> -ret = snprintf(str, len, "Link up at %s %s %s", >> +ret = snprintf(str, len, "Link up at %s %ulanes %s %s", > > Don't you want a space after %u? > > Could yo

Re: Email based retest request process: proposal for new pull/re-apply feature

On Tue, Mar 19, 2024 at 5:30PM, Patrick Robb wrote: On Tue, Mar 19, 2024 at 4:37 AM zhoumin wrote: One more thing I want to confirm is whether we should apply the patch onto the branch commit which existed at the time when that patch was submitted or onto the latest tip of branch if users re

[PATCH v3] app/dma-perf: calrify incorrect NUMA config

In case incorrect NUMA configuration, the current commit shares 1) either `source or destination numa is greater` 2) instead of `actual NUMA` it is `acture NUMA` 3) uses `printf` instead of PRINT_ERR current patch changes the above to 1) identify if source or|and destination is incorrect 2) f

RE: [PATCH] doc: deprecate graph data structures

Acked-by: Zhirun Yan > -Original Message- > From: Nithin Dabilpuram > Sent: Tuesday, March 19, 2024 1:21 PM > To: pbhagavat...@marvell.com > Cc: jer...@marvell.com; ndabilpu...@marvell.com; kirankum...@marvell.com; > Yan, Zhirun ; dev@dpdk.org > Subject: Re: [PATCH] doc: deprecate graph

Tech Board Meeting Tomorrow Wed. 3/20 - 7am pacific/10am Eastern/1400h utc

Agenda (read only) https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db 1. Join from PC, Mac, iPad, or Android *https://zoom-lfx.platform.linuxfoundation.org/meeting/91865709518?password=df302f34-a942-4d14-a95b-a6c46ae98fae*

RE: [PATCH] graph: fix head move when graph walk in mcore dispatch

> -Original Message- > From: Wu, Jingjing > Sent: Tuesday, March 19, 2024 10:15 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; jer...@marvell.com; > pbhagavat...@marvell.com; Yan, Zhirun ; > sta...@dpdk.org > Subject: [PATCH] graph: fix head move when graph walk in mcore dispatch > > Head

Re: Tech Board Meeting Tomorrow Wed. 3/20 - 7am pacific/10am Eastern/1400h utc

Dear DPDK Community, i apologize - this was in error. Ignore the information from that previous message. For some reason, I had two lfx meetings for the tech board on my calendar at different times tomorrow. *The correct time should be 8am Pacific/11am Eastern/1500h UTC.* *And the correct log in

Re: [PATCH v9 5/5] eal: add option to put timestamp on console output

On Tue, 19 Mar 2024 17:13:35 +0100 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Tuesday, 19 March 2024 16.52 > > > > On Tue, 19 Mar 2024 08:37:30 +0100 > > Morten Brørup wrote: > > > > > > static ssize_t > > > > console_log_write(__rte_unus

Re: [PATCH v2] dmadev: fix structure alignment

Hi Wenwu, On 2024/3/15 17:27, Ma, WenwuX wrote: > Hi Chengwen > >> -Original Message- >> From: fengchengwen >> Sent: Friday, March 15, 2024 4:32 PM >> To: Ma, WenwuX ; dev@dpdk.org >> Cc: Jiale, SongX ; sta...@dpdk.org >> Subject: Re: [PATCH v2] dmadev: fix structure alignment >> >> Hi W

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

Hello Ferruh, >BUT overall how can we catch issues like this in the feature, we don't >have a good way to test testpmd flow commands. >@Ori, @Gregory, do you have any idea? >cc'ed CI mail list too. We have a tool for unit tests based on the testpmd. The tool details are here: https://drive.goog

RE: [PATCH] graph: fix head move when graph walk in mcore dispatch

> > /* skip the src nodes which not bind with current worker */ > > if ((int32_t)head < 0 && node->dispatch.lcore_id != graph- > > >dispatch.lcore_id) > > continue; > > - > > + head++; > If current src node not bind with current core, It will