On 3/19/2024 3:29 PM, Ferruh Yigit wrote: > On 3/19/2024 2:51 PM, Ferruh Yigit wrote: >> On 3/18/2024 9:21 AM, Shani Peretz wrote: >>> In the process of auto completion of a command in testpmd, >>> the parser splits the command into tokens, where each token >>> represents an argument and defines a parsing function. >>> The parsing function of the indirect_list action argument was returning >>> before having the opportunity to handle the argument. >>> >> Hi Shani, >> >> I can see a few other handles follows the updated logic, but to >> understand more, was the problematic part following: >> ``` >> if (!action) >> return -1; >> ``` >> >> If so why 'action' can be NULL and why need to continue for this case, >> can you please help me understand? >> >> Also even if 'action' is NULL, function will return output of >> 'parse_int()', is this expected? >> > > I can verify the fix via debugging, > > it seems missing ".comp = comp_none" cause calling handler > (parse_indlst_id2ptr), and 'parse_indlst_id2ptr()' needs to be fixed to > parse correctly. > > I will proceed with patch since it is local to a specific flow command, >
Tested-by: Ferruh Yigit <ferruh.yi...@amd.com> Applied to dpdk-next-net/main, thanks.
