Hi Thomas and Fengchengwen,
>
> 13/03/2024 09:22, Gowrishankar Muthukrishnan:
> > Hi Fengchengwen
> >
> > > Hi Gowrishankar,
> > >
> > > On 2024/3/12 20:24, Gowrishankar Muthukrishnan wrote:
> > > > Hi Fengchengwen
> > > >
> > > >>
> > > >> Hi Thomas,
> > > >>
> > > >> On 2024/3/12 17:15, Thomas
The issue indeed lies with the ixgbe driver. After making the following
modifications, dpdk-dumpcap is now functioning properly.
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index
d6cf00317e77b64f9822c155115f388ae62241eb..99b26f3c758b3c7ced5d59c6b27f305efe6cc33
I got some report for users that VLAN insertion was not working as the
only thing they could see in verbose mode was a 0x0800 ethertype even
though the RTE_MBUF_F_TX_VLAN flag was shown.
Dump the VLAN TCI from mbuf metadata when VLAN insertion is requested.
This should enhance the situation.
Befo
The judgement "obj->callback == NULL" is dead code which can't be
reached, because verify_arg_saver() already make sure obj->callback
must not be NULL when arg->val_saver is NULL.
Signed-off-by: Chengwen Feng
---
app/test/test_argparse.c| 7 ---
lib/argparse/rte_argparse.c | 6 --
2
I found a couple of issues when I revisited the argparse_autotest
output, so got this patchset.
Chengwen Feng (6):
argparse: refine error message
argparse: remove dead code
argparse: replace flag enum with marco
argparse: fix argument flags operate as uint32 type
test/argparse: refine te
The struct rte_argparse_arg's flags was 64bit type, uint64_t should be
used instead of uint32_t where the operation happened.
Also, the flags' bit16 was also unused, so don't test bit16 in testcase
test_argparse_invalid_arg_flags.
In addition, this commit introduces two bitmask marcros and remove
With the line in rst file:
The single mode: "--aaa" or "-a".
corresponding line in html doc:
The single mode: -aaa or -a.
the two hyphens (--aaa) become one (-aaa).
According to [1], this commit uses the backquote (``xxx``) to fix it.
And for consistency, use this format for all ar
Refine testcases, including:
1. add testcase comment.
2. argv[0] should set obj->prog_name.
3. set val_set as NULL in test_argparse_invalid_arg_flags, let it
test to the specified code logic.
4. enable index verification in opt_callback_parse_int_of_no_val.
Fixes: 6c5c6571601c ("argparse: verify a
This patch refines the error message.
Signed-off-by: Chengwen Feng
---
lib/argparse/rte_argparse.c | 31 +--
1 file changed, 17 insertions(+), 14 deletions(-)
diff --git a/lib/argparse/rte_argparse.c b/lib/argparse/rte_argparse.c
index 2d953f1694..48738cd07b 100644
-
The enum rte_argparse_flag's value is u64, but an enum in C is
represented as an int. This commit replace these enum values with
macro.
Fixes: e3e579f5bab5 ("argparse: introduce argparse library")
Fixes: 5357c248c960 ("argparse: parse unsigned integers")
Signed-off-by: Chengwen Feng
---
lib/arg
Hi Thomas,
On 2024/3/18 10:31, Thomas Monjalon wrote:
> 07/03/2024 14:07, Chengwen Feng:
>> --- a/app/test/test_argparse.c
>> +++ b/app/test/test_argparse.c
>> +#define TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK RTE_SHIFT_VAL64(3, 0)
>> +#define TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK RTE_SHIFT_VAL64(255, 2)
18/03/2024 10:18, Chengwen Feng:
> --- a/app/test/test_argparse.c
> +++ b/app/test/test_argparse.c
> +#define TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK RTE_SHIFT_VAL64(3, 0)
> +#define TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK RTE_SHIFT_VAL64(255, 2)
Don't you want to make it part of the API?
I thought it w
In the process of auto completion of a command in testpmd,
the parser splits the command into tokens, where each token
represents an argument and defines a parsing function.
The parsing function of the indirect_list action argument was returning
before having the opportunity to handle the argument.
I found a couple of issues when I revisited the argparse_autotest
output, so got this patchset.
Chengwen Feng (6):
argparse: refine error message
argparse: remove dead code
argparse: replace flag enum with marco
argparse: fix argument flags operate as uint32 type
test/argparse: refine te
This patch refines the error message.
Signed-off-by: Chengwen Feng
---
lib/argparse/rte_argparse.c | 31 +--
1 file changed, 17 insertions(+), 14 deletions(-)
diff --git a/lib/argparse/rte_argparse.c b/lib/argparse/rte_argparse.c
index 2d953f1694..48738cd07b 100644
-
The judgement "obj->callback == NULL" is dead code which can't be
reached, because verify_arg_saver() already make sure obj->callback
must not be NULL when arg->val_saver is NULL.
Signed-off-by: Chengwen Feng
---
app/test/test_argparse.c| 7 ---
lib/argparse/rte_argparse.c | 6 --
2
Refine testcases, including:
1. add testcase comment.
2. argv[0] should set obj->prog_name.
3. set val_set as NULL in test_argparse_invalid_arg_flags, let it
test to the specified code logic.
4. enable index verification in opt_callback_parse_int_of_no_val.
Fixes: 6c5c6571601c ("argparse: verify a
The enum rte_argparse_flag's value is u64, but an enum in C is
represented as an int. This commit replace these enum values with
macro.
Fixes: e3e579f5bab5 ("argparse: introduce argparse library")
Fixes: 5357c248c960 ("argparse: parse unsigned integers")
Signed-off-by: Chengwen Feng
---
lib/arg
The struct rte_argparse_arg's flags was 64bit type, uint64_t should be
used instead of uint32_t where the operation happened.
Also, the flags' bit16 was also unused, so don't test bit16 in testcase
test_argparse_invalid_arg_flags.
In addition, this commit introduces two bitmask marcros and remove
With the line in rst file:
The single mode: "--aaa" or "-a".
corresponding line in html doc:
The single mode: -aaa or -a.
the two hyphens (--aaa) become one (-aaa).
According to [1], this commit uses the backquote (``xxx``) to fix it.
And for consistency, use this format for all ar
Hi Thomas,
On 2024/3/18 17:38, Thomas Monjalon wrote:
> 18/03/2024 10:18, Chengwen Feng:
>> --- a/app/test/test_argparse.c
>> +++ b/app/test/test_argparse.c
>> +#define TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK RTE_SHIFT_VAL64(3, 0)
>> +#define TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK RTE_SHIFT_VAL64(255, 2)
Hi,
> -Original Message-
> From: Itamar Gozlan
> Sent: Thursday, March 14, 2024 1:42 PM
> To: Itamar Gozlan ; Erez Shitrit ;
> Hamdan Agbariya ; Yevgeny Kliteynik
> ; Alex Vesker ; Slava Ovsiienko
> ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Dariusz Sosnowski ; Ori
> Kam ; Suanming Mou
18/03/2024 13:56, Raslan Darawsheh:
> From: Itamar Gozlan
> > From: Erez Shitrit
> >
> > When the user tries to create a matcher and if failed with specific errno
> > (E2BIG) the message will be in debug level and not in warning.
> > It is a part of a feature when the user re-try to insert a ne
12/03/2024 08:52, Dengdui Huang:
> Some speeds can be achieved with different number of lanes. For example,
> 100Gbps can be achieved using two lanes of 50Gbps or four lanes of 25Gbps.
> When use different lanes, the port cannot be up.
I'm not sure what you are referring to.
I suppose it is not PC
On Mon, 18 Mar 2024 10:48:03 +0800
"junwan...@cestc.cn" wrote:
> The issue indeed lies with the ixgbe driver. After making the following
> modifications, dpdk-dumpcap is now functioning properly.
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index
> d6c
On Thu, Mar 7, 2024 at 12:06 PM Adam Hassick wrote:
>
>
> I'm not opposed to having the contexts be a key-value pair argument
> like the others, however that does break backwards compatibility with
> our existing syntax. If we don't care very much about backwards
> compatibility, then we could mak
Hello!
Sending in v2 for my patch series, which changes a lot compared to v1.
The main and big change was the reworking of the arguments handling,
this can potentially be seen as a controversial change but I tried to
explain it as much as I could in the commit body message.
v2:
- complete rework
The existing argument handling in the code relies on basic argparse
functionality and a custom argparse action to integrate environment
variables. This commit improves the current handling by augmenting
argparse through a custom implementation of the arguments.
This rework implements the following
DTS needs an input to gather the DPDK source code from. This is then
built on the remote target. This commit makes sure that this input is
more constrained, separating the Git revision ID – used to create a
tarball using Git – and providing tarballed source code directly, while
retaining mutual exc
Store the stderr of an executed command in RemoteCommandExecutionError.
Consequently, when the exception is logged the error message includes
the stderr.
Signed-off-by: Luca Vizzarro
Reviewed-by: Paul Szczepanek
Reviewed-by: Jack Bond-Preston
---
dts/framework/exception.py
Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.
The patch allows config options based on DPDK config.
Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Sivaprasad Tummala
Acked-by: Konstantin Ananyev
--
With modern CPUs, it is possible to have higher
CPU count thus we can have higher RTE_MAX_LCORES.
In DPDK sample applications, the current config
lcore options are hard limited to 255.
The patchset fixes these constraints by allowing
all lcore IDs up to RTE_MAX_LCORES. Also the queue
IDs are inc
Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.
The patch allows config options based on DPDK config.
Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores
options")
Cc: radu.nico...@intel.com
Cc: sta...@dpdk.org
Si
Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.
The patch allows config options based on DPDK config.
Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton")
Cc: ndabilpu...@marvell.com
Cc: sta...@dpdk.org
Signed-
Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.
The patch allows config options based on DPDK config.
Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Cc: sergio.gonzalez.mon...@intel.com
Cc: sta...@dpdk.org
Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.
The patch allows config options based on DPDK config.
Fixes: 0e8f47491f09 ("examples/vm_power: add command to query CPU frequency")
Cc: marcinx.hajkow...@intel.com
Cc: sta...@dpdk.org
Si
Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.
The patch allows config options based on DPDK config.
Fixes: de3cfa2c9823 ("sched: initial import")
Cc: sta...@dpdk.org
Signed-off-by: Sivaprasad Tummala
---
examples/qos_sched/args.c
With modern CPUs, it is possible to have higher
CPU count thus we can have higher RTE_MAX_LCORES.
In DPDK sample applications, the current config
lcore options are hard limited to 255.
The patchset fixes these constraints by allowing
all lcore IDs up to RTE_MAX_LCORES. Also the queue
IDs are inc
PMD implements sync METER flow action as async.
Queue selected for sync operations is `MLX5_HW_INV_QUEUE`.
That dummy queue value is translated into `CTRL_QUEUE_ID(priv)`.
Async job allocation converts INV queue into the real value, but
job release does not.
This patch fixes the queue value provid
Update dma perf test document with below support features:
1. Memory-to-device and device-to-memory copy.
2. Skip support.
3. Scatter-gather support.
Signed-off-by: Amit Prakash Shukla
---
doc/guides/tools/dmaperf.rst | 89 ++--
1 file changed, 64 insertions(+), 2
Improvements and unification of logging library (for 24.07 release).
This is update to earlier patch set.
v8 - rebase to current code base where logging in in lib/log
use stdio for log timestamp
initialization changes (setup log earlier)
Stephen Hemminger (5):
log: unify logging code
FreeBSD and Linux logging code can use common code. This also
fixes FreeBSD not using syslog.
Signed-off-by: Stephen Hemminger
---
doc/guides/linux_gsg/linux_eal_parameters.rst | 27 ---
doc/guides/prog_guide/log_lib.rst | 18 +++--
lib/eal/freebsd/eal.c
The code to parse for log-level option should be same on
all OS variants.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_options.c | 46 +
lib/eal/common/eal_options.h| 1 +
lib/eal/freebsd/eal.c | 42 --
It is useful for application to be able to set the default log
stream before call rte_eal_init(). This makes all messages go
to the new default.
For example, to skip using syslog; just doing
rte_openlog_stream(stderr);
There is no reason for helper command line applications to clutter
sys
When debugging driver or startup issues, it is useful to have
a timestamp on each message printed. The messages in syslog
already have a timestamp, but often syslog is not available
during testing. The timestamp format is chosen to look
like the default Linux dmesg timestamp.
The first few lines a
Want to make sure that as many log messages as possible
get added with the real log stream.
Signed-off-by: Stephen Hemminger
---
lib/eal/freebsd/eal.c | 16
lib/eal/linux/eal.c | 16
lib/eal/unix/eal_unix_log.c | 0
3 files changed, 16 insertions(
Update dma perf test document with below support features:
1. Memory-to-device and device-to-memory copy.
2. Skip support.
3. Scatter-gather support.
Signed-off-by: Amit Prakash Shukla
---
v2:
- Rebased the patch.
doc/guides/tools/dmaperf.rst | 89 ++--
1 file ch
On Mon, Mar 18, 2024 at 7:56 AM Thomas Monjalon wrote:
>
> 12/03/2024 08:52, Dengdui Huang:
> > Some speeds can be achieved with different number of lanes. For example,
> > 100Gbps can be achieved using two lanes of 50Gbps or four lanes of 25Gbps.
> > When use different lanes, the port cannot be u
On Mon, 18 Mar 2024 14:26:33 -0700
Damodharam Ammepalli wrote:
> On Mon, Mar 18, 2024 at 7:56 AM Thomas Monjalon wrote:
> >
> > 12/03/2024 08:52, Dengdui Huang:
> > > Some speeds can be achieved with different number of lanes. For example,
> > > 100Gbps can be achieved using two lanes of 50Gbp
Improvements and unification of logging library (for 24.07 release).
This is update to earlier patch set.
v9 - reorder patches and fix FreeBSD build
v8 - rebase to current code base where logging in in lib/log
use stdio for log timestamp
initialization changes (setup log earlier)
Steph
FreeBSD and Linux logging code can use common code. This also
fixes FreeBSD not using syslog.
Signed-off-by: Stephen Hemminger
---
doc/guides/linux_gsg/linux_eal_parameters.rst | 27 ---
doc/guides/prog_guide/log_lib.rst | 18 +++--
lib/eal/freebsd/eal.c
The code to parse for log-level option should be same on
all OS variants.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_options.c | 46 +
lib/eal/common/eal_options.h| 1 +
lib/eal/freebsd/eal.c | 42 --
Want to make sure that as many log messages as possible
get added with the real log stream.
Signed-off-by: Stephen Hemminger
---
lib/eal/freebsd/eal.c | 14 +++---
lib/eal/linux/eal.c | 16
lib/eal/unix/eal_unix_log.c | 0
3 files changed, 15 insertions(+)
It is useful for application to be able to set the default log
stream before call rte_eal_init(). This makes all messages go
to the new default.
For example, to skip using syslog; just doing
rte_openlog_stream(stderr);
There is no reason for helper command line applications to clutter
sys
When debugging driver or startup issues, it is useful to have
a timestamp on each message printed. The messages in syslog
already have a timestamp, but often syslog is not available
during testing. The timestamp format is chosen to look
like the default Linux dmesg timestamp.
The first few lines a
On Mon, 5 Apr 2021 21:39:52 +0200
Thomas Monjalon wrote:
> The description of the EAL options was printed before the application
> description provided via the hook.
> It is better to let the application print the global syntax
> and describes the detail of the EAL options below.
>
> Also, some
On Mon, 1 Nov 2021 23:14:47 +0530
Harman Kalra wrote:
> Fixing the error logs level, as currently default level is
> set to debug. Due to this failure is not getting captured.
>
> Fixes: b7c984291611 ("interrupts: add allocator and accessors")
>
> Signed-off-by: Harman Kalra
Patch concept is
On Mon, Mar 18, 2024 at 2:42 PM Stephen Hemminger
wrote:
>
> On Mon, 18 Mar 2024 14:26:33 -0700
> Damodharam Ammepalli wrote:
>
> > On Mon, Mar 18, 2024 at 7:56 AM Thomas Monjalon wrote:
> > >
> > > 12/03/2024 08:52, Dengdui Huang:
> > > > Some speeds can be achieved with different number of lan
Hi Akhil
Sorry for the late reply.
> -Original Message-
> From: Akhil Goyal
> Sent: Friday, March 15, 2024 2:45 AM
> To: Suanming Mou ; Anoob Joseph
> ; ciara.po...@intel.com
> Cc: dev@dpdk.org
> Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption
>
> > During
On 2024/3/15 19:17, Ferruh Yigit wrote:
On 3/15/2024 3:00 AM, Jie Hai wrote:
The RSS algorithm from user is parased but not passed to the
rte_eth_dev_rss_hash_update() API as we wanted, this patch
fixes it.
Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm")
Cc: sta...@dpdk.org
Signed-
On 2024/3/16 5:47, Damodharam Ammepalli wrote:
> On Tue, Mar 12, 2024 at 12:52 AM Dengdui Huang
> wrote:
>>
>> Extended speed command for setting lane number and
>> Show info print lane number.
>>
>> Signed-off-by: Dengdui Huang
>> ---
>> app/test-pmd/cmdline.c | 110 +++
I tested below 18 scenarios on RHEL 9.2 and didn't find any new dpdk issues.
- VM with device assignment(PF) throughput testing(1G hugepage size):
PASS
- VM with device assignment(PF) throughput testing(2M hugepage size) :
PASS
- VM with device assignment(VF) throughput testing: PAS
On Tue, 12 Mar 2024 15:52:36 +0800
Dengdui Huang wrote:
> - ret = snprintf(str, len, "Link up at %s %s %s",
> + ret = snprintf(str, len, "Link up at %s %ulanes %s %s",
Don't you want a space after %u?
Could you make it so that lanes is only part of the message if non-def
On Wed, Feb 21, 2024 at 9:43 PM wrote:
>
> From: Pavan Nikhilesh
>
> Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> structures as will be extended to include node specific error counters
> and error description.
>
> Signed-off-by: Pavan Nikhilesh
Implementation patches
On Tue, Jan 9, 2024 at 7:40 PM wrote:
>
> From: Jerin Jacob
>
> Define qualification criteria for external library
> based on a techboard meeting minutes [1] and past
> learnings from mailing list discussion.
>
> [1]
> http://mails.dpdk.org/archives/dev/2019-June/135847.html
> https://mails.dpdk.
Acked-by: Hemant Agrawal
smime.p7s
Description: S/MIME cryptographic signature
Acked-by: Nithin Dabilpuram
On Wed, Feb 21, 2024 at 9:50 PM wrote:
>
> From: Pavan Nikhilesh
>
> Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> structures as will be extended to include node specific error counters
> and error description.
>
> Signed-off-by: Pavan Nikh
Head move should happen after the core id check, otherwise
source node will be missed.
Fixes: 35dfd9b9fd85 ("graph: introduce graph walk by cross-core dispatch")
Cc: sta...@dpdk.org
Signed-off-by: Jingjing Wu
---
lib/graph/rte_graph_model_mcore_dispatch.h | 4 ++--
1 file changed, 2 insertions(
69 matches
Mail list logo
