Hi Thomas, On 2024/3/18 17:38, Thomas Monjalon wrote: > 18/03/2024 10:18, Chengwen Feng: >> --- a/app/test/test_argparse.c >> +++ b/app/test/test_argparse.c >> +#define TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK RTE_SHIFT_VAL64(3, 0) >> +#define TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK RTE_SHIFT_VAL64(255, 2) > > Don't you want to make it part of the API? > I thought it was what you did in this v3.
In v3 I defined two macros: RTE_ARGPARSE_HAS_VAL_BITMASK and RTE_ARGPARSE_VAL_TYPE_BITMASK in API file. but forgot to remove the above two TEST_ARGPARSE_XXX_BITMASK macros in v3. I already send v4 to fix it, please review it. Thanks > > > > . >
