Re: DTS testpmd and SCAPY integration

2024-01-23 Thread Thomas Monjalon
23/01/2024 04:42, Honnappa Nagarahalli: > > 08/01/2024 13:10, Luca Vizzarro: > > > Your proposal sounds rather interesting. Certainly enabling DTS to > > > accept YAML-written tests sounds more developer-friendly and should > > > enable quicker test-writing. As this is an extra feature though – and

Re: [PATCH v2 01/11] eventdev: improve doxygen introduction text

2024-01-23 Thread Mattias Rönnblom
On 2024-01-19 18:43, Bruce Richardson wrote: Make some textual improvements to the introduction to eventdev and event devices in the eventdev header file. This text appears in the doxygen output for the header file, and introduces the key concepts, for example: events, event devices, queues, port

Re: [PATCH v2 01/11] eventdev: improve doxygen introduction text

2024-01-23 Thread Bruce Richardson
On Tue, Jan 23, 2024 at 09:57:58AM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > Make some textual improvements to the introduction to eventdev and event > > devices in the eventdev header file. This text appears in the doxygen > > output for the header file, and

Re: [PATCH 0/8] optimize the firmware loading process

2024-01-23 Thread Ferruh Yigit
On 1/23/2024 1:46 AM, Chaoyong He wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, January 22, 2024 11:09 PM >> To: Chaoyong He ; dev@dpdk.org >> Cc: oss-drivers >> Subject: Re: [PATCH 0/8] optimize the firmware loading process >> >> On 1/15/2024 2:54 AM, Chaoyong

Re: [PATCH v2 03/11] eventdev: update documentation on device capability flags

2024-01-23 Thread Mattias Rönnblom
On 2024-01-19 18:43, Bruce Richardson wrote: Update the device capability docs, to: * include more cross-references * split longer text into paragraphs, in most cases with each flag having a single-line summary at the start of the doc block * general comment rewording and clarification as app

Re: [PATCH v2 03/11] eventdev: update documentation on device capability flags

2024-01-23 Thread Bruce Richardson
On Tue, Jan 23, 2024 at 10:18:53AM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > Update the device capability docs, to: > > > > * include more cross-references > > * split longer text into paragraphs, in most cases with each flag having > >a single-line summ

Re: [PATCH v2 04/11] eventdev: cleanup doxygen comments on info structure

2024-01-23 Thread Mattias Rönnblom
On 2024-01-19 18:43, Bruce Richardson wrote: Some small rewording changes to the doxygen comments on struct rte_event_dev_info. Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 46 - 1 file changed, 25 insertions(+), 21 deletions(-) diff

Re: [PATCH v2 05/11] eventdev: improve function documentation for query fns

2024-01-23 Thread Mattias Rönnblom
On 2024-01-19 18:43, Bruce Richardson wrote: General improvements to the doxygen docs for eventdev functions for querying basic information: * number of devices * id for a particular device * socket id of device * capability information for a device Signed-off-by: Bruce Richardson --- lib/eve

Re: [PATCH v5 10/10] common/dpaxx: replace zero length array

2024-01-23 Thread Thomas Monjalon
29/11/2023 03:39, Stephen Hemminger: > + * Ip header must follow directly after ipsec_encap_pdb [...] > + > + /* ip header if any follows the encap_pdb */ [...] > + /* ip header if any follows the encap_pdb */ I would change "ip" to "IP".

Re: [PATCH v2 04/11] eventdev: cleanup doxygen comments on info structure

2024-01-23 Thread Bruce Richardson
On Tue, Jan 23, 2024 at 10:35:02AM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > Some small rewording changes to the doxygen comments on struct > > rte_event_dev_info. > > > > Signed-off-by: Bruce Richardson > > --- > > lib/eventdev/rte_eventdev.h | 46 ++

Re: [PATCH v5 07/10] net/mlx5: replace zero length array with flex array

2024-01-23 Thread Thomas Monjalon
29/11/2023 03:39, Stephen Hemminger: > --- a/drivers/net/mlx5/mlx5_tx.h > +++ b/drivers/net/mlx5/mlx5_tx.h > @@ -171,11 +171,12 @@ struct mlx5_txq_data { > struct mlx5_txq_stats stats; /* TX queue counters. */ > struct mlx5_txq_stats stats_reset; /* stats on last reset. */ > struc

Re: [PATCH v2 06/11] eventdev: improve doxygen comments on configure struct

2024-01-23 Thread Mattias Rönnblom
On 2024-01-19 18:43, Bruce Richardson wrote: General rewording and cleanup on the rte_event_dev_config structure. Improved the wording of some sentences and created linked cross-references out of the existing references to the dev_info structure. Signed-off-by: Bruce Richardson --- lib/eventd

Re: [PATCH v2 07/11] eventdev: fix documentation for counting single-link ports

2024-01-23 Thread Mattias Rönnblom
On 2024-01-19 18:43, Bruce Richardson wrote: The documentation of how single-link port-queue pairs were counted in the rte_event_dev_config structure did not match the actual implementation and, if following the documentation, certain valid What "documentation" and what "implementation" are you

Re: [PATCH v2 07/11] eventdev: fix documentation for counting single-link ports

2024-01-23 Thread Bruce Richardson
On Tue, Jan 23, 2024 at 10:48:47AM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > The documentation of how single-link port-queue pairs were counted in > > the rte_event_dev_config structure did not match the actual > > implementation and, if following the documen

Re: [PATCH v2 08/11] eventdev: improve doxygen comments on config fns

2024-01-23 Thread Mattias Rönnblom
On 2024-01-19 18:43, Bruce Richardson wrote: Improve the documentation text for the configuration functions and structures for configuring an eventdev, as well as ports and queues. Clarify text where possible, and ensure references come through as links in the html output. Signed-off-by: Bruce R

Re: [PATCH v2 08/11] eventdev: improve doxygen comments on config fns

2024-01-23 Thread Bruce Richardson
On Tue, Jan 23, 2024 at 11:00:50AM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > Improve the documentation text for the configuration functions and > > structures for configuring an eventdev, as well as ports and queues. > > Clarify text where possible, and ensur

Re: [PATCH v2 09/11] eventdev: improve doxygen comments for control APIs

2024-01-23 Thread Mattias Rönnblom
On 2024-01-19 18:43, Bruce Richardson wrote: The doxygen comments for the port attributes, start and stop (and related functions) are improved. Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 34 +++--- 1 file changed, 23 insertions(+), 11 deleti

Re: [PATCH v5 07/10] net/mlx5: replace zero length array with flex array

2024-01-23 Thread Thomas Monjalon
23/01/2024 10:44, Thomas Monjalon: > 29/11/2023 03:39, Stephen Hemminger: > > --- a/drivers/net/mlx5/mlx5_tx.h > > +++ b/drivers/net/mlx5/mlx5_tx.h > > @@ -171,11 +171,12 @@ struct mlx5_txq_data { > > struct mlx5_txq_stats stats; /* TX queue counters. */ > > struct mlx5_txq_stats stats_rese

Re: [PATCH v5 00/10] Replace zero length arrays

2024-01-23 Thread Thomas Monjalon
29/11/2023 03:39, Stephen Hemminger: > Zero length arrays are a GNU extension that has been > superseded by flex arrays. > > https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > > These are places found by cocci/zero_length_array.cocci > > v5 - revised version of dpaxx ip_hdr fix > rebase

[PATCH v2 1/2] net/virtio-user: improve kick performance with notification area mapping

2024-01-23 Thread Srujana Challa
This patch introduces new virtio-user callbacks to map the vq notification area and implements it for the vhost-vDPA backend. This is simply done by using mmap()/munmap() for the vhost-vDPA fd. And also adds code to write to queue notify address in notify callback. This will help in increasing the

[PATCH v2 2/2] net/virtio-user: add VIRTIO_NET_F_RSS to supported features

2024-01-23 Thread Srujana Challa
This patch introduces new function to get rss device config and adds code to forward the RSS control command to backend through hw control queue if RSS feature is negotiated. This patch will help to negotiate VIRTIO_NET_F_RSS feature if vhost-vdpa backend supports RSS in HW. Signed-off-by: Srujana

RE: [PATCH v5 07/10] net/mlx5: replace zero length array with flex array

2024-01-23 Thread Dariusz Sosnowski
From: Thomas Monjalon Sent: Tuesday, January 23, 2024 11:28 > 23/01/2024 10:44, Thomas Monjalon: > > 29/11/2023 03:39, Stephen Hemminger: > > > --- a/drivers/net/mlx5/mlx5_tx.h > > > +++ b/drivers/net/mlx5/mlx5_tx.h > > > @@ -171,11 +171,12 @@ struct mlx5_txq_data { > > > struct mlx5_txq_stats

RE: [PATCH 0/8] optimize the firmware loading process

2024-01-23 Thread Chaoyong He
> >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Monday, January 22, 2024 11:09 PM > >> To: Chaoyong He ; dev@dpdk.org > >> Cc: oss-drivers > >> Subject: Re: [PATCH 0/8] optimize the firmware loading process > >> > >> On 1/15/2024 2:54 AM, Chaoyong He wrote: > >>> This patch ser

RE: [RFC] ethdev: fast path async flow API

2024-01-23 Thread Dariusz Sosnowski
Hi Stephen, Sorry for such a late response. From: Stephen Hemminger Sent: Thursday, January 4, 2024 02:08 > On Wed, 3 Jan 2024 19:14:49 + > Dariusz Sosnowski wrote: > > In summary, in my opinion extending the async flow API with bulking > capabilities or exposing the queue directly to the a

[PATCH 1/6] net/i40e: remove incorrect 16B descriptor read block

2024-01-23 Thread Bruce Richardson
By default, the driver works with 32B descriptors, but has a separate descriptor read block for reading two descriptors at a time when using 16B descriptors. However, the 32B reads used are not guaranteed to be atomic, which will cause issues if that is not the case on a system, since the descripto

[PATCH 0/6] remove incorrect code for loading 16B descriptors

2024-01-23 Thread Bruce Richardson
Inside the AVX2 code paths, there was special case code for loading two 16-byte descriptors simultaneously, if that build-time feature was enabled. As well as not being enabled by default, these code blocks also were incorrect as there is no guarantee of the two descriptors being loaded either atom

[PATCH 2/6] net/i40e: reduce code indentation

2024-01-23 Thread Bruce Richardson
With the removal of the #ifdef block for 16-byte descriptor loads, the do { } while(0) around the descriptor load block becomes unnecessary. Removing that do-while allows us to reduce indentation level of the code by one tab, and makes the function that little cleaner and clearer to read. Signed-o

[PATCH 3/6] net/iavf: remove incorrect 16B descriptor read block

2024-01-23 Thread Bruce Richardson
By default, the driver works with 32B descriptors, but has a separate descriptor read block for reading two descriptors at a time when using 16B descriptors. However, the 32B reads used are not guaranteed to be atomic, which will cause issues if that is not the case on a system, since the descripto

[PATCH 4/6] net/iavf: reduce code indent

2024-01-23 Thread Bruce Richardson
With the removal of the separate block for 16B-descriptors, we can remove the superfluous braces and dedent the code a bit. This allows us to reduce overall number of lines, since we can merge quite a number of lines together. Signed-off-by: Bruce Richardson --- drivers/net/iavf/iavf_rxtx_vec_av

[PATCH 5/6] net/ice: remove incorrect 16B descriptor read block

2024-01-23 Thread Bruce Richardson
By default, the driver works with 32B descriptors, but has a separate descriptor read block for reading two descriptors at a time when using 16B descriptors. However, the 32B reads used are not guaranteed to be atomic, which will cause issues if that is not the case on a system, since the descripto

[PATCH 6/6] net/ice: reduce code indent

2024-01-23 Thread Bruce Richardson
With the removal of the separate block for 16B-descriptors, we can remove the superfluous braces and dedent the code a bit. This allows us to reduce overall number of lines, since we can merge quite a number of lines together. Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_rxtx_vec_avx2

RE: [PATCH v1] crypto/ipsec_mb: upgrade IPsec Multi-buffer to 1.4

2024-01-23 Thread Power, Ciara
Hi Venkat, > -Original Message- > From: Sivaramakrishnan Venkat > Sent: Friday, January 19, 2024 11:40 AM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Sivaramakrishnan, VenkatX > > Subject: [PATCH v1] crypto/ipsec_mb: upgrade IPsec Multi-buffer to 1.4 > > SW PMDs do not

Re: [PATCH 0/8] optimize the firmware loading process

2024-01-23 Thread Ferruh Yigit
On 1/23/2024 11:27 AM, Chaoyong He wrote: -Original Message- From: Ferruh Yigit Sent: Monday, January 22, 2024 11:09 PM To: Chaoyong He ; dev@dpdk.org Cc: oss-drivers Subject: Re: [PATCH 0/8] optimize the firmware loading process On 1/15/2024 2:54 A

Re: [dpdk-dev] [v2] ethdev: support Tx queue used count

2024-01-23 Thread Ferruh Yigit
On 1/22/2024 1:00 PM, Konstantin Ananyev wrote: > CAUTION: This message has originated from an External Source. Please use > proper judgment and caution when opening attachments, clicking links, or > responding to this email. > > >> From: Jerin Jacob >> >> Introduce a new API to retrieve the n

RE: [PATCH v5 2/2] drivers/net: return number of types in get supported types

2024-01-23 Thread Power, Ciara
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Friday, January 19, 2024 2:51 PM > To: Sivaramakrishnan, VenkatX ; Igor > Russkikh ; Selwin Sebastian > ; Ajit Khaparde > ; Somnath Kotur > ; Nithin Dabilpuram > ; Kiran Kumar K ; > Sunil Kumar Kori ; Satha Rao > ; Zhang, Yuying

Re: [PATCH v5 2/2] drivers/net: return number of types in get supported types

2024-01-23 Thread Ferruh Yigit
On 1/23/2024 12:07 PM, Power, Ciara wrote: > Hi Ferruh, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, January 19, 2024 2:51 PM >> To: Sivaramakrishnan, VenkatX ; Igor >> Russkikh ; Selwin Sebastian >> ; Ajit Khaparde >> ; Somnath Kotur >> ; Nithin Dabilpuram >> ; Kiran Ku

Re: [PATCH v5 2/2] drivers/net: return number of types in get supported types

2024-01-23 Thread Ferruh Yigit
On 1/23/2024 2:59 PM, Ferruh Yigit wrote: > On 1/23/2024 12:07 PM, Power, Ciara wrote: >> Hi Ferruh, >> >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Friday, January 19, 2024 2:51 PM >>> To: Sivaramakrishnan, VenkatX ; Igor >>> Russkikh ; Selwin Sebastian >>> ; Ajit Khaparde >>>

Re: [PATCH 0/8] optimize the firmware loading process

2024-01-23 Thread Ferruh Yigit
On 1/15/2024 2:54 AM, Chaoyong He wrote: > This patch series aims to speedup the DPDK application start by optimize > the firmware loading process in sereval places. > We also simplify the port name in multiple PF firmware case to make the > customer happy. > > Peng Zhang (8): > net/nfp: add the

RE: [PATCH v5 2/2] drivers/net: return number of types in get supported types

2024-01-23 Thread Power, Ciara
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 23, 2024 3:13 PM > To: Power, Ciara ; Sivaramakrishnan, VenkatX > ; Igor Russkikh > ; Selwin Sebastian ; > Ajit Khaparde ; Somnath Kotur > ; Nithin Dabilpuram > ; Kiran Kumar K ; > Sunil Kumar Kori ; Satha Rao > ; Zhang,

Re: [PATCH v2 10/11] eventdev: RFC clarify comments on scheduling types

2024-01-23 Thread Mattias Rönnblom
On 2024-01-19 18:43, Bruce Richardson wrote: The description of ordered and atomic scheduling given in the eventdev doxygen documentation was not always clear. Try and simplify this so that it is clearer for the end-user of the application Signed-off-by: Bruce Richardson --- NOTE TO REVIEWERS:

[PATCH v5 0/5] changes for 24.03

2024-01-23 Thread Hernan Vargas
v5: Created separate commit for doc fix. Cosmetic uppercase changes. v4: Targeting 24.03. Updated FPGA PMD based on review comments. v3: Made changes requested during review. v2: Targeting 23.11. Update in commits 1,2 based on review comments. v1: Targeting 23.07 if possible. Add support for AGX100

[PATCH v5 1/5] doc: fix fpga 5gnr configuration values

2024-01-23 Thread Hernan Vargas
flr_timeout was removed from the code a while ago, updating doc. Fix minor typo in 5GNR example. Fixes: 2d4306438c92 ("baseband/fpga_5gnr_fec: add configure function") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/fpga_5gnr_fec.rst | 7 +-- 1 file changed, 1 inserti

[PATCH v5 2/5] baseband/fpga_5gnr_fec: renaming for consistency

2024-01-23 Thread Hernan Vargas
Rename generic functions and constants using the FPGA 5GNR prefix naming to prepare for code reuse for new FPGA implementation variant. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 117 +++-- .../fpga_5gnr_fe

[PATCH v5 3/5] baseband/fpga_5gnr_fec: add Vista Creek variant

2024-01-23 Thread Hernan Vargas
Create a new file vc_5gnr_pmd.h to store structures and macros specific to Vista Creek 5G FPGA implementation and rename functions specific to the Vista Creek variant. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 183 ++- .../

[PATCH v5 4/5] baseband/fpga_5gnr_fec: add AGX100 support

2024-01-23 Thread Hernan Vargas
Add support for new FPGA variant AGX100 (on Arrow Creek N6000). Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/fpga_5gnr_fec.rst | 69 +- drivers/baseband/fpga_5gnr_fec/agx100_pmd.h | 273 .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 12 +- .../fpga_5gnr_fec/rte_fpga

[PATCH v5 5/5] baseband/fpga_5gnr_fec: cosmetic comment changes

2024-01-23 Thread Hernan Vargas
Cosmetic changes for comments. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/fpga_5gnr_fec/agx100_pmd.h | 4 +- .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 49 ++-- .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 258 +- .../fpga_5gnr_fec/rte_pm

[PATCH 0/7] net/gve: RSS Support for GVE Driver

2024-01-23 Thread Joshua Washington
This patch series introduces RSS support for the GVE poll-mode driver. This series includes implementations of the following eth_dev_ops: 1) rss_hash_update 2) rss_hash_conf_get 3) reta_query 4) reta_update In rss_hash_update, the GVE driver supports the following RSS hash types: * RTE_ETH_RSS_I

[PATCH v2 1/7] net/gve: fully expose RSS offload support in dev_info

2024-01-23 Thread Joshua Washington
This patch communicates that the GVE driver supports RSS, along with the RSS offloads supported by the driver. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.c | 4 +++- drivers/net/gve/gve_ethdev.h | 8 2 files c

[PATCH v2 2/7] net/gve: RSS adminq command changes

2024-01-23 Thread Joshua Washington
This change introduces admin queue changes that enable the configuration of RSS parameters for the GVE driver. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/base/gve.h| 15 drivers/net/gve/base/gve_adminq.c | 59 +++

[PATCH v2 3/7] net/gve: add gve_rss library for handling RSS-related behaviors

2024-01-23 Thread Joshua Washington
This change includes a number of helper functions to facilitate RSS configuration on the GVE DPDK driver. These methods are declared in gve_rss.h. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/base/gve_adminq.h | 10 +- drivers/net

[PATCH v2 4/7] net/gve: RSS configuration update support

2024-01-23 Thread Joshua Washington
This patch adds support for updating the RSS hash key and hash fields in the GVE PMD through the implementation of rss_hash_update and rss_hash_conf_get. The RSS hash key for gVNIC is required to be 40 bytes. On initial configuration of the RSS hash key, the RSS redirection table will be set to a

[PATCH v2 5/7] net/gve: RSS redirection table update support

2024-01-23 Thread Joshua Washington
This patch introduces support for updating the RSS redirection table in the GVE PMD through the implementation of rss_reta_update and rss_reta_query. Due to an infrastructure limitation, the RSS hash key must be manually configured before the redirection table can be updated or queried. The redire

[PATCH v2 6/7] net/gve: update gve.ini with RSS capabilities

2024-01-23 Thread Joshua Washington
This patch updates the DPDK feature matrix to expose that the GVE driver supports RSS hash, RSS key update, and RSS reta update. Signed-off-by: Joshua Washington --- doc/guides/nics/features/gve.ini | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/features/gve.ini b/doc/gui

[PATCH v2 7/7] net/gve: update GVE documentation with RSS support

2024-01-23 Thread Joshua Washington
This patch updates the GVE doc page to communicate that GVE now supports RSS configuration and explains the limitations. Signed-off-by: Joshua Washington --- doc/guides/nics/gve.rst | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/doc/guides/nics/gve.rst b/do

Re: DTS testpmd and SCAPY integration

2024-01-23 Thread Jeremy Spewock
On Tue, Jan 23, 2024 at 3:50 AM Thomas Monjalon wrote: > 23/01/2024 04:42, Honnappa Nagarahalli: > > > 08/01/2024 13:10, Luca Vizzarro: > > > > Your proposal sounds rather interesting. Certainly enabling DTS to > > > > accept YAML-written tests sounds more developer-friendly and should > > > > en

[PATCH 0/7] net/gve: RSS Support for GVE Driver

2024-01-23 Thread Joshua Washington
This patch series introduces RSS support for the GVE poll-mode driver. This series includes implementations of the following eth_dev_ops: 1) rss_hash_update 2) rss_hash_conf_get 3) reta_query 4) reta_update In rss_hash_update, the GVE driver supports the following RSS hash types: * RTE_ETH_RSS_I

[PATCH v3 1/7] net/gve: fully expose RSS offload support in dev_info

2024-01-23 Thread Joshua Washington
This patch communicates that the GVE driver supports RSS, along with the RSS offloads supported by the driver. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.c | 4 +++- drivers/net/gve/gve_ethdev.h | 8 2 files c

[PATCH v3 2/7] net/gve: RSS adminq command changes

2024-01-23 Thread Joshua Washington
This change introduces admin queue changes that enable the configuration of RSS parameters for the GVE driver. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/base/gve.h| 15 drivers/net/gve/base/gve_adminq.c | 58 +++

[PATCH v3 3/7] net/gve: add gve_rss library for handling RSS-related behaviors

2024-01-23 Thread Joshua Washington
This change includes a number of helper functions to facilitate RSS configuration on the GVE DPDK driver. These methods are declared in gve_rss.h. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/base/gve_adminq.h | 10 +- drivers/net

[PATCH v3 4/7] net/gve: RSS configuration update support

2024-01-23 Thread Joshua Washington
This patch adds support for updating the RSS hash key and hash fields in the GVE PMD through the implementation of rss_hash_update and rss_hash_conf_get. The RSS hash key for gVNIC is required to be 40 bytes. On initial configuration of the RSS hash key, the RSS redirection table will be set to a

[PATCH v3 5/7] net/gve: RSS redirection table update support

2024-01-23 Thread Joshua Washington
This patch introduces support for updating the RSS redirection table in the GVE PMD through the implementation of rss_reta_update and rss_reta_query. Due to an infrastructure limitation, the RSS hash key must be manually configured before the redirection table can be updated or queried. The redire

[PATCH v3 6/7] net/gve: update gve.ini with RSS capabilities

2024-01-23 Thread Joshua Washington
This patch updates the DPDK feature matrix to expose that the GVE driver supports RSS hash, RSS key update, and RSS reta update. Signed-off-by: Joshua Washington --- doc/guides/nics/features/gve.ini | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/features/gve.ini b/doc/gui

[PATCH v3 7/7] net/gve: update GVE documentation with RSS support

2024-01-23 Thread Joshua Washington
This patch updates the GVE doc page to communicate that GVE now supports RSS configuration and explains the limitations. Signed-off-by: Joshua Washington --- doc/guides/nics/gve.rst | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/doc/guides/nics/gve.rst b/do

[PATCH 0/7] net/gve: RSS Support for GVE Driver

2024-01-23 Thread Joshua Washington
This patch series introduces RSS support for the GVE poll-mode driver. This series includes implementations of the following eth_dev_ops: 1) rss_hash_update 2) rss_hash_conf_get 3) reta_query 4) reta_update In rss_hash_update, the GVE driver supports the following RSS hash types: * RTE_ETH_RSS_I

[PATCH v3 0/7] net/gve: RSS Support for GVE Driver

2024-01-23 Thread Joshua Washington
This patch series introduces RSS support for the GVE poll-mode driver. This series includes implementations of the following eth_dev_ops: 1) rss_hash_update 2) rss_hash_conf_get 3) reta_query 4) reta_update In rss_hash_update, the GVE driver supports the following RSS hash types: * RTE_ETH_RSS_I

[PATCH v3 0/7] net/gve: RSS Support for GVE Driver

2024-01-23 Thread Joshua Washington
This patch series introduces RSS support for the GVE poll-mode driver. This series includes implementations of the following eth_dev_ops: 1) rss_hash_update 2) rss_hash_conf_get 3) reta_query 4) reta_update In rss_hash_update, the GVE driver supports the following RSS hash types: * RTE_ETH_RSS_I

[PATCH v3 1/7] net/gve: fully expose RSS offload support in dev_info

2024-01-23 Thread Joshua Washington
This patch communicates that the GVE driver supports RSS, along with the RSS offloads supported by the driver. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.c | 4 +++- drivers/net/gve/gve_ethdev.h | 8 2 files c

[PATCH v3 2/7] net/gve: RSS adminq command changes

2024-01-23 Thread Joshua Washington
This change introduces admin queue changes that enable the configuration of RSS parameters for the GVE driver. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/base/gve.h| 15 drivers/net/gve/base/gve_adminq.c | 58 +++

[PATCH v3 3/7] net/gve: add gve_rss library for handling RSS-related behaviors

2024-01-23 Thread Joshua Washington
This change includes a number of helper functions to facilitate RSS configuration on the GVE DPDK driver. These methods are declared in gve_rss.h. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/base/gve_adminq.h | 10 +- drivers/net

[PATCH v3 4/7] net/gve: RSS configuration update support

2024-01-23 Thread Joshua Washington
This patch adds support for updating the RSS hash key and hash fields in the GVE PMD through the implementation of rss_hash_update and rss_hash_conf_get. The RSS hash key for gVNIC is required to be 40 bytes. On initial configuration of the RSS hash key, the RSS redirection table will be set to a

[PATCH v3 6/7] net/gve: update gve.ini with RSS capabilities

2024-01-23 Thread Joshua Washington
This patch updates the DPDK feature matrix to expose that the GVE driver supports RSS hash, RSS key update, and RSS reta update. Signed-off-by: Joshua Washington --- doc/guides/nics/features/gve.ini | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/features/gve.ini b/doc/gui

[PATCH v3 5/7] net/gve: RSS redirection table update support

2024-01-23 Thread Joshua Washington
This patch introduces support for updating the RSS redirection table in the GVE PMD through the implementation of rss_reta_update and rss_reta_query. Due to an infrastructure limitation, the RSS hash key must be manually configured before the redirection table can be updated or queried. The redire

[PATCH v3 7/7] net/gve: update GVE documentation with RSS support

2024-01-23 Thread Joshua Washington
This patch updates the GVE doc page to communicate that GVE now supports RSS configuration and explains the limitations. Signed-off-by: Joshua Washington --- doc/guides/nics/gve.rst | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/doc/guides/nics/gve.rst b/do

[PATCH] net/iavf: fix access to null value

2024-01-23 Thread Mingjin Ye
The "vsi" may be null, so it needs to be used after checking. Fixes: ab28aad9c24f ("net/iavf: fix Rx Tx burst in multi-process") Cc: sta...@dpdk.org Signed-off-by: Mingjin Ye --- drivers/net/iavf/iavf_rxtx.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/

Re: [PATCH v2] mempool: test performance with larger bursts

2024-01-23 Thread fengchengwen
Hi Morten, On 2024/1/22 22:34, Morten Brørup wrote: > Bursts of up to 64 or 128 packets are not uncommon, so increase the > maximum tested get and put burst sizes from 32 to 128. > > Some applications keep more than 512 objects, so increase the maximum > number of kept objects from 512 to 8192, s

[PATCH] app/crypto-perf: support TLS record

2024-01-23 Thread Akhil Goyal
Added support for latency and throughput measurement of TLS and DTLS security ops. Signed-off-by: Akhil Goyal --- app/test-crypto-perf/cperf_ops.c | 144 +++ app/test-crypto-perf/cperf_options.h | 5 +- app/test-crypto-perf/cperf_options_parsing.c | 60