In heavy-weight mode GRO which is based on timer, the GRO packets
will not be flushed in spite of timer expiry if there is no packet
in the current poll. If timer mode GRO is enabled the
rte_gro_timeout_flush API should be invoked.
Signed-off-by: Kumara Parameshwaran
---
v1:
Changes to make s
On Wed, Jan 17, 2024 at 10:19:58AM -0800, Stephen Hemminger wrote:
> Clang does not allow const variable in a static_assert
> expression.
>
> Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
On Fri, Jan 12, 2024 at 5:04 PM Ferruh Yigit wrote:
>
> On 1/11/2024 3:17 PM, jer...@marvell.com wrote:
> > From: Jerin Jacob
> >
> > Introduce a new API to retrieve the number of used descriptors
> > in a Tx queue. Applications can leverage this API in the fast path to
> > inspect the Tx queue o
HWS guys claimed this check was needed to make sure matcher works well on ESP.
Are we sure we can remove this ?
> -Original Message-
> From: Raslan Darawsheh
> Sent: Wednesday, January 17, 2024 7:12 PM
> To: Michael Baum ; dev@dpdk.org
> Cc: Matan Azrad ; Dariusz Sosnowski
> ; Slava Ovsi
> Clang does not handle casts in static_assert() expressions.
> It doesn't like use of floating point to calculate threshold.
> Use a different expression with same effect.
>
> Modify comment in mlx5 so that developers don't go searching
> for old value.
>
> Signed-off-by: Stephen Hemminger
>
> Clang does not allow const variable in a static_assert
> expression.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/i40e/i40e_ethdev.h | 1 +
> drivers/net/i40e/i40e_rxtx_vec_sse.c | 10 --
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/
On Wed, Jan 17, 2024 at 06:28:11PM -0800, Stephen Hemminger wrote:
> DPDK will not build on FreeBSD 14.0
>
> [2/2] Generating kernel/freebsd/nic_uio with a custom command
> FAILED: kernel/freebsd/nic_uio.ko
> /usr/bin/make -f ../kernel/freebsd/BSDmakefile.meson
> KMOD_OBJDIR=kernel/freebsd KMOD_
> These macros work like RTE_MIN and RTE_MAX but take an explicit
> type. Necessary when being used in static assertions since
> RTE_MIN and RTE_MAX use temporary variables which confuses
> compilers constant expression checks. These macros could also
> be useful in other scenarios when bounded r
On 1/17/24 21:19, Stephen Hemminger wrote:
The macro RTE_MIN has some hidden assignments to provide type
safety which means the statement can not be fully evaluated in
first pass of compiler. Replace RTE_MIN() with equivalent macro.
Fixes: 4f93d790 ("net/sfc: support TSO for EF100 native dat
On 1/17/24 21:32, Morten Brørup wrote:
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Sent: Wednesday, 17 January 2024 19.20
Clang does not handle casts in static_assert() expressions.
It doesn't like use of floating point to calculate threshold.
Use a different expression with same
On 1/17/24 21:19, Stephen Hemminger wrote:
RTE_BUILD_BUG_ON() was being used with a non-constant value.
The inline function rte_is_power_of_2() is not constant since
inline expansion happens later in the compile process.
Replace it with the macro which will be constant.
Fixes: 4236ce9bf5bf ("eve
On 1/17/24 21:19, Stephen Hemminger wrote:
These macros work like RTE_MIN and RTE_MAX but take an explicit
type. Necessary when being used in static assertions since
RTE_MIN and RTE_MAX use temporary variables which confuses
compilers constant expression checks. These macros could also
be useful
From: Jerin Jacob
Introduce a new API to retrieve the number of used descriptors
in a Tx queue. Applications can leverage this API in the fast path to
inspect the Tx queue occupancy and take appropriate actions based on the
available free descriptors.
A notable use case could be implementing Ran
Hi Jerin,
> > > Introduce a new API to retrieve the number of used descriptors
> > > in a Tx queue. Applications can leverage this API in the fast path to
> > > inspect the Tx queue occupancy and take appropriate actions based on the
> > > available free descriptors.
> > >
> > > A notable use cas
In a nested virtualization environment, running dpdk vdpa in QEMU-L1 for
software live migration will result in a deadlock between dpdke-vdpa and
QEMU-L2 processes.
rte_vdpa_relay_vring_used->
__vhost_iova_to_vva->
vhost_user_iotlb_rd_unlock(vq)->
vhost_user_iotlb_miss-> send vhost message VHOST_US
Remove my name for next-net-intel, fm10k, ice and af_xdp.
Signed-off-by: Qi Zhang
---
MAINTAINERS | 4
1 file changed, 4 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0d1c8126e3..7d74486d1a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -37,7 +37,6 @@ M: Ajit Khaparde
T: git:/
https://bugs.dpdk.org/show_bug.cgi?id=1368
Bug ID: 1368
Summary: inconsistency in eventdev dev_info and config structs
makes some valid configs impossible
Product: DPDK
Version: unspecified
Hardware: All
OS:
On Thu, Jan 18, 2024 at 3:47 PM Konstantin Ananyev
wrote:
>
>
> Hi Jerin,
Hi Konstantin,
>
> > > > Introduce a new API to retrieve the number of used descriptors
> > > > in a Tx queue. Applications can leverage this API in the fast path to
> > > > inspect the Tx queue occupancy and take appropr
On Thu, Jan 18, 2024 at 11:18:58AM +, bugzi...@dpdk.org wrote:
>Bug ID [1]1368
>Summary inconsistency in eventdev dev_info and config structs makes
>some valid configs impossible
>Product DPDK
>Version unspecified
>Hardware All
>OS All
>Status UNCONFIRMED
>Se
Currently IPsec MB provides both the JOB API and direct API.
AESNI_MB PMD is using the JOB API codepath while ZUC, KASUMI, SNOW3G,
CHACHA20_POLY1305 and AESNI_GCM are using the direct API.
Instead of using the direct API for these PMDs, they should now make
use of the JOB API codepath. This would r
Address Sanitizer detects a buffer overflow caused by an incorrect
ptypes list. Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow.
Fix the ptypes list for drivers.
Fixes: 0849ac3b6122 ("net/tap: add packet type management")
Fixes: a7bdc3bd4244 ("net/dpaa: support packet type parsing")
Fixes
Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow.
Enhance code such that the dev_supported_ptypes_get()
function pointer now returns the number of elements to
eliminate the need for "RTE_PTYPE_UNKNOWN" as the last item.
Signed-off-by: Sivaramakrishnan Venkat
--
v5:
- modified com
Hi folks,
Let me summarize the yesterday's discussion in a few keys points:
- Greg's proposal aims at simplicity and is useful mainly for test cases
which can be written in a few minutes. More complex test cases are not
suitable for the YAML approach.
- The above implies that the YAML
On Thu, Jan 18, 2024 at 11:26:45AM +, Bruce Richardson wrote:
> On Thu, Jan 18, 2024 at 11:18:58AM +, bugzi...@dpdk.org wrote:
> >Bug ID [1]1368
> >Summary inconsistency in eventdev dev_info and config structs makes
> >some valid configs impossible
> >Product DPDK
> >Ver
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com]
> Sent: Thursday, 18 January 2024 11.17
>
> Hi Jerin,
>
> > > > Introduce a new API to retrieve the number of used descriptors
> > > > in a Tx queue. Applications can leverage this API in the fast
> path to
> > > > inspect the Tx q
Make some textual improvements to the introduction to eventdev and event
devices in the eventdev header file. This text appears in the doxygen
output for the header file, and introduces the key concepts, for
example: events, event devices, queues, ports and scheduling.
This patch makes the followi
Inside the doxygen introduction text, some internal details of how
eventdev works was mixed in with application-relevant details. Move
these details on probing etc. to the driver-relevant section.
Signed-off-by: Bruce Richardson
---
lib/eventdev/rte_eventdev.h | 32 --
Some small rewording changes to the doxygen comments on struct
rte_event_dev_info.
Signed-off-by: Bruce Richardson
---
lib/eventdev/rte_eventdev.c | 2 +-
lib/eventdev/rte_eventdev.h | 46 -
2 files changed, 26 insertions(+), 22 deletions(-)
diff --git a/lib
General improvements to the doxygen docs for eventdev functions for
querying basic information:
* number of devices
* id for a particular device
* socket id of device
* capability information for a device
Signed-off-by: Bruce Richardson
---
lib/eventdev/rte_eventdev.h | 22 +-
Update the device capability docs, to:
* include more cross-references
* split longer text into paragraphs, in most cases with each flag having
a single-line summary at the start of the doc block
* general comment rewording and clarification as appropriate
Signed-off-by: Bruce Richardson
---
General rewording and cleanup on the rte_event_dev_config structure.
Improved the wording of some sentences and created linked
cross-references out of the existing references to the dev_info
structure.
Signed-off-by: Bruce Richardson
---
lib/eventdev/rte_eventdev.h | 47 +++--
The documentation of how single-link port-queue pairs were counted in
the rte_event_dev_config structure did not match the actual
implementation and, if following the documentation, certain valid
port/queue configurations would have been impossible to configure. Fix
this by changing the documentati
This patchset makes small rewording improvements to the eventdev doxygen
documentation to try and ensure that it is as clear as possible,
describes the implementation as accurately as possible, and is
consistent within itself. Most changes are just minor rewordings, along
with plenty of changes to
On Thu, Jan 18, 2024 at 01:45:54PM +, Bruce Richardson wrote:
> Some small rewording changes to the doxygen comments on struct
> rte_event_dev_info.
>
> Signed-off-by: Bruce Richardson
> ---
> lib/eventdev/rte_eventdev.c | 2 +-
> lib/eventdev/rte_eventdev.h | 46 ---
Hello,
On Thu, Jan 18, 2024 at 11:34 AM Hao Chen wrote:
>
> In a nested virtualization environment, running dpdk vdpa in QEMU-L1 for
> software live migration will result in a deadlock between dpdke-vdpa and
> QEMU-L2 processes.
> rte_vdpa_relay_vring_used->
> __vhost_iova_to_vva->
> vhost_user_i
After debugging this, I found a spurious port, which was renamed, and it all
started working.
Thanks
From: James Tervit
Date: Thursday, 18 January 2024 at 13:22
To: dev@dpdk.org
Subject: Ubuntu Upgrade 20.04.6 to 22.04 Jammy 23.06 HomeGateway example
Dear DPDK Folks,
I am following the latest
This series fixes a couple places where expressions that could not
be evaluated as constant early in compiler passes were used.
Then converts RTE_BUILD_BUG_ON() with static_assert.
static_assert() is more picky about the expression has to
be a constant, which also catches some existing undefined
b
These macros work like RTE_MIN and RTE_MAX but take an explicit
type. Necessary when being used in static assertions since
RTE_MIN and RTE_MAX use temporary variables which confuses
compilers constant expression checks. These macros could also
be useful in other scenarios when bounded range is usef
RTE_BUILD_BUG_ON() was being used with a non-constant value.
The inline function rte_is_power_of_2() is not constant since
inline expansion happens later in the compile process.
Replace it with the macro which will be constant.
Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library
The macro RTE_MIN has some hidden assignments to provide type
safety which means the statement can not be fully evaluated in
first pass of compiler. Replace RTE_MIN() with equivalent macro.
Fixes: 4f93d790 ("net/sfc: support TSO for EF100 native datapath")
Signed-off-by: Stephen Hemminger
Ack
Clang does not allow const variable in a static_assert
expression.
Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
Acked-by: Konstantin Ananyev
---
drivers/net/i40e/i40e_ethdev.h | 1 +
drivers/net/i40e/i40e_rxtx_vec_sse.c | 10 --
2 files changed, 5 insertions(+), 6
Clang does not handle casts in static_assert() expressions.
It doesn't like use of floating point to calculate threshold.
Use a different expression with same effect.
Modify comment in mlx5 so that developers don't go searching
for old value.
Signed-off-by: Stephen Hemminger
Acked-by: Konstantin
Both Gcc, clang and MSVC have better way to do compile time
assertions rather than using out of bounds array access.
The old method would fail if -Wvla is enabled because compiler
can't determine size in that code. Also, the use of new
_Static_assert will catch broken code that is passing non-cons
> Subject: [PATCH v3 00/24] Fixes and improvements in crypto cnxk
>
> Add following features
> - TLS record processing offload (TLS 1.2-1.3, DTLS 1.2)
> - Rx inject to allow lookaside packets to be injected to ethdev Rx
> - Use PDCP_CHAIN opcode instead of PDCP opcode for cipher-only and auth
>
From: Long Li
The device capabilities reported from RDMA layer are in int. Those values can
overflow with the data types defined in dev_info_get().
Fix this by doing a upper bound before returning those values.
Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
Cc: sta...
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, 18 January 2024 17.51
>
> Both Gcc, clang and MSVC have better way to do compile time
> assertions rather than using out of bounds array access.
> The old method would fail if -Wvla is enabled because compiler
> can't
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, 18 January 2024 17.51
>
> Clang does not handle casts in static_assert() expressions.
> It doesn't like use of floating point to calculate threshold.
> Use a different expression with same effect.
>
> Modify comment i
January 18, 2024
#
Attendees
1. Lincoln Lavoie
2. Thomas Monjalon
3. Aaron Conole
4. Jeremy Spewock
5. Paul Szczepanek
6. Ali Alnubani
7. Juraj Linkeš
#
Minutes
I forgot to CC the dev mailing list
-- Forwarded message -
From: Patrick Robb
Date: Thu, Jan 18, 2024 at 2:52 PM
Subject: DTS WG Meeting Minutes - January 17, 2024
To:
Cc: , NBU-Contact-Thomas Monjalon (EXTERNAL) <
tho...@monjalon.net>, Juraj Linkeš
January 17, 2024
#
Release status meeting minutes 2024-01-18
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* AMD
* Intel
* Marvell
* Nvidia
* Red Hat
Release Dates
-
The following are the current working dates for 24.03:
The sfc base code had its own definition of static assertions
using the out of bound array access hack. Replace it with a
static_assert like rte_common.h.
Fixes: f67e4719147d ("net/sfc/base: fix coding style")
Signed-off-by: Stephen Hemminger
---
drivers/common/sfc_efx/base/efx.h | 4 ++--
1 fil
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, 18 January 2024 21.18
>
> The sfc base code had its own definition of static assertions
> using the out of bound array access hack. Replace it with a
> static_assert like rte_common.h.
>
> Fixes: f67e4719147d ("net/sf
On 2024/1/19 0:50, Stephen Hemminger wrote:
> These macros work like RTE_MIN and RTE_MAX but take an explicit
> type. Necessary when being used in static assertions since
> RTE_MIN and RTE_MAX use temporary variables which confuses
> compilers constant expression checks. These macros could also
> b
An additional CPT LF will be reserved and attached with
inline device to enable RXC and use for Rx inject purpose.
Signed-off-by: Rahul Bhansali
---
Depends-on: series-30819 ("Fixes and improvements in crypto cnxk")
drivers/common/cnxk/roc_features.h | 7 +++
drivers/common/cnxk/roc_nix.h
Add Rx inject security callback APIs to configure, inject
packet to CPT and receive back as in receive path.
Devargs "rx_inj_ena=1" will be required to enable the
inline IPsec Rx inject feature. If inline device is used
then this devarg will be required for both inline device
and eth device.
Signe
Add missing check of Inline device pointer before accessing
is_multi_channel variable.
Fixes: 7ea187184a51 ("common/cnxk: support 1-N pool-aura per NIX LF")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Bhansali
---
drivers/common/cnxk/roc_nix_inl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deleti
For IPsec decrypted packets, full packet format condition check
is enabled for both reassembly and non-reassembly path as part
of OOP handling. Instead, it should be only in reassembly path.
To fix this, NIX_RX_REAS_F flag condition is added to avoid
packet format check in non-reassembly fast path.
LLC transaction optimization by using LDWB LDTYPE option
in SG preparation for Tx. With this, if data is present
and dirty in LLC then the LLC would mark the data clean.
Signed-off-by: Rahul Bhansali
---
drivers/net/cnxk/cn10k_tx.h | 16 +---
1 file changed, 13 insertions(+), 3 delet
Add test for inline IPsec Rx inject verification. This test case
will inject the known vector to crypto HW from ethdev and
verifies it back with decrypted packet from ethdev Rx.
Signed-off-by: Rahul Bhansali
---
app/test/test_security_inline_proto.c | 325 ++
app/test/tes
在 2024/1/18 22:46, David Marchand 写道:
Hello,
On Thu, Jan 18, 2024 at 11:34 AM Hao Chen wrote:
In a nested virtualization environment, running dpdk vdpa in QEMU-L1 for
software live migration will result in a deadlock between dpdke-vdpa and
QEMU-L2 processes.
rte_vdpa_relay_vring_used->
__v
Hi maintainer of DPDK,
I've noticed an error on comment of DPDK version 23.11 rte_cryptodev.h: 928-930
/**
* Create a symmetric session mempool.
*
* @param name
* The unique mempool name.
* @param nb_elts
* The number of elements in the mempool.
* @param elt_size
* The size of the e
Fix to allow telemetry to handle empty dictionaries correctly.
This patch resolves an issue where empty dictionaries are reported
by telemetry as '[]' rather than '{}'. Initializing the output
buffer based on the container type resolves the issue.
Signed-off-by: Jonathan Erb
---
.mailmap
Hello,
On Fri, Jan 19, 2024 at 8:48 AM Wang, Songyi wrote:
>
> Hi maintainer of DPDK,
Redirecting to the cryptodev maintainers.
Akhil, Fan, can you have a look?
Thanks.
>
>
>
> I’ve noticed an error on comment of DPDK version 23.11 rte_cryptodev.h:
> 928-930
--
David Marchand
63 matches
Mail list logo
