HWS guys claimed this check was needed to make sure matcher works well on ESP.
Are we sure we can remove this ?
> -----Original Message-----
> From: Raslan Darawsheh <rasl...@nvidia.com>
> Sent: Wednesday, January 17, 2024 7:12 PM
> To: Michael Baum <michae...@nvidia.com>; dev@dpdk.org
> Cc: Matan Azrad <ma...@nvidia.com>; Dariusz Sosnowski
> <dsosnow...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com>; Ori
> Kam <or...@nvidia.com>; Suanming Mou <suanmi...@nvidia.com>; Hamdan
> Igbaria <hamd...@nvidia.com>; sta...@dpdk.org
> Subject: RE: [PATCH] net/mlx5/hws: fix ESP matching validation
>
> Hi,
> > -----Original Message-----
> > From: Michael Baum <michae...@nvidia.com>
> > Sent: Monday, January 15, 2024 2:10 PM
> > To: dev@dpdk.org
> > Cc: Matan Azrad <ma...@nvidia.com>; Dariusz Sosnowski
> > <dsosnow...@nvidia.com>; Raslan Darawsheh <rasl...@nvidia.com>; Slava
> > Ovsiienko <viachesl...@nvidia.com>; Ori Kam <or...@nvidia.com>;
> > Suanming Mou <suanmi...@nvidia.com>; Hamdan Igbaria
> > <hamd...@nvidia.com>; sta...@dpdk.org
> > Subject: [PATCH] net/mlx5/hws: fix ESP matching validation
> >
> > The "mlx5dr_definer_conv_item_esp()" function validates first whether
> > "ipsec_offload" PRM flag is on, if the flag is off the function
> > returns error.
> >
> > The "ipsec_offload" PRM flag indicates whether IPsec encrypt/decrypt
> > is supported, IPsec matching may be supported even when this flag is off.
> >
> > This patch removes this validation.
> >
> > Fixes: 81cf20a25abf ("net/mlx5/hws: support match on ESP item")
> > Cc: hamd...@nvidia.com
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Michael Baum <michae...@nvidia.com>
> > Acked-by: Hamdan Igbaria <hamd...@nvidia.com>
> > Acked-by: Matan Azrad <ma...@nvidia.com>
> Patch applied to next-net-mlx,
>
> Kindest regards
> Raslan Darawsheh
